New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 590974 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 547953



Sign in to add a comment

New tab button icon top edge not sharp on non-Retina

Project Member Reported by shrike@chromium.org, Mar 1 2016

Issue description

Last time I looked at it the line was being rendered across along two rows of pixels instead of a single crisp line. It's a crisp line on Retina.

 
Status: Assigned (was: Unconfirmed)
Status: Started (was: Assigned)
I had left it unconfirmed because I wasn't sure it was a real issue (but had planned to check into it).
Before and after screenshots attached.
NewTabButtonBefore.png
4.6 KB View Download
NewTabButtonWithFix.png
4.5 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/339bd5d94f7ce32a1d6f6d03f1d1e703b447d0a0

commit 339bd5d94f7ce32a1d6f6d03f1d1e703b447d0a0
Author: shrike <shrike@chromium.org>
Date: Tue Mar 01 21:23:23 2016

Adjust new tab button path to get crisp line along top edge (Mac).

BUG= 590974 

Review URL: https://codereview.chromium.org/1751153002

Cr-Commit-Position: refs/heads/master@{#378561}

[modify] https://crrev.com/339bd5d94f7ce32a1d6f6d03f1d1e703b447d0a0/chrome/browser/ui/cocoa/new_tab_button.mm

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 2 2016

Labels: Merge-Merged-master1
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/339bd5d94f7ce32a1d6f6d03f1d1e703b447d0a0

commit 339bd5d94f7ce32a1d6f6d03f1d1e703b447d0a0
Author: shrike <shrike@chromium.org>
Date: Tue Mar 01 21:23:23 2016

Sign in to add a comment