Issue 590958 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	calamity@chromium.org
Closed:	Jun 2016
Cc:	█ tsergeant@chromium.org
Components:	UI>Browser>History
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Chrome , Mac
Pri:	2
Type:	Feature
Proj-MaterialDesign-WebUI

Blocking:
issue 425625

MD History: Display synced tabs

Project Member Reported by tsergeant@chromium.org, Mar 1 2016

Issue description

We need to display synced tabs in a separate 'page' with a sidebar to switch between the main history view and the synced tab view.

We should make sure that there's a URL push state for the synced tabs page (chrome://history/openTabs or something).

Switching between pages is also an opportunity to introduce some slick animations.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82fc0fecbea601eef1bbc3a98f6e82286a473977

commit 82fc0fecbea601eef1bbc3a98f6e82286a473977
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Apr 08 03:20:23 2016

MD History: Support dynamically updating synced tab data

The history backend periodically sends updated tab data to the front-end
page, which we use to update any existing devices and show new ones.

Based off https://codereview.chromium.org/1619153002/ by yingran@google.com

BUG= 590958 

Review URL: https://codereview.chromium.org/1874473004

Cr-Commit-Position: refs/heads/master@{#385974}

[modify] https://crrev.com/82fc0fecbea601eef1bbc3a98f6e82286a473977/chrome/browser/resources/history/externs.js
[modify] https://crrev.com/82fc0fecbea601eef1bbc3a98f6e82286a473977/chrome/browser/resources/md_history/history.js
[modify] https://crrev.com/82fc0fecbea601eef1bbc3a98f6e82286a473977/chrome/browser/resources/md_history/synced_device_manager.js
[modify] https://crrev.com/82fc0fecbea601eef1bbc3a98f6e82286a473977/chrome/browser/ui/webui/foreign_session_handler.cc
[modify] https://crrev.com/82fc0fecbea601eef1bbc3a98f6e82286a473977/chrome/test/data/webui/md_history/history_synced_tabs_test.js

Comment 2 by tdander...@chromium.org, Apr 11 2016

Labels: Proj-MaterialDesign-WebUI

Comment 3 by tsergeant@chromium.org, Jun 2 2016

Status: Fixed (was: Assigned)

►

Issue 590958 link

Issue metadata

MD History: Display synced tabs

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 8 2016

Comment 1 Deleted

Comment 2 by tdander...@chromium.org, Apr 11 2016

Comment 2 Deleted

Comment 3 by tsergeant@chromium.org, Jun 2 2016

Comment 3 Deleted

Sign in to add a comment