New issue
Advanced search Search tips

Issue 590955 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Need per user WindowManager

Project Member Reported by sky@chromium.org, Mar 1 2016

Issue description

Mus should support a WindowManager per user id.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04ce21af244667b86ba7fa17f99e0d45f7d577ba

commit 04ce21af244667b86ba7fa17f99e0d45f7d577ba
Author: sky <sky@chromium.org>
Date: Tue Mar 01 04:16:16 2016

Changes ownership of WindowTreeHostConnection

Changes ownership of WindowTreeHostConnection

Previously WindowTreeHostConnection owned then WindowTreeHost. This
change makes the WindowTreeHosts owned by the
ConnectionManager. WindowTreeHost in turn owns the
WindowTreeHostConnection. I'm doing this as multiple windows managers
per display implies WindowTreeHost won't always have a
WindowTreeHostConnection.

I also nuked WindowTreeHostDelegate and folded into
WindowTreeHostConnection.

BUG= 590955 
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1750143002

Cr-Commit-Position: refs/heads/master@{#378393}

[modify] https://crrev.com/04ce21af244667b86ba7fa17f99e0d45f7d577ba/components/mus/mus_app.cc
[modify] https://crrev.com/04ce21af244667b86ba7fa17f99e0d45f7d577ba/components/mus/ws/BUILD.gn
[modify] https://crrev.com/04ce21af244667b86ba7fa17f99e0d45f7d577ba/components/mus/ws/connection_manager.cc
[modify] https://crrev.com/04ce21af244667b86ba7fa17f99e0d45f7d577ba/components/mus/ws/connection_manager.h
[modify] https://crrev.com/04ce21af244667b86ba7fa17f99e0d45f7d577ba/components/mus/ws/window_tree_host_connection.cc
[modify] https://crrev.com/04ce21af244667b86ba7fa17f99e0d45f7d577ba/components/mus/ws/window_tree_host_connection.h
[delete] https://crrev.com/a7e8a5f5cabcd125f82b6a204cf1210dad41a1f7/components/mus/ws/window_tree_host_delegate.h
[modify] https://crrev.com/04ce21af244667b86ba7fa17f99e0d45f7d577ba/components/mus/ws/window_tree_host_impl.cc
[modify] https://crrev.com/04ce21af244667b86ba7fa17f99e0d45f7d577ba/components/mus/ws/window_tree_host_impl.h
[modify] https://crrev.com/04ce21af244667b86ba7fa17f99e0d45f7d577ba/components/mus/ws/window_tree_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2016

Labels: Merge-Merged-master1
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/04ce21af244667b86ba7fa17f99e0d45f7d577ba

commit 04ce21af244667b86ba7fa17f99e0d45f7d577ba
Author: sky <sky@chromium.org>
Date: Tue Mar 01 04:16:16 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbe425b94131041e3a754c18c269702acd624880

commit cbe425b94131041e3a754c18c269702acd624880
Author: sky <sky@chromium.org>
Date: Wed Mar 02 20:04:27 2016

Adds WindowManagerManager to mus

WindowTreeHostImpl now has a set of WindowManagerManagers. There are
two distinct modes:
. Created by way of using WindowTreeHostFactory. In this mode there is
  only one WindowManagerManager for the host.
. Created implicitly when no WindowTreeHostFactorys have been used. In
  this mode there is a WindowManagerManager per userid.

This patch doesn't enforce WindowTreeClients only created windows
under the WindowManager with the id. That'll come after
this. Additionally there is a lot of cleanup to do, but I'm trying to
minimize the extent of the changes, which are already quite large.

I've changed mash (desktop_wm) so that it no longer
uses WindowTreeHostFactory. This triggers having mus create a default
WindowTreeHost (the second mode above).

BUG= 590955 
TEST=covered by tests
R=ben@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1755223002

Cr-Commit-Position: refs/heads/master@{#378809}

[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/mus_app.cc
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/mus_app.h
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/BUILD.gn
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/client_connection.cc
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/client_connection.h
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/connection_manager.cc
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/connection_manager.h
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/connection_manager_delegate.h
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/window_manager_access_policy.cc
[add] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/window_manager_factory_registry.cc
[add] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/window_manager_factory_registry.h
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/window_manager_factory_service.cc
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/window_manager_factory_service.h
[add] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/window_manager_state.cc
[add] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/window_manager_state.h
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/window_tree_host_impl.cc
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/window_tree_host_impl.h
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/window_tree_impl.cc
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/components/mus/ws/window_tree_unittest.cc
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/mash/wm/root_window_controller.cc
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/mash/wm/root_window_controller.h
[modify] https://crrev.com/cbe425b94131041e3a754c18c269702acd624880/mash/wm/window_manager_application.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/464574d96d15eeb2c984fcd025d5f1cb7da34594

commit 464574d96d15eeb2c984fcd025d5f1cb7da34594
Author: sky <sky@chromium.org>
Date: Thu Mar 03 05:08:33 2016

Changes ownership of ClientConnection

Previously ClientConnection owned the WindowTreeImpl. This is mildly
confusing and weird. Now WindowTreeImpl owns the ClientConnection and
ConnectionManager owns the WindowTreeImpls.

As part of this I also changed around how WindowTreeImpls are created.

BUG= 590955 
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1764483003

Cr-Commit-Position: refs/heads/master@{#378961}

[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/mus_app.cc
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/mus_app.h
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/client_connection.cc
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/client_connection.h
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/connection_manager.cc
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/connection_manager.h
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/connection_manager_delegate.h
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/window_tree_factory.cc
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/window_tree_host_impl.cc
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/window_tree_impl.cc
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/window_tree_impl.h
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/window_tree_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 3 2016

Labels: merge-merged-2666
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/464574d96d15eeb2c984fcd025d5f1cb7da34594

commit 464574d96d15eeb2c984fcd025d5f1cb7da34594
Author: sky <sky@chromium.org>
Date: Thu Mar 03 05:08:33 2016

Changes ownership of ClientConnection

Previously ClientConnection owned the WindowTreeImpl. This is mildly
confusing and weird. Now WindowTreeImpl owns the ClientConnection and
ConnectionManager owns the WindowTreeImpls.

As part of this I also changed around how WindowTreeImpls are created.

BUG= 590955 
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1764483003

Cr-Commit-Position: refs/heads/master@{#378961}

[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/mus_app.cc
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/mus_app.h
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/client_connection.cc
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/client_connection.h
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/connection_manager.cc
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/connection_manager.h
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/connection_manager_delegate.h
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/window_tree_factory.cc
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/window_tree_host_impl.cc
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/window_tree_impl.cc
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/window_tree_impl.h
[modify] https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594/components/mus/ws/window_tree_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4

commit 1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4
Author: sky <sky@chromium.org>
Date: Fri Mar 04 00:42:24 2016

More user id tracking for mus:

Adds UserIdTracker to track set of known/valid user ids.

Start of adding test coverage for multiple windowmanagers per treehost
along with a handful of fixes.

BUG= 590955 
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1757403002

Cr-Commit-Position: refs/heads/master@{#379156}

[modify] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/mus_app.cc
[modify] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/BUILD.gn
[modify] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/access_policy.h
[modify] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/connection_manager.cc
[modify] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/connection_manager.h
[add] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/test_utils.cc
[add] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/test_utils.h
[add] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/user_id.h
[add] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/user_id_tracker.cc
[add] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/user_id_tracker.h
[add] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/user_id_tracker_observer.h
[modify] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/window_manager_factory_registry.cc
[modify] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/window_manager_factory_registry.h
[add] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/window_manager_factory_registry_observer.h
[modify] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/window_manager_factory_service.cc
[modify] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/window_manager_factory_service.h
[modify] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/window_tree_apptest.cc
[modify] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/window_tree_host_impl.cc
[modify] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/window_tree_host_impl.h
[add] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/window_tree_host_unittest.cc
[modify] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/window_tree_impl.h
[modify] https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4/components/mus/ws/window_tree_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bddcde6d2804df3c11d2e8112aa08d64f699b85

commit 3bddcde6d2804df3c11d2e8112aa08d64f699b85
Author: sky <sky@chromium.org>
Date: Mon Mar 07 17:03:40 2016

Refators display related functionality into own class

BUG= 590955 
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1766943002

Cr-Commit-Position: refs/heads/master@{#379567}

[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/mus_app.cc
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/mus_app.h
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/BUILD.gn
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/connection_manager.cc
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/connection_manager.h
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/connection_manager_delegate.h
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/display.cc
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/display.h
[add] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/display_manager.cc
[add] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/display_manager.h
[add] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/display_manager_delegate.h
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/display_unittest.cc
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/server_window_delegate.h
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/test_server_window_delegate.cc
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/test_server_window_delegate.h
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/test_utils.cc
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/test_utils.h
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/window_manager_state.cc
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/window_tree.cc
[modify] https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85/components/mus/ws/window_tree.h

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/407d2458d1294dd019b6aec72aba33e4777bad37

commit 407d2458d1294dd019b6aec72aba33e4777bad37
Author: sky <sky@chromium.org>
Date: Mon Mar 07 22:34:09 2016

Moves FrameDecorations from Display to WindowManagerState

The FrameDecoration values come from the windowmanager, which is per
user. So, move FrameDecorations from Display to WindowManagerState.
This also introduces a UserDisplayManager to track the per user
display state.

BUG= 590955 
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1775583002

Cr-Commit-Position: refs/heads/master@{#379668}

[modify] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/mus_app.cc
[modify] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/BUILD.gn
[modify] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/connection_manager.cc
[modify] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/connection_manager.h
[modify] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/display.cc
[modify] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/display.h
[modify] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/display_manager.cc
[modify] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/display_manager.h
[modify] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/test_utils.h
[add] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/user_display_manager.cc
[add] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/user_display_manager.h
[add] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/user_display_manager_unittest.cc
[modify] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/window_manager_state.cc
[modify] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/window_manager_state.h
[modify] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/window_tree.cc
[modify] https://crrev.com/407d2458d1294dd019b6aec72aba33e4777bad37/components/mus/ws/window_tree.h

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28fd0ec2412b6662697ba5f023b0f24b9f448ad8

commit 28fd0ec2412b6662697ba5f023b0f24b9f448ad8
Author: sky <sky@chromium.org>
Date: Wed Mar 09 01:03:06 2016

Moves EventDispatcher from Display to WindowManagerState

EventDispatcher maintains state that is per WindowManager
(accelerators, root...), so it makes sense that the EventDispatcher is
owned by the WindowManagerState.

This patch also makes Display update WindowManagerState and
EventDispatcher appropriately when the active user changes. When the
active user changes capture and any other event related state is reset.

BUG= 590955 
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1775133003

Cr-Commit-Position: refs/heads/master@{#380005}

[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/connection_manager.cc
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/connection_manager.h
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/display.cc
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/display.h
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/display_manager.cc
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/display_manager.h
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/display_manager_delegate.h
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/display_unittest.cc
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/event_dispatcher.cc
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/event_dispatcher.h
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/event_dispatcher_unittest.cc
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/test_utils.cc
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/test_utils.h
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/user_id_tracker.cc
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/user_id_tracker.h
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/user_id_tracker_observer.h
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/window_manager_factory_registry.cc
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/window_manager_factory_registry.h
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/window_manager_state.cc
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/window_manager_state.h
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/window_tree.cc
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/window_tree.h
[modify] https://crrev.com/28fd0ec2412b6662697ba5f023b0f24b9f448ad8/components/mus/ws/window_tree_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24475251b51b0e76fe011351626473034e80e332

commit 24475251b51b0e76fe011351626473034e80e332
Author: sky <sky@chromium.org>
Date: Fri Mar 11 23:10:50 2016

Makes WindowTree take the AccessPolicy

Having callers decide the policy makes more sense, and will be useful
as we add more policies (such as the director).

BUG= 590955 
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1782123003

Cr-Commit-Position: refs/heads/master@{#380777}

[modify] https://crrev.com/24475251b51b0e76fe011351626473034e80e332/components/mus/ws/access_policy.h
[modify] https://crrev.com/24475251b51b0e76fe011351626473034e80e332/components/mus/ws/connection_manager.cc
[modify] https://crrev.com/24475251b51b0e76fe011351626473034e80e332/components/mus/ws/connection_manager.h
[modify] https://crrev.com/24475251b51b0e76fe011351626473034e80e332/components/mus/ws/default_access_policy.cc
[modify] https://crrev.com/24475251b51b0e76fe011351626473034e80e332/components/mus/ws/default_access_policy.h
[modify] https://crrev.com/24475251b51b0e76fe011351626473034e80e332/components/mus/ws/display_binding.cc
[modify] https://crrev.com/24475251b51b0e76fe011351626473034e80e332/components/mus/ws/window_manager_access_policy.cc
[modify] https://crrev.com/24475251b51b0e76fe011351626473034e80e332/components/mus/ws/window_manager_access_policy.h
[modify] https://crrev.com/24475251b51b0e76fe011351626473034e80e332/components/mus/ws/window_tree.cc
[modify] https://crrev.com/24475251b51b0e76fe011351626473034e80e332/components/mus/ws/window_tree.h
[modify] https://crrev.com/24475251b51b0e76fe011351626473034e80e332/components/mus/ws/window_tree_factory.cc
[modify] https://crrev.com/24475251b51b0e76fe011351626473034e80e332/components/mus/ws/window_tree_unittest.cc

Components: MUS

Comment 12 by sky@chromium.org, Sep 21 2016

Status: Fixed (was: Started)
I'm calling this done.
Labels: VerifyIn-55

Comment 14 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 15 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 16 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 17 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 18 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 20 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment