New issue
Advanced search Search tips

Issue 590932 link

Starred by 1 user
Status: WontFix
Owner:
jianli@chromium.org
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Add test for offline page *not* adding a nav stack entry when reloading

Project Member Reported by petewil@chromium.org, Mar 1 2016 
https://codereview.chromium.org/1742763002/ adds code to keep us from adding a new back stack entry when we reload an offline page with its online version.  We should add a test.

From a reviewer: the way we test that in Custom Tabs is by checking Tab.canGoBack() in instrumentation tests. May be worth adding one here as well.

Comment 1 by fgor...@chromium.org, Mar 2 2016

Owner: petewil@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by petewil@chromium.org, Apr 25 2016

Owner: jianli@chromium.org
The original implementation using should_replace_current_entry failed.  JianLi is redoing the change with URLRequestInterceptor.  This bug should serve as a reminder to add a unit test for the new URLRequestInterceptor change.

Comment 3 by jianli@chromium.org, Aug 26 2016

Status: WontFix (was: Assigned)
This is not longer needed after we moved away from the redirect implementation.
►

Sign in to add a comment