New issue
Advanced search Search tips

Issue 590921 link

Starred by 0 users
Status: Fixed
Owner:
cblume@chromium.org
Closed: Mar 2016
Cc:
cblume@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

11.9%-70.9% regression in blink_perf.canvas at 378165:378167

Project Member Reported by qyears...@chromium.org, Mar 1 2016 
See the link to graphs below.

Comment 2 by tkent@chromium.org, Mar 1 2016

Components: -Blink>Performance Blink

Comment 3 by chrishtr@chromium.org, Mar 1 2016

Components: -Blink Blink>Canvas
Labels: -Pri-2 ReleaseBlock-Beta Pri-1

Comment 4 by junov@chromium.org, Mar 3 2016

Owner: bsalomon@chromium.org
Looks like GPU readback performance took a massive hit with this skia roll:
https://chromium.googlesource.com/chromium/src/+/c01f05493e86069f923fbb6f115c0c2b1e965f7b

bsalomon: PTAL
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Mar 4 2016

Cc: cblume@chromium.org
Owner: cblume@chromium.org

=== Auto-CCing suspected CL author cblume@chromium.org ===

Hi cblume@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Creating functions for uploading a mipmapped texture.
Author  : cblume
Commit description:
  
BUG= 476416 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1249543003

Review URL: https://codereview.chromium.org/1249543003
Commit  : 55f2d2d57f4dd4109aa0c9dab6023373e3b928ec
Date    : Fri Feb 26 21:20:48 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@378165         218.792     0.72954     5           good
chromium@378166         220.4946    3.664267    5           good
chromium@378166,skia@eb79eea617222.9942    6.825715    5           good
chromium@378166,skia@d524f16b98220.4808    0.754512    5           good
chromium@378166,skia@e015c2646f224.5238    5.409382    5           good
chromium@378166,skia@55f2d2d57f385.004     13.871092   5           bad
chromium@378166,skia@0fe12bcfb7371.7976    11.829226   5           bad
chromium@378167         381.7698    5.609876    5           bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 590921

Test Command: python src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --also-run-disabled-tests blink_perf.canvas
Test Metric: toBlob_duration/toBlob_duration
Relative Change: 74.49%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/857
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9019180311604627392


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Mar 4 2016 


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Creating functions for uploading a mipmapped texture.
Author  : cblume
Commit description:
  
BUG= 476416 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1249543003

Review URL: https://codereview.chromium.org/1249543003
Commit  : 55f2d2d57f4dd4109aa0c9dab6023373e3b928ec
Date    : Fri Feb 26 21:20:48 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@378165         169.674943  4.019337    5           good
chromium@378166         169.441629  3.594811    5           good
chromium@378166,skia@eb79eea617169.420308  3.60651     5           good
chromium@378166,skia@d524f16b98170.918851  4.09626     5           good
chromium@378166,skia@e015c2646f173.899128  3.007409    5           good
chromium@378166,skia@55f2d2d57f131.036898  2.431118    5           bad
chromium@378166,skia@0fe12bcfb7132.324028  1.477623    5           bad
chromium@378167         130.589591  3.546422    5           bad
chromium@378169         130.973004  3.677633    5           bad

Bisect job ran on: winx64ati_perf_bisect
Bug ID: 590921

Test Command: python src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --also-run-disabled-tests blink_perf.canvas
Test Metric: getImageData/getImageData
Relative Change: 22.81%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64ati_perf_bisect/builds/1276
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9019179996027558384


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Mar 4 2016 


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Creating functions for uploading a mipmapped texture.
Author  : cblume
Commit description:
  
BUG= 476416 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1249543003

Review URL: https://codereview.chromium.org/1249543003
Commit  : 55f2d2d57f4dd4109aa0c9dab6023373e3b928ec
Date    : Fri Feb 26 21:20:48 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@378165         142.81964   1.478763    5           good
chromium@378166         141.779881  0.858302    5           good
chromium@378166,skia@eb79eea617142.705195  0.908935    5           good
chromium@378166,skia@d524f16b98142.248607  0.976191    5           good
chromium@378166,skia@e015c2646f142.363539  0.928604    5           good
chromium@378166,skia@55f2d2d57f55.319155   0.820254    5           bad
chromium@378166,skia@0fe12bcfb755.51902    0.83495     5           bad
chromium@378167         55.603136   0.376208    5           bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 590921

Test Command: python src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --also-run-disabled-tests blink_perf.canvas
Test Metric: getImageData/getImageData
Relative Change: 61.07%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/856
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9019180322775321552


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Mar 4 2016 


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Creating functions for uploading a mipmapped texture.
Author  : cblume
Commit description:
  
BUG= 476416 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1249543003

Review URL: https://codereview.chromium.org/1249543003
Commit  : 55f2d2d57f4dd4109aa0c9dab6023373e3b928ec
Date    : Fri Feb 26 21:20:48 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@378165         220.9386    4.440898    5           good
chromium@378166         221.8488    5.259306    5           good
chromium@378166,skia@eb79eea617219.1836    0.621123    5           good
chromium@378166,skia@d524f16b98221.4866    6.209787    5           good
chromium@378166,skia@e015c2646f219.5322    0.852355    5           good
chromium@378166,skia@55f2d2d57f378.2406    8.311413    5           bad
chromium@378166,skia@0fe12bcfb7376.5874    2.969074    5           bad
chromium@378167         379.4938    11.873702   5           bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 590921

Test Command: python src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --also-run-disabled-tests blink_perf.canvas
Test Metric: toBlob_duration/toBlob_duration
Relative Change: 71.76%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/860
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9019174293975811520


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!

Comment 9 by vollick@chromium.org, Mar 9 2016 

Hey - any updates here?

Comment 10 by cblume@chromium.org, Mar 9 2016 

Not yet. bsalomon@ and I talked about it a bit, surprised that this would have caused an issue on read back.

On the graphs, there is a moment when it returns to normal. But then it dips back down. That spike happens to coincide with a patch bsalomon@ landed but reverted which altered the offending patch ever so slightly. That patch was just relanded. I am curious to see if that returns us to normal. If not, I will begin investigating.

Comment 11 by cblume@chromium.org, Mar 10 2016

Status: Fixed (was: Assigned)
If you scroll the graphs to the right this seems to be fixed now.
https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDAn_rWpwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDAn63ZvAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDAn63OrQoM

In the range which fixed it is an update from bsalomon@ which disallows passing nullptr to the new mipmap code.

This matches with the spike-of-fixed that we previously saw when it landed but was rolled back. So I suspect that was indeed the regression. And so I believe it is now fixed.
►

Sign in to add a comment