New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 590919 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

content/test/gpu presubmit checks failing

Project Member Reported by kbr@chromium.org, Mar 1 2016

Issue description

Attempting to upload a change to src/content/test/gpu/webgl2_conformance_expectations.py fails with the following:

kbr-macbookpro4:src kbr$ git cl upload
Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit upload checks ...

** Presubmit Warnings **
('run_content_test_gpu_unittests',) (0.72s) failed
Failed to import test module: gpu_tests.memory_test
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/loader.py", line 254, in _find_tests
    module = self._get_module_from_name(name)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/loader.py", line 232, in _get_module_from_name
    __import__(name)
  File "/Users/kbr/src/chrome/src/content/test/gpu/gpu_tests/memory_test.py", line 4, in <module>
    from gpu_tests import gpu_test_base
  File "/Users/kbr/src/chrome/src/content/test/gpu/gpu_tests/gpu_test_base.py", line 7, in <module>
    from telemetry import benchmark as benchmark_module
  File "/Users/kbr/src/chrome/src/third_party/catapult/telemetry/telemetry/benchmark.py", line 8, in <module>
    from telemetry.internal import story_runner
  File "/Users/kbr/src/chrome/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 18, in <module>
    from telemetry import page
  File "/Users/kbr/src/chrome/src/third_party/catapult/telemetry/telemetry/page/__init__.py", line 12, in <module>
    from telemetry.page import shared_page_state
  File "/Users/kbr/src/chrome/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 27, in <module>
    from telemetry.web_perf import timeline_based_measurement
  File "/Users/kbr/src/chrome/src/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_measurement.py", line 8, in <module>
    from tracing.metrics import metric_runner
ImportError: No module named metrics

Telemetry folks, could you please help? Can we further add some checks so Catapult rolls don't break our unit tests? Thanks.

 
Cc: stanisc@chromium.org
I am able to reproduce the problem. Looks like there is a staled .pyc file in third_party/catapult/tracing/__init__.pyc. 

Run: rm third_party/catapult/tracing/__init__.pyc should fix the problem. Looks like the __init__.pyc has been there for a very long time and only cause problem until now when we try to import tracing (which is supposed to be tracing/tracing/__init__.py)
@Ken: we do run gpu test on the CQ bot but it didn't catch this problem because the bot removes the stale .pyc files, IIRC. 

Probably the bug/feature request here is "git fetch" should automatically remove the old .pyc files?
Owner: nedngu...@google.com
Status: Started (was: Available)
Status: Fixed (was: Started)

Comment 6 by kbr@chromium.org, Mar 2 2016

Thanks for tracking this down Ned. Definitely non-obvious. I think the resolution should probably be "WontFix" rather than "Fixed" since no code change was made. Maybe the presubmit script should delete all of the .pyc files before it starts to run.

Status: WontFix (was: Fixed)
Status: Available (was: WontFix)
Hmhh, so many people who use telemetry in chromium/src is affected by this. I think at least we should add a run_hooks step that clean up all the stale pyc file in catapult.
Status: Started (was: Available)
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b1f2222426a6d415e341c8dc015a78dda82ad8b

commit 1b1f2222426a6d415e341c8dc015a78dda82ad8b
Author: nednguyen <nednguyen@google.com>
Date: Wed Mar 02 21:12:21 2016

Add hook to remove stale pyc files from catapult project

BUG= 590919 

Review URL: https://codereview.chromium.org/1761533003

Cr-Commit-Position: refs/heads/master@{#378830}

[modify] https://crrev.com/1b1f2222426a6d415e341c8dc015a78dda82ad8b/DEPS

Status: Fixed (was: Started)

Sign in to add a comment