Occasionally broken window capture on Linux |
||||
Issue descriptionVersion: 48 OS: Goobuntu What steps will reproduce the problem? 1. Start a hangouts, initiate window sharing to display picker 2. Create a new tab in the same Chrome window, drag out the tab to create a separate window 3. Now move that window slightly What is the expected output? What do you see instead? On a regular basis this makes the new window go black in the picker, meaning that the content can't be scraped properly. Please use labels and text to provide additional information.
,
Mar 3 2016
,
Mar 3 2016
I'm able to reproduce this issue in Ubuntu 14.04 M48 48.0.2564.71 (with the original repro steps) After creating a new tab, dragging it as a new window and moving that window, I see that window is rendered as black thumbnail in the hangouts screenshare dialog. Attached screenshots.
,
Mar 3 2016
I see the exact same behavior with screenshare window picker in https://test.webrtc.org/manual/peer2peer/ as well screenshot below
,
Mar 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a21a35a14f00f2a14681f50454b7eff79fda7765 commit a21a35a14f00f2a14681f50454b7eff79fda7765 Author: gyzhou <gyzhou@chromium.org> Date: Thu Mar 17 15:13:58 2016 Fix NativeDesktopMediaList to set aura_id for chrome Aura windows for Linux and windows. Previously NativeDesktopMediaList was returning only native window ID, now it also sets aura_id for chrome in Linux and windows. This allows to capture browser windows directly from Aura, which is faster and more reliable. BUG= 581790 , 289779 , 590915 Review URL: https://codereview.chromium.org/1763753003 Cr-Commit-Position: refs/heads/master@{#381711} [modify] https://crrev.com/a21a35a14f00f2a14681f50454b7eff79fda7765/chrome/browser/media/desktop_media_list_base.cc [modify] https://crrev.com/a21a35a14f00f2a14681f50454b7eff79fda7765/chrome/browser/media/desktop_media_list_base.h [modify] https://crrev.com/a21a35a14f00f2a14681f50454b7eff79fda7765/chrome/browser/media/native_desktop_media_list.cc [modify] https://crrev.com/a21a35a14f00f2a14681f50454b7eff79fda7765/chrome/browser/media/native_desktop_media_list.h [modify] https://crrev.com/a21a35a14f00f2a14681f50454b7eff79fda7765/chrome/browser/media/tab_desktop_media_list.cc [modify] https://crrev.com/a21a35a14f00f2a14681f50454b7eff79fda7765/content/browser/renderer_host/media/media_stream_manager.cc
,
Mar 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b2c1c16e25d7bf6296aebc20ac9354d12ba6b3d commit 0b2c1c16e25d7bf6296aebc20ac9354d12ba6b3d Author: gyzhou <gyzhou@chromium.org> Date: Mon Mar 21 20:52:11 2016 Use DesktopCaptureDeviceAura for all aura windows in Windows and Linux OSs in desktop window sharing. DesktopCaptureDeviceAura was used for chrome browser windows only. For Chrome extension windows may not be captured correctly. Chrome doesn't keep tack of a list of all aura windows. It asks OS with native IDs to get aura windows BUG= 581790 , 289779 , 590915 Review URL: https://codereview.chromium.org/1808273002 Cr-Commit-Position: refs/heads/master@{#382383} [modify] https://crrev.com/0b2c1c16e25d7bf6296aebc20ac9354d12ba6b3d/chrome/browser/media/native_desktop_media_list.cc [modify] https://crrev.com/0b2c1c16e25d7bf6296aebc20ac9354d12ba6b3d/chrome/browser/media/native_desktop_media_list.h
,
Mar 22 2016
Rechecked this on Chrome version 51.0.2687.0 on Ubuntu 12.04. Unable to see any Black rectangles while sharing Screen in a Hangout video. Attached screen shot for the same. Note: The same issue was reproduced on Windows 7 for the same chrome version. Details updated in Bug 289779 with screen shot.
,
Mar 30 2016
,
Apr 1 2016
Verified in M51 Canary 51.0.2696.0 in Ubuntu 14.04 Thumbnails of resized windows are no longer black, in hangouts screenshare and windows picker https://test.webrtc.org/manual/peer2peer/
,
Apr 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5db3ea5297b94573a1147d9d21fb990179f5991 commit e5db3ea5297b94573a1147d9d21fb990179f5991 Author: gyzhou <gyzhou@chromium.org> Date: Fri Apr 08 18:33:48 2016 Modify unit tests for NativeDesktopMediaList to cover aura window capture. This unit tests CL is associated wiht CL https://codereview.chromium.org/1808273002/. Changes in NativeDesktopMediaList. h and NativeDesktopMediaList.cc honor the after landing comments in CL https://codereview.chromium.org/1808273002/ BUG= 581790 , 289779 , 590915 Review URL: https://codereview.chromium.org/1828303003 Cr-Commit-Position: refs/heads/master@{#386129} [modify] https://crrev.com/e5db3ea5297b94573a1147d9d21fb990179f5991/chrome/browser/media/native_desktop_media_list.cc [modify] https://crrev.com/e5db3ea5297b94573a1147d9d21fb990179f5991/chrome/browser/media/native_desktop_media_list.h [modify] https://crrev.com/e5db3ea5297b94573a1147d9d21fb990179f5991/chrome/browser/media/native_desktop_media_list_unittest.cc [modify] https://crrev.com/e5db3ea5297b94573a1147d9d21fb990179f5991/chrome/chrome_tests_unit.gypi |
||||
►
Sign in to add a comment |
||||
Comment 1 by gyzhou@chromium.org
, Mar 3 2016