New issue
Advanced search Search tips

Issue 590905 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug , Feature



Sign in to add a comment

restrict chromeos_config masters to a known list

Project Member Reported by akes...@chromium.org, Feb 29 2016

Issue description

As far as I can tell, the current configs that are masters currently exist, and are exclusive (ie one per master).

canary    :   master-release
pfq       :   lumpy-pre-flight-branch
paladin   :   master-paladin
toolchain :   master-toolchain-release
chrome    :   master-chromium-pfq
android   :   master-android-pfq

Confirming with dnj@ that we want a test that
a) Only these master types exist.
b) Each master type is used by a unique master.

Is that all correct?
 

Comment 1 by d...@chromium.org, Mar 1 2016

Yeah, that looks correct.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7ab8dd5d3d49c9b895b00e24dacc05f97517f277

commit 7ab8dd5d3d49c9b895b00e24dacc05f97517f277
Author: Aviv Keshet <akeshet@chromium.org>
Date: Tue Mar 01 18:52:11 2016

chromeos_config_unittest: restrict build_type of masters to a known list

BUG= chromium:590905 
TEST=local run with and without intentionally bad configs

Change-Id: Ie653212879f199daaf6632db1722dbd82a16c385
Reviewed-on: https://chromium-review.googlesource.com/329749
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/7ab8dd5d3d49c9b895b00e24dacc05f97517f277/cbuildbot/chromeos_config_unittest.py

Owner: akes...@chromium.org
Status: Fixed (was: Untriaged)
Labels: VerifyIn-51

Comment 5 by benhenry@google.com, Apr 27 2016

Components: Infra>Client>ChromeOS
Labels: -Infra-ChromeOS
Status: Verified (was: Fixed)
Bulk verified

Sign in to add a comment