New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 590902 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 534578



Sign in to add a comment

Add controllerTraceDataKey to trace data

Project Member Reported by zh...@chromium.org, Feb 29 2016

Issue description

We need to add controller_trace_data_key to specify which trace data come from the tracing controller.

See:
https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/edit#heading=h.q8di1j2nawlp
 

Comment 1 by zh...@chromium.org, Feb 29 2016

Blocking: 534578

Comment 2 by zh...@chromium.org, Mar 1 2016

Oystein, is there a way to distinguish if tracing is initialized by Chrome as the controller?

Can I assume the StringTraceDataSink and CompressedStringTraceDataSink in tracing_controller_impl_data_sinks are always used by Chrome as the controller?

Or should I instead set controller_trace_data_key in tracing_ui? That is: https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/tracing/tracing_ui.cc&l=192 (right before calling stop tracing) Does this cover both chrome://tracing and chrome://inspect?tracing?


By the way, I just realized that maybe I should use controllerTraceDataKey instead of controller_trace_data_key?

Comment 3 by zh...@chromium.org, Mar 1 2016

Summary: Add controllerTraceDataKey to trace data (was: Add controller_trace_data_key to trace data)

Comment 4 by zh...@chromium.org, Mar 28 2016

Status: WontFix (was: Assigned)
This is probably not needed on the Chrome side.
Components: Speed>Tracing
Labels: -Performance-Tracing

Sign in to add a comment