New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 590899 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"git cl format" styles unrelated lt,gt signs like template angle brackets

Project Member Reported by msw@chromium.org, Feb 29 2016

Issue description

"git cl format" styles unrelated lt,gt signs like template angle brackets
Here's the diff after running "git cl format" on my patch set [1].

     bool increasing_drag =
         GetShelfWidget()->shelf()->SelectValueForShelfAlignment(
-            scroll_delta < 0, scroll_delta > 0,
-            scroll_delta < 0, scroll_delta > 0);
+            scroll_delta<0, scroll_delta> 0, scroll_delta<0, scroll_delta> 0);

It looks like it's incorrectly trying to use template angle brackets.
(each comma should actually separate these four function arguments)
Please take a look; thanks!

[1] https://codereview.chromium.org/1743493002/#ps140001
 
Status: Archived (was: Untriaged)
Archiving issues older than 2 years with no owner or component.

Sign in to add a comment