Issue metadata
Sign in to add a comment
|
[All boards] Not able to submit feedback reports. |
||||||||||||||||||||||
Issue descriptionVersion: 7978.1.0 OS: Chrome What steps will reproduce the problem? 1. Sign in to the device. 2. Open feedback report(Alt+ shift+ I) 2. Try to submit feedback report. What is the expected output? User should able to enter text and submit/cancle the form What do you see instead? Click is not working on feedback window. Please use labels and text to provide additional information.
,
Feb 29 2016
Facing this issue only with the first time login. Feedback report is working fine after log-out and log-in back again.
,
Feb 29 2016
,
Feb 29 2016
,
Mar 8 2016
abodenha@ - I have assigned this to you since this is a UI issue. Please feel free to re-assign to the right owner if this is not on your team.
,
Mar 8 2016
afakhry@ could this be related to your recent changes?
,
Mar 8 2016
I'm not sure, it was working fine when I tested it. I'm looking into it now.
,
Mar 8 2016
I found it! The OPEN_FEEDBACK_PAGE accelerator action is not one of the non-repeatable actions. So if one presses Alt+Shift+I and hold even for a fraction of a second, the Accelerator::IsRepeat() is ignored and the system information will be requested several times which will slow down the whole system. I'll upload a fix in the accelerator table as well as postpone requesting system information until the UI is actually started.
,
Mar 9 2016
Afakhry@ thanks for the update. Please note that any fixes need to be in by monday the 14th.
,
Mar 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1eeae89ed794769fba4fe6b53e3d3250ca20d261 commit 1eeae89ed794769fba4fe6b53e3d3250ca20d261 Author: afakhry <afakhry@chromium.org> Date: Wed Mar 09 21:43:51 2016 Fix Starting the feedback app. The accelerator for starting the feedback app should be non-repeatable. We should only request system information once the UI is shown not before, and limit doing the initialization only to when we determine we need to create a new feedback window. R=rkc@chromium.org BUG= 590892 TEST=manually Review URL: https://codereview.chromium.org/1780553002 Cr-Commit-Position: refs/heads/master@{#380230} [modify] https://crrev.com/1eeae89ed794769fba4fe6b53e3d3250ca20d261/ash/accelerators/accelerator_table.cc [modify] https://crrev.com/1eeae89ed794769fba4fe6b53e3d3250ca20d261/chrome/browser/resources/feedback/js/event_handler.js [modify] https://crrev.com/1eeae89ed794769fba4fe6b53e3d3250ca20d261/chrome/browser/resources/feedback/js/feedback.js
,
Mar 10 2016
Please verify.
,
Mar 15 2016
verified in ChromeOS 7978.18.0 / 50.0.2661.32 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by son...@google.com
, Feb 29 2016