New issue
Advanced search Search tips

Issue 590886 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Remove "Show saved copy" button from error page

Project Member Reported by jianli@chromium.org, Feb 29 2016

Issue description

After we landed the patch to redirect to offline copy when an online version fails to load due to no network (https://bugs.chromium.org/p/chromium/issues/detail?id=584417), there is no need to show "Show saved copy" button in the dino page.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ea0b744e361b07bac102f1ae24e413effa8a7fc

commit 9ea0b744e361b07bac102f1ae24e413effa8a7fc
Author: jianli <jianli@chromium.org>
Date: Wed Mar 02 01:19:48 2016

Remove "Show saved copy" button from error page

This is not longer needed after we redirect to offline copy when an
online version fails to load.

BUG= 590886 

Review URL: https://codereview.chromium.org/1750113002

Cr-Commit-Position: refs/heads/master@{#378645}

[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/chrome/browser/android/tab_android.h
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/chrome/browser/net/net_error_tab_helper.cc
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/chrome/browser/net/net_error_tab_helper.h
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/chrome/common/render_messages.h
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/chrome/renderer/net/net_error_helper.h
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/chrome/renderer/net/net_error_page_controller.cc
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/chrome/renderer/net/net_error_page_controller.h
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/components/error_page.gypi
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/components/error_page/common/BUILD.gn
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/components/error_page/common/localized_error.cc
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/components/error_page/common/localized_error.h
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/components/error_page/common/net_error_info.h
[delete] https://crrev.com/76abf5241c467e11324254d20de3dce30e7ee999/components/error_page/common/offline_page_types.h
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/components/error_page/renderer/net_error_helper_core.cc
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/components/error_page/renderer/net_error_helper_core.h
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/components/error_page/renderer/net_error_helper_core_unittest.cc
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/components/error_page_strings.grdp
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/components/neterror/resources/neterror.html
[modify] https://crrev.com/9ea0b744e361b07bac102f1ae24e413effa8a7fc/components/neterror/resources/neterror.js

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2016

Labels: Merge-Merged-master1
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/9ea0b744e361b07bac102f1ae24e413effa8a7fc

commit 9ea0b744e361b07bac102f1ae24e413effa8a7fc
Author: jianli <jianli@chromium.org>
Date: Wed Mar 02 01:19:48 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in 51.0.2674.3, users can't get to this page with offline pages enabled, but the redirect is working as expected and we still show "Show all saved pages" for online bookmarks.

Sign in to add a comment