We should experiment with multiple clients connecting simultaneously. Some domains will probably require exclusive access, while others should just work.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b547858514737d59af3c55b2b06b4e511624c304 commit b547858514737d59af3c55b2b06b4e511624c304 Author: dgozman <dgozman@chromium.org> Date: Tue Mar 01 19:16:24 2016 [DevTools] Postpone more agents instantiation until attached. To support multiple attached devtools, we have to instantiate individual agents on demand, rather than on creation. This patch moves most of agents, with only worker and inspector to go. BUG= 590878 Review URL: https://codereview.chromium.org/1746393003 Cr-Commit-Position: refs/heads/master@{#378509} [modify] https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp [modify] https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h [modify] https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304/third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h [modify] https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304/third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp [modify] https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h [modify] https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp [modify] https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h [modify] https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304/third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.cpp [modify] https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304/third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.h [modify] https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp [modify] https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
The following revision refers to this bug: https://chrome-internal.googlesource.com/bling/chromium.git/+/b547858514737d59af3c55b2b06b4e511624c304 commit b547858514737d59af3c55b2b06b4e511624c304 Author: dgozman <dgozman@chromium.org> Date: Tue Mar 01 19:16:24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/924fe8af695e29594c55db971d793d4d931b337c commit 924fe8af695e29594c55db971d793d4d931b337c Author: dgozman <dgozman@chromium.org> Date: Thu Mar 03 22:18:16 2016 Revert of [DevTools] Postpone more agents instantiation until attached. (patchset #1 id:1 of https://codereview.chromium.org/1746393003/ ) Reason for revert: Speculative revert to fix performance regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=591406 Original issue's description: > [DevTools] Postpone more agents instantiation until attached. > > To support multiple attached devtools, we have to instantiate > individual agents on demand, rather than on creation. > This patch moves most of agents, with only worker and inspector to go. > > BUG= 590878 > > Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304 > Cr-Commit-Position: refs/heads/master@{#378509} TBR=pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 590878 Review URL: https://codereview.chromium.org/1761663003 Cr-Commit-Position: refs/heads/master@{#379111} [modify] https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp [modify] https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h [modify] https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c/third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h [modify] https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c/third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp [modify] https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h [modify] https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp [modify] https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h [modify] https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c/third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.cpp [modify] https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c/third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.h [modify] https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp [modify] https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/924fe8af695e29594c55db971d793d4d931b337c/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd commit fe63b6b42585c51c7ab9a3b158b20d08d5b552dd Author: dgozman <dgozman@chromium.org> Date: Fri Mar 11 17:51:45 2016 [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client. For multiclient, we will move the global collection of WorkerInspectorProxy objects to a static collection in WorkerInspectorProxy class. BUG= 590878 Review URL: https://codereview.chromium.org/1774323002 Cr-Commit-Position: refs/heads/master@{#380666} [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/frame/FrameConsole.cpp [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/frame/FrameConsole.h [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/inspector/ConsoleMessage.h [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.h [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp [modify] https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34f22b83b76ac457f93d35aece3ed56657689d7d commit 34f22b83b76ac457f93d35aece3ed56657689d7d Author: alexmos <alexmos@chromium.org> Date: Fri Mar 11 18:13:55 2016 Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client. (patchset #3 id:40001 of https://codereview.chromium.org/1774323002/ ) Reason for revert: Seems to have broken compile on WebKit Linux non-Oilpan Builder: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20non-Oilpan%20Builder/builds/2317 Output snippet: In file included from ../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:31: In file included from ../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.h:35: In file included from ../../third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h:29: In file included from ../../third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h:35: In file included from ../../third_party/WebKit/Source/core/inspector/InstrumentingAgents.h:1: In file included from gen/blink/core/InstrumentingAgentsInl.h:7: In file included from ../../third_party/WebKit/Source/platform/heap/Handle.h:35: In file included from ../../third_party/WebKit/Source/platform/heap/HeapAllocator.h:9: ../../third_party/WebKit/Source/platform/heap/TraceTraits.h:173:5: error: static_assert failed "T should be traced" static_assert(WTF::NeedsTracing<T>::value || WTF::IsWeak<T>::value, "T should be traced"); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../third_party/WebKit/Source/platform/heap/Visitor.h:193:24: note: in instantiation of member function 'blink::TraceTrait<WTF::HashSet<WTF::RawPtr<blink::WorkerInspectorProxy>, WTF::PtrHash<WTF::RawPtr<blink::WorkerInspectorProxy> >, WTF::HashTraits<WTF::RawPtr<blink::WorkerInspectorProxy> >, WTF::PartitionAllocator> >::trace' requested here TraceTrait<T>::trace(Derived::fromHelper(this), &const_cast<T&>(t)); ^ ../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:67:14: note: in instantiation of function template specialization 'blink::VisitorHelper<blink::Visitor>::trace<WTF::HashSet<WTF::RawPtr<blink::WorkerInspectorProxy>, WTF::PtrHash<WTF::RawPtr<blink::WorkerInspectorProxy> >, WTF::HashTraits<WTF::RawPtr<blink::WorkerInspectorProxy> >, WTF::PartitionAllocator> >' requested here visitor->trace(m_workersWithEnabledConsole); ^ ../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:63:1: note: in instantiation of function template specialization 'blink::PageConsoleAgent::traceImpl<blink::Visitor *>' requested here DEFINE_TRACE(PageConsoleAgent) ^ ../../third_party/WebKit/Source/platform/heap/Visitor.h:77:39: note: expanded from macro 'DEFINE_TRACE' void T::trace(Visitor* visitor) { traceImpl(visitor); } \ ^ Original issue's description: > [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client. > > For multiclient, we will move the global collection of WorkerInspectorProxy objects > to a static collection in WorkerInspectorProxy class. > > BUG= 590878 > > Committed: https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd > Cr-Commit-Position: refs/heads/master@{#380666} TBR=pfeldman@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 590878 Review URL: https://codereview.chromium.org/1777323004 Cr-Commit-Position: refs/heads/master@{#380668} [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/frame/FrameConsole.cpp [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/frame/FrameConsole.h [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/inspector/ConsoleMessage.h [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.h [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp [modify] https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a2dcc610860524680bf95af50ad7367367b705f commit 6a2dcc610860524680bf95af50ad7367367b705f Author: dgozman <dgozman@chromium.org> Date: Fri Mar 11 22:06:22 2016 [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client. For multiclient, we will move the global collection of WorkerInspectorProxy objects to a static collection in WorkerInspectorProxy class. BUG= 590878 Review URL: https://codereview.chromium.org/1774323002 Cr-Commit-Position: refs/heads/master@{#380745} [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/frame/FrameConsole.cpp [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/frame/FrameConsole.h [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/inspector/ConsoleMessage.h [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.h [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp [modify] https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67 commit 58925fbb6bf9ab2360a2672424a8ef20b3c0cc67 Author: dgozman <dgozman@chromium.org> Date: Sat Mar 12 00:56:06 2016 Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client. (patchset #4 id:60001 of https://codereview.chromium.org/1774323002/ ) Reason for revert: Introduced leaks. See https://bugs.chromium.org/p/chromium/issues/detail?id=594304 Original issue's description: > [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client. > > For multiclient, we will move the global collection of WorkerInspectorProxy objects > to a static collection in WorkerInspectorProxy class. > > BUG= 590878 > > Committed: https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f > Cr-Commit-Position: refs/heads/master@{#380745} TBR=pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 590878 Review URL: https://codereview.chromium.org/1777323005 Cr-Commit-Position: refs/heads/master@{#380810} [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/frame/FrameConsole.cpp [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/frame/FrameConsole.h [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/inspector/ConsoleMessage.h [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.h [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp [modify] https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9fd87883c0d8d5b69e07d61a92e149b647b4e38 commit d9fd87883c0d8d5b69e07d61a92e149b647b4e38 Author: dgozman <dgozman@chromium.org> Date: Mon Mar 14 23:36:25 2016 [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client. For multiclient, we will move the global collection of WorkerInspectorProxy objects to a static collection in WorkerInspectorProxy class. BUG= 590878 Review URL: https://codereview.chromium.org/1774323002 Cr-Commit-Position: refs/heads/master@{#381112} [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/frame/FrameConsole.cpp [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/frame/FrameConsole.h [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/inspector/ConsoleMessage.h [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.h [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp [modify] https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c52adadab8a5b1455ffdf10cf258d3041e99c38 commit 4c52adadab8a5b1455ffdf10cf258d3041e99c38 Author: dgozman <dgozman@chromium.org> Date: Tue Mar 22 02:59:31 2016 Keep the list of active WorkerInspectorProxy objects. This removes the requirement of always instrumenting with InspectorWorkerAgent. Now agent can ask WorkerInspectorProxy about all the instances and connect to some of them when needed. The change will allow to construct worker agent lazily and move closer to inspector multi-client. BUG= 590878 Review URL: https://codereview.chromium.org/1823663003 Cr-Commit-Position: refs/heads/master@{#382487} [modify] https://crrev.com/4c52adadab8a5b1455ffdf10cf258d3041e99c38/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/4c52adadab8a5b1455ffdf10cf258d3041e99c38/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/4c52adadab8a5b1455ffdf10cf258d3041e99c38/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp [modify] https://crrev.com/4c52adadab8a5b1455ffdf10cf258d3041e99c38/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h [modify] https://crrev.com/4c52adadab8a5b1455ffdf10cf258d3041e99c38/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp [modify] https://crrev.com/4c52adadab8a5b1455ffdf10cf258d3041e99c38/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cd7f315c2510c49b8424f71e1e77daeddc28232 commit 2cd7f315c2510c49b8424f71e1e77daeddc28232 Author: dgozman <dgozman@chromium.org> Date: Tue Mar 29 21:33:29 2016 [DevTools] Create agents on attach. To support multiple attached devtools, we have to instantiate individual agents on demand, rather than on creation. This patch moves regular of agents, with view-specific and worker's left. BUG= 590878 Review URL: https://codereview.chromium.org/1834073002 Cr-Commit-Position: refs/heads/master@{#383833} [modify] https://crrev.com/2cd7f315c2510c49b8424f71e1e77daeddc28232/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp [modify] https://crrev.com/2cd7f315c2510c49b8424f71e1e77daeddc28232/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp [modify] https://crrev.com/2cd7f315c2510c49b8424f71e1e77daeddc28232/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h [modify] https://crrev.com/2cd7f315c2510c49b8424f71e1e77daeddc28232/third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp [modify] https://crrev.com/2cd7f315c2510c49b8424f71e1e77daeddc28232/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h [modify] https://crrev.com/2cd7f315c2510c49b8424f71e1e77daeddc28232/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp [modify] https://crrev.com/2cd7f315c2510c49b8424f71e1e77daeddc28232/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h [modify] https://crrev.com/2cd7f315c2510c49b8424f71e1e77daeddc28232/third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.cpp [modify] https://crrev.com/2cd7f315c2510c49b8424f71e1e77daeddc28232/third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.h [modify] https://crrev.com/2cd7f315c2510c49b8424f71e1e77daeddc28232/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp [modify] https://crrev.com/2cd7f315c2510c49b8424f71e1e77daeddc28232/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/2cd7f315c2510c49b8424f71e1e77daeddc28232/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/071a0f6f8ea7191da644265ec12df41216c68635 commit 071a0f6f8ea7191da644265ec12df41216c68635 Author: dgozman <dgozman@chromium.org> Date: Fri Apr 15 00:47:44 2016 [DevTools] Create last agents on attach, modify InspectorDatabaseAgent to support it. We now ask DatabaseTracker about all open databases when creating the agent. BUG= 590878 TEST=http/tests/inspector-enabled/database-open.html Review URL: https://codereview.chromium.org/1880273002 Cr-Commit-Position: refs/heads/master@{#387496} [modify] https://crrev.com/071a0f6f8ea7191da644265ec12df41216c68635/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/database-open-expected.txt [modify] https://crrev.com/071a0f6f8ea7191da644265ec12df41216c68635/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/database-open.html [modify] https://crrev.com/071a0f6f8ea7191da644265ec12df41216c68635/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp [modify] https://crrev.com/071a0f6f8ea7191da644265ec12df41216c68635/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h [modify] https://crrev.com/071a0f6f8ea7191da644265ec12df41216c68635/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp [modify] https://crrev.com/071a0f6f8ea7191da644265ec12df41216c68635/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h [modify] https://crrev.com/071a0f6f8ea7191da644265ec12df41216c68635/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/071a0f6f8ea7191da644265ec12df41216c68635/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/139c34259dd888542d53715f68d5abb8f1777b44 commit 139c34259dd888542d53715f68d5abb8f1777b44 Author: dgozman <dgozman@chromium.org> Date: Fri Apr 15 02:22:05 2016 [DevTools] Move style sheet content storage from css agent to resource loader. This is required to destroy agents on detach as a part of multiclient work. BUG= 590878 TBR=pfeldman@chromium.org Review URL: https://codereview.chromium.org/1888673002 Cr-Commit-Position: refs/heads/master@{#387522} [modify] https://crrev.com/139c34259dd888542d53715f68d5abb8f1777b44/third_party/WebKit/Source/core/core.gypi [modify] https://crrev.com/139c34259dd888542d53715f68d5abb8f1777b44/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp [modify] https://crrev.com/139c34259dd888542d53715f68d5abb8f1777b44/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h [add] https://crrev.com/139c34259dd888542d53715f68d5abb8f1777b44/third_party/WebKit/Source/core/inspector/InspectorResourceContainer.cpp [add] https://crrev.com/139c34259dd888542d53715f68d5abb8f1777b44/third_party/WebKit/Source/core/inspector/InspectorResourceContainer.h [modify] https://crrev.com/139c34259dd888542d53715f68d5abb8f1777b44/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp [modify] https://crrev.com/139c34259dd888542d53715f68d5abb8f1777b44/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.h [modify] https://crrev.com/139c34259dd888542d53715f68d5abb8f1777b44/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/139c34259dd888542d53715f68d5abb8f1777b44/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd70a057c54c0b5f70bd2c59e60c78eb1f0cded1 commit cd70a057c54c0b5f70bd2c59e60c78eb1f0cded1 Author: dgozman <dgozman@chromium.org> Date: Tue Apr 19 03:55:07 2016 [DevTools] Destroy agents on detach. This is good in itself and is a step towards multiclient. BUG= 590878 Review URL: https://codereview.chromium.org/1883193004 Cr-Commit-Position: refs/heads/master@{#388131} [modify] https://crrev.com/cd70a057c54c0b5f70bd2c59e60c78eb1f0cded1/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp [modify] https://crrev.com/cd70a057c54c0b5f70bd2c59e60c78eb1f0cded1/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp [modify] https://crrev.com/cd70a057c54c0b5f70bd2c59e60c78eb1f0cded1/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h [modify] https://crrev.com/cd70a057c54c0b5f70bd2c59e60c78eb1f0cded1/third_party/WebKit/Source/web/InspectorOverlay.cpp [modify] https://crrev.com/cd70a057c54c0b5f70bd2c59e60c78eb1f0cded1/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/cd70a057c54c0b5f70bd2c59e60c78eb1f0cded1/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8 commit 8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8 Author: dgozman <dgozman@chromium.org> Date: Wed Apr 20 20:33:24 2016 [DevTools] Introduce InspectorSession. Session manages agents list, does bookkeeping and handles messages. Session only exists while client is attached. There will be one session per client in multi-client scenario. Simplified InspectorAgent interface along the way. BUG= 590878 Review URL: https://codereview.chromium.org/1899933003 Cr-Commit-Position: refs/heads/master@{#388569} [modify] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/core/core.gypi [delete] https://crrev.com/f6f806674c4f6ebbb8b20197ae5b6c7a40bba08f/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp [modify] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h [modify] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp [modify] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h [modify] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp [modify] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h [modify] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp [modify] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h [modify] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp [modify] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h [add] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/core/inspector/InspectorSession.cpp [add] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/core/inspector/InspectorSession.h [modify] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp [modify] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h [modify] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c51d2bdec6a00f959f4ad5be7173761532dee0a commit 9c51d2bdec6a00f959f4ad5be7173761532dee0a Author: dgozman <dgozman@chromium.org> Date: Thu Apr 21 03:04:53 2016 [DevTools] Remove InspectorAgent::discardAgent. BUG= 590878 Review URL: https://codereview.chromium.org/1901593006 Cr-Commit-Position: refs/heads/master@{#388670} [modify] https://crrev.com/9c51d2bdec6a00f959f4ad5be7173761532dee0a/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h [modify] https://crrev.com/9c51d2bdec6a00f959f4ad5be7173761532dee0a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp [modify] https://crrev.com/9c51d2bdec6a00f959f4ad5be7173761532dee0a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h [modify] https://crrev.com/9c51d2bdec6a00f959f4ad5be7173761532dee0a/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp [modify] https://crrev.com/9c51d2bdec6a00f959f4ad5be7173761532dee0a/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/946af3c81704defad704e49046c65e29ccd5f5dd commit 946af3c81704defad704e49046c65e29ccd5f5dd Author: dgozman <dgozman@chromium.org> Date: Fri Apr 22 01:14:33 2016 [DevTools] Move from InstrumentingAgents to InstrumentingSessions. InspectorSession now holds auto-generated InstrumentingAgents instance. InspectorInstrumentation fetches InstrumentingSessions from different entities and then calls into agents in each session. This could potentially speed up instrumentation when inspector is not attached: we only have InspectorSession objects when attached, while InstrumentingAgents object was always present before. BUG= 590878 Review URL: https://codereview.chromium.org/1903953002 Cr-Commit-Position: refs/heads/master@{#388992} [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/core.gyp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/core.gypi [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/core_generated.gypi [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/frame/LocalFrame.h [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/BUILD.gn [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectedFrames.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorSession.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorSession.h [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [delete] https://crrev.com/254c536ce14380dc8009240cfff27117a1d52897/third_party/WebKit/Source/core/inspector/InstrumentingAgents.h [add] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/InstrumentingSessions.h [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/core/testing/Internals.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/821ac29a26b665d65f674d6ccf88590ad91c5806 commit 821ac29a26b665d65f674d6ccf88590ad91c5806 Author: dgozman <dgozman@chromium.org> Date: Mon Apr 25 20:42:10 2016 [DevTools] Move v8-related instrumentation from agents to InspectorSession. Added V8InspectorSessionClient which gets notified when instrumentation should start and stop. BUG= 590878 , 580337 Review URL: https://codereview.chromium.org/1907663005 Cr-Commit-Position: refs/heads/master@{#389556} [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/core/inspector/InspectorSession.cpp [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/core/inspector/InspectorSession.h [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/core/inspector/PageDebuggerAgent.h [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/platform/blink_platform.gypi [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h [add] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h [modify] https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6 commit 9e2a3f0f53e1d90938c811bb90838d38e9fa07c6 Author: dgozman <dgozman@chromium.org> Date: Mon Jul 18 21:36:51 2016 [DevTools] Pass client initiating DevToolsAgentHost::inspectElement. BUG= 590878 Review-Url: https://codereview.chromium.org/2161493002 Cr-Commit-Position: refs/heads/master@{#406104} [modify] https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6/chrome/browser/devtools/devtools_window.cc [modify] https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6/content/common/devtools_messages.h [modify] https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6/content/public/browser/devtools_agent_host.h [modify] https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6/content/renderer/devtools/devtools_agent.cc [modify] https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6/content/renderer/devtools/devtools_agent.h [modify] https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6/content/shell/browser/shell_devtools_frontend.cc [modify] https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6/content/shell/browser/shell_devtools_frontend.h [modify] https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h [modify] https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6/third_party/WebKit/public/web/WebDevToolsAgent.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d77188631f0c3503585d1e5971366208a0752a38 commit d77188631f0c3503585d1e5971366208a0752a38 Author: dgozman <dgozman@chromium.org> Date: Wed Nov 16 01:34:39 2016 [DevTools] Introduce DevToolsSession. This class so far encapsulates session id and dispatcher. Going forward, it will also contain domain handlers and client (for multi-client support). BUG= 664683 , 590878 TBR=pfeldman Review-Url: https://codereview.chromium.org/2499343002 Cr-Commit-Position: refs/heads/master@{#432343} [modify] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/BUILD.gn [modify] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/browser_devtools_agent_host.cc [modify] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/devtools_agent_host_impl.h [add] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/devtools_session.cc [add] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/devtools_session.h [modify] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/forwarding_agent_host.cc [modify] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/worker_devtools_agent_host.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39d9d9ab10964aa9864273742dccc848b9c514bd commit 39d9d9ab10964aa9864273742dccc848b9c514bd Author: dgozman <dgozman@chromium.org> Date: Wed Dec 28 18:56:30 2016 [DevTools] Rework DevToolsSession interaction with domain handlers. - Introduced base class DevToolsDomainHandler. - Agent host registers handlers in DevToolsSession. - Passing DevToolsSession instance around. This is to: - reduce boilerplate; - prepare for multi-client (there will be multiple sessions). BUG= 590878 TBR=pfeldman Review-Url: https://codereview.chromium.org/2590293003 Cr-Commit-Position: refs/heads/master@{#440874} [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/BUILD.gn [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/browser_devtools_agent_host.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/browser_devtools_agent_host.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/devtools_session.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/devtools_session.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/forwarding_agent_host.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/forwarding_agent_host.h [add] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/devtools_domain_handler.cc [add] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/devtools_domain_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/dom_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/dom_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/emulation_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/emulation_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/input_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/input_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/inspector_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/inspector_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/io_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/io_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/memory_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/memory_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/network_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/network_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/page_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/page_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/schema_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/schema_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/security_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/security_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/service_worker_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/service_worker_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/storage_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/storage_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/system_info_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/system_info_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/tethering_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/tethering_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/tracing_handler.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/protocol/tracing_handler.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/worker_devtools_agent_host.cc [modify] https://crrev.com/39d9d9ab10964aa9864273742dccc848b9c514bd/content/browser/devtools/worker_devtools_agent_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e20b0107a76f5a7ff3fd0dac5b0a1a0c4a1fe7b commit 2e20b0107a76f5a7ff3fd0dac5b0a1a0c4a1fe7b Author: dgozman <dgozman@chromium.org> Date: Fri May 05 02:07:25 2017 [DevTools] Do not talk to inspector overlay from outside Mediated three methods through WebDevToolsAgentImpl, which encapsulates overlay logic inside. This will avoid changes outside of WebDevToolsAgentImpl in case of multiclient. BUG= 590878 Review-Url: https://codereview.chromium.org/2859273002 Cr-Commit-Position: refs/heads/master@{#469572} [modify] https://crrev.com/2e20b0107a76f5a7ff3fd0dac5b0a1a0c4a1fe7b/third_party/WebKit/Source/web/InspectorOverlayAgent.cpp [modify] https://crrev.com/2e20b0107a76f5a7ff3fd0dac5b0a1a0c4a1fe7b/third_party/WebKit/Source/web/InspectorOverlayAgent.h [modify] https://crrev.com/2e20b0107a76f5a7ff3fd0dac5b0a1a0c4a1fe7b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/2e20b0107a76f5a7ff3fd0dac5b0a1a0c4a1fe7b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h [modify] https://crrev.com/2e20b0107a76f5a7ff3fd0dac5b0a1a0c4a1fe7b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp [modify] https://crrev.com/2e20b0107a76f5a7ff3fd0dac5b0a1a0c4a1fe7b/third_party/WebKit/Source/web/WebFrameWidgetImpl.h [modify] https://crrev.com/2e20b0107a76f5a7ff3fd0dac5b0a1a0c4a1fe7b/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/2e20b0107a76f5a7ff3fd0dac5b0a1a0c4a1fe7b/third_party/WebKit/Source/web/WebViewImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8e3acc298ce63513565847c5e876012d9c67201 commit e8e3acc298ce63513565847c5e876012d9c67201 Author: dgozman <dgozman@chromium.org> Date: Fri May 05 17:38:28 2017 [DevTools] Pass session id in detach request This makes it symmetric to attach/restore and closes the last gap in public methods not supporting multiclient. BUG= 590878 Review-Url: https://codereview.chromium.org/2858043003 Cr-Commit-Position: refs/heads/master@{#469706} [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/content/browser/devtools/worker_devtools_agent_host.cc [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/content/child/shared_worker_devtools_agent.cc [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/content/child/shared_worker_devtools_agent.h [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/content/common/devtools_messages.h [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/content/public/renderer/render_frame.h [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/content/renderer/devtools/devtools_agent.cc [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/content/renderer/devtools/devtools_agent.h [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/content/renderer/render_frame_impl.cc [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/content/renderer/render_frame_impl.h [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/content/renderer/render_view_browsertest.cc [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/content/renderer/service_worker/embedded_worker_devtools_agent.cc [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/content/renderer/service_worker/embedded_worker_devtools_agent.h [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/content/shell/renderer/layout_test/blink_test_runner.cc [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/third_party/WebKit/Source/web/WebSharedWorkerImpl.h [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/third_party/WebKit/public/web/WebDevToolsAgent.h [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/third_party/WebKit/public/web/WebEmbeddedWorker.h [modify] https://crrev.com/e8e3acc298ce63513565847c5e876012d9c67201/third_party/WebKit/public/web/WebSharedWorker.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39 commit 9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39 Author: dgozman <dgozman@chromium.org> Date: Fri May 05 22:35:26 2017 [DevTools] Support multiple sessions in content/ domain handlers We now have a set of sessions (which has at most one element for now) and retrieve multiple domain handlers at instrumentation points. BUG= 590878 Review-Url: https://codereview.chromium.org/2863623003 Cr-Commit-Position: refs/heads/master@{#469780} [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/devtools_io_context.h [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/devtools_session.cc [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/devtools_session.h [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/devtools_domain_handler.cc [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/devtools_domain_handler.h [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/input_handler.cc [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/input_handler.h [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/inspector_handler.cc [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/inspector_handler.h [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/network_handler.cc [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/network_handler.h [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/page_handler.cc [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/page_handler.h [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/security_handler.cc [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/security_handler.h [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/tracing_handler.cc [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/protocol/tracing_handler.h [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/service_worker_devtools_agent_host.cc [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/devtools/worker_devtools_agent_host.cc [modify] https://crrev.com/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39/content/browser/ssl/ssl_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/55849b167c16bb7f87b5c747b02d27f531bc4086 commit 55849b167c16bb7f87b5c747b02d27f531bc4086 Author: dgozman <dgozman@chromium.org> Date: Thu May 18 23:11:20 2017 [inspector] Refactor inspector test - moved all extensions to inspector_test.cc; - properly supported multiple context groups and sessions; - better isolation between components; - better infrastructure in protocol-test. BUG= chromium:590878 Review-Url: https://codereview.chromium.org/2890463004 Cr-Commit-Position: refs/heads/master@{#45409} [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/console/destroy-context-during-log.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/debugger/destory-in-break-program.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/debugger/framework-break.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/debugger/framework-precise-ranges.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/debugger/framework-stepping.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/debugger/get-possible-breakpoints.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/debugger/inspector-break-api.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/debugger/pause.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/debugger/step-over-another-context-group.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/debugger/stepping-ignores-injected-script.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/debugger/stepping-with-exposed-injected-script.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/debugger/wasm-scripts.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/inspector-impl.cc [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/inspector-impl.h [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/inspector-test.cc [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/isolate-data.cc [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/isolate-data.h [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/json-parse.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/protocol-test.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/runtime/create-context.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/runtime/runtime-restore.js [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/task-runner.cc [modify] https://crrev.com/55849b167c16bb7f87b5c747b02d27f531bc4086/test/inspector/task-runner.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/3655dc52b2f9c76c46a28a567ad5176c5d89612d commit 3655dc52b2f9c76c46a28a567ad5176c5d89612d Author: dgozman <dgozman@chromium.org> Date: Wed May 31 00:07:55 2017 [inspector] Prepare some methods in V8InspectorImpl to multiple sessions - introduced session id, which fixes an issue of reconnect while evaluating; - forEachContext provides a safe way to iterate over contexts in a group. BUG= chromium:590878 Review-Url: https://codereview.chromium.org/2905543004 Cr-Commit-Position: refs/heads/master@{#45613} [modify] https://crrev.com/3655dc52b2f9c76c46a28a567ad5176c5d89612d/src/inspector/injected-script.cc [modify] https://crrev.com/3655dc52b2f9c76c46a28a567ad5176c5d89612d/src/inspector/injected-script.h [modify] https://crrev.com/3655dc52b2f9c76c46a28a567ad5176c5d89612d/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/3655dc52b2f9c76c46a28a567ad5176c5d89612d/src/inspector/v8-debugger.cc [modify] https://crrev.com/3655dc52b2f9c76c46a28a567ad5176c5d89612d/src/inspector/v8-inspector-impl.cc [modify] https://crrev.com/3655dc52b2f9c76c46a28a567ad5176c5d89612d/src/inspector/v8-inspector-impl.h [modify] https://crrev.com/3655dc52b2f9c76c46a28a567ad5176c5d89612d/src/inspector/v8-inspector-session-impl.cc [modify] https://crrev.com/3655dc52b2f9c76c46a28a567ad5176c5d89612d/src/inspector/v8-inspector-session-impl.h [modify] https://crrev.com/3655dc52b2f9c76c46a28a567ad5176c5d89612d/src/inspector/v8-runtime-agent-impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed commit 375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed Author: dgozman <dgozman@chromium.org> Date: Thu Jun 01 21:33:59 2017 [inspector] Support multiple sessions per context group This patch adds ability to connect multiple sessions to a single context group. This is an experimental feature, which is already supported in test harness. So far covered runtime domain with tests (and found a bug thanks to the test). More tests to follow in next patches, probably with code adjustments as well. BUG= chromium:590878 Review-Url: https://codereview.chromium.org/2906153002 Cr-Commit-Position: refs/heads/master@{#45667} [modify] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/src/inspector/injected-script.cc [modify] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/src/inspector/inspected-context.cc [modify] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/src/inspector/inspected-context.h [modify] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/src/inspector/v8-console-message.cc [modify] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/src/inspector/v8-console.cc [modify] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/src/inspector/v8-debugger.cc [modify] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/src/inspector/v8-debugger.h [modify] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/src/inspector/v8-inspector-impl.cc [modify] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/src/inspector/v8-inspector-impl.h [modify] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/src/inspector/v8-runtime-agent-impl.cc [add] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/test/inspector/debugger/set-skip-all-pauses-expected.txt [add] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/test/inspector/debugger/set-skip-all-pauses.js [modify] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/test/inspector/isolate-data.cc [modify] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/test/inspector/isolate-data.h [add] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/test/inspector/sessions/create-session-expected.txt [add] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/test/inspector/sessions/create-session.js [add] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/test/inspector/sessions/runtime-console-api-called-expected.txt [add] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/test/inspector/sessions/runtime-console-api-called.js [add] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/test/inspector/sessions/runtime-evaluate-exception-expected.txt [add] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/test/inspector/sessions/runtime-evaluate-exception.js [add] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/test/inspector/sessions/runtime-evaluate-expected.txt [add] https://crrev.com/375bea1c45e4ce1f71d9a2ab3a3c6e38a5833eed/test/inspector/sessions/runtime-evaluate.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/b5e81c7ccf304407190ebd4dcfef2388c447d7a0 commit b5e81c7ccf304407190ebd4dcfef2388c447d7a0 Author: dgozman <dgozman@chromium.org> Date: Mon Jun 05 17:37:25 2017 [inspector] Create InjectedScript per session in each context This gives sessions separate remote objects space and also makes command line api respect the session it was called from. BUG= chromium:590878 Review-Url: https://codereview.chromium.org/2916803005 Cr-Commit-Position: refs/heads/master@{#45708} [modify] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/src/inspector/injected-script.cc [modify] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/src/inspector/injected-script.h [modify] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/src/inspector/inspected-context.cc [modify] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/src/inspector/inspected-context.h [modify] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/src/inspector/v8-console.cc [modify] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/src/inspector/v8-console.h [modify] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/src/inspector/v8-inspector-session-impl.cc [modify] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/test/inspector/inspector-test.cc [modify] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/test/inspector/isolate-data.cc [modify] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/test/inspector/isolate-data.h [modify] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/test/inspector/protocol-test.js [add] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/test/inspector/sessions/runtime-command-line-api-expected.txt [add] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/test/inspector/sessions/runtime-command-line-api.js [add] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/test/inspector/sessions/runtime-remote-object-expected.txt [add] https://crrev.com/b5e81c7ccf304407190ebd4dcfef2388c447d7a0/test/inspector/sessions/runtime-remote-object.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/f5767bf6c4eb693a1a754f27230300a2a1c1d72b commit f5767bf6c4eb693a1a754f27230300a2a1c1d72b Author: dgozman <dgozman@chromium.org> Date: Mon Jun 05 18:41:00 2017 [inspector] Make pausing on console.assert work with multiple sessions Instead of going through debugger agent, this patch implements console.assert pause similar to debugger statement and OOM break. New test uncovered a bug, where pause on exceptions state mix up between different context groups. Added a TODO to fix it. BUG= chromium:590878 Review-Url: https://codereview.chromium.org/2916363002 Cr-Commit-Position: refs/heads/master@{#45711} [modify] https://crrev.com/f5767bf6c4eb693a1a754f27230300a2a1c1d72b/src/inspector/v8-console.cc [modify] https://crrev.com/f5767bf6c4eb693a1a754f27230300a2a1c1d72b/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/f5767bf6c4eb693a1a754f27230300a2a1c1d72b/src/inspector/v8-debugger-agent-impl.h [modify] https://crrev.com/f5767bf6c4eb693a1a754f27230300a2a1c1d72b/src/inspector/v8-debugger.cc [modify] https://crrev.com/f5767bf6c4eb693a1a754f27230300a2a1c1d72b/src/inspector/v8-debugger.h [add] https://crrev.com/f5767bf6c4eb693a1a754f27230300a2a1c1d72b/test/inspector/sessions/pause-on-console-assert-expected.txt [add] https://crrev.com/f5767bf6c4eb693a1a754f27230300a2a1c1d72b/test/inspector/sessions/pause-on-console-assert.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/754f81e20e9e7abfb3ce82e73a3389a72f4657a6 commit 754f81e20e9e7abfb3ce82e73a3389a72f4657a6 Author: dgozman <dgozman@chromium.org> Date: Mon Jun 05 22:14:13 2017 [inspector] Test how Profiler interacts with multiple sessions BUG= chromium:590878 Review-Url: https://codereview.chromium.org/2920313002 Cr-Commit-Position: refs/heads/master@{#45715} [add] https://crrev.com/754f81e20e9e7abfb3ce82e73a3389a72f4657a6/test/inspector/sessions/cpu-profile-expected.txt [add] https://crrev.com/754f81e20e9e7abfb3ce82e73a3389a72f4657a6/test/inspector/sessions/cpu-profile.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/5bba0d1a0bb44edaae87e772607ec0ab03e01988 commit 5bba0d1a0bb44edaae87e772607ec0ab03e01988 Author: mtrofin <mtrofin@chromium.org> Date: Mon Jun 05 22:32:20 2017 Revert of [inspector] Test how Profiler interacts with multiple sessions (patchset #2 id:10003 of https://codereview.chromium.org/2920313002/ ) Reason for revert: Bot failure: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/13172 Original issue's description: > [inspector] Test how Profiler interacts with multiple sessions > > BUG= chromium:590878 > > Review-Url: https://codereview.chromium.org/2920313002 > Cr-Commit-Position: refs/heads/master@{#45715} > Committed: https://chromium.googlesource.com/v8/v8/+/754f81e20e9e7abfb3ce82e73a3389a72f4657a6 TBR=alph@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= chromium:590878 Review-Url: https://codereview.chromium.org/2928493002 Cr-Commit-Position: refs/heads/master@{#45716} [delete] https://crrev.com/754f81e20e9e7abfb3ce82e73a3389a72f4657a6/test/inspector/sessions/cpu-profile-expected.txt [delete] https://crrev.com/754f81e20e9e7abfb3ce82e73a3389a72f4657a6/test/inspector/sessions/cpu-profile.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/679604bdd2991a19cadf7ab5c462fc6f368f32fc commit 679604bdd2991a19cadf7ab5c462fc6f368f32fc Author: dgozman <dgozman@chromium.org> Date: Tue Jun 06 00:14:01 2017 [inspector] Test how Profiler interacts with multiple sessions BUG= chromium:590878 Review-Url: https://codereview.chromium.org/2920313002 Cr-Original-Commit-Position: refs/heads/master@{#45715} Committed: https://chromium.googlesource.com/v8/v8/+/754f81e20e9e7abfb3ce82e73a3389a72f4657a6 Review-Url: https://codereview.chromium.org/2920313002 Cr-Commit-Position: refs/heads/master@{#45717} [add] https://crrev.com/679604bdd2991a19cadf7ab5c462fc6f368f32fc/test/inspector/sessions/cpu-profile-expected.txt [add] https://crrev.com/679604bdd2991a19cadf7ab5c462fc6f368f32fc/test/inspector/sessions/cpu-profile.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/0532e964980b3cc72e2e4c2ba066125e2fe6d217 commit 0532e964980b3cc72e2e4c2ba066125e2fe6d217 Author: dgozman <dgozman@chromium.org> Date: Tue Jun 06 15:43:39 2017 Revert of [inspector] Test how Profiler interacts with multiple sessions (patchset #3 id:30001 of https://codereview.chromium.org/2920313002/ ) Reason for revert: DCHECKS triggering in debug build. Original issue's description: > [inspector] Test how Profiler interacts with multiple sessions > > BUG= chromium:590878 > > Review-Url: https://codereview.chromium.org/2920313002 > Cr-Original-Commit-Position: refs/heads/master@{#45715} > Committed: https://chromium.googlesource.com/v8/v8/+/754f81e20e9e7abfb3ce82e73a3389a72f4657a6 > Review-Url: https://codereview.chromium.org/2920313002 > Cr-Commit-Position: refs/heads/master@{#45717} > Committed: https://chromium.googlesource.com/v8/v8/+/679604bdd2991a19cadf7ab5c462fc6f368f32fc TBR=alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= chromium:590878 Review-Url: https://codereview.chromium.org/2926533003 Cr-Commit-Position: refs/heads/master@{#45736} [delete] https://crrev.com/c7fa0bf0e0173ddf814b19742073ce3fc63b6e20/test/inspector/sessions/cpu-profile-expected.txt [delete] https://crrev.com/c7fa0bf0e0173ddf814b19742073ce3fc63b6e20/test/inspector/sessions/cpu-profile.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/579c1e2976efdae7416ce670b12c8a6365695f05 commit 579c1e2976efdae7416ce670b12c8a6365695f05 Author: dgozman <dgozman@chromium.org> Date: Tue Jun 06 17:09:22 2017 [inspector] Test how multiple sessions interact with pausing Found multiple issues (added TODOs for them): - isPaused() check is global, so one can resume from another session/context group without receiving 'paused' notification; - setBreakpointsActive flag is global affecting all sessions and context groups; - max async call stack depth is global, and should be per context group. BUG= chromium:590878 Review-Url: https://codereview.chromium.org/2921373002 Cr-Commit-Position: refs/heads/master@{#45742} [modify] https://crrev.com/579c1e2976efdae7416ce670b12c8a6365695f05/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/579c1e2976efdae7416ce670b12c8a6365695f05/src/inspector/v8-debugger.cc [add] https://crrev.com/579c1e2976efdae7416ce670b12c8a6365695f05/test/inspector/sessions/debugger-stepping-and-breakpoints-expected.txt [add] https://crrev.com/579c1e2976efdae7416ce670b12c8a6365695f05/test/inspector/sessions/debugger-stepping-and-breakpoints.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/31662cc3e4552927bffd6b1f9ecf167ea4675a37 commit 31662cc3e4552927bffd6b1f9ecf167ea4675a37 Author: dgozman <dgozman@chromium.org> Date: Wed Jun 07 00:06:08 2017 [inspector] Make breakpoints active state per-agent ... as opposite to a global per-isolate one. Also streamlined multiple checks into a single acceptsPause() method. BUG= chromium:590878 Review-Url: https://codereview.chromium.org/2925903002 Cr-Commit-Position: refs/heads/master@{#45749} [modify] https://crrev.com/31662cc3e4552927bffd6b1f9ecf167ea4675a37/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/31662cc3e4552927bffd6b1f9ecf167ea4675a37/src/inspector/v8-debugger-agent-impl.h [modify] https://crrev.com/31662cc3e4552927bffd6b1f9ecf167ea4675a37/src/inspector/v8-debugger.cc [modify] https://crrev.com/31662cc3e4552927bffd6b1f9ecf167ea4675a37/src/inspector/v8-debugger.h [modify] https://crrev.com/31662cc3e4552927bffd6b1f9ecf167ea4675a37/test/inspector/sessions/debugger-stepping-and-breakpoints-expected.txt [modify] https://crrev.com/31662cc3e4552927bffd6b1f9ecf167ea4675a37/test/inspector/sessions/debugger-stepping-and-breakpoints.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdc887c27d1270de1006ae0ac972fb0215eef62a commit cdc887c27d1270de1006ae0ac972fb0215eef62a Author: dgozman <dgozman@chromium.org> Date: Wed Jun 07 04:47:16 2017 [DevTools] Support multiple sessions in WebDevToolsAgentImpl BUG= 590878 Review-Url: https://codereview.chromium.org/2860013002 Cr-Commit-Position: refs/heads/master@{#477551} [modify] https://crrev.com/cdc887c27d1270de1006ae0ac972fb0215eef62a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/cdc887c27d1270de1006ae0ac972fb0215eef62a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c97486f93ac2360cb9d7b8a29aa5a624da3fb2df commit c97486f93ac2360cb9d7b8a29aa5a624da3fb2df Author: dgozman <dgozman@chromium.org> Date: Fri Jun 16 21:12:41 2017 [DevTools] Make DevToolsSession own it's DevToolsMessageChunkProcessor Session now handles the state cookie and messages waiting for response. This will also help with multiple sessions. BUG= 590878 Review-Url: https://codereview.chromium.org/2933243002 Cr-Commit-Position: refs/heads/master@{#480170} [modify] https://crrev.com/c97486f93ac2360cb9d7b8a29aa5a624da3fb2df/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/c97486f93ac2360cb9d7b8a29aa5a624da3fb2df/content/browser/devtools/devtools_session.cc [modify] https://crrev.com/c97486f93ac2360cb9d7b8a29aa5a624da3fb2df/content/browser/devtools/devtools_session.h [modify] https://crrev.com/c97486f93ac2360cb9d7b8a29aa5a624da3fb2df/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/c97486f93ac2360cb9d7b8a29aa5a624da3fb2df/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/c97486f93ac2360cb9d7b8a29aa5a624da3fb2df/content/browser/devtools/worker_devtools_agent_host.cc [modify] https://crrev.com/c97486f93ac2360cb9d7b8a29aa5a624da3fb2df/content/browser/devtools/worker_devtools_agent_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/451245fd167ca58e0a604c7b0b94df4d5070e794 commit 451245fd167ca58e0a604c7b0b94df4d5070e794 Author: dgozman <dgozman@chromium.org> Date: Tue Jun 20 21:55:54 2017 [DevTools] Support multiple sessions in dedicated workers This is internal refactoring only, protocol does not expose an ability to connect multiple sessions yet. BUG= 590878 Review-Url: https://codereview.chromium.org/2951833002 Cr-Commit-Position: refs/heads/master@{#480973} [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/workers/SharedWorkerReportingProxy.cpp [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/workers/SharedWorkerReportingProxy.h [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.cpp [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.h [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp [modify] https://crrev.com/451245fd167ca58e0a604c7b0b94df4d5070e794/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af7a673ba20493cf63845a5506ba8d44d6e49ca3 commit af7a673ba20493cf63845a5506ba8d44d6e49ca3 Author: dgozman <dgozman@chromium.org> Date: Thu Jun 29 21:37:28 2017 [DevTools] Provide Target.targetInfoChanged notification This one currently triggers when attached bit has changed on target. This moves node-specific logic to frontend, and simplifies backend in preparation for multi-client. BUG= 590878 Review-Url: https://codereview.chromium.org/2956423003 Cr-Commit-Position: refs/heads/master@{#483495} [modify] https://crrev.com/af7a673ba20493cf63845a5506ba8d44d6e49ca3/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/af7a673ba20493cf63845a5506ba8d44d6e49ca3/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/af7a673ba20493cf63845a5506ba8d44d6e49ca3/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/af7a673ba20493cf63845a5506ba8d44d6e49ca3/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/af7a673ba20493cf63845a5506ba8d44d6e49ca3/third_party/WebKit/Source/core/inspector/browser_protocol.json [modify] https://crrev.com/af7a673ba20493cf63845a5506ba8d44d6e49ca3/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f204165f361bd4e8c3a125517603be2af437c99 commit 9f204165f361bd4e8c3a125517603be2af437c99 Author: dgozman <dgozman@chromium.org> Date: Fri Jul 14 00:55:47 2017 [DevTools] Split auto-attach part of TargetHandler into a separate class This will make multiple sessions in TargetHandler easier to handle. BUG= 590878 Review-Url: https://codereview.chromium.org/2969753002 Cr-Commit-Position: refs/heads/master@{#486558} [modify] https://crrev.com/9f204165f361bd4e8c3a125517603be2af437c99/content/browser/BUILD.gn [add] https://crrev.com/9f204165f361bd4e8c3a125517603be2af437c99/content/browser/devtools/protocol/target_auto_attacher.cc [add] https://crrev.com/9f204165f361bd4e8c3a125517603be2af437c99/content/browser/devtools/protocol/target_auto_attacher.h [modify] https://crrev.com/9f204165f361bd4e8c3a125517603be2af437c99/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/9f204165f361bd4e8c3a125517603be2af437c99/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/9f204165f361bd4e8c3a125517603be2af437c99/content/browser/devtools/render_frame_devtools_agent_host.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3 commit 237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3 Author: Dmitry Gozman <dgozman@chromium.org> Date: Thu Jul 20 20:47:14 2017 [DevTools] Support multiple sessions in Target domain BUG= 590878 Change-Id: Idcebf0336623322813b4cdfac66183d37c28f2bd Reviewed-on: https://chromium-review.googlesource.com/573411 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#488395} [modify] https://crrev.com/237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3/content/browser/devtools/protocol/target_auto_attacher.cc [modify] https://crrev.com/237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3/content/browser/devtools/protocol/target_auto_attacher.h [modify] https://crrev.com/237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/inspector-protocol-test.js [modify] https://crrev.com/237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-agents-expected.txt [modify] https://crrev.com/237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3/third_party/WebKit/Source/core/inspector/browser_protocol.json [modify] https://crrev.com/237f82767da3bbdcd8d6ad3fa4449ef6a3fe8bd3/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
Chromedriver uses the following domains: Console, DOM, Emulation, HeapProfiler, Input, Inspector, Log, Network, Page, Profiler, Runtime, Tracing.
WebStorm uses Debugger and Runtime.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bca6d017817166b770cc4862159805f27bd803d commit 0bca6d017817166b770cc4862159805f27bd803d Author: Dmitry Gozman <dgozman@chromium.org> Date: Fri Aug 18 22:19:30 2017 [DevTools] Support multiple sessions in non-browser-side-navigation world Bug: 590878 Change-Id: I66d072cc780dbb9d9701febc65f6ab2f4a33621b Reviewed-on: https://chromium-review.googlesource.com/621769 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#495715} [modify] https://crrev.com/0bca6d017817166b770cc4862159805f27bd803d/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/0bca6d017817166b770cc4862159805f27bd803d/content/browser/devtools/render_frame_devtools_agent_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8962a6d9c488ddc69792adbdb38737c8f16988c8 commit 8962a6d9c488ddc69792adbdb38737c8f16988c8 Author: Dmitry Gozman <dgozman@chromium.org> Date: Sat Aug 19 05:19:50 2017 [DevTools] Add basic tests for multiple sessions Many domains are ready for multiple sessions today. JS domains are already covered with tests in V8, so here we add tests to Chrome-specific ones. BUG= 590878 Change-Id: Iea76a3fbf79b127630445db60b94b6928158804a Reviewed-on: https://chromium-review.googlesource.com/582232 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#495803} [modify] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/content/browser/devtools/render_frame_devtools_agent_host.cc [add] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/LayoutTests/inspector-protocol/sessions/dom-modification-expected.txt [add] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/LayoutTests/inspector-protocol/sessions/dom-modification.js [add] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/LayoutTests/inspector-protocol/sessions/input-dispatch-mouse-event-expected.txt [add] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/LayoutTests/inspector-protocol/sessions/input-dispatch-mouse-event.js [add] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/LayoutTests/inspector-protocol/sessions/log-entry-added-expected.txt [add] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/LayoutTests/inspector-protocol/sessions/log-entry-added.js [add] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/LayoutTests/inspector-protocol/sessions/page-frame-events-expected.txt [add] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/LayoutTests/inspector-protocol/sessions/page-frame-events.js [add] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/LayoutTests/inspector-protocol/sessions/page-set-document-content-expected.txt [add] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/LayoutTests/inspector-protocol/sessions/page-set-document-content.js [add] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/LayoutTests/inspector-protocol/sessions/runtime-evaluate-expected.txt [add] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/LayoutTests/inspector-protocol/sessions/runtime-evaluate.js [add] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/LayoutTests/inspector-protocol/sessions/tracing-start-expected.txt [add] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/LayoutTests/inspector-protocol/sessions/tracing-start.js [modify] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/8962a6d9c488ddc69792adbdb38737c8f16988c8/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e792e102ed4fb22d4df5e07666155361085f34d0 commit e792e102ed4fb22d4df5e07666155361085f34d0 Author: Dmitry Gozman <dgozman@chromium.org> Date: Mon Aug 21 23:55:41 2017 [DevTools] Enable multiple sessions under kEnableDevToolsExperiments flag Device mode and disabled cache require user toggle if another client is already attached. Bug: 590878 Change-Id: I58db62201a510d7729b9100e0174b691d2d82a0d Reviewed-on: https://chromium-review.googlesource.com/624697 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#496130} [modify] https://crrev.com/e792e102ed4fb22d4df5e07666155361085f34d0/chrome/browser/devtools/devtools_ui_bindings.cc [modify] https://crrev.com/e792e102ed4fb22d4df5e07666155361085f34d0/chrome/browser/devtools/devtools_ui_bindings.h [modify] https://crrev.com/e792e102ed4fb22d4df5e07666155361085f34d0/chrome/browser/devtools/devtools_window.cc [modify] https://crrev.com/e792e102ed4fb22d4df5e07666155361085f34d0/chrome/browser/devtools/devtools_window.h [modify] https://crrev.com/e792e102ed4fb22d4df5e07666155361085f34d0/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/e792e102ed4fb22d4df5e07666155361085f34d0/content/public/browser/devtools_agent_host.h [modify] https://crrev.com/e792e102ed4fb22d4df5e07666155361085f34d0/third_party/WebKit/Source/devtools/front_end/common/Settings.js [modify] https://crrev.com/e792e102ed4fb22d4df5e07666155361085f34d0/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js [modify] https://crrev.com/e792e102ed4fb22d4df5e07666155361085f34d0/third_party/WebKit/Source/devtools/front_end/main/module.json
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/dc26486cf31077e4e47c2ed9cf1eb5f859ab8d5b commit dc26486cf31077e4e47c2ed9cf1eb5f859ab8d5b Author: Dmitry Gozman <dgozman@chromium.org> Date: Tue Aug 22 21:43:27 2017 [inspector] Issue Debugger.paused during Debugger.enable if already paused Bug: chromium:590878 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id94d3557980522d98c136aa444615930bee2e3ba Reviewed-on: https://chromium-review.googlesource.com/625159 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47526} [modify] https://crrev.com/dc26486cf31077e4e47c2ed9cf1eb5f859ab8d5b/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/dc26486cf31077e4e47c2ed9cf1eb5f859ab8d5b/test/inspector/sessions/debugger-stepping-and-breakpoints-expected.txt [modify] https://crrev.com/dc26486cf31077e4e47c2ed9cf1eb5f859ab8d5b/test/inspector/sessions/debugger-stepping-and-breakpoints.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed41e02276efc1c32085b2837f93f2dcfcdc471e commit ed41e02276efc1c32085b2837f93f2dcfcdc471e Author: Dmitry Gozman <dgozman@chromium.org> Date: Thu Aug 24 20:12:10 2017 [DevTools] Enable multiple sessions This patch allows: - multiple connections through http handler; - multiple debugging sessions via debugger api from different extensions, but not from the same one; - single DevTools window in addition to any other debuggers. Bug: 590878 Change-Id: Ib19ff0325235a40432f4f247edaefc2dfd5cb2a2 Reviewed-on: https://chromium-review.googlesource.com/629816 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#497170} [modify] https://crrev.com/ed41e02276efc1c32085b2837f93f2dcfcdc471e/chrome/browser/devtools/devtools_ui_bindings.cc [modify] https://crrev.com/ed41e02276efc1c32085b2837f93f2dcfcdc471e/chrome/browser/extensions/api/debugger/debugger_api.cc [modify] https://crrev.com/ed41e02276efc1c32085b2837f93f2dcfcdc471e/chrome/browser/extensions/api/debugger/debugger_api.h [modify] https://crrev.com/ed41e02276efc1c32085b2837f93f2dcfcdc471e/chrome/test/data/extensions/api_test/debugger/background.js [modify] https://crrev.com/ed41e02276efc1c32085b2837f93f2dcfcdc471e/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/ed41e02276efc1c32085b2837f93f2dcfcdc471e/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/ed41e02276efc1c32085b2837f93f2dcfcdc471e/content/browser/devtools/devtools_http_handler.cc [modify] https://crrev.com/ed41e02276efc1c32085b2837f93f2dcfcdc471e/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/ed41e02276efc1c32085b2837f93f2dcfcdc471e/content/browser/devtools/site_per_process_devtools_browsertest.cc [modify] https://crrev.com/ed41e02276efc1c32085b2837f93f2dcfcdc471e/content/public/browser/devtools_agent_host.h [modify] https://crrev.com/ed41e02276efc1c32085b2837f93f2dcfcdc471e/content/shell/browser/shell_devtools_bindings.cc [modify] https://crrev.com/ed41e02276efc1c32085b2837f93f2dcfcdc471e/headless/lib/browser/headless_devtools_client_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7a1c2f774a634cd56d9bccbc881ab04f22a998c commit f7a1c2f774a634cd56d9bccbc881ab04f22a998c Author: Dmitry Gozman <dgozman@chromium.org> Date: Tue Sep 12 19:37:02 2017 [DevTools] Support multiple sessions in remote debugging Bug: 590878 Change-Id: I5606ba2082e7ea81b95547b8b28f476ce3f59b43 Reviewed-on: https://chromium-review.googlesource.com/630564 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501361} [modify] https://crrev.com/f7a1c2f774a634cd56d9bccbc881ab04f22a998c/chrome/browser/android/devtools_manager_delegate_android.cc [modify] https://crrev.com/f7a1c2f774a634cd56d9bccbc881ab04f22a998c/chrome/browser/devtools/device/devtools_device_discovery.cc [modify] https://crrev.com/f7a1c2f774a634cd56d9bccbc881ab04f22a998c/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/f7a1c2f774a634cd56d9bccbc881ab04f22a998c/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/f7a1c2f774a634cd56d9bccbc881ab04f22a998c/content/browser/devtools/devtools_manager_unittest.cc [modify] https://crrev.com/f7a1c2f774a634cd56d9bccbc881ab04f22a998c/content/browser/devtools/devtools_session.h [modify] https://crrev.com/f7a1c2f774a634cd56d9bccbc881ab04f22a998c/content/browser/devtools/forwarding_agent_host.cc [modify] https://crrev.com/f7a1c2f774a634cd56d9bccbc881ab04f22a998c/content/browser/devtools/forwarding_agent_host.h [modify] https://crrev.com/f7a1c2f774a634cd56d9bccbc881ab04f22a998c/content/public/browser/devtools_external_agent_proxy_delegate.h
The implementation is done. Any bugs found will get a separate issue now.
Comment 1 by bugdroid1@chromium.org
, Mar 1 2016