New issue
Advanced search Search tips

Issue 590870 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 522133



Sign in to add a comment

Port Chromium's Linux GPU workarounds to ANGLE

Project Member Reported by cwallez@chromium.org, Feb 29 2016

Issue description

To allow Chromium's GPU command buffer to be mostly passthrough we need to port the GPU driver bug workaround logic over to ANGLE. This is a tracking bug for the Linux part of this porting,
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/cc068e9385d2d3023793ffcd20471222f87e8a60

commit cc068e9385d2d3023793ffcd20471222f87e8a60
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon Feb 29 21:37:04 2016

Add DisplayGL::getDriverVersion and implementation on Linux NVIDIA

Some GPU driver bug workarounds should be active only for specific
driver version ranges. This adds NVIDIA Linux driver detection using
the XNVCtrl X11 extension.

BUG=590870

Change-Id: I8cbf692a0c8a6da7473169f29d720bdc2d07663d
Reviewed-on: https://chromium-review.googlesource.com/329637
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/libANGLE/renderer/gl/wgl/DisplayWGL.h
[add] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/third_party/libXNVCtrl/NVCtrl.h
[modify] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/libANGLE/renderer/gl/cgl/DisplayCGL.mm
[add] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/third_party/libXNVCtrl/nv_control.h
[add] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/third_party/libXNVCtrl/NVCtrlLib.h
[modify] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/libANGLE/renderer/gl/DisplayGL.h
[modify] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/libANGLE/renderer/gl/cgl/DisplayCGL.h
[add] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/third_party/libXNVCtrl/LICENSE
[add] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/third_party/libXNVCtrl/BUILD.gn
[modify] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/BUILD.gn
[add] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/third_party/libXNVCtrl/README.angle
[add] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/third_party/libXNVCtrl/libXNVCtrl.gyp
[add] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/third_party/libXNVCtrl/NVCtrl.c
[modify] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/libANGLE/renderer/gl/glx/DisplayGLX.cpp
[modify] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/libGLESv2.gypi
[modify] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/libANGLE/renderer/gl/renderergl_utils.h
[modify] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/libANGLE/renderer/gl/wgl/DisplayWGL.cpp
[modify] https://crrev.com/cc068e9385d2d3023793ffcd20471222f87e8a60/src/libANGLE/renderer/gl/glx/DisplayGLX.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a5b73fc8615892260d6f47242d1d6a642e3dcfc

commit 6a5b73fc8615892260d6f47242d1d6a642e3dcfc
Author: jmadill <jmadill@chromium.org>
Date: Sat Apr 02 01:36:02 2016

Roll ANGLE 00f394e..0c0d800

https://chromium.googlesource.com/angle/angle.git/+log/00f394e..0c0d800

BUG=593448, 598944 , 595836 ,590870
TBR=geofflang@chromium.org
TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1849013003

Cr-Commit-Position: refs/heads/master@{#384777}

[modify] https://crrev.com/6a5b73fc8615892260d6f47242d1d6a642e3dcfc/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/aab7e8683b444011825dc970ae0324813f448f1c

commit aab7e8683b444011825dc970ae0324813f448f1c
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon Apr 18 15:47:28 2016

DisplayGLX: Add AMD driver version detection

BUG=590870

Change-Id: I8b2548038635182bafa691671bdaa16f12b45694
Reviewed-on: https://chromium-review.googlesource.com/339450
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/aab7e8683b444011825dc970ae0324813f448f1c/src/libANGLE/renderer/gl/glx/DisplayGLX.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50ab168147c80f5d8c223eca33899fc8053bca2e

commit 50ab168147c80f5d8c223eca33899fc8053bca2e
Author: jmadill <jmadill@chromium.org>
Date: Mon May 02 16:09:25 2016

Roll ANGLE 250062b..bbd663a

https://chromium.googlesource.com/angle/angle.git/+log/250062b..bbd663a

BUG= 541551 ,590870, 605775 
TBR=geofflang@chromium.org
TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1941803002
Cr-Commit-Position: refs/heads/master@{#390958}

[modify] https://crrev.com/50ab168147c80f5d8c223eca33899fc8053bca2e/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6

commit 5d79fa21a0e1536b439584a8bce1f17fbc0c22b6
Author: cwallez <cwallez@chromium.org>
Date: Thu Sep 08 21:05:42 2016

GPU driver bug list: remove the use program after link workaround

The origins of this workaround go waaaaay in the past and seem to
contradict themselves (only OSX, vs. not OSX)

BUG=590870
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2326713002
Cr-Commit-Position: refs/heads/master@{#417397}

[modify] https://crrev.com/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6/gpu/config/gpu_driver_bug_workaround_type.h

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b358646432848ce6d8954fa28bd7833e51ebbc7c

commit b358646432848ce6d8954fa28bd7833e51ebbc7c
Author: cwallez <cwallez@chromium.org>
Date: Fri Sep 09 16:03:17 2016

GPU driver bug list: Remove Linux Intel occlusion queries workaround

The relevant WebGL2 CTS tests work fine on recent Intel drivers.

BUG=590870
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2319223004
Cr-Commit-Position: refs/heads/master@{#417594}

[modify] https://crrev.com/b358646432848ce6d8954fa28bd7833e51ebbc7c/gpu/config/gpu_driver_bug_list_json.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed7c9c148e43cb09bcef26c131bd445a1d0be078

commit ed7c9c148e43cb09bcef26c131bd445a1d0be078
Author: cwallez <cwallez@chromium.org>
Date: Mon Sep 12 13:48:38 2016

Revert of GPU driver bug list: remove the use program after link workaround (patchset #2 id:20001 of https://codereview.chromium.org/2326713002/ )

Reason for revert:
Potential regression https://bugs.chromium.org/p/chromium/issues/detail?id=645498

Original issue's description:
> GPU driver bug list: remove the use program after link workaround
>
> The origins of this workaround go waaaaay in the past and seem to
> contradict themselves (only OSX, vs. not OSX)
>
> BUG=590870
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6
> Cr-Commit-Position: refs/heads/master@{#417397}

TBR=zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590870
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2326553004
Cr-Commit-Position: refs/heads/master@{#417930}

[modify] https://crrev.com/ed7c9c148e43cb09bcef26c131bd445a1d0be078/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/ed7c9c148e43cb09bcef26c131bd445a1d0be078/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/ed7c9c148e43cb09bcef26c131bd445a1d0be078/gpu/config/gpu_driver_bug_workaround_type.h

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f569fe159454c63b60782fbaa1d37caa9f32ec3

commit 0f569fe159454c63b60782fbaa1d37caa9f32ec3
Author: cwallez <cwallez@chromium.org>
Date: Tue Sep 13 15:15:40 2016

Reland of GPU driver bug list: remove the use program after link workaround (patchset #2 id:100001 of https://codereview.chromium.org/2326553004/ )

Reason for revert:
Revert didn't help.

Original issue's description:
> Revert of GPU driver bug list: remove the use program after link workaround (patchset #2 id:20001 of https://codereview.chromium.org/2326713002/ )
>
> Reason for revert:
> Potential regression https://bugs.chromium.org/p/chromium/issues/detail?id=645498
>
> Original issue's description:
> > GPU driver bug list: remove the use program after link workaround
> >
> > The origins of this workaround go waaaaay in the past and seem to
> > contradict themselves (only OSX, vs. not OSX)
> >
> > BUG=590870
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6
> > Cr-Commit-Position: refs/heads/master@{#417397}
>
> TBR=zmo@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=590870
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/ed7c9c148e43cb09bcef26c131bd445a1d0be078
> Cr-Commit-Position: refs/heads/master@{#417930}

TBR=zmo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=590870

Review-Url: https://codereview.chromium.org/2334203002
Cr-Commit-Position: refs/heads/master@{#418251}

[modify] https://crrev.com/0f569fe159454c63b60782fbaa1d37caa9f32ec3/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/0f569fe159454c63b60782fbaa1d37caa9f32ec3/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/0f569fe159454c63b60782fbaa1d37caa9f32ec3/gpu/config/gpu_driver_bug_workaround_type.h

Blocking: 522133

Sign in to add a comment