Re-enable CertVerifyProcTest.CybertrustGTERoot |
||||||||||||||
Issue descriptionI had to disable CertVerifyProcTest.CybertrustGTERoot because it was failing on multiple Mac bots. I don't know what patch has caused the test to fail, but from the blame set I found out that you made a change in net/ that might be related: "net: merge two versions of SetTCPNoDelay() function into one (issue" Could you re-enable the test once you figure out what is causing the issue? Feel free to re-assign if my quick investigation is wrong. https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/12559/steps/net_unittests%20on%20Mac-10.9/logs/CertVerifyProcTest.CybertrustGTERoot
,
Feb 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f9cd66a841a603275f5137c0d59b093654a054d commit 8f9cd66a841a603275f5137c0d59b093654a054d Author: nektar <nektar@chromium.org> Date: Mon Feb 29 23:14:22 2016 Disables CertVerifyProcTest.CybertrustGTERoot. Failures on multiple bots, e.g. https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/12559/steps/net_unittests%20on%20Mac-10.9/logs/CertVerifyProcTest.CybertrustGTERoot BUG= 590868 NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1751593002 Cr-Commit-Position: refs/heads/master@{#378311} [modify] https://crrev.com/8f9cd66a841a603275f5137c0d59b093654a054d/net/cert/cert_verify_proc_unittest.cc
,
Mar 1 2016
Looks like the certificate in question expired today: 2016-02-29 So this is not related to the suspected revert in https://codereview.chromium.org/1744153003/. Ryan, should this test be removed now?
,
Mar 1 2016
Yes, it should be removed. https://codereview.chromium.org/1751733002/
,
Mar 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ad3f48a16790967f9fc311d83198cc04404b567 commit 9ad3f48a16790967f9fc311d83198cc04404b567 Author: rsleevi <rsleevi@chromium.org> Date: Tue Mar 01 17:16:59 2016 Remove CertVerifyProcTest.CybertrustGTERoot unit test This test originally tested a CA-specific workaround in chain building. However, due to more OS X "quirks", the CA-specific workaround was replaced with a CA-agnostic one. While this unit test did provide some value for the specific CA test, it was only relevant on pre-10.9 systems anyways; with OS X <10.9 being deprecated, this test is no longer relevant for those platforms. Given that the CertVerifyProcWeakDigestTest covers the superset of the GTE issue, simply removing this test is sufficient. BUG= 590868 R=eroman@chromium.org Review URL: https://codereview.chromium.org/1751733002 Cr-Commit-Position: refs/heads/master@{#378462} [modify] https://crrev.com/9ad3f48a16790967f9fc311d83198cc04404b567/net/cert/cert_verify_proc_unittest.cc [modify] https://crrev.com/9ad3f48a16790967f9fc311d83198cc04404b567/net/data/ssl/certificates/README [delete] https://crrev.com/8be1ff11dc1fae61146dbcfaa38e12314d290dca/net/data/ssl/certificates/cybertrust_baltimore_cross_certified_1.pem [delete] https://crrev.com/8be1ff11dc1fae61146dbcfaa38e12314d290dca/net/data/ssl/certificates/cybertrust_baltimore_cross_certified_2.pem [delete] https://crrev.com/8be1ff11dc1fae61146dbcfaa38e12314d290dca/net/data/ssl/certificates/cybertrust_baltimore_root.pem [delete] https://crrev.com/8be1ff11dc1fae61146dbcfaa38e12314d290dca/net/data/ssl/certificates/cybertrust_gte_root.pem [delete] https://crrev.com/8be1ff11dc1fae61146dbcfaa38e12314d290dca/net/data/ssl/certificates/cybertrust_omniroot_chain.pem
,
Mar 1 2016
49/50 TPMs - disabling & deleting a test to keep your release waterfalls green? :)
,
Mar 1 2016
Has this been checked into and validated in ToT?
,
Mar 1 2016
re comment 7: Yes, this is shown by comment #5. As explained, it's disabling & deleting a test that will already fail 100% of the time.
,
Mar 1 2016
,
Mar 2 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/bling/chromium.git/+/9ad3f48a16790967f9fc311d83198cc04404b567 commit 9ad3f48a16790967f9fc311d83198cc04404b567 Author: rsleevi <rsleevi@chromium.org> Date: Tue Mar 01 17:16:59 2016
,
Mar 3 2016
[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.
,
Mar 3 2016
[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.
,
Mar 3 2016
Merge approved for M49 (branch 2623)
,
Mar 3 2016
Please merge your change to M49 branch 2623 asap if you think it is a safe merge. We're planning M49 stable candidate cut for next week release on tomorrow, Friday @ 5:00 PM PST.
,
Mar 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d5ba976a8f0e95a76c4b603a75d85c6a84bc0ee commit 0d5ba976a8f0e95a76c4b603a75d85c6a84bc0ee Author: Ryan Sleevi <rsleevi@chromium.org> Date: Thu Mar 03 21:36:56 2016 Remove CertVerifyProcTest.CybertrustGTERoot unit test This test originally tested a CA-specific workaround in chain building. However, due to more OS X "quirks", the CA-specific workaround was replaced with a CA-agnostic one. While this unit test did provide some value for the specific CA test, it was only relevant on pre-10.9 systems anyways; with OS X <10.9 being deprecated, this test is no longer relevant for those platforms. Given that the CertVerifyProcWeakDigestTest covers the superset of the GTE issue, simply removing this test is sufficient. BUG= 590868 TBR=eroman@chromium.org Review URL: https://codereview.chromium.org/1751733002 Cr-Commit-Position: refs/heads/master@{#378462} (cherry picked from commit 9ad3f48a16790967f9fc311d83198cc04404b567) Review URL: https://codereview.chromium.org/1763853002 . Cr-Commit-Position: refs/branch-heads/2623@{#571} Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907} [modify] https://crrev.com/0d5ba976a8f0e95a76c4b603a75d85c6a84bc0ee/net/cert/cert_verify_proc_unittest.cc [modify] https://crrev.com/0d5ba976a8f0e95a76c4b603a75d85c6a84bc0ee/net/data/ssl/certificates/README [delete] https://crrev.com/3f9af68e9892ec825152065246424a23be9ed115/net/data/ssl/certificates/cybertrust_baltimore_cross_certified_1.pem [delete] https://crrev.com/3f9af68e9892ec825152065246424a23be9ed115/net/data/ssl/certificates/cybertrust_baltimore_cross_certified_2.pem [delete] https://crrev.com/3f9af68e9892ec825152065246424a23be9ed115/net/data/ssl/certificates/cybertrust_baltimore_root.pem [delete] https://crrev.com/3f9af68e9892ec825152065246424a23be9ed115/net/data/ssl/certificates/cybertrust_gte_root.pem [delete] https://crrev.com/3f9af68e9892ec825152065246424a23be9ed115/net/data/ssl/certificates/cybertrust_omniroot_chain.pem
,
Mar 4 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/bling/chromium.git/+/0d5ba976a8f0e95a76c4b603a75d85c6a84bc0ee commit 0d5ba976a8f0e95a76c4b603a75d85c6a84bc0ee Author: Ryan Sleevi <rsleevi@chromium.org> Date: Thu Mar 03 21:36:56 2016
,
Mar 4 2016
Merge approved for M50 (branch 2661). Pls go ahead merge.
,
Mar 4 2016
Ryan is out of office. I will handle the merge to M50 (assuming it hasn't already been done).
,
Mar 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/589c2ab3c663c6eefed35e132db7c77bfea44c94 commit 589c2ab3c663c6eefed35e132db7c77bfea44c94 Author: Eric Roman <eroman@chromium.org> Date: Fri Mar 04 22:27:56 2016 Remove CertVerifyProcTest.CybertrustGTERoot unit test This test originally tested a CA-specific workaround in chain building. However, due to more OS X "quirks", the CA-specific workaround was replaced with a CA-agnostic one. While this unit test did provide some value for the specific CA test, it was only relevant on pre-10.9 systems anyways; with OS X <10.9 being deprecated, this test is no longer relevant for those platforms. Given that the CertVerifyProcWeakDigestTest covers the superset of the GTE issue, simply removing this test is sufficient. BUG= 590868 R=eroman@chromium.org Review URL: https://codereview.chromium.org/1751733002 Cr-Commit-Position: refs/heads/master@{#378462} (cherry picked from commit 9ad3f48a16790967f9fc311d83198cc04404b567) Review URL: https://codereview.chromium.org/1764363002 . Cr-Commit-Position: refs/branch-heads/2661@{#87} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/589c2ab3c663c6eefed35e132db7c77bfea44c94/net/cert/cert_verify_proc_unittest.cc [modify] https://crrev.com/589c2ab3c663c6eefed35e132db7c77bfea44c94/net/data/ssl/certificates/README [delete] https://crrev.com/389f47fd4af8ff44f8396e353a14b078e500f6f0/net/data/ssl/certificates/cybertrust_baltimore_cross_certified_1.pem [delete] https://crrev.com/389f47fd4af8ff44f8396e353a14b078e500f6f0/net/data/ssl/certificates/cybertrust_baltimore_cross_certified_2.pem [delete] https://crrev.com/389f47fd4af8ff44f8396e353a14b078e500f6f0/net/data/ssl/certificates/cybertrust_baltimore_root.pem [delete] https://crrev.com/389f47fd4af8ff44f8396e353a14b078e500f6f0/net/data/ssl/certificates/cybertrust_gte_root.pem [delete] https://crrev.com/389f47fd4af8ff44f8396e353a14b078e500f6f0/net/data/ssl/certificates/cybertrust_omniroot_chain.pem
,
Mar 4 2016
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9204c52f2df95f47190949f7d5fe60e6c1ede337 commit 9204c52f2df95f47190949f7d5fe60e6c1ede337 Author: Eric Roman <eroman@chromium.org> Date: Tue Oct 17 03:05:47 2017 Remove unused code TestRootCerts::SetAllowSystemTrust(). The method was needed for test CertVerifyProcTest.CybertrustGTERoot (Mac), however it has since been deleted (9ad3f48a16790967f9fc311d83198cc04404b567). Bug: 590868 Change-Id: Ie85b19d5665cc6398c34048fc672fce1a9f2a2cd Reviewed-on: https://chromium-review.googlesource.com/720255 Reviewed-by: Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509253} [modify] https://crrev.com/9204c52f2df95f47190949f7d5fe60e6c1ede337/net/cert/test_root_certs.h [modify] https://crrev.com/9204c52f2df95f47190949f7d5fe60e6c1ede337/net/cert/test_root_certs_mac.cc
,
Jan 24 2018
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by dschuyler@chromium.org
, Feb 29 2016