Issue metadata
Sign in to add a comment
|
MenuButtons used instead of Combobox |
||||||||||||||||||||||||
Issue descriptionI don't think there's a good reason why we use MenuButton for - ContentSettingBubbleContents's |menu_button|s - PermissionMenuButton - PermissionCombobox (despite its name!) by using a MenuButton we (a) miss out on normal accelerator and event handling (b) have to reimplement basic functionality such as PermissionCombobox::GetAccessibleState (c) get random bugs like bug 590171 +felt to triage
,
Feb 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/923d19c7b8dad55f35d0f2aeaae5975f0b002930 commit 923d19c7b8dad55f35d0f2aeaae5975f0b002930 Author: estade <estade@chromium.org> Date: Mon Feb 29 23:24:08 2016 Views - Fix text elision in content settings bubble's faux combobox BUG= 590171 , 590850 Review URL: https://codereview.chromium.org/1748733002 Cr-Commit-Position: refs/heads/master@{#378314} [modify] https://crrev.com/923d19c7b8dad55f35d0f2aeaae5975f0b002930/chrome/browser/ui/views/content_setting_bubble_contents.cc
,
Mar 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6761aebd1bb77c21e9fabf78cb134a65aa65b49a commit 6761aebd1bb77c21e9fabf78cb134a65aa65b49a Author: Evan Stade <estade@chromium.org> Date: Thu Mar 03 21:44:07 2016 Views - Fix text elision in content settings bubble's faux combobox BUG= 590171 , 590850 Review URL: https://codereview.chromium.org/1748733002 Cr-Commit-Position: refs/heads/master@{#378314} (cherry picked from commit 923d19c7b8dad55f35d0f2aeaae5975f0b002930) Review URL: https://codereview.chromium.org/1755313004 . Cr-Commit-Position: refs/branch-heads/2661@{#73} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/6761aebd1bb77c21e9fabf78cb134a65aa65b49a/chrome/browser/ui/views/content_setting_bubble_contents.cc
,
Mar 16 2016
thanks for fixing, marking you as the owner & the bug as fixed?
,
Mar 16 2016
no, I didn't fix it. I band-aided.
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4c886dba28f91e73e470a3737666501043f8cf2 commit b4c886dba28f91e73e470a3737666501043f8cf2 Author: estade <estade@chromium.org> Date: Fri May 13 20:41:45 2016 Make the combobox in ContentSettingBubbleContents an actual combobox. ...instead of a menubutton that looks just like a combobox. BUG= 590850 , 571500 Review-Url: https://codereview.chromium.org/1977673002 Cr-Commit-Position: refs/heads/master@{#393625} [modify] https://crrev.com/b4c886dba28f91e73e470a3737666501043f8cf2/chrome/browser/ui/content_settings/content_setting_media_menu_model.h [modify] https://crrev.com/b4c886dba28f91e73e470a3737666501043f8cf2/chrome/browser/ui/views/content_setting_bubble_contents.cc [modify] https://crrev.com/b4c886dba28f91e73e470a3737666501043f8cf2/chrome/browser/ui/views/content_setting_bubble_contents.h [modify] https://crrev.com/b4c886dba28f91e73e470a3737666501043f8cf2/chrome/chrome_browser_ui.gypi
,
May 25 2016
Elly's actually started exploring doing this for PermissionMenuButton in https://codereview.chromium.org/2011963002/ - but initially just for Mac. Perhaps we should just opt in to combobox for all platforms.
,
May 26 2016
yes indeed
,
Nov 23 2016
,
Nov 29 2016
,
Nov 10 2017
,
Feb 18 2018
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by est...@chromium.org
, Feb 29 2016