Wrong theme color used for ink ripple for Apps bookmark button and extension buttons in app menu |
|||||||
Issue descriptionVersion: 51.0.2664.0 OS: Linux, Chrome OS, haven't tried on Windows What steps will reproduce the problem? 1. Run with --top-chrome-md=material 2. Press and hold Apps button in bookmarks toolbar 3. Press and hold an extension button in app menu overflow What is the expected output? What do you see instead? Ink ripple animation using some shade of gray is expected. Instead a pink color is used suggesting that we are not setting the theme color properly. Please use labels and text to provide additional information. A regression, probably after https://codereview.chromium.org/1724963002/ If this reproduces in M-50 canary, it should probably be a blocker.
,
Mar 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84e53c857ee87964ca99b52cc892a407b56e2dca commit 84e53c857ee87964ca99b52cc892a407b56e2dca Author: estade <estade@chromium.org> Date: Tue Mar 01 04:57:16 2016 [MD] Fix some ink drop colors BUG= 590843 Review URL: https://codereview.chromium.org/1752553002 Cr-Commit-Position: refs/heads/master@{#378397} [modify] https://crrev.com/84e53c857ee87964ca99b52cc892a407b56e2dca/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/84e53c857ee87964ca99b52cc892a407b56e2dca/chrome/browser/ui/views/toolbar/app_menu_button.cc [modify] https://crrev.com/84e53c857ee87964ca99b52cc892a407b56e2dca/chrome/browser/ui/views/toolbar/app_menu_button.h [modify] https://crrev.com/84e53c857ee87964ca99b52cc892a407b56e2dca/chrome/browser/ui/views/toolbar/toolbar_action_view.cc [modify] https://crrev.com/84e53c857ee87964ca99b52cc892a407b56e2dca/chrome/browser/ui/views/toolbar/toolbar_action_view.h [modify] https://crrev.com/84e53c857ee87964ca99b52cc892a407b56e2dca/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/84e53c857ee87964ca99b52cc892a407b56e2dca/chrome/browser/ui/views/toolbar/toolbar_button.h
,
Mar 1 2016
,
Mar 1 2016
,
Mar 2 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 2 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/bling/chromium.git/+/84e53c857ee87964ca99b52cc892a407b56e2dca commit 84e53c857ee87964ca99b52cc892a407b56e2dca Author: estade <estade@chromium.org> Date: Tue Mar 01 04:57:16 2016
,
Mar 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ece42be202a0146da9531c4f20625aa7cbd98ebb commit ece42be202a0146da9531c4f20625aa7cbd98ebb Author: Evan Stade <estade@chromium.org> Date: Mon Mar 07 23:12:41 2016 [MD] Fix some ink drop colors BUG= 590843 Review URL: https://codereview.chromium.org/1752553002 Cr-Commit-Position: refs/heads/master@{#378397} (cherry picked from commit 84e53c857ee87964ca99b52cc892a407b56e2dca) Review URL: https://codereview.chromium.org/1767273002 . Cr-Commit-Position: refs/branch-heads/2661@{#112} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/ece42be202a0146da9531c4f20625aa7cbd98ebb/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/ece42be202a0146da9531c4f20625aa7cbd98ebb/chrome/browser/ui/views/toolbar/app_menu_button.cc [modify] https://crrev.com/ece42be202a0146da9531c4f20625aa7cbd98ebb/chrome/browser/ui/views/toolbar/app_menu_button.h [modify] https://crrev.com/ece42be202a0146da9531c4f20625aa7cbd98ebb/chrome/browser/ui/views/toolbar/toolbar_action_view.cc [modify] https://crrev.com/ece42be202a0146da9531c4f20625aa7cbd98ebb/chrome/browser/ui/views/toolbar/toolbar_action_view.h [modify] https://crrev.com/ece42be202a0146da9531c4f20625aa7cbd98ebb/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/ece42be202a0146da9531c4f20625aa7cbd98ebb/chrome/browser/ui/views/toolbar/toolbar_button.h
,
Mar 8 2016
Verified it on Linux/Ubuntu 14.04 - Version 50.0.2661.18 dev (64-bit) and it is working as expected. Some shade of gray is shown upon pressing & holding the Apps or extensions button correctly. I will check on Windows & CrOS and update the bug as Verified.
,
Mar 9 2016
The fix is working fine on CrOS Daisy 7978.8.0/50.0.2661.17 & Win7/64 bit - Version 50.0.2661.18 (64-bit) |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by varkha@chromium.org
, Feb 29 20165.8 KB
5.8 KB View Download
23.8 KB
23.8 KB View Download