Get rid of gpu related switches by passing gpu::GpuPreferences via IPC, at same time get rid of duplcate code in deferred_gpu_command_service.cc & content/gpu/gpu_child_thread.cc.
I found a reference to this issue in the code at [1]. Without understanding all the details, it appears to me that there are still command-line switches being propagated to the GPU process. If I understand the changes associated with this issue correctly, the GPU process is now supposed to pull all configuration flags through GpuPreferences via IPC instead of being invoked with command-line switches. With the issue being marked as fixed, shouldn't the code that propagates command-line switches have been removed? If not, why is it still needed?
The reason I ask is that I may need to make a modification to the switches, and I need to understand if propagating them to the GPU process is still needed.
[1] https://cs.chromium.org/chromium/src/content/browser/gpu/gpu_process_host.cc?sq=package:chromium&dr=C&rcl=1467126994&l=1008
There are some switches that are needed before the GpuMsg_Initialize message is sent (which sends GpuPreferences) - e.g. whether to turn on the mailbox, logging related, etc.
But generally new switches should go to GpuPreferences.
Comment 1 by penghuang@chromium.org
, Mar 2 2016