Issue metadata
Sign in to add a comment
|
Blimp engine containerized builds should use target_os=linux instead of chromeos
Reported by
jessi...@chromium.org,
Feb 29 2016
|
||||||||||||||||||||
Issue descriptionBlimp uses target_os=chromeos to avoid dependencies (e.g. X11) that are the default on linux, but will be unavailable in a docker container. However this causes a host of other changes to the resulting binary that are not desired. The blimp containerized build should instead use target_os=linux and other build arguments to turn off unsupported dependencies.
,
Feb 29 2016
,
Feb 29 2016
,
Mar 1 2016
,
Mar 2 2016
Note to self: do not use spaces when listing multiple bugs on code review. The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fceb956ec7d991db287f963e3a5368422de58b02 commit fceb956ec7d991db287f963e3a5368422de58b02 Author: jessicag <jessicag@chromium.org> Date: Wed Mar 02 19:16:18 2016 Update gn args instructions for engine inside a docker container. Blimp uses target_os=chromeos to avoid dependencies (e.g. X11) that are the default on linux, but will be unavailable in a docker container. However this causes a host of other changes to the resulting binary that are not desired (e.g. crash reporting flow). This change uses target_os='linux' with the unsupported dependencies turned off. It will work within a docker container without the unwanted binary changes. BUG= 589166 , 590816 Review URL: https://codereview.chromium.org/1751433002 Cr-Commit-Position: refs/heads/master@{#378794} [modify] https://crrev.com/fceb956ec7d991db287f963e3a5368422de58b02/blimp/docs/build.md |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by jessi...@chromium.org
, Feb 29 2016Status: Duplicate (was: Started)