about:null is displayed as the title for the alerts triggered from iFrames |
||||||||||
Issue descriptionApp Version: M49.0.2623.70 dev iOS Version: 9.2.1 Device: iPhone5, iPhone6s URL: http://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_alert Steps to reproduce: 1. Launch Google Chrome 2. Open the above URL and tap on "Try it" 3. Observe the alert displayed Observed results: "about:null" is displayed as the alert title Expected results: web page domain name should be displayed as the alert title. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Dolphin/Safari/Firefox: Firefox: NO, Safari: NO Bug reproducible on current stable build (App Version, iOS Version): M48 YES Bug reproducible on the current beta channel build (App Version, iOS Version): M49 YES Link to video/image: https://docs.google.com/drawings/d/1aCIAHQt_y8OQWak74ZwYeN0exEUtdYygOx0r8DUU-OQ/preview
,
Apr 27 2017
,
May 10 2017
Chris could you please advice if it's ok to use main frame's hostname from security perspective? alert was requested by iframe and it's URL was about:blank.
,
May 10 2017
I'm not on the security UX team anymore. +lgarron
,
May 10 2017
> https://developer.mozilla.org/en-US/docs/Web/API/Window/alert "Starting with Chrome 46.0 this method is blocked inside an <iframe> unless its sandbox attribute has the value allow-modal." Except... I can still trigger it? On desktop, we show IDS_JAVASCRIPT_MESSAGEBOX_TITLE_NONSTANDARD_URL_IFRAME [1] in this particular case. See [2] for the logic. [1] https://cs.chromium.org/chromium/src/components/app_modal_strings.grdp?type=cs&q=%22An+embedded+page%22&l=15 [2] https://cs.chromium.org/chromium/src/components/app_modal/javascript_dialog_manager.cc?q=%22base::string16+JavaScriptDialogManager::GetTitle(%22&l=95
,
May 10 2017
,
May 11 2017
Thanks Lucas!
,
May 11 2017
Peter, do you want to take this bug?
,
May 11 2017
Yes! If Kurt isn't planning on working on it any time soon - Kurt, do you want to assign it to me? Thanks!
,
May 11 2017
All yours, Peter!
,
Jun 20 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4da94ecef84eb4c38c68952b54f28b1159289998 commit 4da94ecef84eb4c38c68952b54f28b1159289998 Author: peterlaurens <peterlaurens@chromium.org> Date: Thu Jun 22 17:47:24 2017 Improve dialog titles generated by embedded pages. BUG= 590815 TEST=See steps to reproduce in bug. Review-Url: https://codereview.chromium.org/2944243002 Cr-Commit-Position: refs/heads/master@{#481591} [modify] https://crrev.com/4da94ecef84eb4c38c68952b54f28b1159289998/ios/chrome/browser/ui/dialogs/dialog_presenter.mm
,
Jun 27 2017
Verified on iPhone 7 iOS 10.3.1,iPad iOS 10.3.2 The following issue has been Verified for fix on Build - 61.0.3142.0 Canary “about:null is displayed as the title for the alerts triggered from iFrames" The Title appears now for alerts triggered from iFrames.
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ed4f536d098e75cf5f999fdc076bcc81bad39ab commit 3ed4f536d098e75cf5f999fdc076bcc81bad39ab Author: peterlaurens <peterlaurens@chromium.org> Date: Fri Jun 30 01:38:24 2017 Check page URL origin to determine JavaScript alert titles. BUG= 590815 Review-Url: https://codereview.chromium.org/2957423002 Cr-Commit-Position: refs/heads/master@{#483583} [modify] https://crrev.com/3ed4f536d098e75cf5f999fdc076bcc81bad39ab/ios/chrome/browser/ui/dialogs/dialog_presenter.h [modify] https://crrev.com/3ed4f536d098e75cf5f999fdc076bcc81bad39ab/ios/chrome/browser/ui/dialogs/dialog_presenter.mm [modify] https://crrev.com/3ed4f536d098e75cf5f999fdc076bcc81bad39ab/ios/chrome/browser/ui/dialogs/dialog_presenter_unittest.mm [modify] https://crrev.com/3ed4f536d098e75cf5f999fdc076bcc81bad39ab/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
,
Jul 11 2017
,
Nov 1 2017
"An embedded page on this webpage says" is displayed as the title of the alert box. Verified in M64.0.3254.0 canary iOS: 11.2 Device: iPhone7Plus |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by baxley@chromium.org
, Feb 29 2016Owner: kkhorimoto@chromium.org
Status: Assigned (was: Untriaged)