Generate anisotropic mipmap levels |
|||
Issue descriptionkkinnunen@nvidia.com noticed we were using TexStoragei values which are not supported by ES2. [18413:18413:0229/113825:ERROR:gles2_cmd_decoder_autogen.h(2853)] [.CommandBufferContext.RenderWorker-0x3d352c0d89a0.GpuRasterization]GL ERROR :GL_INVALID_ENUM : glTexParameteri: pname was GL_TEXTURE_BASE_LEVEL [18413:18413:0229/113825:ERROR:gles2_cmd_decoder_autogen.h(2853)] [.CommandBufferContext.RenderWorker-0x3d352c0d89a0.GpuRasterization]GL ERROR :GL_INVALID_ENUM : glTexParameteri: pname was GL_TEXTURE_MAX_LOD [18413:18413:0229/113825:ERROR:gles2_cmd_decoder_autogen.h(2853)] [.CommandBufferContext.RenderWorker-0x3d352c0d89a0.GpuRasterization]GL ERROR :GL_INVALID_ENUM : glTexParameteri: pname was GL_TEXTURE_MAX_LEVEL_APPLE (setting the texture params on ES2 context, where the params are supported only in ES3) This started a conversation about generating mipmap levels in anisotropic space, which Skia is currently not doing. If we generated anisotropic mipmap levels then we could create a complete mipmap stack in the eyes of OpenGL. This would allow us to still support mipmaps on ES2 and only call TexParami with these values when the platform supports it.
,
Feb 29 2016
Chris, Is there anything you need from the iOS team? Or could you mark the bug as assigned/started?
,
Feb 29 2016
Whoops. Sorry.
,
Mar 1 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/5b9ad7620b36858f99fef0763d7fc04d024fd71d commit 5b9ad7620b36858f99fef0763d7fc04d024fd71d Author: cblume <cblume@chromium.org> Date: Tue Mar 01 21:54:30 2016 Adding anisotropic mipmap levels to SkMipMap. Adding 1x2, 1x3, 2x1, 3x1 filters to SkMipMap and enabling SkMipMap to generate anisotropic mip levels. BUG= 590804 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1750303002 Review URL: https://codereview.chromium.org/1750303002 [modify] https://crrev.com/5b9ad7620b36858f99fef0763d7fc04d024fd71d/src/core/SkMipMap.cpp [modify] https://crrev.com/5b9ad7620b36858f99fef0763d7fc04d024fd71d/tests/MipMapTest.cpp
,
Mar 1 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/09bd2c09b6b36737df289fdb5fa38c280162cbb8 commit 09bd2c09b6b36737df289fdb5fa38c280162cbb8 Author: cblume <cblume@chromium.org> Date: Tue Mar 01 22:08:28 2016 Disabling calls to TexParameteri when the values do not exist on ES2. BUG= 590804 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1750833003 Review URL: https://codereview.chromium.org/1750833003 [modify] https://crrev.com/09bd2c09b6b36737df289fdb5fa38c280162cbb8/src/gpu/gl/GrGLCaps.cpp [modify] https://crrev.com/09bd2c09b6b36737df289fdb5fa38c280162cbb8/src/gpu/gl/GrGLCaps.h [modify] https://crrev.com/09bd2c09b6b36737df289fdb5fa38c280162cbb8/src/gpu/gl/GrGLGpu.cpp
,
Mar 1 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Feb 29 2016