New issue
Advanced search Search tips

Issue 590794 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 584802
Owner:
Closed: Feb 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16% regression in media.tough_video_cases at 373758:373768

Project Member Reported by jrumm...@chromium.org, Feb 29 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=590794

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDA55OTpwoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac10
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Feb 29 2016

Mergedinto: 584802
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : base: Set initial thread priority in ThreadFunc.
Author  : reveman
Commit description:
  
Instead of relying on base::InitOnThread to set the initial thread
priority to normal, always set it to thread_params->priority in
ThreadFunc.

The result is that thread priority will be set correctly on all
posix platforms and not only Android.

BUG= 584025 
TEST=base_unittests --gtest_filter=PlatformThreadTest.ThreadPriorityCurrentThread

Review URL: https://codereview.chromium.org/1660273004

Cr-Commit-Position: refs/heads/master@{#373761}
Commit  : 45828eb26e18f1ba333f0c39b20036a60932886b
Date    : Fri Feb 05 07:08:48 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@373757         208.6       19.424212   5           good
chromium@373760         215.6       2.19089     5           good
chromium@373761         249.8       2.48998     5           bad
chromium@373762         252.2       2.683282    5           bad
chromium@373763         250.4       2.966479    5           bad
chromium@373768         248.6       2.701851    5           bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 590794

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests media.tough_video_cases
Test Metric: idle_wakeups_gpu/idle_wakeups_gpu
Relative Change: 19.18%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/1992
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9019459394196812432


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 29 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : base: Set initial thread priority in ThreadFunc.
Author  : reveman
Commit description:
  
Instead of relying on base::InitOnThread to set the initial thread
priority to normal, always set it to thread_params->priority in
ThreadFunc.

The result is that thread priority will be set correctly on all
posix platforms and not only Android.

BUG= 584025 
TEST=base_unittests --gtest_filter=PlatformThreadTest.ThreadPriorityCurrentThread

Review URL: https://codereview.chromium.org/1660273004

Cr-Commit-Position: refs/heads/master@{#373761}
Commit  : 45828eb26e18f1ba333f0c39b20036a60932886b
Date    : Fri Feb 05 07:08:48 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@373757         213.8       3.34664     5           good
chromium@373760         210.0       2.915476    5           good
chromium@373761         247.6       3.209361    5           bad
chromium@373762         245.4       6.69328     5           bad
chromium@373763         249.8       4.658326    5           bad
chromium@373768         249.2       5.263079    5           bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 590794

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests media.tough_video_cases
Test Metric: idle_wakeups_gpu/idle_wakeups_gpu
Relative Change: 16.56%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/1993
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9019459386253652816


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!

Sign in to add a comment