New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 590792 link

Starred by 1 user
Status: Fixed
Owner:
█ reve...@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Cc:
█ penny...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 571915



Sign in to add a comment

DiscardableSharedMemoryTest.ZeroSize failing on win10

Project Member Reported by wfh@chromium.org, Feb 29 2016 
Version: 8de43b1b18151fd3428cb9812a95254e36770f84
OS: Windows 10 10.0.10586

What steps will reproduce the problem?

DiscardableSharedMemoryTest.ZeroSize fails:

DiscardableSharedMemoryTest.ZeroSize (run #1):
[ RUN      ] DiscardableSharedMemoryTest.ZeroSize
e:uild\slave\chromium_win_10uild\srcase\memory\discardable_shared_memory_unittest.cc(361): error: Value of: lock_rv
  Actual: 1
Expected: DiscardableSharedMemory::SUCCESS
Which is: 0
[  FAILED  ] DiscardableSharedMemoryTest.ZeroSize (1 ms)

https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%2010/builds/2328

Comment 1 by wfh@chromium.org, Feb 29 2016

Blocking: 571915
Labels: Proj-Windows10

Comment 2 by pennymac@google.com, Feb 29 2016 

https://codereview.chromium.org/1741403002/

Thanks for opening the ticket Will!
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ffe952ecf9319a9f6eed847e7a6d6d20b893e4c

commit 4ffe952ecf9319a9f6eed847e7a6d6d20b893e4c
Author: reveman <reveman@chromium.org>
Date: Tue Mar 01 23:15:47 2016

base: Avoid calling VirtualAlloc with 0 length.

BUG=577786, 590792 
TEST=base_unittests --gtest_filter=DiscardableSharedMemoryTest.ZeroSize

Review URL: https://codereview.chromium.org/1741403002

Cr-Commit-Position: refs/heads/master@{#378595}

[modify] https://crrev.com/4ffe952ecf9319a9f6eed847e7a6d6d20b893e4c/base/memory/discardable_shared_memory.cc
[modify] https://crrev.com/4ffe952ecf9319a9f6eed847e7a6d6d20b893e4c/base/memory/discardable_shared_memory_unittest.cc

Comment 4 by reve...@chromium.org, Mar 2 2016

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 2 2016

Labels: Merge-Merged-master1
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/4ffe952ecf9319a9f6eed847e7a6d6d20b893e4c

commit 4ffe952ecf9319a9f6eed847e7a6d6d20b893e4c
Author: reveman <reveman@chromium.org>
Date: Tue Mar 01 23:15:47 2016
►

Sign in to add a comment