New issue
Advanced search Search tips

Issue 590781 link

Starred by 1 user
Status: Fixed
Owner:
pmonette@chromium.org
Closed: Feb 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DefaultBrowserSettingEnabled removes the "Set Chrome as the default browser" when set as true

Project Member Reported by pmonette@chromium.org, Feb 29 2016 
Version of Google Chrome (Wrench-> About Google Chrome): m48
Version of MSI (if applicable):
Using group policy settings? Yes

We should still let the user click this button when the group policy is set to "Make Chrome the default browser".

The problem is that the code only check if the preference is managed and not its value.

This is only a problem on Win8+ where it is not possible to set the default browser without user interaction.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c79a5837aba384a557bb02f26a5ad4e37c91a21

commit 4c79a5837aba384a557bb02f26a5ad4e37c91a21
Author: pmonette <pmonette@chromium.org>
Date: Mon Feb 29 21:15:40 2016

Fixes hidden "Set Default Browser" button when group policy is enabled

The user will now be able to click the button when "Set Google Chrome as
the default browser" is Enabled.

BUG= 590781 

Review URL: https://codereview.chromium.org/1749813002

Cr-Commit-Position: refs/heads/master@{#378273}

[modify] https://crrev.com/4c79a5837aba384a557bb02f26a5ad4e37c91a21/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/4c79a5837aba384a557bb02f26a5ad4e37c91a21/chrome/browser/ui/webui/settings/settings_default_browser_handler.cc

Comment 2 by pmonette@chromium.org, Feb 29 2016

Status: Fixed (was: Assigned)
Test:
On Windows 8 and 10.

1. Make sure Chrome is NOT the default browser.
2. Set up a Group Policy for Chrome and enable DefaultBrowserSettingEnabled. (https://support.google.com/chrome/a/answer/187202?hl=en). The name for the policy in Local Group Policy Editor is "Set Google Chrome as Default Browser".
3. Open Chrome and got to the settings page. You should be able to click "Make Google Chrome the default Browser". The button should only go away if DefaultBrowserSettingEnabled is Disabled.
►

Sign in to add a comment