New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 590765 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Optimize bandwidth used by UMA by not sending counts & sum fields sometimes

Project Member Reported by asvitk...@chromium.org, Feb 29 2016

Issue description

Optimize bandwidth used by UMA.

We have a few optimizations in mind that can reduce the bandwidth used by UMA uploads.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0955394cb22f2b84de5a9d3a804c0f379b3455db

commit 0955394cb22f2b84de5a9d3a804c0f379b3455db
Author: asvitkine <asvitkine@chromium.org>
Date: Tue Mar 01 01:42:34 2016

Optimizations to histogram protobuf encoding.

Omits several fields from being sent if their value is one of the
common field values.

BUG= 590765 

Review URL: https://codereview.chromium.org/1744283002

Cr-Commit-Position: refs/heads/master@{#378364}

[modify] https://crrev.com/0955394cb22f2b84de5a9d3a804c0f379b3455db/components/metrics/histogram_encoder.cc
[modify] https://crrev.com/0955394cb22f2b84de5a9d3a804c0f379b3455db/components/metrics/proto/histogram_event.proto

Summary: Optimize bandwidth used by UMA by not sending counts & sum fields sometimes (was: Optimize bandwidth used by UMA)
Labels: -M-51 Merge-Request-50 M-50
Requesting merge to M50 - this is a very safe change that should save bandwidth for UMA users and help with the UMA for cellular launch.

Comment 4 by tin...@google.com, Mar 2 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 2 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbb3c78c166261745387a9a6a86d42b05dcf2115

commit fbb3c78c166261745387a9a6a86d42b05dcf2115
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Wed Mar 02 18:16:05 2016

Optimizations to histogram protobuf encoding.

Omits several fields from being sent if their value is one of the
common field values.

BUG= 590765 

Review URL: https://codereview.chromium.org/1744283002

Cr-Commit-Position: refs/heads/master@{#378364}
(cherry picked from commit 0955394cb22f2b84de5a9d3a804c0f379b3455db)

Review URL: https://codereview.chromium.org/1758553004 .

Cr-Commit-Position: refs/branch-heads/2661@{#45}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/fbb3c78c166261745387a9a6a86d42b05dcf2115/components/metrics/histogram_encoder.cc
[modify] https://crrev.com/fbb3c78c166261745387a9a6a86d42b05dcf2115/components/metrics/proto/histogram_event.proto

Status: Fixed (was: Assigned)
Marking as Fixed for M50. Will file new bugs to track other improvements.

Sign in to add a comment