New issue
Advanced search Search tips

Issue 590763 link

Starred by 1 user
Status: Fixed
Owner:
melandory@chromium.org
Closed: Feb 2016
Cc:
hwi@chromium.org
sabineb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 400674



Sign in to add a comment

Auto sign-in first run dialog should use new strings for the explanation text.

Project Member Reported by melandory@chromium.org, Feb 29 2016 
IDS_AUTO_SIGNIN_FIRST_RUN_SMART_LOCK_TEXT (Google Smart Lock automatically signs you in to eligible sites and apps with passwords you saved.)
should be used instead of
IDS_MANAGE_PASSWORDS_AUTO_SIGNIN_SMART_LOCK_WELCOME (Google Smart Lock remembers your passwords and signs you in to apps and sites automatically across devices.)

IDS_AUTO_SIGNIN_FIRST_RUN_TEXT (Google Chrome automatically signs you in to eligible sites with passwords you saved.)
should be used instead of
IDS_MANAGE_PASSWORDS_AUTO_SIGNIN_DEFAULT_WELCOME (Google Chrome remembers your passwords and signs you in to sites automatically on this device.)
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0a5e3271af5d8a5b8237915acd08a5dc07c8a4d

commit b0a5e3271af5d8a5b8237915acd08a5dc07c8a4d
Author: melandory <melandory@chromium.org>
Date: Mon Feb 29 17:55:35 2016

[Smart Lock, UI] Auto sign-in first run dialog should use new strings.

Auto sign-in first run dialog should use new strings for the explanation
text.

BUG= 590763 

Review URL: https://codereview.chromium.org/1743263002

Cr-Commit-Position: refs/heads/master@{#378229}

[modify] https://crrev.com/b0a5e3271af5d8a5b8237915acd08a5dc07c8a4d/chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc

Comment 2 by melandory@chromium.org, Feb 29 2016

Components: UI>Browser>Passwords

Comment 3 by melandory@chromium.org, Feb 29 2016

Status: Fixed (was: Started)

Comment 4 by melandory@chromium.org, Feb 29 2016

Labels: Merge-Request-50

Comment 5 by tin...@google.com, Feb 29 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 29 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bbd8e90a44d18008111b7209d835369b5794f9a

commit 8bbd8e90a44d18008111b7209d835369b5794f9a
Author: Tatiana Gornak <melandory@chromium.org>
Date: Mon Feb 29 23:47:42 2016

[Smart Lock, UI] Auto sign-in first run dialog should use new strings.

Auto sign-in first run dialog should use new strings for the explanation
text.

BUG= 590763 

Review URL: https://codereview.chromium.org/1743263002

Cr-Commit-Position: refs/heads/master@{#378229}
(cherry picked from commit b0a5e3271af5d8a5b8237915acd08a5dc07c8a4d)

Review URL: https://codereview.chromium.org/1750033003 .

Cr-Commit-Position: refs/branch-heads/2661@{#10}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/8bbd8e90a44d18008111b7209d835369b5794f9a/chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc
►

Sign in to add a comment