New issue
Advanced search Search tips

Issue 590756 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 400674



Sign in to add a comment

Fix title for Auto signin first run experience.

Project Member Reported by melandory@chromium.org, Feb 29 2016

Issue description

Title for the auto sign-in dialog should reflect state of the Auto sign-in setting for the user (is it synced across devices or not).
 
Status: Fixed (was: Started)
Labels: Merge-Request-50

Comment 4 by tin...@google.com, Feb 29 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 29 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e793c79f11ef1f2a8ff3a884c9c6a627ee33333a

commit e793c79f11ef1f2a8ff3a884c9c6a627ee33333a
Author: Tatiana Gornak <melandory@chromium.org>
Date: Mon Feb 29 23:52:25 2016

[Smart Lock, UI] Use correct string for the auto sign-in first run.

Method which check is settings are synced should check PRIORITY_PREFERENCE instead of PREFERENCE, because only they are synced on mobile devices.

BUG= 590756 

Review URL: https://codereview.chromium.org/1750603002

Cr-Commit-Position: refs/heads/master@{#378238}
(cherry picked from commit d2329b1a69b53d8f4384c60d0cd31cd03908cde3)

Review URL: https://codereview.chromium.org/1747003003 .

Cr-Commit-Position: refs/branch-heads/2661@{#11}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/e793c79f11ef1f2a8ff3a884c9c6a627ee33333a/chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc
[modify] https://crrev.com/e793c79f11ef1f2a8ff3a884c9c6a627ee33333a/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
[modify] https://crrev.com/e793c79f11ef1f2a8ff3a884c9c6a627ee33333a/chrome/browser/ui/passwords/manage_passwords_view_utils.h
[modify] https://crrev.com/e793c79f11ef1f2a8ff3a884c9c6a627ee33333a/chrome/browser/ui/passwords/password_dialog_controller_impl.cc

Sign in to add a comment