New issue
Advanced search Search tips

Issue 590747 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

chromium.perf: v8.infinite_scroll crashes on Windows at 377547:377558

Project Member Reported by rbyers@chromium.org, Feb 29 2016

Issue description

Link to failing step log:
https://build.chromium.org/p/chromium.perf/builders/Win%207%20Intel%20GPU%20Perf%20%285%29/builds/2076/steps/v8.infinite_scroll/logs/stdio

All 5 pages appear to be failing with a DevtoolsTargetCrashException: Devtools target crashed.

I'm investigating further.

 

Comment 1 by rbyers@chromium.org, Feb 29 2016

Cc: ssid@chromium.org
Labels: -OS-All OS-Windows
Summary: chromium.perf: v8.infinite_scroll crashes on Windows at 377547:377558 (was: v8.infinite_scroll crashes on chromium.perf at 377547:377558)
Only seeing failures on Windows:

https://build.chromium.org/p/chromium.perf/builders/Win%2010%20Perf%20%285%29/builds/2334/steps/v8.infinite_scroll/logs/stdio

https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf%20%285%29/builds/3620/steps/v8.infinite_scroll/logs/stdio

https://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf%20%285%29/builds/3502/steps/v8.infinite_scroll/logs/stdio

There's nothing obvious in the changelog for this range, except perhaps a v8 roll?  I'll do a build bisect.
Cc: hajimehoshi@chromium.org
Owner: hajimehoshi@chromium.org

=== Auto-CCing suspected CL author hajimehoshi@chromium.org ===

Hi hajimehoshi@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Refactoring: Move some classes from content/child to platform
Author  : hajimehoshi
Commit description:
  
This CL moves these classes:
- WebMemoryAllocatorDumpImpl
- WebMemoryDumpProviderAdapter
- WebProcessMemoryDumpImpl(Test)
from content/child to platform. Now that platform can depend on base,
we don't need adapter classes in Chromium side.

After this CL, we will be able to reduce glue classes by unifying:
- WebMemoryAllocatorDump and WebMemoryAllocatorDumpImpl
- WebProcessMemoryDump and WebProcessMemoryDumpImpl
- WebMemoryDumpProvider and WebMemoryDumpProviderAdapter
so that we can reduce lots of code.

BUG=548254

Review URL: https://codereview.chromium.org/1660383002

Cr-Commit-Position: refs/heads/master@{#377552}
Commit  : a8227af5f6016e10e78b539ffa55aeb634ca7601
Date    : Thu Feb 25 11:07:51 2016


===== TESTED REVISIONS =====
Revision                Exit Code   Std. Dev.   Num Values  Good?
chromium@377547         0           N/A         5           good
chromium@377550         0           N/A         5           good
chromium@377551         0           N/A         5           good
chromium@377552         1           N/A         5           bad
chromium@377553         1           N/A         5           bad
chromium@377559         1           N/A         5           bad

Bisect job ran on: win_8_perf_bisect
Bug ID: 590747

Test Command: python src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests v8.infinite_scroll
Test Metric: Scrolling-frame_times/facebook
Relative Change: Zero to non-zero
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/1843
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9019442398914739040


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Cc: primiano@chromium.org haraken@chromium.org
Let me investigate this on Windows, or I'd appreciate if someone could give the stack trace for this crash.
Cc: tasak@google.com
+tasak
Current perfbot sheriff here: disabling this benchmark on Windows until the issue is fixed. https://codereview.chromium.org/1747303002
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b922a4493af40a539a287c75e124f5335595ab7

commit 0b922a4493af40a539a287c75e124f5335595ab7
Author: eakuefner <eakuefner@chromium.org>
Date: Wed Mar 02 02:05:18 2016

[BotHealth] Disable v8.infinite_scroll on Windows

BUG= 590747 
TBR=sullivan
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1747303002

Cr-Commit-Position: refs/heads/master@{#378651}

[modify] https://crrev.com/0b922a4493af40a539a287c75e124f5335595ab7/tools/perf/benchmarks/v8.py

Labels: -Pri-1 Pri-2
Friendly sheriff ping. Could this be related to  issue 579546 ?

(According to the Perf Bot Sheriffing guide, Pri-2 build bot bugs should be pinged weekly. Please close the issue if it's already been fixed.)
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c3d275c2cb227ffa0314ae46b44c20f94f6ca36

commit 9c3d275c2cb227ffa0314ae46b44c20f94f6ca36
Author: ulan <ulan@chromium.org>
Date: Tue Mar 29 18:29:55 2016

Re-enable v8.infinite_scroll on Windows.

The crash does not reproduce on TOT.

BUG= 590747 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1822293002

Cr-Commit-Position: refs/heads/master@{#383776}

[modify] https://crrev.com/9c3d275c2cb227ffa0314ae46b44c20f94f6ca36/tools/perf/benchmarks/v8.py

Status: Fixed (was: Assigned)
Recent builds are all green; I think this is fixed.

Sign in to add a comment