Issue metadata
Sign in to add a comment
|
Gmail perf tests timing out in top_25 pageset |
||||||||||||||||||
Issue descriptionRevision range first seen: 377600-377622 Link to failing step log: Eg: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%285%29/builds/13878/steps/blink_style.top_25/logs/stdio https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%285%29/builds/13878/steps/rasterize_and_record_micro.top_25_smooth/logs/stdio Almost certainly triggered by the re-record in https://chromium.googlesource.com/chromium/src/+/65af911fdf45a594f73125aec870f68d987eb7f0 Perhaps the updated Timeout isn't being applied consistently?
,
Feb 29 2016
,
Feb 29 2016
Seeing on Windows as well, so probably affects all OSes https://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf%20%285%29/builds/8400/steps/blink_style.top_25/logs/stdio
,
Feb 29 2016
Looks like we use the same GmailPage class to login to https://mail.google.com/mail as recorded across a variety of recordings of Gmail: https://code.google.com/p/chromium/codesearch#search/&q=mail%5C.google%5C.com%20file:%5Esrc/tools/perf/page_sets/data/.*%5C.json&sq=package:chromium&type=cs There are so many recordings that would need updating it may be worth making a new GmailPage class for the updated login flow.
,
Feb 29 2016
https://codereview.chromium.org/1742363002 in CQ will fix this.
,
Feb 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/184919658089ea1a9e1f66a4799abc2905717e6a commit 184919658089ea1a9e1f66a4799abc2905717e6a Author: flackr <flackr@chromium.org> Date: Mon Feb 29 19:17:43 2016 Only use new login flow for GmailSmoothPage Updating the https://mail.google.com/mail/ recording for only top_25_smooth.json required changing the login mechanism. This unfortunately caused tests using the old login flow to begin failing. This is a short term patch to only use the new flow for top_25_smooth.json until a more general solution is developed. BUG= 590735 , 590766 Review URL: https://codereview.chromium.org/1742363002 Cr-Commit-Position: refs/heads/master@{#378245} [modify] https://crrev.com/184919658089ea1a9e1f66a4799abc2905717e6a/tools/perf/page_sets/top_25_smooth.py [modify] https://crrev.com/184919658089ea1a9e1f66a4799abc2905717e6a/tools/perf/page_sets/top_pages.py
,
Feb 29 2016
The issue should be resolved now. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by rbyers@chromium.org
, Feb 29 2016