New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 590718 link

Starred by 0 users
Status: Fixed
Owner:
█ vabr@chromium.org
hobby only
Closed: Mar 2016
Cc:
asvitk...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add server-side experiment configs field trials for Password Manager features.

Reported by pritam.n...@samsung.com, Feb 29 2016 
Experimental field trials for password manager features need to be appended to server-side configs.

Please refer [1] for details.


Vaclav already compiled [2] an overview of what the features' default values and Field trial dependencies should be, based on the current code:

affiliation-based-matching:
* default = on
* Field trial name = "AffiliationBasedMatching"
  - groups starting with "Disabled" turns the feature off
  - other groups turn it on

drop-sync-credential
* default = on
* Field trial name = "PasswordManagerDropSyncCredential"
  - group "Disabled" turns the feature off
  - other groups turn it on

protect-sync-credential
* default = off
* Field trial name = "AutofillSyncCredential"
  - group "DisallowSyncCredentials" turns the feature on
  - other groups turn it off

protect-sync-credential-on-reauth
* default = off
* Field trial name = "AutofillSyncCredential"
  - groups "DisallowSyncCredentials" and "DisallowSyncCredentialsForReauth" turn
the feature on
  - other groups turn it off

[1] https://codereview.chromium.org/1668523002/#msg51
[2] https://codereview.chromium.org/1668523002/#msg34

Comment 1 by vabr@chromium.org, Mar 7 2016

Cc: asvitk...@chromium.org
Status: Assigned (was: Available)
asvitkine@ -- I'm not completely sure what you meant in https://codereview.chromium.org/1668523002/diff/320001/components/password_manager/core/browser/password_manager_util.cc#newcode116.

Could you please confirm that this is just the matter of adding disable_features and ensable_features fields in the config?

Comment 2 by asvitk...@chromium.org, Mar 7 2016 

Yep, that's what I meant.
On 7 Mar 2016 8:01 a.m., "vabr@chromium.org via Monorail" <
monorail@chromium.org> wrote:

Comment 3 by vabr@chromium.org, Mar 8 2016

Status: Started (was: Assigned)
Thanks! I uploaded an internal CL with number 116649079 for that.

Comment 4 by vabr@chromium.org, Mar 29 2016

Status: Fixed (was: Started)
►

Sign in to add a comment