New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 590688 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: On 'Cast dialog' unnecessary tab focus is seen on 'Share your screen'.

Reported by rk...@etouch.net, Feb 29 2016

Issue description

Chrome Version: 51.0.2663.0 Revision 5c3e3aa16e4d6f592742fff247fe2d591c170fd6-refs/heads/master@{#378159}(32/64 bit)
OS: All(Win-7 Aero Enabled)

Precondition: Enabled 'Media Router' flag from chrome://flags

What steps will reproduce the problem?
1. Launch chrome,click on 'Cast' option from wrench menu.
2. click on Cast to drop down option and then press Tab key,observe.

Unnecessary tab focus is seen on 'Share your screen' and nothing happens after pressing Enter key.

Tab focus should not seen on 'Share your screen'.

This is a regression issue,broken in 'M-46',below is bisect info:

Good Build: 46.0.2473.0
Bad Build: 46.0.2475.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/cf3b821f4e0020cf1d8dc42e4272f748b1b8d94c..3b2098124a4a9c13e57ed0464f79555b180dbf69?pretty=fuller&n=10

Suspecting: r342009
 
Actual_Highlight.mov
7.3 MB Download

Comment 1 by sko...@chromium.org, Feb 29 2016

Labels: -Pri-1 -M-48 Pri-3
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89fa440fdd71e96da75a9570d99acb25b63be812

commit 89fa440fdd71e96da75a9570d99acb25b63be812
Author: apacible <apacible@chromium.org>
Date: Wed Mar 16 00:35:02 2016

[Media Router WebUI] Remove cosmetic styling on focused "Share your screen" subheading.

Visible styling when "Share your screen" is focused gives an impression that it's clickable/will do something. This change removes the cosmetic styling. We still want this to be focusable for accessibility reasons, so focus is not disabled for this text.

BUG= 590688 

Review URL: https://codereview.chromium.org/1801523002

Cr-Commit-Position: refs/heads/master@{#381367}

[modify] https://crrev.com/89fa440fdd71e96da75a9570d99acb25b63be812/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css

Status: Fixed (was: Started)

Sign in to add a comment