New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 590683 link

Starred by 1 user
Status: Fixed
Owner:
cbiesin...@chromium.org
Closed: Mar 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Devtools] Regression: Weird behavior of horizontal scrollbar is seen in devices section of devtools

Project Member Reported by sc00335...@techmahindra.com, Feb 29 2016 
Version: 51.0.2663.0 dev
OS: Ubuntu 12.04,14.04,windows

What steps will reproduce the problem?
1. Launch chrome and open any page[Ex:chrome://Settings] >> Hit F12 for devtools
2. Hit F1 for settings of devtools >> Go to devices section and observe horizontal scrollbar
3. Now add any device with long name and observe for horizontal scrollbar [Please refer video] 

Expected: After Step-2: No unwanted horizontal scrollbar should be seen
After Step-3: If it is intended horizontal scrollbar should not vanish on providing long name

Actual: Instead in step-2 unwanted horizontal scroll bar is seen and in step-3 on adding long name horizontal scroolbar vanishes

This is a regression issue broken in M50.

Good Build: 50.0.2660.0 dev
Bad Build: 50.0.2661.0 dev

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/19c030e8689cd94f5bc43fcce349e86e4d1ea405..8a3777d77af8e154f4eb03bfa87a8c73b58fa880

Suspecting https://codereview.chromium.org/1734203002 from changelog

@cbiesinger:Please confirm whether it is an issue or intended behavior
Actual_scrollbar.ogv
2.9 MB Download
Expected_scrollbar.png
177 KB View Download
Actual_scrollbar.png
187 KB View Download

Comment 1 by kavvaru@chromium.org, Feb 29 2016 

Able to reproduce the issue on windows 7 using chrome version 51.0.2663.0.But not observed the horizontal scroll bar on Mac 10.11 after step 2.

Comment 2 by cbiesin...@chromium.org, Feb 29 2016 

:(

Devtools can work around this by specifying overflow-x: hidden on .list (inside the .devices-list shadow root). But I'm still investigating.

Comment 3 by kavvaru@chromium.org, Mar 11 2016 

Just to update 
Able to reproduce the issue on windows 7 using chrome version 51.0.2674.0
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbb25cec59deb052604d63036f1c5baf6efd2a5c

commit fbb25cec59deb052604d63036f1c5baf6efd2a5c
Author: cbiesinger <cbiesinger@chromium.org>
Date: Fri Mar 18 20:40:05 2016

Set m_{width,height}AvailableToChildrenChanged when scrollbars appear

This is a regression from https://codereview.chromium.org/1734203002. Before
that change, we'd just call layoutBlock(true). However, the new approach
just marks for layout and eventually recurses down, so to ensure that
the children get laid out, we have to set
m_{width,height}AvailableToChildrenChanged.

BUG= 594465 , 593593 , 590683 , 593624 , 593593 

Review URL: https://codereview.chromium.org/1811753003

Cr-Commit-Position: refs/heads/master@{#382074}

[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos-expected.html
[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos.html
[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-expected.html
[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes.html
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Comment 6 by cbiesin...@chromium.org, Mar 18 2016

Status: Fixed (was: Assigned)
merge request in  bug 594465
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 21 2016

Labels: merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f4a99dd2428b2395fff7db0330a4c9280054162

commit 7f4a99dd2428b2395fff7db0330a4c9280054162
Author: Christian Biesinger <cbiesinger@chromium.org>
Date: Mon Mar 21 20:04:39 2016

Set m_{width,height}AvailableToChildrenChanged when scrollbars appear

This is a regression from https://codereview.chromium.org/1734203002. Before
that change, we'd just call layoutBlock(true). However, the new approach
just marks for layout and eventually recurses down, so to ensure that
the children get laid out, we have to set
m_{width,height}AvailableToChildrenChanged.

BUG= 594465 , 593593 , 590683 , 593624 , 593593 

Review URL: https://codereview.chromium.org/1811753003

Cr-Commit-Position: refs/heads/master@{#382074}
(cherry picked from commit fbb25cec59deb052604d63036f1c5baf6efd2a5c)

Review URL: https://codereview.chromium.org/1819993002 .

Cr-Commit-Position: refs/branch-heads/2661@{#324}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos-expected.html
[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos.html
[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-expected.html
[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes.html
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Comment 10 by ssamanoori@chromium.org, Mar 22 2016

Labels: TE-Verified-50.0.2661.48 TE-Verified-M50
Tested the issue on Windows 7, Ubuntu 14.04 using 50.0.2661.48.Observed that No unwanted horizontal scrollbar is seen.
Please find attached screencast.

Marking it as TE-Verified.
590683.mp4
1.0 MB Download
►

Sign in to add a comment