New issue
Advanced search Search tips

Issue 590676 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

fetch_dispatcher_ in ServiceWorkerVersionBrowserTest must be cleared on IO thread.

Project Member Reported by horo@chromium.org, Feb 29 2016

Issue description

The crashes ( issue 590400 ) were happened while resetting |fetch_dispatcher_| in ServiceWorkerVersionBrowserTest::FetchOnRegisteredWorker().
https://chromium.googlesource.com/chromium/src/+/3fbfbe6e7690dd2b169cfaaae2ad7ac89537d74b/content/browser/service_worker/service_worker_browsertest.cc#458

|fetch_dispatcher_| is created on IO thread.
So it must be cleared on IO thread.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d028982479f6173a0a20c274cd8bac2852fefaf6

commit d028982479f6173a0a20c274cd8bac2852fefaf6
Author: horo <horo@chromium.org>
Date: Tue Mar 01 09:46:20 2016

Reset fetch_dispatcher_ in ServiceWorkerVersionBrowserTest on IO thread.

The crashes ( issue 590400 ) happened while resetting |fetch_dispatcher_| in ServiceWorkerVersionBrowserTest::FetchOnRegisteredWorker().
https://chromium.googlesource.com/chromium/src/+/3fbfbe6e7690dd2b169cfaaae2ad7ac89537d74b/content/browser/service_worker/service_worker_browsertest.cc#458

|fetch_dispatcher_| is created on IO thread.
So it must be cleared on IO thread.

BUG= 590676 ,  590400 

Review URL: https://codereview.chromium.org/1750513002

Cr-Commit-Position: refs/heads/master@{#378421}

[modify] https://crrev.com/d028982479f6173a0a20c274cd8bac2852fefaf6/content/browser/service_worker/service_worker_browsertest.cc

Comment 2 by horo@chromium.org, Mar 1 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 2 2016

Labels: Merge-Merged-master1
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/d028982479f6173a0a20c274cd8bac2852fefaf6

commit d028982479f6173a0a20c274cd8bac2852fefaf6
Author: horo <horo@chromium.org>
Date: Tue Mar 01 09:46:20 2016

Sign in to add a comment