Issue metadata
Sign in to add a comment
|
Regression: ’Speaker’ icon doesn’t appear in tab, while ‘CAPTCHA’ code is being spoken.
Reported by
yfulgaon...@etouch.net,
Feb 29 2016
|
||||||||||||||||||||||
Issue descriptionChrome version : 51.0.2662.0 4d223c72fe4e76c7404bffb662f742b947f97107-refs/heads/master@{#378134} 64-bit. OS : Mac URL: chrome://chrome-signin/?access_point=0&reason=0 Steps : 1. Launch chrome and go to above URL. 2. Keep entering wrong login credentials until it promotes to enter a ‘CAPTCHA’ code. 3. Once the ‘CAPTCHA’ code is appeared, click on ‘Accessibility logo’ and observe. Actual : ’Speaker’ icon doesn’t appear in tab, while ‘CAPTCHA’ code is being spoken. Expected : ’Speaker’ icon should appear in tab, while ‘CAPTCHA’ code is being spoken. This is a regression issue broken in 'M-41’ and below is the manual regression and narrow bisect info: Good build : 41.0.2269.0 Bad build : 41.0.2270.0 Narrow Bisect : https://chromium.googlesource.com/chromium/src/+log/fc9d656e519581df1eff7adcb11c7560b5b828d0..379d1c4874598ad81662b8baa45105fe07e13ed9?pretty=fuller&n=10000 Suspecting r310403 or 310408 ? from narrow bisect Note : Issue is not seen on Windows and Linux OS. @ccameron : Could you please help to reassign if your change is not the cause for this issue
,
Mar 3 2016
To Elly to take a look. Given that it broke in M41, probably not a P1.
,
Mar 3 2016
,
Mar 25 2016
This was introduced likely by r310404, which changed how signin is done. Still digging a little bit to figure out why this happened.
,
Mar 25 2016
Okay. I can confirm that this happens on chrome://signin/, but *not* on https://accounts.google.com/ServiceLogin?hl=en&passive=true&continue=https://www.google.com/#identifier, which seems to serve the same type of captcha. I'm now wondering if this has to do with the fact that the chrome://signin/ flow appears to use an extension. Going to find someone who understands extensions to ask them.
,
Apr 7 2016
Assigning to wjmaclean@ for investigation; I think this is related to chrome://signin/ using a webview.
,
Apr 8 2016
This also appears to reproduce on Linux, marking as "all" for now.
,
Apr 8 2016
Likely the inverse of https://codereview.chromium.org/1554233004/, where we need to plumb WasRecentlyAudible() from the guest webcontents to the embedder WebContents.
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dabf3e34c14d34d9fb262a54cd26c1878eb0034 commit 1dabf3e34c14d34d9fb262a54cd26c1878eb0034 Author: wjmaclean <wjmaclean@chromium.org> Date: Fri May 13 23:34:44 2016 Audio notification plumbed from guest WebContents up to embedder. When a guest webcontents is playing audio, there is no way for an entity interacting with the embedder webcontents to determine this. This CL adds two things: i) The ability for WebContentsImpl::WasRecentlyAudible() to query any guest/child contents to determine if they were recently audible, and ii) the ability for a guest webcontents to pass any navigation state changes up to the embedder in order to make them visible at the top level. BUG= 590656 Review-Url: https://codereview.chromium.org/1970313002 Cr-Commit-Position: refs/heads/master@{#393689} [modify] https://crrev.com/1dabf3e34c14d34d9fb262a54cd26c1878eb0034/chrome/browser/apps/guest_view/web_view_browsertest.cc [add] https://crrev.com/1dabf3e34c14d34d9fb262a54cd26c1878eb0034/chrome/test/data/extensions/platform_apps/web_view/simple/ping.mp3 [modify] https://crrev.com/1dabf3e34c14d34d9fb262a54cd26c1878eb0034/content/browser/browser_plugin/browser_plugin_embedder.cc [modify] https://crrev.com/1dabf3e34c14d34d9fb262a54cd26c1878eb0034/content/browser/browser_plugin/browser_plugin_embedder.h [modify] https://crrev.com/1dabf3e34c14d34d9fb262a54cd26c1878eb0034/content/browser/web_contents/web_contents_impl.cc
,
May 13 2016
This should now be fixed as of r393689. Marking fixed, please re-open if needed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ccameron@chromium.org
, Mar 2 2016