Nothing happens after selecting 'Print' option from context menu of 'Cast' overlay
Reported by
jshan...@etouch.net,
Feb 29 2016
|
|||||||||||||
Issue descriptionChrome Version: 51.0.2662.0 (Official Build) 4d223c72fe4e76c7404bffb662f742b947f97107-refs/heads/master@{#378134}-32/64 bit OS: All(Win 7-Aero enabled) Pre-condition: Enable the 'Media Router' flag from chrome://flags. Steps: 1. Launch Chrome and go to NTP. 2. Right click to open the context menu and select 'Cast' 3. Right click on 'Cast' overlay and select 'Print' option from context menu and observe. Actual: Nothing happens after selecting 'Print' option from context menu of 'Cast' overlay. Expected: Print option should work or Print option should be disable in context menu. This is a non regression issue,seen from 'M-46'series.
,
Feb 29 2016
,
Feb 29 2016
Jennifer, it seems we should be disabling the default context menu in the MR overlays. WDYT?
,
Feb 29 2016
,
Mar 1 2016
SGTM.
,
Mar 3 2016
,
Mar 23 2016
,
May 12 2016
,
May 12 2016
,
Jul 20 2016
,
Jul 20 2016
takumif@: I saw your CL for this go out. There was an offline chat about just disabling "Print" in the contextual menu rather than the entire menu after #5, and we never updated the bug to reflect it. Can you confirm with skonig@ about our intended behavior here? Thanks!
,
Jul 20 2016
I don't see any harm in having a contextual menu, so long as the options are valid/make sense/work. If we've disabled Print already and everything else is fine to have there, I'm good with where we've landed.
,
Jul 20 2016
Actually, we haven't disabled Print yet. Jennifer was working on it sometime ago but she never submitted it, and now she can't find it anymore. I agree that just disabling Print would be good, unless it's really complex to do so.
,
Jul 20 2016
SGTM on disabling Print. I can show you what files I was working on if you need any pointers, just let me know.
,
Aug 5 2016
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10d41a7cb5416afdb434e98c3b411284c0ab0be8 commit 10d41a7cb5416afdb434e98c3b411284c0ab0be8 Author: takumif <takumif@chromium.org> Date: Fri Aug 05 19:19:50 2016 Disable Print in the context menu when a modal dialog is shown Disable the "Print..." option in the page context menu when chrome::CanPrint is false. This disables printing when a modal dialog, such as the Media Router dialog, is being shown, just like the Print option in the hotdog menu. BUG= 590650 Review-Url: https://codereview.chromium.org/2215123002 Cr-Commit-Position: refs/heads/master@{#410138} [modify] https://crrev.com/10d41a7cb5416afdb434e98c3b411284c0ab0be8/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/10d41a7cb5416afdb434e98c3b411284c0ab0be8/chrome/browser/renderer_context_menu/render_view_context_menu.h
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a89a3fe84309645f6cbf9d745bbd66a80853ffba commit a89a3fe84309645f6cbf9d745bbd66a80853ffba Author: takumif <takumif@chromium.org> Date: Fri Aug 05 19:38:58 2016 Revert of Disable Print in the context menu when a modal dialog is shown (patchset #3 id:40001 of https://codereview.chromium.org/2215123002/ ) Reason for revert: chrome::FindBrowserWithWebContents(source_web_contents_) returns a nullptr for the PDF viewer, causing the Print option to be disabled for PDFs. We need to replace chrome::FindBrowserWithWebContents(source_web_contents_). Original issue's description: > Disable Print in the context menu when a modal dialog is shown > > Disable the "Print..." option in the page context menu when chrome::CanPrint > is false. This disables printing when a modal dialog, such as the Media Router > dialog, is being shown, just like the Print option in the hotdog menu. > > BUG= 590650 > > Committed: https://crrev.com/10d41a7cb5416afdb434e98c3b411284c0ab0be8 > Cr-Commit-Position: refs/heads/master@{#410138} TBR=thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 590650 Review-Url: https://codereview.chromium.org/2214323003 Cr-Commit-Position: refs/heads/master@{#410146} [modify] https://crrev.com/a89a3fe84309645f6cbf9d745bbd66a80853ffba/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/a89a3fe84309645f6cbf9d745bbd66a80853ffba/chrome/browser/renderer_context_menu/render_view_context_menu.h
,
Aug 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60869c312fa69649a1cdbcae7539071cefaa9b10 commit 60869c312fa69649a1cdbcae7539071cefaa9b10 Author: takumif <takumif@chromium.org> Date: Thu Aug 11 04:04:29 2016 Reland "Disable Print in the context menu when a modal dialog is shown" Original CL: https://codereview.chromium.org/2215123002/ Disable the "Print..." option in the page context menu when chrome::CanPrint is false. This disables printing when a modal dialog, such as the Media Router dialog, is being shown, just like the Print option in the hotdog menu. BUG= 590650 Review-Url: https://codereview.chromium.org/2219173002 Cr-Commit-Position: refs/heads/master@{#411258} [modify] https://crrev.com/60869c312fa69649a1cdbcae7539071cefaa9b10/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/60869c312fa69649a1cdbcae7539071cefaa9b10/chrome/browser/renderer_context_menu/render_view_context_menu.h
,
Aug 11 2016
,
Aug 3
Issue 586446 has been merged into this issue. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by msrchandra@chromium.org
, Feb 29 2016