Issue metadata
Sign in to add a comment
|
Selection.deleteFromDocument() crashes with ::first-letter. |
||||||||||||||||||||||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=6263501967851520 Fuzzer: bj_broddelwerk Job Type: linux_asan_content_shell_drt Platform Id: linux Crash Type: UNKNOWN Crash Address: 0x61d2000c767e Crash State: blink::VisiblePositionTemplate<blink::EditingAlgorithm<blink::NodeTraversal> > b blink::nextSentencePosition blink::SelectionEditor::modifyMovingForward Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_content_shell_drt&range=375259:376290 Minimized Testcase (1.56 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96td64TS90LrmvEdR6zKeEug6YR8xMcQP3bg_JySmrlg0YZwp4v72rWJiQbJxLFIyVVpcqUti-zk02nKp1AALfD7RDCkVemyDrEdfBNBcVvM9ZBBxQeSxz9a_P7f5N7BaPFkGEkZHeP3aFfx2VdWAO5eh9r7A Filer: inferno See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Feb 29 2016
,
Feb 29 2016
,
Feb 29 2016
yosin, might we know why you removed the owner? I manually reverted the CL mentioned in #1, and it no longer crashes. We wish to make sure that security bugs (especially high severity) are always be in someone's work queue. If we've assigned/CC'ed the wrong people, it would be appreciated if you could point us to the right direction.
,
Feb 29 2016
This issue has pretty much the same root cause as cr588548 that, |Selection::deleteFromDocument()| does not work properly with <pseudo:first-letter>. This time it hits another assertion: ASSERTION FAILED: currentPos.offsetInLeafNode() >= 1 ../../third_party/WebKit/Source/core/editing/VisibleUnits.cpp(2551) : PositionTemplate<Strategy> blink::mostBackwardCaretPosition(const PositionTemplate<Strategy> &, blink::EditingBoundaryCrossingRule) [Strategy = blink::EditingAlgorithm<blink::NodeTraversal>] Received signal 11 SEGV_MAPERR 0000fbadbeef #0 0x000008415c7e base::debug::StackTrace::StackTrace() #1 0x0000084157bf base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f0b91317340 <unknown> #3 0x0000048f87a8 blink::mostBackwardCaretPosition<>() #4 0x0000048f8122 blink::mostBackwardCaretPosition() #5 0x0000048edf34 blink::canonicalPosition<>() #6 0x0000048edd7c blink::canonicalPositionOf() #7 0x0000048e467c blink::VisiblePositionTemplate<>::create() #8 0x0000048e44dc blink::createVisiblePosition() #9 0x0000048e4488 blink::createVisiblePosition() #10 0x00000489fcba blink::DOMSelection::setBaseAndExtent() #11 0x0000048a100c blink::DOMSelection::deleteFromDocument() #12 0x000003d49039 blink::DOMSelectionV8Internal::deleteFromDocumentMethod() #13 0x000003d45c98 blink::DOMSelectionV8Internal::deleteFromDocumentMethodCallback() In both cr588548 and this issue, |Selection::deleteFromDocument()| passes some invalid content to |nextBoundary()|. Before the CL mentioned in #1, there was some validation (in an implicit form), so it did not crash. The validation was removed by the CL. The same validation can be added back as a quick patch to these two issues. The root cause is still there, though.
,
Mar 1 2016
Sorry for my typo in #5. It hits the same assertion as in cr588548.
,
Mar 1 2016
,
Mar 12 2016
ClusterFuzz has detected this issue as fixed in range 380105:380830. Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6263501967851520 Fuzzer: bj_broddelwerk Job Type: linux_asan_content_shell_drt Platform Id: linux Crash Type: UNKNOWN Crash Address: 0x61d2000c767e Crash State: blink::VisiblePositionTemplate<blink::EditingAlgorithm<blink::NodeTraversal> > b blink::nextSentencePosition blink::SelectionEditor::modifyMovingForward Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_content_shell_drt&range=375259:376290 Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_content_shell_drt&range=380105:380830 Minimized Testcase (1.56 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96td64TS90LrmvEdR6zKeEug6YR8xMcQP3bg_JySmrlg0YZwp4v72rWJiQbJxLFIyVVpcqUti-zk02nKp1AALfD7RDCkVemyDrEdfBNBcVvM9ZBBxQeSxz9a_P7f5N7BaPFkGEkZHeP3aFfx2VdWAO5eh9r7A See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Jun 17 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 1 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by infe...@chromium.org
, Feb 29 2016Components: Blink>Editing
Owner: xiaoche...@chromium.org
Status: Assigned (was: Available)