New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 590490 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 571915



Sign in to add a comment

SandboxWinTest.Inherit*HandlesSandboxed tests failing on Win10

Project Member Reported by wfh@chromium.org, Feb 28 2016

Issue description

Version: 3e56c19c6d4c68c446d79ff030b8276c81169304
OS: Windows 10 64-bit 10.0.10586

content_browsertests failing on

[ RUN      ] SandboxWinTest.InheritMultipleHandlesSandboxed
e:\b\build\slave\chromium_win_10\build\src\content\common\sandbox_win_unittest.cc(324): error: Value of: exit_code
  Actual: -1066598274
Expected: 0
[  FAILED  ] SandboxWinTest.InheritMultipleHandlesSandboxed (60 ms)
[840/1254] SandboxWinTest.InheritMultipleHandlesSandboxed (101 ms)
[ RUN      ] SandboxWinTest.InheritSingleHandleSandboxed
e:\b\build\slave\chromium_win_10\build\src\content\common\sandbox_win_unittest.cc(216): error: Value of: exit_code
  Actual: -1066598274
Expected: 0
[  FAILED  ] SandboxWinTest.InheritSingleHandleSandboxed (187 ms)

https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%2010/builds/2306/steps/content_browsertests/logs/stdio
 

Comment 1 by wfh@chromium.org, Feb 28 2016

Blocking: 571915
Labels: Proj-Windows10

Comment 2 by wfh@chromium.org, Feb 28 2016

I also can't repro this locally

Comment 3 by roc...@chromium.org, Feb 29 2016

Is there someone who can help sort out how to locally repro the environment these tests are run in? Or even if I could manually kick off a job on the FYI bot that would be a good start.

Comment 4 by wfh@chromium.org, Feb 29 2016

base::debug::`anonymous namespace'::InitializeSymbols is failing from within the sandbox on the win10 bot

ModLoad: 00007ffc`f39f0000 00007ffc`f3a22000   C:\WINDOWS\SYSTEM32\fwbase.dll
(12fc.1300): Unknown exception - code c06d007e (first chance)
(12fc.1300): Unknown exception - code c06d007e (!!! second chance !!!)
*** ERROR: Symbol file could not be found.  Defaulted to export symbols for C:\WINDOWS\system32\KERNELBASE.dll - 
KERNELBASE!RaiseException+0x68:
00007ffc`f4f61f08 488b8c24c0000000 mov     rcx,qword ptr [rsp+0C0h] ss:000000cd`c25bf3b0=0000a8f9ec683574
3:015> k
*** WARNING: Unable to verify checksum for content_browsertests.exe
Child-SP          RetAddr           Call Site
000000cd`c25bf2f0 00007ff6`33124c31 KERNELBASE!RaiseException+0x68
000000cd`c25bf3d0 00007ff6`330e7aff content_browsertests!__delayLoadHelper2+0x189 [f:\dd\vctools\delayimp\delayhlp.cpp @ 315]
000000cd`c25bf490 00007ff6`3105a8ee content_browsertests!_tailMerge_dbghelp_dll+0x3f
000000cd`c25bf500 00007ff6`3316f30f content_browsertests!base::debug::`anonymous namespace'::InitializeSymbols+0x4e
000000cd`c25bf5e0 00007ff6`3316d44b content_browsertests!base::TestSuite::Initialize+0xff
000000cd`c25bf790 00007ff6`3316f682 content_browsertests!content::ContentTestSuiteBase::Initialize+0xb
000000cd`c25bf7c0 00007ff6`3314ba19 content_browsertests!base::TestSuite::Run+0x22
000000cd`c25bf840 00007ff6`30e03d2b content_browsertests!content::ContentTestLauncherDelegate::RunTestSuite+0x39
000000cd`c25bf8c0 00007ff6`3314baa9 content_browsertests!content::LaunchTests+0x25b
000000cd`c25bfd60 00007ff6`330eae6c content_browsertests!main+0x59
*** ERROR: Symbol file could not be found.  Defaulted to export symbols for C:\WINDOWS\system32\KERNEL32.DLL - 
000000cd`c25bfda0 00007ffc`f7e28102 content_browsertests!__tmainCRTStartup+0x144 [f:\dd\vctools\crt\crtw32\startup\crt0.c @ 255]
000000cd`c25bfde0 00007ffc`f86ac574 KERNEL32!BaseThreadInitThunk+0x22
000000cd`c25bfe10 00000000`00000000 ntdll!RtlUserThreadStart+0x34

Comment 5 by wfh@chromium.org, Feb 29 2016

Other tests that run sandboxed childs (e.g. sbox_integration_tests) have a very early if() statement to avoid instantiating the entire test suite e.g.

https://code.google.com/p/chromium/codesearch#chromium/src/sandbox/win/tests/integration_tests/integration_tests.cc&sq=package:chromium&type=cs&l=13

I don't think it's possible to launch an entire test based on base::TestSuite in the sandbox successfully. I'm surprised this works on other OS, perhaps there is something different happening with delay load on this particular win10 bot.

Comment 6 by wfh@chromium.org, Feb 29 2016

it doesn't make any sense that these tests are failing on the vm17-m1 bot but passing on all other win10 boxes I have.

I have tried the following:
 * Disabling UAC on my test vm to match vm17-m1 - still passes on my vm and fails on vm17-m1.
 * isolating the tests, running from a new dir. still fails on vm17-m1.
 * Setting path on vm17-m1 to same as my test VM, still fails on vm17-m1.
 * copying the tests off vm17-m1 and running on another VM - passes on another VM but still not on vm17-m1.
 * running depends on both the vm and my test machine and they look the same, both loading dbghelp.dll via imagehlp.dll

I don't understand this.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7e5cabccbc6297a67af7960ac4b0d5afe36089d

commit b7e5cabccbc6297a67af7960ac4b0d5afe36089d
Author: rockot <rockot@chromium.org>
Date: Tue Mar 01 16:47:38 2016

Delete content sandbox tests which exercise handle inheritance

Sandboxing content_browsertests seems to break Win10 bots. It's
not clear why, but ultimately these tests are probably not worth
the trouble: the unsandboxed case is just a glorified base::LaunchProcess
test, and the sandboxed case is allready covered by a policy test
in sbox_integration_tests.

BUG= 590490 

Review URL: https://codereview.chromium.org/1750793002

Cr-Commit-Position: refs/heads/master@{#378455}

[delete] https://crrev.com/f3e3dcffa4704e72b4c3e34d2f10d4f49b097375/content/common/sandbox_win_unittest.cc
[modify] https://crrev.com/b7e5cabccbc6297a67af7960ac4b0d5afe36089d/content/content_tests.gypi

Status: Fixed (was: Assigned)
Fixed the glitch
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 2 2016

Labels: Merge-Merged-master1
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/b7e5cabccbc6297a67af7960ac4b0d5afe36089d

commit b7e5cabccbc6297a67af7960ac4b0d5afe36089d
Author: rockot <rockot@chromium.org>
Date: Tue Mar 01 16:47:38 2016

Sign in to add a comment