New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 590480 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Add a policy for controlling access to ending tasks via Task Manager

Project Member Reported by maxkirsch@chromium.org, Feb 27 2016

Issue description

Owner: maxkirsch@chromium.org
Max what is the priority on this one? Assigning you as the owner to get it off the triage queue.
Labels: Hotlist-GoodFirstBug
Owner: atwilson@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7a3229d4266db4286ede951643303b1f735023c

commit e7a3229d4266db4286ede951643303b1f735023c
Author: hunyadym <hunyadym@chromium.org>
Date: Wed Apr 20 00:23:43 2016

Add TaskManagerEndProcessEnabled policy, which enables or disables killing a process from Chromium's Task Manager.

End process button in task manager is disabled when policy is set to
false. If the policy is not set or set to true, killing a process is possible.

BUG= 590480 

Review URL: https://codereview.chromium.org/1861383002

Cr-Commit-Position: refs/heads/master@{#388373}

[modify] https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c/chrome/browser/task_manager/task_manager.cc
[modify] https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c/chrome/browser/task_manager/task_manager.h
[modify] https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c/chrome/browser/ui/cocoa/task_manager_mac.mm
[modify] https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c/chrome/browser/ui/views/new_task_manager_view.cc
[modify] https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c/chrome/browser/ui/views/task_manager_view.cc
[modify] https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c/chrome/common/pref_names.cc
[modify] https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c/chrome/common/pref_names.h
[modify] https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c/components/policy/resources/policy_templates.json
[modify] https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c/tools/metrics/histograms/histograms.xml

Owner: hunyadym@chromium.org
Status: Fixed (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/380576660edab0f912671529fa8b5682986f3480

commit 380576660edab0f912671529fa8b5682986f3480
Author: hunyadym <hunyadym@chromium.org>
Date: Wed Apr 27 08:05:18 2016

Remove unnecessary space

BUG= 590480 

Review URL: https://codereview.chromium.org/1923553002

Cr-Commit-Position: refs/heads/master@{#390016}

[modify] https://crrev.com/380576660edab0f912671529fa8b5682986f3480/components/policy/resources/policy_templates.json

Cc: pucchakayala@chromium.org
Test Update:
Works on ChromeOS R52: Tested that this works on 52.0.2743.50:8350.39.0
Verified the implementation pf the TaskManagerEndProcessEnabled.
Verified that the End Process in the task manager is disabled, hence preventing termination of process(es),  when the TaskManagerEndProcessEnabled policy is set to Flase.
When the TaskManagerEndProcessEnabled policy is set to True or not set the End process button is enabled and a process could be terminated.

Not marking this bug as verified as this needs to be verified on Chromium (Linux, Mac, Windows).

Cc: kaishenc@chromium.org
Labels: M-52 OS-All
Note: Fix was checked in to 52.0.2719.0.
Labels: -OS-All OS-Chrome
Status: Verified (was: Fixed)
CPanel implemented per b/27392056.
Since this is a Chrome OS-only user policy, marking as verified per #7.
When verifying the policy on the latest M52 52.0.2743.116 with account ktest@crosprqa1.com, the chrome browser keeps crashing. It works ok with other domain user account. A log is attached.
Steps:
1. Sign-in ktest@crosprqa1.com on device
2. Open chrome browser and let it sitting on chrome://policy page a few minutes
3. Result: the browser is crashing and sign-out user account
log-080816-163052.tar.gz
394 KB Download
Cc: zhanlu@chromium.org

Sign in to add a comment