Style pane numeric property change modifier shortcuts are undiscoverable. Shift mousewheel doesn't work
Reported by
noj...@gmail.com,
Feb 27 2016
|
||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.0 Safari/537.36 Steps to reproduce the problem: 1. Go to google.com 2. Select #sfdiv 3. Select max-width 4. Mousewheel on max-width changes it 5. Shift mousewheel does nothing. Shift up/down adds +-10. Alt and pg/up down are totally undiscoverable for +-0.1 and +-100 modifiers What is the expected behavior? Shift + mousewheel / up / down should change numeric property by 10 alt + .. should change .. by 0.1 ctrl + .. should change .. by 100 What went wrong? While testing css changes, especially font-size, margin, padding, translate, opacity and other numeric properties having precision modifiers would make it a lot easier to get a number in human brain translated to a css property value. Did this work before? No Chrome version: 50.0.2661.0 Channel: n/a OS Version: 10.0 Flash Version: Shockwave Flash 21.0 r0 I have a working fix for this. Turns out shift+mousewheel sends as deltaX rather than deltaY. I also added ctrl as +- 100 modifier. There is page up/down but those keys aren't very usable due to their location in the keyboard. I have also added a tooltip that shows up when doing such modifications to increase discover-ability. Let me know what you think?, will send a patch by EOD for review.
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00f8cd4924f855d92d9d05560a4fbe6e174fee04 commit 00f8cd4924f855d92d9d05560a4fbe6e174fee04 Author: nojvek <nojvek@gmail.com> Date: Mon May 09 19:51:34 2016 Fixes 590477: Style pane numeric property change modifier shortcuts are undiscoverable. Shift mousewheel doesn't work BUG= 590477 Review-Url: https://codereview.chromium.org/1824683002 Cr-Commit-Position: refs/heads/master@{#392402} [modify] https://crrev.com/00f8cd4924f855d92d9d05560a4fbe6e174fee04/third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html [modify] https://crrev.com/00f8cd4924f855d92d9d05560a4fbe6e174fee04/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js [modify] https://crrev.com/00f8cd4924f855d92d9d05560a4fbe6e174fee04/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js [modify] https://crrev.com/00f8cd4924f855d92d9d05560a4fbe6e174fee04/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
,
May 9 2016
Doesn't the commit automatically close the bug? Or does someone have to go and close it?
,
May 9 2016
This is fixed now.
,
May 9 2016
Perfect. I'm glad this is in. My designer friends probably owe me a beer now. |
||
►
Sign in to add a comment |
||
Comment 1 by caseq@chromium.org
, Mar 14 2016Labels: -OS-Windows -Pri-2 -Arch-x86_64 OS-All Pri-3
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)