Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 587995 PaymentRequest API
Starred by 24 users Project Member Reported by rouslan@chromium.org, Feb 18 2016 Back to list
Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Status: ----
Launch-Test: ----
Launch-UI: ----


Sign in to add a comment
Change description:
An API that allows browsers to act as an intermediary between the three key parties in a financial transaction: the merchant (e.g. an online web store), the buyer (e.g. the user buying from the online web store), and the Payment Method (e.g. credit card). Information necessary to process and confirm a transaction is passed between the Payment Method and the merchant via the browser with the buyer confirming and authorizing as necessary across the flow.

Changes to API surface:
New interface: PaymentRequest.

Links:
http://wicg.github.io/paymentrequest/specs/paymentrequest.html

Support in other browsers:
Internet Explorer: Plans to support the API.
Firefox: Member of web payments working group.
Safari: Member of web payments working group.
 
Issue 587207 has been merged into this issue.
Project Member Comment 2 by bugdroid1@chromium.org, Mar 3 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c757fcfb1cd39e90b7e520572ec8dcb276ebb748

commit c757fcfb1cd39e90b7e520572ec8dcb276ebb748
Author: rouslan <rouslan@chromium.org>
Date: Thu Mar 03 01:46:27 2016

PaymentRequest API.

An API that allows browsers to act as an intermediary between the three
key parties in a financial transaction: the merchant (e.g. an online web
store), the buyer (e.g. the user buying from the online web store), and
the Payment Method (e.g. credit card). Information necessary to process
and confirm a transaction is passed between the Payment Method and the
merchant via the browser with the buyer confirming and authorizing as
necessary across the flow.

Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/gbSs15ZSWtA/JFU3H7fTDQAJ

BUG=587995

Review URL: https://codereview.chromium.org/1702223002

Cr-Commit-Position: refs/heads/master@{#378911}

[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[rename] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/bindings/core/v8/JSONValuesForV8.cpp
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/bindings/core/v8/JSONValuesForV8.h
[modify] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/bindings/core/v8/v8.gypi
[modify] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/core/events/EventTypeNames.in
[modify] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/EventTargetModulesFactory.in
[modify] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/modules.gypi
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/CurrencyAmount.idl
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/OWNERS
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentDetails.idl
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentItem.idl
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentOptions.idl
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentRequest.h
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentRequest.idl
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentResponse.h
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentResponse.idl
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/ShippingAddress.h
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/ShippingAddress.idl
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/ShippingOption.idl
[delete] https://crrev.com/6d43ad63a0639e8ca8871fd6ad907e1dd47c206f/third_party/WebKit/Source/platform/JSONValuesForV8.h
[modify] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/platform/blink_platform.gypi

Project Member Comment 3 by bugdroid1@chromium.org, Mar 3 2016
Labels: merge-merged-2666
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c757fcfb1cd39e90b7e520572ec8dcb276ebb748

commit c757fcfb1cd39e90b7e520572ec8dcb276ebb748
Author: rouslan <rouslan@chromium.org>
Date: Thu Mar 03 01:46:27 2016

PaymentRequest API.

An API that allows browsers to act as an intermediary between the three
key parties in a financial transaction: the merchant (e.g. an online web
store), the buyer (e.g. the user buying from the online web store), and
the Payment Method (e.g. credit card). Information necessary to process
and confirm a transaction is passed between the Payment Method and the
merchant via the browser with the buyer confirming and authorizing as
necessary across the flow.

Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/gbSs15ZSWtA/JFU3H7fTDQAJ

BUG=587995

Review URL: https://codereview.chromium.org/1702223002

Cr-Commit-Position: refs/heads/master@{#378911}

[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[rename] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/bindings/core/v8/JSONValuesForV8.cpp
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/bindings/core/v8/JSONValuesForV8.h
[modify] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/bindings/core/v8/v8.gypi
[modify] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/core/events/EventTypeNames.in
[modify] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/EventTargetModulesFactory.in
[modify] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/modules.gypi
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/CurrencyAmount.idl
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/OWNERS
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentDetails.idl
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentItem.idl
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentOptions.idl
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentRequest.h
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentRequest.idl
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentResponse.h
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/PaymentResponse.idl
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/ShippingAddress.h
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/ShippingAddress.idl
[add] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/modules/payments/ShippingOption.idl
[delete] https://crrev.com/6d43ad63a0639e8ca8871fd6ad907e1dd47c206f/third_party/WebKit/Source/platform/JSONValuesForV8.h
[modify] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/c757fcfb1cd39e90b7e520572ec8dcb276ebb748/third_party/WebKit/Source/platform/blink_platform.gypi

Project Member Comment 4 by bugdroid1@chromium.org, Apr 1 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f

commit 763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f
Author: rouslan <rouslan@chromium.org>
Date: Fri Apr 01 00:03:53 2016

PaymentRequest Mojo bindings.

The Mojo (new IPC replacement) bindings for PaymentRequest Blink API.
Blink uses the bindings to procure the functionality for the API. Mojo
eliminates multiple layers of abstraction, letting the embedder provide
the functionality by implementing the PaymentRequest interface in C++ or
Java for Android. The PaymentRequest interface lives in:

third_party/Webkit/public/platform/modules/payments/payment_request.mojom

The embedder does not provide any functionality in this patch.

PaymentRequest draft spec:
https://w3c.github.io/browser-payment-api/specs/paymentrequest.html

BUG=587995
TEST=PaymentRequestTest.cpp
TEST=PaymentResponseTest.cpp
TEST=PaymentsValidatorsTest.cpp
TEST=ShippingAddressTest.cpp
TEST=payment-request-interface.html

Review URL: https://codereview.chromium.org/1753543002

Cr-Commit-Position: refs/heads/master@{#384439}

[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.h
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/battery/BatteryDispatcher.cpp
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/modules.gyp
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/CurrencyAmount.idl
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/DEPS
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentCompleter.h
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentDetails.idl
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.cpp
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.h
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentItem.idl
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentOptions.idl
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentRequest.h
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentRequest.idl
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentResponse.h
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentResponse.idl
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentsValidators.h
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/ShippingAddress.cpp
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/ShippingAddress.h
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/ShippingAddress.idl
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/ShippingAddressTest.cpp
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/modules/payments/ShippingOption.idl
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/platform/DEPS
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/platform/MojoHelper.h
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/platform/blink_platform.gyp
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/platform/blink_platform.gypi
[delete] https://crrev.com/1dbbd7933b654b4c61bba47b26e60f4e574e7740/third_party/WebKit/Source/platform/threading/BindForMojo.h
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/platform/threading/DEPS
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/Source/web/web_tests.gyp
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/public/blink.gyp
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/public/platform/modules/payments/OWNERS
[add] https://crrev.com/763f2a3acbf7ee75d8eb4f1c0a6d90399f75082f/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Project Member Comment 5 by bugdroid1@chromium.org, Apr 7 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abec35f181976833456084b6f4862afa80f5bc8f

commit abec35f181976833456084b6f4862afa80f5bc8f
Author: rouslan <rouslan@chromium.org>
Date: Thu Apr 07 00:22:41 2016

Use the frame-specific service registry for PaymentRequest

This patch changes PaymentRequest to use the Mojo service registry from
LocalFrame.h. This service registry is distinct from Platform.h, which
is for the render thread. Thread's and frame's service registries
communicate to different sets of Mojo services in the browser.

BUG=587995

Review URL: https://codereview.chromium.org/1866083002

Cr-Commit-Position: refs/heads/master@{#385599}

[modify] https://crrev.com/abec35f181976833456084b6f4862afa80f5bc8f/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Project Member Comment 6 by bugdroid1@chromium.org, Apr 7 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f6c373bd44bfbaad1468d86d13293b4a8640c58

commit 2f6c373bd44bfbaad1468d86d13293b4a8640c58
Author: rouslan <rouslan@chromium.org>
Date: Thu Apr 07 03:51:42 2016

Scaffolding for Android implementation of PaymentRequest.

This patch places ServiceRegistryAndroid in content/public/, so Chrome
can register Android-specific services for Mojo. ServiceRegistryAndroid
is a pure virtual interface, implemented by ServiceRegistryAndroidImpl
in content/browser/android/.

The first user of the Android-specific features of Mojo in Chrome is the
PaymentRequest service. This patch adds a skeleton implementation of
this service.

BUG=587995
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1831173002

Cr-Commit-Position: refs/heads/master@{#385647}

[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/chrome/android/BUILD.gn
[add] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeServiceRegistrar.java
[add] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestDialog.java
[add] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/chrome/android/java_sources.gni
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/chrome/browser/android/chrome_jni_registrar.cc
[add] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/chrome/browser/android/mojo/chrome_service_registrar_android.cc
[add] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/chrome/browser/android/mojo/chrome_service_registrar_android.h
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/chrome/chrome.gyp
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/chrome/chrome_browser.gypi
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/content/browser/android/browser_jni_registrar.cc
[rename] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/content/browser/android/service_registry_android_impl.cc
[add] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/content/browser/android/service_registry_android_impl.h
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/content/browser/mojo/mojo_application_host.cc
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/content/browser/mojo/mojo_application_host.h
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/content/browser/mojo/service_registrar_android.cc
[delete] https://crrev.com/9869b607088767819f5408674d45d82aa5a381d8/content/browser/mojo/service_registry_android.h
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/content/content_browser.gypi
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/content/public/android/java/src/org/chromium/content/browser/ServiceRegistry.java
[add] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/content/public/browser/android/service_registry_android.h
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/content/shell/browser/shell_mojo_test_utils_android.cc
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/2f6c373bd44bfbaad1468d86d13293b4a8640c58/third_party/WebKit/public/blink.gyp

Project Member Comment 7 by bugdroid1@chromium.org, Apr 12 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/beabbc4259fe54a818c1e824768495e8e8663406

commit beabbc4259fe54a818c1e824768495e8e8663406
Author: rob.buis <rob.buis@samsung.com>
Date: Tue Apr 12 03:33:17 2016

Add unit test for providing empty list of detail items

Add unit test for testing that an exception is thrown for an empty list
of detail items, this is different from not providing detail items
at all (ItemListRequired).

BUG=587995

Review URL: https://codereview.chromium.org/1877943002

Cr-Commit-Position: refs/heads/master@{#386569}

[modify] https://crrev.com/beabbc4259fe54a818c1e824768495e8e8663406/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

Blockedon: 602657
Blockedon: 602659
Blockedon: 602660
Blockedon: 602662
Blockedon: 602663
Blockedon: 602664
Blockedon: 602665
Blockedon: 602666
Blockedon: 603635
Project Member Comment 18 by bugdroid1@chromium.org, Apr 18 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/297a4b7b0e8651b599f8f6e5ee7455b7ef792127

commit 297a4b7b0e8651b599f8f6e5ee7455b7ef792127
Author: rouslan <rouslan@chromium.org>
Date: Mon Apr 18 20:38:38 2016

Add type and icon to credit card object in Java

This patch adds the credit card type and issuer icon to the credit card
object in Java. The issuer icon is shown to the user in PaymentRequest UI.

The card types are strings as defined in "Basic Card Payment" W3C editor's
draft:

https://w3c.github.io/browser-payment-api/specs/basic-card-payment.html#method-id

The card type is returned to the merchant website in PaymentRequest
response object:

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentresponse-interface

BUG=587995

Review URL: https://codereview.chromium.org/1902513002

Cr-Commit-Position: refs/heads/master@{#388004}

[modify] https://crrev.com/297a4b7b0e8651b599f8f6e5ee7455b7ef792127/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/297a4b7b0e8651b599f8f6e5ee7455b7ef792127/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
[modify] https://crrev.com/297a4b7b0e8651b599f8f6e5ee7455b7ef792127/chrome/browser/autofill/android/personal_data_manager_android.cc

Project Member Comment 19 by bugdroid1@chromium.org, Apr 19 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ebc6f22f9eb3c0ebda41830f1aae1e225141a8e

commit 6ebc6f22f9eb3c0ebda41830f1aae1e225141a8e
Author: rouslan <rouslan@chromium.org>
Date: Tue Apr 19 21:13:37 2016

Provide web contents to Chrome's mojo services

For the mojo service implementations in Chrome that fulfill tasks for
render frames, the ChromeServiceRegistrar should provide the WebContents
object that corresponds to the render frame that requested the service.
This allows the service implementation to access WebContents-specific
data and show UI on top of the WebContents.

This patch also renames PaymentRequestDialog.java into
PaymentRequestImpl.java, because it implements the mojo PaymentRequest
service, while the UI functionality is implemented in a separate class.

BUG=587995

Review URL: https://codereview.chromium.org/1902913002

Cr-Commit-Position: refs/heads/master@{#388310}

[modify] https://crrev.com/6ebc6f22f9eb3c0ebda41830f1aae1e225141a8e/chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeServiceRegistrar.java
[delete] https://crrev.com/dafbff4e06b16d2005b0bdc077e5ea7f2642237a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestDialog.java
[modify] https://crrev.com/6ebc6f22f9eb3c0ebda41830f1aae1e225141a8e/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java
[add] https://crrev.com/6ebc6f22f9eb3c0ebda41830f1aae1e225141a8e/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/6ebc6f22f9eb3c0ebda41830f1aae1e225141a8e/chrome/android/java_sources.gni
[modify] https://crrev.com/6ebc6f22f9eb3c0ebda41830f1aae1e225141a8e/chrome/browser/android/mojo/chrome_service_registrar_android.cc
[modify] https://crrev.com/6ebc6f22f9eb3c0ebda41830f1aae1e225141a8e/chrome/browser/android/mojo/chrome_service_registrar_android.h
[modify] https://crrev.com/6ebc6f22f9eb3c0ebda41830f1aae1e225141a8e/chrome/browser/chrome_content_browser_client.cc

Project Member Comment 20 by bugdroid1@chromium.org, Apr 20 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a

commit 23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a
Author: rouslan <rouslan@chromium.org>
Date: Wed Apr 20 00:04:19 2016

Customize card unmasking prompt

This patch enables switching the card unmasking prompt between two
configurations:

UNMASK_FOR_AUTOFILL:
 - Title: "Verify your card"
 - Instructions: "Enter the 3-digit CVC number from the back of your
                  card."
 - Confirm button: "Verify"

The UNMASK_FOR_AUTOFILL mode is how the unmasking prompt looks today.

UNMASK_FOR_PAYMENT_REQUEST:
 - Title: "Pay with your card"
 - Instructions: "Enter the 3-digit CVC number from the back of your
                  card for verification."
 - Confirm button: "Continue"

The UNMASK_FOR_PAYMENT_REQUEST mode is needed to support paying with
masked server cards in PaymentRequest.

BUG=587995

Review URL: https://codereview.chromium.org/1895143003

Cr-Commit-Position: refs/heads/master@{#388368}

[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/android_webview/native/aw_autofill_client.cc
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/android_webview/native/aw_autofill_client.h
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/components/autofill/core/browser/ui/card_unmask_prompt_controller.h
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.h
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl_unittest.cc
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/components/autofill_strings.grdp
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/ios/chrome/browser/ui/autofill/autofill_client_ios.h
[modify] https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a/ios/chrome/browser/ui/autofill/autofill_client_ios.mm

Project Member Comment 21 by bugdroid1@chromium.org, Apr 25 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f65036c8c638497a88eed1a7278b2d3022d39e4e

commit f65036c8c638497a88eed1a7278b2d3022d39e4e
Author: rouslan <rouslan@chromium.org>
Date: Mon Apr 25 18:35:36 2016

Card unmasking without form filling

This patch enables users of Autofill Manager to unmask credit cards even
when a credit card form is not being filled. This is accomplished by
refactoring the card unmasking functionality into its own class
FullCardRequest, owned by PersonalDataManager.

The FullCardRequest class is used to retrieve the full PAN and CVC of
the card. If the card is already unmasked, the user is still prompted
for the CVC, but there's no unmasking.

This is primarily useful for PaymentRequest, which provides the full PAN
and the CVC of a card to the JavaScript API.

Only one unmask request per Autofill Manager can be active at a time.
(There's one Autofill Manager per frame.)

The patch also exposes the card unmasking functionality to Java callers
through PersonalDataManager. Because there's only one instance of
PersonalDataManager in Java, only one unmask request from Java can be
active a time.

BUG=587995

Review URL: https://codereview.chromium.org/1899893002

Cr-Commit-Position: refs/heads/master@{#389520}

[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill.gypi
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/autofill_external_delegate_unittest.cc
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/autofill_metrics_unittest.cc
[add] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/payments/full_card_request.cc
[add] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/payments/full_card_request.h
[add] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/payments/full_card_request_unittest.cc
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/components_tests.gyp

Project Member Comment 22 by bugdroid1@chromium.org, Apr 25 2016
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/cc06404b8f69f60492a8bd2c6deb068fcefa43c5

commit cc06404b8f69f60492a8bd2c6deb068fcefa43c5
Author: jdonnelly <jdonnelly@google.com>
Date: Mon Apr 25 19:19:51 2016

Project Member Comment 23 by bugdroid1@chromium.org, Apr 25 2016
Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f65036c8c638497a88eed1a7278b2d3022d39e4e

commit f65036c8c638497a88eed1a7278b2d3022d39e4e
Author: rouslan <rouslan@chromium.org>
Date: Mon Apr 25 18:35:36 2016

Card unmasking without form filling

This patch enables users of Autofill Manager to unmask credit cards even
when a credit card form is not being filled. This is accomplished by
refactoring the card unmasking functionality into its own class
FullCardRequest, owned by PersonalDataManager.

The FullCardRequest class is used to retrieve the full PAN and CVC of
the card. If the card is already unmasked, the user is still prompted
for the CVC, but there's no unmasking.

This is primarily useful for PaymentRequest, which provides the full PAN
and the CVC of a card to the JavaScript API.

Only one unmask request per Autofill Manager can be active at a time.
(There's one Autofill Manager per frame.)

The patch also exposes the card unmasking functionality to Java callers
through PersonalDataManager. Because there's only one instance of
PersonalDataManager in Java, only one unmask request from Java can be
active a time.

BUG=587995

Review URL: https://codereview.chromium.org/1899893002

Cr-Commit-Position: refs/heads/master@{#389520}

[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill.gypi
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/autofill_external_delegate_unittest.cc
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/autofill_metrics_unittest.cc
[add] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/payments/full_card_request.cc
[add] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/payments/full_card_request.h
[add] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/autofill/core/browser/payments/full_card_request_unittest.cc
[modify] https://crrev.com/f65036c8c638497a88eed1a7278b2d3022d39e4e/components/components_tests.gyp

Blockedon: 606930
Blockedon: 607672
Blockedon: 607705
Blockedon: 607971
Blockedon: 608222
Blockedon: 608223
Blockedon: 608234
Project Member Comment 31 by bugdroid1@chromium.org, May 2 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c526a8e3f57decf22c644a3d9a9b28710c3b482e

commit c526a8e3f57decf22c644a3d9a9b28710c3b482e
Author: rouslan <rouslan@chromium.org>
Date: Mon May 02 18:35:29 2016

Provide shipping address only to merchants that need it.

If the merchant provides NULL shipping options, the merchant needs a
shipping address to calculate shipping costs. The UI requires the user
to make an address selection and passes that information to the
merchant.

If the merchant provides non-NULL shipping options, the merchant does
not need shipping address to calculate shipping costs. The UI selects
the default shipping address, but does not send it to the merchant until
the user clicks "Pay".

BUG=587995

Review-Url: https://codereview.chromium.org/1942653002
Cr-Commit-Position: refs/heads/master@{#391004}

[modify] https://crrev.com/c526a8e3f57decf22c644a3d9a9b28710c3b482e/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Project Member Comment 32 by bugdroid1@chromium.org, May 2 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f33419202c68e3272053961ef89562e80352f5e

commit 5f33419202c68e3272053961ef89562e80352f5e
Author: rouslan <rouslan@chromium.org>
Date: Mon May 02 20:36:58 2016

PaymentResponse tests

- Verify that PaymentResponse.details contains the parsed stringified
  JSON object with instrument details.

- Verify that PaymentResponse.complete(boolean) will forward the correct
  boolean boolean value to the implementation of the PaymentCompleter.

BUG=587995

Review-Url: https://codereview.chromium.org/1941633002
Cr-Commit-Position: refs/heads/master@{#391047}

[modify] https://crrev.com/5f33419202c68e3272053961ef89562e80352f5e/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp

Project Member Comment 33 by bugdroid1@chromium.org, May 2 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1cf4691f10367fe89b124329181957d7e587d53

commit e1cf4691f10367fe89b124329181957d7e587d53
Author: rouslan <rouslan@chromium.org>
Date: Mon May 02 22:33:40 2016

More thorough tests for PaymentRequest

- If 'requestShipping' is false, then shippingOption should be null
  regardless of shipping options passed to PaymentRequest constructor.

- An abort() will not throw after show().

- The show() promise is rejected if the shipping address is invalid.

- Should not be able to call show() twice.

- Should not be able to call complete() twice.

- The show() and complete() promises are rejected if the user cancels
  the payment process.

BUG=587995

Review-Url: https://codereview.chromium.org/1938853002
Cr-Commit-Position: refs/heads/master@{#391077}

[modify] https://crrev.com/e1cf4691f10367fe89b124329181957d7e587d53/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/e1cf4691f10367fe89b124329181957d7e587d53/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/e1cf4691f10367fe89b124329181957d7e587d53/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

Project Member Comment 34 by bugdroid1@chromium.org, May 2 2016
Project Member Comment 35 by bugdroid1@chromium.org, Jun 1 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e98a33075ec069bad2924c2bfb6f610e13a67aa9

commit e98a33075ec069bad2924c2bfb6f610e13a67aa9
Author: rouslan <rouslan@chromium.org>
Date: Wed Jun 01 00:58:35 2016

Empty list of payment methods should throw TypeError.

This patch ensures that an empty list of payment methods should throw a
TypeError. Before this patch, any type of error would pass the test. The
code under test:

  new PaymentRequest([], buildDetails());

BUG=587995

Review-Url: https://codereview.chromium.org/2022283004
Cr-Commit-Position: refs/heads/master@{#397004}

[modify] https://crrev.com/e98a33075ec069bad2924c2bfb6f610e13a67aa9/third_party/WebKit/LayoutTests/payments/payment-request-interface.html

Project Member Comment 36 by bugdroid1@chromium.org, Jun 1 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16a031ebcd38ec010bb3148f4aec24bc23b90063

commit 16a031ebcd38ec010bb3148f4aec24bc23b90063
Author: rouslan <rouslan@chromium.org>
Date: Wed Jun 01 02:21:34 2016

Remove id attribute from PaymentItem in test.

PaymentItem no longer has an 'id' attribute. This patch removes the 'id'
attribute from one of the last places in the code base. This place was
missed in the patch that originally introduced the change.

BUG=587995

Review-Url: https://codereview.chromium.org/2025213002
Cr-Commit-Position: refs/heads/master@{#397026}

[modify] https://crrev.com/16a031ebcd38ec010bb3148f4aec24bc23b90063/third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html

Project Member Comment 37 by bugdroid1@chromium.org, Jun 1 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b26313ef9d24c94f72c87f450e54999404e55e51

commit b26313ef9d24c94f72c87f450e54999404e55e51
Author: rouslan <rouslan@chromium.org>
Date: Wed Jun 01 02:53:34 2016

PaymentRequest should throw if not in top context.

The PaymentRequest specification currently states that PaymentRequest
can be constructed only in a top-level browsing context. When inside of
an iframe, the constructor should throw a SecurityError.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentrequest-constructor

Note this may change in the future via iframe sandboxing.

https://github.com/w3c/browser-payment-api/issues/2

BUG=587995

Review-Url: https://codereview.chromium.org/2029473002
Cr-Commit-Position: refs/heads/master@{#397035}

[add] https://crrev.com/b26313ef9d24c94f72c87f450e54999404e55e51/third_party/WebKit/LayoutTests/payments/payment-request-in-iframe.html
[modify] https://crrev.com/b26313ef9d24c94f72c87f450e54999404e55e51/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Cc: -haava...@opera.com jinho.b...@samsung.com
Blockedon: 616568
Blockedon: 616948
Components: UI>Browser>Autofill>Payments Blink>Payments
Project Member Comment 42 by bugdroid1@chromium.org, Jun 3 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c11d1de471dea33c3aa3242e59bc2bb03eb42b6d

commit c11d1de471dea33c3aa3242e59bc2bb03eb42b6d
Author: rouslan <rouslan@chromium.org>
Date: Fri Jun 03 02:23:24 2016

Rename 'items' into 'displayItems' in PaymentDetails.

This patch renames PaymentDetails.items into PaymentDetails.displayItems
to follow the spec updates. This patch does not introduce 100%
compliance with the spec. It is a simple search-and-replace patch.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/commit/9ef1dd251089299fe3a50df6ff77f02821f7663f

BUG=587995

Review-Url: https://codereview.chromium.org/2028603004
Cr-Commit-Position: refs/heads/master@{#397576}

[modify] https://crrev.com/c11d1de471dea33c3aa3242e59bc2bb03eb42b6d/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/c11d1de471dea33c3aa3242e59bc2bb03eb42b6d/chrome/test/data/android/payments/dynamic_shipping.js
[modify] https://crrev.com/c11d1de471dea33c3aa3242e59bc2bb03eb42b6d/chrome/test/data/android/payments/free_shipping.js
[modify] https://crrev.com/c11d1de471dea33c3aa3242e59bc2bb03eb42b6d/chrome/test/data/android/payments/no_shipping.js
[modify] https://crrev.com/c11d1de471dea33c3aa3242e59bc2bb03eb42b6d/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/c11d1de471dea33c3aa3242e59bc2bb03eb42b6d/third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html
[modify] https://crrev.com/c11d1de471dea33c3aa3242e59bc2bb03eb42b6d/third_party/WebKit/Source/modules/payments/PaymentDetails.idl
[modify] https://crrev.com/c11d1de471dea33c3aa3242e59bc2bb03eb42b6d/third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.cpp
[modify] https://crrev.com/c11d1de471dea33c3aa3242e59bc2bb03eb42b6d/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/c11d1de471dea33c3aa3242e59bc2bb03eb42b6d/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
[modify] https://crrev.com/c11d1de471dea33c3aa3242e59bc2bb03eb42b6d/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Blockedon: 617190
Blockedon: 617191
Blockedon: 617193
Blockedon: 617194
Blockedon: 617195
Labels: -M-51 M-53
Blockedon: 618754
Blockedon: 618857
Blockedon: 618860
Blockedon: -602663
Blockedon: 620901
Project Member Comment 54 by bugdroid1@chromium.org, Jun 17 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1532d8d156be95a9bc272cc9fcbb96c00a67c286

commit 1532d8d156be95a9bc272cc9fcbb96c00a67c286
Author: rouslan <rouslan@chromium.org>
Date: Fri Jun 17 23:38:43 2016

Add shippingOption to PaymentResponse

PaymentRequest lets web developers access the shipping option String
through the PaymentRequest object. As it is a part of information
necessary to complete a transaction, it makes sense to place this
information in PaymentResponse as well.

https://w3c.github.io/browser-payment-api/#paymentresponse-interface
https://github.com/w3c/browser-payment-api/commit/47db154ac80a1b1b6bfde4627eab6f496e47670c

* All tests for PaymentRequest::OnPaymentResponse() have been moved into
  OnPaymentResponseTest.cpp.
* The shipping_option_id field in Mojo is renamed to shipping_option to
  match the JavaScript API.

BUG=587995

Review-Url: https://codereview.chromium.org/2073603002
Cr-Commit-Position: refs/heads/master@{#400545}

[modify] https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286/chrome/test/data/android/payments/dynamic_shipping.js
[modify] https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286/chrome/test/data/android/payments/free_shipping.js
[modify] https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286/third_party/WebKit/Source/modules/modules.gypi
[add] https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286/third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp
[modify] https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
[modify] https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
[modify] https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286/third_party/WebKit/Source/modules/payments/PaymentResponse.h
[modify] https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286/third_party/WebKit/Source/modules/payments/PaymentResponse.idl
[modify] https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp
[modify] https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Cc: sanjoy....@samsung.com
Project Member Comment 56 by bugdroid1@chromium.org, Jul 6 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c42ffcad7cfef3c3737fed642cdb24f44341ddda

commit c42ffcad7cfef3c3737fed642cdb24f44341ddda
Author: sanjoy.pal <sanjoy.pal@samsung.com>
Date: Wed Jul 06 05:26:59 2016

Add test case to test that empty supported payment method identifiers throw TypeError.

BUG=587995

Review-Url: https://codereview.chromium.org/2122843002
Cr-Commit-Position: refs/heads/master@{#403854}

[modify] https://crrev.com/c42ffcad7cfef3c3737fed642cdb24f44341ddda/third_party/WebKit/LayoutTests/payments/payment-request-interface.html

Project Member Comment 57 by bugdroid1@chromium.org, Jul 7 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bd82467d47867c4c6787666eb7578026fdf92cd

commit 7bd82467d47867c4c6787666eb7578026fdf92cd
Author: sanjoy.pal <sanjoy.pal@samsung.com>
Date: Thu Jul 07 16:25:40 2016

Duplicate payment method identifiers in methodData and details.modififiers should throw TypeError.

BUG=587995

Review-Url: https://codereview.chromium.org/2117213003
Cr-Commit-Position: refs/heads/master@{#404159}

[modify] https://crrev.com/7bd82467d47867c4c6787666eb7578026fdf92cd/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/7bd82467d47867c4c6787666eb7578026fdf92cd/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Project Member Comment 58 by bugdroid1@chromium.org, Jul 8 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37cd2dda7f0314e45cc242ecc07836a3e711cb6e

commit 37cd2dda7f0314e45cc242ecc07836a3e711cb6e
Author: sanjoy.pal <sanjoy.pal@samsung.com>
Date: Fri Jul 08 16:46:15 2016

Moving assert_throws test cases under generate_tests.

BUG=587995

Review-Url: https://codereview.chromium.org/2135633002
Cr-Commit-Position: refs/heads/master@{#404412}

[modify] https://crrev.com/37cd2dda7f0314e45cc242ecc07836a3e711cb6e/third_party/WebKit/LayoutTests/payments/payment-request-interface.html

Project Member Comment 59 by bugdroid1@chromium.org, Jul 8 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8142cc7a7fe456a03d36343a4420d117b7207c1c

commit 8142cc7a7fe456a03d36343a4420d117b7207c1c
Author: sanjoy.pal <sanjoy.pal@samsung.com>
Date: Fri Jul 08 18:36:57 2016

Early return if we find selected shipping option from last.

The spec requires using the last selected shipping option.
Instead of going through the whole list of shipping options
from front to back, iterate from back to front and early
return on the first selected shipping option.

BUG=587995
TEST=None (No behavior change)

Review-Url: https://codereview.chromium.org/2131963002
Cr-Commit-Position: refs/heads/master@{#404449}

[modify] https://crrev.com/8142cc7a7fe456a03d36343a4420d117b7207c1c/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Blockedon: 627705
Blockedon: 629461
Blockedon: 629462
Project Member Comment 65 by bugdroid1@chromium.org, Jul 25 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0452d6b6cf1ba95c7449f84df149edfc639f2b7

commit c0452d6b6cf1ba95c7449f84df149edfc639f2b7
Author: sanjoy.pal <sanjoy.pal@samsung.com>
Date: Mon Jul 25 04:50:47 2016

Add test to check that the payment response details field is a JSON-serializable object.

BUG=587995

Review-Url: https://codereview.chromium.org/2171973005
Cr-Commit-Position: refs/heads/master@{#407415}

[modify] https://crrev.com/c0452d6b6cf1ba95c7449f84df149edfc639f2b7/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp

Blockedon: 632708
Blockedon: 632716
Blockedon: 648049
Blockedon: 648050
Blockedon: 648051
Blockedon: 648052
Blockedon: 648238
Blockedon: 648240
Blockedon: 652147
Blockedon: 652148
Project Member Comment 77 by bugdroid1@chromium.org, Oct 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84b683c8c0e9495462022b214b6f08922e4fd6fb

commit 84b683c8c0e9495462022b214b6f08922e4fd6fb
Author: rob.buis <rob.buis@samsung.com>
Date: Thu Oct 20 21:07:55 2016

Make PaymentOption store a Drawable instead of id

Make PaymentOption store a Drawable instead of id for the icon.
This will allow to use icons not contained in the default resources.

BUG=587995

Review-Url: https://chromiumcodereview.appspot.com/2436883002
Cr-Commit-Position: refs/heads/master@{#426596}

[modify] https://crrev.com/84b683c8c0e9495462022b214b6f08922e4fd6fb/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java
[modify] https://crrev.com/84b683c8c0e9495462022b214b6f08922e4fd6fb/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java
[modify] https://crrev.com/84b683c8c0e9495462022b214b6f08922e4fd6fb/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/84b683c8c0e9495462022b214b6f08922e4fd6fb/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
[modify] https://crrev.com/84b683c8c0e9495462022b214b6f08922e4fd6fb/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/84b683c8c0e9495462022b214b6f08922e4fd6fb/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentAppFactory.java
[modify] https://crrev.com/84b683c8c0e9495462022b214b6f08922e4fd6fb/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
[modify] https://crrev.com/84b683c8c0e9495462022b214b6f08922e4fd6fb/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/84b683c8c0e9495462022b214b6f08922e4fd6fb/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java
[modify] https://crrev.com/84b683c8c0e9495462022b214b6f08922e4fd6fb/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
[modify] https://crrev.com/84b683c8c0e9495462022b214b6f08922e4fd6fb/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Project Member Comment 78 by bugdroid1@chromium.org, Oct 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/403cce524dcb11fb72bed9f0f1ff30219b8b824f

commit 403cce524dcb11fb72bed9f0f1ff30219b8b824f
Author: dskiba <dskiba@google.com>
Date: Thu Oct 20 22:21:53 2016

Revert of Make PaymentOption store a Drawable instead of id (patchset #4 id:100001 of https://codereview.chromium.org/2436883002/ )

Reason for revert:
This broke internal class (which relied on 'icon' being int). Please coordinate with rouslan@ to push a fix right after relanding.

Original issue's description:
> Make PaymentOption store a Drawable instead of id
>
> Make PaymentOption store a Drawable instead of id for the icon.
> This will allow to use icons not contained in the default resources.
>
> BUG=587995

TBR=rouslan@chromium.org,miguelg@chromium.org,tedchoc@chromium.org,rob.buis@samsung.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=587995

Review-Url: https://chromiumcodereview.appspot.com/2437223002
Cr-Commit-Position: refs/heads/master@{#426618}

[modify] https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java
[modify] https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java
[modify] https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
[modify] https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentAppFactory.java
[modify] https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
[modify] https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java
[modify] https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
[modify] https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Project Member Comment 79 by bugdroid1@chromium.org, Oct 24
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78d60d3db799ca9a37385f8357901c154451cadc

commit 78d60d3db799ca9a37385f8357901c154451cadc
Author: rob.buis <rob.buis@samsung.com>
Date: Mon Oct 24 14:43:28 2016

Introduce method data map in getInstrument

Payments apps can support multiple methods, and each method can
have associated data, so instead of passing on method associated
data as JSON string, pass a method -> method specific data map.

This CL also renames some methods to make it clear if we are dealing
with the PaymentApp or PaymentInstrument.

BUG=587995

Review-Url: https://codereview.chromium.org/2434333005
Cr-Commit-Position: refs/heads/master@{#427068}

[modify] https://crrev.com/78d60d3db799ca9a37385f8357901c154451cadc/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/78d60d3db799ca9a37385f8357901c154451cadc/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
[modify] https://crrev.com/78d60d3db799ca9a37385f8357901c154451cadc/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java
[modify] https://crrev.com/78d60d3db799ca9a37385f8357901c154451cadc/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentAppFactory.java
[modify] https://crrev.com/78d60d3db799ca9a37385f8357901c154451cadc/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
[modify] https://crrev.com/78d60d3db799ca9a37385f8357901c154451cadc/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/78d60d3db799ca9a37385f8357901c154451cadc/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Project Member Comment 80 by bugdroid1@chromium.org, Oct 24
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/34c92badd6f49d8d867585c0551c2864bdb18fc5

commit 34c92badd6f49d8d867585c0551c2864bdb18fc5
Author: Yusuf Ozuysal <yusufo@google.com>
Date: Mon Oct 24 18:11:56 2016

Project Member Comment 81 by bugdroid1@chromium.org, Oct 28
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/d3aa0f9117936499c1d3fb05e3c18de92e7966fc

commit d3aa0f9117936499c1d3fb05e3c18de92e7966fc
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Tue Oct 25 16:04:13 2016

Project Member Comment 82 by bugdroid1@chromium.org, Nov 11
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fffa1db7f84ef85dc99c9d821e4d1cf22eeed12f

commit fffa1db7f84ef85dc99c9d821e4d1cf22eeed12f
Author: corona10 <corona10@gmail.com>
Date: Fri Nov 11 22:30:11 2016

[Web Payments] Should set stop propagation flag
in PaymentRequestUpdateEvent::updateWith.

reference from
https://w3c.github.io/browser-payment-api/#updatewith

set stop propagation flag is missing.
BUG=587995

Review-Url: https://codereview.chromium.org/2495713002
Cr-Commit-Position: refs/heads/master@{#431671}

[modify] https://crrev.com/fffa1db7f84ef85dc99c9d821e4d1cf22eeed12f/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp

Project Member Comment 83 by bugdroid1@chromium.org, Nov 28
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65814338da3efcfbcac4368a9725c6c48e8676c3

commit 65814338da3efcfbcac4368a9725c6c48e8676c3
Author: rob.buis <rob.buis@samsung.com>
Date: Mon Nov 28 20:25:59 2016

Remove superfluous closeUI call

Remove superfluous closeUI call from onDismiss, this is
already done in disconnectFromClientWithDebugMessage.

BUG=587995

Review-Url: https://codereview.chromium.org/2536783002
Cr-Commit-Position: refs/heads/master@{#434708}

[modify] https://crrev.com/65814338da3efcfbcac4368a9725c6c48e8676c3/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Blockedon: 670291
Project Member Comment 85 by bugdroid1@chromium.org, Dec 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3da0af8a1228f17aebefd2f73518654c8b2ab98

commit e3da0af8a1228f17aebefd2f73518654c8b2ab98
Author: rob.buis <rob.buis@samsung.com>
Date: Fri Dec 02 23:36:57 2016

Rename canMakeActivePayment to canMakePayment

It was decided to rename canMakeActivePayment to canMakePayment:
https://github.com/w3c/browser-payment-api/pull/316

Note that this feature is still behind a runtime flag, now
named CanMakePayment.

BUG=587995

Review-Url: https://codereview.chromium.org/2545523004
Cr-Commit-Position: refs/heads/master@{#436078}

[modify] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java
[modify] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/android/java_sources.gni
[rename] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryNoCardTest.java
[rename] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryTest.java
[rename] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryNoCardTest.java
[rename] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryTest.java
[rename] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppCanMakePaymentQueryTest.java
[modify] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[modify] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/browser/payments/payment_request_impl.h
[rename] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/test/data/android/payments/can_make_payment_query.js
[rename] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/test/data/android/payments/can_make_payment_query_bobpay.js
[rename] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/test/data/android/payments/can_make_payment_query_cc.js
[rename] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/test/data/android/payments/payment_request_can_make_payment_query_bobpay_test.html
[rename] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/test/data/android/payments/payment_request_can_make_payment_query_cc_test.html
[rename] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/chrome/test/data/android/payments/payment_request_can_make_payment_query_test.html
[modify] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/components/payments/payment_request.mojom
[modify] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/third_party/WebKit/Source/modules/BUILD.gn
[rename] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/third_party/WebKit/Source/modules/payments/CanMakePaymentTest.cpp
[modify] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/third_party/WebKit/Source/modules/payments/PaymentRequest.h
[modify] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/third_party/WebKit/Source/modules/payments/PaymentRequest.idl
[modify] https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Project Member Comment 86 by bugdroid1@chromium.org, Dec 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/013458048b4ef7d09cc2fddded677d19c4e20c2d

commit 013458048b4ef7d09cc2fddded677d19c4e20c2d
Author: rob.buis <rob.buis@samsung.com>
Date: Fri Dec 16 23:59:30 2016

Factor getCertificateChain out of ConnectionPopupInfo

This patch refactors the GetCertificateChain logic out of
connection_info_popup_android.cc so we can share it between
ConnectionInfoPopup and PaymentRequestImpl.

BUG=587995

Review-Url: https://codereview.chromium.org/2567673002
Cr-Commit-Position: refs/heads/master@{#439237}

[add] https://crrev.com/013458048b4ef7d09cc2fddded677d19c4e20c2d/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/CertificateChainHelper.java
[modify] https://crrev.com/013458048b4ef7d09cc2fddded677d19c4e20c2d/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java
[modify] https://crrev.com/013458048b4ef7d09cc2fddded677d19c4e20c2d/chrome/android/java_sources.gni
[modify] https://crrev.com/013458048b4ef7d09cc2fddded677d19c4e20c2d/chrome/browser/BUILD.gn
[modify] https://crrev.com/013458048b4ef7d09cc2fddded677d19c4e20c2d/chrome/browser/android/chrome_jni_registrar.cc
[modify] https://crrev.com/013458048b4ef7d09cc2fddded677d19c4e20c2d/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/013458048b4ef7d09cc2fddded677d19c4e20c2d/chrome/browser/ui/android/page_info/certificate_chain_helper.cc
[add] https://crrev.com/013458048b4ef7d09cc2fddded677d19c4e20c2d/chrome/browser/ui/android/page_info/certificate_chain_helper.h
[modify] https://crrev.com/013458048b4ef7d09cc2fddded677d19c4e20c2d/chrome/browser/ui/android/page_info/connection_info_popup_android.cc

Sign in to add a comment