New issue
Advanced search Search tips

Issue 587964 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2016
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 579196



Sign in to add a comment

Drop Windows XP workaround from zlib CPU detection

Project Member Reported by robert.b...@intel.com, Feb 18 2016

Issue description

When the SIMD optimisation work for zlib was implemented it was necessary to workaround the lack of InitOnceExecuteOnce() in the CPU detection code. Now that master no longer needs to support XP, InitOnceExecuteOnce() can be used directly.
 
Blocking: chromium:579196
Status: Started
Owner: robert.b...@intel.com
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18ad5f3a40ceab583961ca5dc064e01900514c57

commit 18ad5f3a40ceab583961ca5dc064e01900514c57
Author: robert.bradford <robert.bradford@intel.com>
Date: Fri Feb 26 18:30:30 2016

zlib: Remove Windows XP workaround for CPU feature detection

XP didn't have InitOnceExecuteOnce() so it was necessary to implement an
equivalent using atomic compare-and-swap. With XP support no longer necessary
the CPU feature detection code can now use InitOnceExecuteOnce() directly.

TEST=net_unittests(GZipUnitTest)
BUG= 587964 

Review URL: https://codereview.chromium.org/1711683003

Cr-Commit-Position: refs/heads/master@{#377928}

[modify] https://crrev.com/18ad5f3a40ceab583961ca5dc064e01900514c57/third_party/zlib/x86.c

Status: Fixed (was: Started)

Sign in to add a comment