New issue
Advanced search Search tips

Issue 587072 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 658646



Sign in to add a comment

Change default font for zh-hans Chrome on Windows

Reported by guizhon...@gmail.com, Feb 16 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Firefox/38.0

Example URL:
https://zh.wikipedia.org

Steps to reproduce the problem:
1. A zh-hans Chrome, set fonts to default.
2. Open the home page of Chinese Wikipedia (https://zh.wikipedia.org/), and zoom page to 125%.
3. Now you can see the difference between two columns. Left words are fuzzy and right words are clear.

What is the expected behavior?
The font-family is set to sans-serif only, so a sans-serif font should be displayed instead of current 'SimSun' (In Chinese: 宋体, a serif font). No other popular browsers set 'SimSun' as their default font.

What went wrong?
SimSun embeds bitmap characters in low-px sizes. It looks clear when font size < 18px, but otherwise very fuzzy.

It is common for people to enlarge font size on a high-resolution screen, and the default 'SimSun' font may make them uncomfortable.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? Yes SimSun is not the default font before Chrome 21

Does this work in other browsers? Yes 

Chrome version: 48  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

It seems worse when lang ∉ "zh" category, e.g. https://gan.wikipedia.org

The default font can be changed to 'Microsoft YaHei', which is provided in Vista+. At least the sans-serif font should be changed, because 'SimSun' is not sans-serif at all.
 
Labels: -Cr-Blink Cr-Blink-Fonts

Comment 2 by e...@chromium.org, Feb 16 2016

Owner: kojii@chromium.org
Status: Assigned
Would you mind taking a look at this kojii@?

Comment 3 Deleted

Just for your information, Chrome is already use MS Yahei for Simplified Chinese content when you're using non-Chinese interface. It's kinda ironic they haven't update the default font for Chinese interface itself.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5129404af72b720b8074a7277e088b001bd3c9e7

commit 5129404af72b720b8074a7277e088b001bd3c9e7
Author: kojii <kojii@chromium.org>
Date: Thu Mar 10 18:24:34 2016

Modernize Chinese system font fallback list for Windows

Following the change for Japanese in crrev.com/379189, this patch
changes Chinese system font fallback list for Windows to prefer more
modern, post-ClearType era fonts. This change improves font rendering
of generic font families and system fallback on Windows for Chinese
characters, both simplified and traditional.

Results of Win10 failures where this change affects are reviewed. All
these failures on Win10 are due to changes in fonts and rebaseline
should fix them. Their failure expectations are removed in this patch.

BUG= 579842 ,  587072 

Review URL: https://codereview.chromium.org/1754143002

Cr-Commit-Position: refs/heads/master@{#380435}

[modify] https://crrev.com/5129404af72b720b8074a7277e088b001bd3c9e7/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/5129404af72b720b8074a7277e088b001bd3c9e7/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp

Comment 6 by kojii@chromium.org, Mar 11 2016

Status: Fixed (was: Assigned)
I think another file should be changed:
src/chrome/app/resources/platform_locale_settings/locale_settings_win_zh-CN.xtb

Comment 8 by kojii@chromium.org, Mar 27 2016

Status: Assigned (was: Fixed)
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8667717dada38aae323b355a493b71f2ee322d32

commit 8667717dada38aae323b355a493b71f2ee322d32
Author: kojii <kojii@chromium.org>
Date: Sun Mar 27 18:37:14 2016

Revert of Modernize Chinese system font fallback list for Windows (patchset #3 id:40001 of https://codereview.chromium.org/1754143002/ )

Reason for revert:
Reverting due to a performance regressions.

BUG= 594268 

Original issue's description:
> Modernize Chinese system font fallback list for Windows
>
> Following the change for Japanese in crrev.com/379189, this patch
> changes Chinese system font fallback list for Windows to prefer more
> modern, post-ClearType era fonts. This change improves font rendering
> of generic font families and system fallback on Windows for Chinese
> characters, both simplified and traditional.
>
> Results of Win10 failures where this change affects are reviewed. All
> these failures on Win10 are due to changes in fonts and rebaseline
> should fix them. Their failure expectations are removed in this patch.
>
> BUG= 579842 ,  587072 
>
> Committed: https://crrev.com/5129404af72b720b8074a7277e088b001bd3c9e7
> Cr-Commit-Position: refs/heads/master@{#380435}

TBR=eae@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 579842 ,  587072 

Review URL: https://codereview.chromium.org/1839593002

Cr-Commit-Position: refs/heads/master@{#383469}

[modify] https://crrev.com/8667717dada38aae323b355a493b71f2ee322d32/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8667717dada38aae323b355a493b71f2ee322d32/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp

What about default Chinese fonts for non-Chinese interface?

It's still Microsoft YaHei, why it will not cause performance issue?
So, according to  bug 368568 , it supposed to be changed in 2014. If you look at file locale_settings_win.grd, it has been updated to Microsoft Yahei and Microsoft JhengHei for years. But the owner of that bug forgot to change file FontFallbackWin.cpp at the same time. As a result, Chinese interface users ironically are the only ones who are still stuck on "20 years old" SimSun as their default Chinese fonts. 

Same story for Japanese users, but you fixed that months ago. No idea why only Chinese users are fucked at the moment and this change somehow has performance issue here. :/


Comment 12 by kojii@chromium.org, Mar 28 2016

Apologies but I'll be on vacation for a week, and got the performance issue, so I can't look into what's really caused the performance issue for now. I'll investigate further when I'm back.

I'm not very familiar with *.grd files, but IIUC they affect the default font settings when user creates a new profile. I can try to look into that too, but it'd take time to learn and test.

Font fallback is when a glpyh does not exist in all specified fonts, including fonts in the user settings if the page has generic families (e.g., serif, sans-serif,) so they're two different settings.

Comment 13 Deleted

Yeah I knew they are different. But the point of this issue (and that old one) is exactly to "Change default font for zh-hans Chrome". AFAIK, you were seeking the wrong file (FontFallbackWin.cpp) because this bug has nothing to do with Font Fallback. It's simply that the default preference needs updating.

Check src/chrome/app/resources/platform_locale_settings/locale_settings_win_zh-CN.xtb

This file is the reason why the default setting for zh-hans Chrome is till SimSun. We need to update this. To be more specific, we need to change the sans-serif font to Microsoft Yahei.
Any update? Especially about what I said last time?

Let me repeat here: The default font settings for Simplified Chinese Chrome is stored at 

src/chrome/app/resources/platform_locale_settings/locale_settings_win_zh-CN.xtb

And that's the ONLY modification OP and me (among lots of Chinese users) asking for (also do Japanese users a favor, upate src/chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb as well).

You do NOT need to modify any font fallback logic, which is totally irrelevant to this particular problem. Not to mention it even got some performance issues.. we don't need to modify it.
In a developing 51.0 version I saw this file

src/chrome/app/resources/platform_locale_settings/locale_settings_win_zh-CN.xtb

being modified to have Microsoft Yahei in the list.

And later it was changed back to SimSun. Why?

Comment 17 by kojii@chromium.org, Oct 24 2016

Blockedon: 658646
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a4a11b1cfe0a7122fb0120672cce84e2bd78c6d

commit 0a4a11b1cfe0a7122fb0120672cce84e2bd78c6d
Author: kojii <kojii@chromium.org>
Date: Wed Nov 02 19:36:33 2016

Update the default generic font family settings for Chinese/Japanese

This patch updates the default generic font family settings for
Chinese and Japanese.

Win Japanese standard/sans-serif
Changed to Meiryo if available[1]. It was once Meiryo, but
crbug.com/506837 changed to Yu Gothic because Meiryo is not available
on non-Japanese versions of Win10.
Meiryo is preferred when available because its rendering quality is
better than Yu Gothic at this point.

Win Japanese serif
Changed to Yu Mincho if available[1].
Also added Times New Roman as fallback, since neither Yu Mincho nor MS
PMincho are available on non-Japanese versions of Win10.

Win Chinese cursive
Changed to Kaiti/DFKai-SB (SC/TC.)

Mac Chinese standard/sans-serif
Changed to PingFang SC/TC if available[1]. These fonts are available
since 10.11.

Mac Chinese cursive
Changed to Kaiti SC/TC. These are fonts available since 10.8/10.9.

[1] The first-available-font-list was added in  crbug.com/658646 

BUG= 579842 , 506837,  592199 ,  587072 ,  648256 

Review-Url: https://codereview.chromium.org/2454583002
Cr-Commit-Position: refs/heads/master@{#429366}

[modify] https://crrev.com/0a4a11b1cfe0a7122fb0120672cce84e2bd78c6d/chrome/app/resources/locale_settings_mac.grd
[modify] https://crrev.com/0a4a11b1cfe0a7122fb0120672cce84e2bd78c6d/chrome/app/resources/locale_settings_win.grd
[modify] https://crrev.com/0a4a11b1cfe0a7122fb0120672cce84e2bd78c6d/chrome/app/resources/platform_locale_settings/locale_settings_mac_zh-CN.xtb
[modify] https://crrev.com/0a4a11b1cfe0a7122fb0120672cce84e2bd78c6d/chrome/app/resources/platform_locale_settings/locale_settings_mac_zh-TW.xtb
[modify] https://crrev.com/0a4a11b1cfe0a7122fb0120672cce84e2bd78c6d/chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb
[modify] https://crrev.com/0a4a11b1cfe0a7122fb0120672cce84e2bd78c6d/chrome/app/resources/platform_locale_settings/locale_settings_win_zh-CN.xtb
[modify] https://crrev.com/0a4a11b1cfe0a7122fb0120672cce84e2bd78c6d/chrome/app/resources/platform_locale_settings/locale_settings_win_zh-TW.xtb
[modify] https://crrev.com/0a4a11b1cfe0a7122fb0120672cce84e2bd78c6d/chrome/browser/ui/prefs/prefs_tab_helper.cc
[modify] https://crrev.com/0a4a11b1cfe0a7122fb0120672cce84e2bd78c6d/chrome/common/pref_names.cc
[modify] https://crrev.com/0a4a11b1cfe0a7122fb0120672cce84e2bd78c6d/chrome/common/pref_names.h

Why doesn't it change SimSun to Microsoft YaHei?
NVM, it did, just not got mentioned in the comment.
Status: Fixed (was: Assigned)
Ah, sorry, forgot in the description.

Appreciate your tests when available in Canary.

Sign in to add a comment