New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 584969 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 579196



Sign in to add a comment

Try PSAPI_VERSION=2

Project Member Reported by yukawa@chromium.org, Feb 7 2016

Issue description

We should be able to set PSAPI_VERSION=2 globally as we no longer support Windows XP/Vista.
 
Blocking: chromium:579196
Components: Internals>PlatformIntegration
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 27 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Owner: chengx@chromium.org
Status: Assigned (was: Untriaged)
From MSDN:

"
If PSAPI_VERSION is 2 or greater, this function is defined as K32QueryWorkingSet in Psapi.h and exported in Kernel32.lib and Kernel32.dll. If PSAPI_VERSION is 1, this function is defined as QueryWorkingSet in Psapi.h and exported in Psapi.lib and Psapi.dll as a wrapper that calls K32QueryWorkingSet.
Programs that must run on earlier versions of Windows as well as Windows 7 and later versions should always call this function as QueryWorkingSet. To ensure correct resolution of symbols, add Psapi.lib to the TARGETLIBS macro and compile the program with -DPSAPI_VERSION=1. To use run-time dynamic linking, load Psapi.dll.
"

In other words, if switch to PSAPI_VERSION == 2 then we shouldn't need to load psapi.dll anymore, which seems like a win (modest memory/startup savings). Seems worth trying to see if it is trivial. Delegating!

Comment 5 by chengx@chromium.org, Apr 27 2017

I'll take a look, thanks!
Owner: davidbienvenu@chromium.org

Comment 7 by davidbienvenu@chromium.org, Dec 5 (5 days ago)

I have a POC CL that I'm doing a CQ dry run on. https://chromium-review.googlesource.com/c/chromium/src/+/1363891

The slightly tricky part is that the value of PSAPI_VERSION in build/config/win/BUILD.gn needs to match the version in third_party/crashpad/crashpad/util/win/get_module_information.h, currently.

Sign in to add a comment