New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 5 users

Issue metadata

Status: Started
Owner:
Last visit 16 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on: View detail
issue 535220
issue 672793

Blocking:
issue 425389
issue 567920



Sign in to add a comment
link

Issue 582328: Web MIDI: Mojo + Onionsoup

Reported by toyoshim@chromium.org, Jan 29 2016 Project Member

Issue description

In favor of IPC::Message being deprecated, Web MIDI would want to use Mojo for its IPC.

IPC::Message is deprecated; https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/3zK8HWY10eo

This is one of proposed oppotunitied, "Supporting Mojo clients in the Blink platform layer, also deleting lots of redundant code (and ultimately all of content/renderer and much of content/child) in the process.
"
 

Comment 1 by bugdroid1@chromium.org, Jul 7 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc

commit 15c1a1ffd1f4c620b89191209dc76ef5557dd8fc
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Jul 07 12:32:49 2016

Web MIDI: use mojom::blink::PermissionService directly to ask permission

Web MIDI asked permissions via public/web interfaces.
But now that PermissionService is available in Blink,
use the service to ask permissions.

This migration makes it possible to remove all MIDI
related public/web interfaces.

BUG=582328

Review-Url: https://codereview.chromium.org/2116763002
Cr-Commit-Position: refs/heads/master@{#404136}

[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/android_webview/javatests/src/org/chromium/android_webview/test/AwPermissionManagerTest.java
[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/content/content_renderer.gypi
[delete] https://crrev.com/fe9c3e778fcdeedaedd3dbd96d6f2b30f12fb6eb/content/renderer/media/midi_dispatcher.cc
[delete] https://crrev.com/fe9c3e778fcdeedaedd3dbd96d6f2b30f12fb6eb/content/renderer/media/midi_dispatcher.h
[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/content/renderer/render_frame_impl.h
[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/third_party/WebKit/LayoutTests/webmidi/loopback-receive.html
[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/third_party/WebKit/LayoutTests/webmidi/permission.html
[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/third_party/WebKit/LayoutTests/webmidi/send-messages.html
[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp
[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp
[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.h
[delete] https://crrev.com/fe9c3e778fcdeedaedd3dbd96d6f2b30f12fb6eb/third_party/WebKit/Source/modules/webmidi/MIDIClient.h
[delete] https://crrev.com/fe9c3e778fcdeedaedd3dbd96d6f2b30f12fb6eb/third_party/WebKit/Source/modules/webmidi/MIDIController.cpp
[delete] https://crrev.com/fe9c3e778fcdeedaedd3dbd96d6f2b30f12fb6eb/third_party/WebKit/Source/modules/webmidi/MIDIController.h
[delete] https://crrev.com/fe9c3e778fcdeedaedd3dbd96d6f2b30f12fb6eb/third_party/WebKit/Source/web/MIDIClientProxy.cpp
[delete] https://crrev.com/fe9c3e778fcdeedaedd3dbd96d6f2b30f12fb6eb/third_party/WebKit/Source/web/MIDIClientProxy.h
[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[delete] https://crrev.com/fe9c3e778fcdeedaedd3dbd96d6f2b30f12fb6eb/third_party/WebKit/Source/web/WebMIDIPermissionRequest.cpp
[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/third_party/WebKit/Source/web/web.gypi
[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/third_party/WebKit/public/blink_headers.gypi
[modify] https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc/third_party/WebKit/public/web/WebFrameClient.h
[delete] https://crrev.com/fe9c3e778fcdeedaedd3dbd96d6f2b30f12fb6eb/third_party/WebKit/public/web/modules/webmidi/OWNERS
[delete] https://crrev.com/fe9c3e778fcdeedaedd3dbd96d6f2b30f12fb6eb/third_party/WebKit/public/web/modules/webmidi/WebMIDIClient.h
[delete] https://crrev.com/fe9c3e778fcdeedaedd3dbd96d6f2b30f12fb6eb/third_party/WebKit/public/web/modules/webmidi/WebMIDIOptions.h
[delete] https://crrev.com/fe9c3e778fcdeedaedd3dbd96d6f2b30f12fb6eb/third_party/WebKit/public/web/modules/webmidi/WebMIDIPermissionRequest.h

Comment 2 by bugdroid1@chromium.org, Jul 7 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e66467f60aee961c4e216e160863932a6a484fb

commit 2e66467f60aee961c4e216e160863932a6a484fb
Author: hush <hush@chromium.org>
Date: Thu Jul 07 18:06:24 2016

Revert of Web MIDI: use mojom::blink::PermissionService directly to ask permission (patchset #7 id:120001 of https://codereview.chromium.org/2116763002/ )

Reason for revert:
This CL is suspected to break
org.chromium.webview_shell.test.WebViewLayoutTest#testRequestMIDIAccessDenyPermission
org.chromium.webview_shell.test.WebViewLayoutTest#testRequestMIDIAccess

https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Webview%20M%20%28dbg%29/builds/11186

Original issue's description:
> Web MIDI: use mojom::blink::PermissionService directly to ask permission
>
> Web MIDI asked permissions via public/web interfaces.
> But now that PermissionService is available in Blink,
> use the service to ask permissions.
>
> This migration makes it possible to remove all MIDI
> related public/web interfaces.
>
> BUG=582328
>
> Committed: https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc
> Cr-Commit-Position: refs/heads/master@{#404136}

TBR=yukishiino@chromium.org,sammc@chromium.org,kinuko@chromium.org,tkent@chromium.org,torne@chromium.org,esprehn@chromium.org,haraken@chromium.org,tobiasjs@chromium.org,toyoshim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=582328

Review-Url: https://codereview.chromium.org/2129913005
Cr-Commit-Position: refs/heads/master@{#404178}

[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/android_webview/javatests/src/org/chromium/android_webview/test/AwPermissionManagerTest.java
[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/content/content_renderer.gypi
[add] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/content/renderer/media/midi_dispatcher.cc
[add] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/content/renderer/media/midi_dispatcher.h
[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/content/renderer/render_frame_impl.h
[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/LayoutTests/webmidi/loopback-receive.html
[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/LayoutTests/webmidi/permission.html
[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/LayoutTests/webmidi/send-messages.html
[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp
[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp
[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.h
[add] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/Source/modules/webmidi/MIDIClient.h
[add] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/Source/modules/webmidi/MIDIController.cpp
[add] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/Source/modules/webmidi/MIDIController.h
[add] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/Source/web/MIDIClientProxy.cpp
[add] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/Source/web/MIDIClientProxy.h
[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[add] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/Source/web/WebMIDIPermissionRequest.cpp
[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/Source/web/web.gypi
[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/public/blink_headers.gypi
[modify] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/public/web/WebFrameClient.h
[add] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/public/web/modules/webmidi/OWNERS
[add] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/public/web/modules/webmidi/WebMIDIClient.h
[add] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/public/web/modules/webmidi/WebMIDIOptions.h
[add] https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb/third_party/WebKit/public/web/modules/webmidi/WebMIDIPermissionRequest.h

Comment 3 by bugdroid1@chromium.org, Jul 28 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/055d3a2166c34eeef2a15281fdfb0082b7994787

commit 055d3a2166c34eeef2a15281fdfb0082b7994787
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Jul 28 10:47:41 2016

Implement AwPermissionManager::RequestPermissions

This is needed to work with new Web MIDI permission requests.

BUG=582328
TEST=git cl try
TEST=run_android_webview_unittests --gtest_filter='AwPermissionManagerTest.*'
TEST=run_system_webview_shell_layout_test_apk with built SystemWebViewGoogle.apk

Review-Url: https://codereview.chromium.org/2143573002
Cr-Commit-Position: refs/heads/master@{#408371}

[modify] https://crrev.com/055d3a2166c34eeef2a15281fdfb0082b7994787/android_webview/android_webview_tests.gypi
[modify] https://crrev.com/055d3a2166c34eeef2a15281fdfb0082b7994787/android_webview/browser/aw_permission_manager.cc
[modify] https://crrev.com/055d3a2166c34eeef2a15281fdfb0082b7994787/android_webview/browser/aw_permission_manager.h
[add] https://crrev.com/055d3a2166c34eeef2a15281fdfb0082b7994787/android_webview/browser/aw_permission_manager_unittest.cc
[modify] https://crrev.com/055d3a2166c34eeef2a15281fdfb0082b7994787/android_webview/test/BUILD.gn

Comment 4 by bugdroid1@chromium.org, Jul 29 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4

commit 8c21bb977b580edb009eb2fe0d3f511fd5ca42f4
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Jul 29 12:27:04 2016

Reland: Web MIDI: use mojom::blink::PermissionService directly to ask permission

Changes from the first attempt:

- AwPermissionManager::RequestPermissions() was implemented for
  Android WebView in a separate CL.
- Workarounds to avoid touching NOTIMPLEMENTED() was removed

Original description follows:

SystemWebViewShellLayoutTest failed because of the same reason with
other modified tests in this CL. Tests are modified to pass, but now
it does not cover {sysex:true} case that needs
AwPermissionManager::RequestPermissions implementation.
It will be implemented in the next CL soon.

Original description follows:
Web MIDI asked permissions via public/web interfaces.
But now that PermissionService is available in Blink,
use the service to ask permissions.

This migration makes it possible to remove all MIDI
related public/web interfaces.

BUG=582328

Committed: https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc
Cr-Commit-Position: refs/heads/master@{#404136}

TEST=${OUT}/bin/run_system_webview_shell_layout_test_apk # with a built SystemWebViewGoogle.apk
TEST=git cl try

Review-Url: https://codereview.chromium.org/2116763002
Cr-Commit-Position: refs/heads/master@{#408621}

[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/android_webview/tools/system_webview_shell/test/data/blink-apis/webmidi/requestmidiaccess-expected.txt
[rename] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/android_webview/tools/system_webview_shell/test/data/blink-apis/webmidi/requestmidiaccess-permission-denied-expected.txt
[add] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/android_webview/tools/system_webview_shell/test/data/blink-apis/webmidi/requestmidiaccess-with-sysex-expected.txt
[add] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/android_webview/tools/system_webview_shell/test/data/blink-apis/webmidi/requestmidiaccess-with-sysex.html
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/android_webview/tools/system_webview_shell/test/data/blink-apis/webmidi/requestmidiaccess.html
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/content/content_renderer.gypi
[delete] https://crrev.com/536ea432350f23a084fcda1973619a0c6d661294/content/renderer/media/midi_dispatcher.cc
[delete] https://crrev.com/536ea432350f23a084fcda1973619a0c6d661294/content/renderer/media/midi_dispatcher.h
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/content/renderer/render_frame_impl.h
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/third_party/WebKit/LayoutTests/webmidi/loopback-receive.html
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/third_party/WebKit/LayoutTests/webmidi/permission.html
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/third_party/WebKit/LayoutTests/webmidi/send-messages.html
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.h
[delete] https://crrev.com/536ea432350f23a084fcda1973619a0c6d661294/third_party/WebKit/Source/modules/webmidi/MIDIClient.h
[delete] https://crrev.com/536ea432350f23a084fcda1973619a0c6d661294/third_party/WebKit/Source/modules/webmidi/MIDIController.cpp
[delete] https://crrev.com/536ea432350f23a084fcda1973619a0c6d661294/third_party/WebKit/Source/modules/webmidi/MIDIController.h
[delete] https://crrev.com/536ea432350f23a084fcda1973619a0c6d661294/third_party/WebKit/Source/web/MIDIClientProxy.cpp
[delete] https://crrev.com/536ea432350f23a084fcda1973619a0c6d661294/third_party/WebKit/Source/web/MIDIClientProxy.h
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[delete] https://crrev.com/536ea432350f23a084fcda1973619a0c6d661294/third_party/WebKit/Source/web/WebMIDIPermissionRequest.cpp
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/third_party/WebKit/Source/web/web.gypi
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/third_party/WebKit/public/blink_headers.gypi
[modify] https://crrev.com/8c21bb977b580edb009eb2fe0d3f511fd5ca42f4/third_party/WebKit/public/web/WebFrameClient.h
[delete] https://crrev.com/536ea432350f23a084fcda1973619a0c6d661294/third_party/WebKit/public/web/modules/webmidi/OWNERS
[delete] https://crrev.com/536ea432350f23a084fcda1973619a0c6d661294/third_party/WebKit/public/web/modules/webmidi/WebMIDIClient.h
[delete] https://crrev.com/536ea432350f23a084fcda1973619a0c6d661294/third_party/WebKit/public/web/modules/webmidi/WebMIDIOptions.h
[delete] https://crrev.com/536ea432350f23a084fcda1973619a0c6d661294/third_party/WebKit/public/web/modules/webmidi/WebMIDIPermissionRequest.h

Comment 5 by sheriffbot@chromium.org, Jul 31 2017

Project Member
Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by toyoshim@chromium.org, Aug 1 2017

Labels: -Hotlist-Recharge-Cold
Owner: toyoshim@chromium.org
Status: Assigned (was: Untriaged)

Comment 7 by toyoshim@chromium.org, Oct 16 2017

Cc: bashi@chromium.org yukishiino@chromium.org toyoshim@chromium.org
 Issue 582327  has been merged into this issue.

Comment 8 by toyoshim@chromium.org, Oct 16 2017

Blockedon: -582327
Blocking: 567920 535220 425389
import blocking list

Comment 9 by toyoshim@chromium.org, Oct 16 2017

Blockedon: 535220
Blocking: -535220
This issue is blocked by 535220 rather than blocking.

Comment 10 by toyoshim@chromium.org, Oct 16 2017

Blockedon: 672793
and 672793 is the major issue that blocks mojoficiation effort now, and I'm actively working on.

Comment 11 by toyoshim@chromium.org, Oct 16 2017

Status: Started (was: Assigned)
then let me mark this as Started since I'm already working on preparation efforts in issues that block this.

Comment 12 by bugdroid1@chromium.org, Oct 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bebaf729d115764c3d13bb61eaa55e5fa7515735

commit bebaf729d115764c3d13bb61eaa55e5fa7515735
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Wed Oct 17 15:59:40 2018

[WebMIDI] Replace midi::MidiPortInfo with midi::mojom::PortInfo

This should make mojofying MidiHost and MidiMessageFilter easier.

Bug: 582328
Change-Id: I4dfcdb990cd938a63ec99f238020bc6ba325350f
Reviewed-on: https://chromium-review.googlesource.com/c/1244601
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600407}
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/content/browser/media/midi_host.cc
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/content/browser/media/midi_host.h
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/content/browser/media/midi_host_unittest.cc
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/content/common/media/midi_messages.h
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/content/renderer/media/midi/midi_message_filter.cc
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/content/renderer/media/midi/midi_message_filter.h
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/media/midi/BUILD.gn
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/media/midi/midi_manager.cc
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/media/midi/midi_manager.h
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/media/midi/midi_manager_alsa.cc
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/media/midi/midi_manager_android.cc
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/media/midi/midi_manager_mac.cc
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/media/midi/midi_manager_mac.h
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/media/midi/midi_manager_mac_unittest.cc
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/media/midi/midi_manager_unittest.cc
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/media/midi/midi_manager_usb.cc
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/media/midi/midi_manager_usb_unittest.cc
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/media/midi/midi_manager_win.cc
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/media/midi/midi_manager_winrt.cc
[delete] https://crrev.com/b6c8da514f4b3f481a07488f709a355f9369cd3d/media/midi/midi_port_info.cc
[delete] https://crrev.com/b6c8da514f4b3f481a07488f709a355f9369cd3d/media/midi/midi_port_info.h
[modify] https://crrev.com/bebaf729d115764c3d13bb61eaa55e5fa7515735/media/midi/midi_service.mojom

Comment 13 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8ada8069dcbafe34b644de687b092bd95ef0258

commit e8ada8069dcbafe34b644de687b092bd95ef0258
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Wed Nov 28 17:17:34 2018

[WebMIDI] Mojofy and remove midi_messages.h

- Converts IPC messages in midi_messages.h to mojo interfaces
  (in midi_service.mojom)
- Updates MidiHost and MidiMessageFilter to use mojo
- Changes MidiMessageFilter to do all work on the main task runner
- Renames MidiMessageFilter to MidiClientImpl

Bug: 582328
Change-Id: I1a62af005dc31118aad0081c30b6fbd1f63068a3
Reviewed-on: https://chromium-review.googlesource.com/c/1238815
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611747}
[modify] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/content/browser/media/midi_host.cc
[modify] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/content/browser/media/midi_host.h
[modify] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/content/browser/media/midi_host_unittest.cc
[modify] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/content/common/BUILD.gn
[modify] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/content/common/content_message_generator.h
[delete] https://crrev.com/310bb6399810687c96d9ef9dce64068c7b3865c1/content/common/media/midi_messages.h
[modify] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/content/renderer/BUILD.gn
[delete] https://crrev.com/310bb6399810687c96d9ef9dce64068c7b3865c1/content/renderer/media/midi/midi_message_filter.cc
[delete] https://crrev.com/310bb6399810687c96d9ef9dce64068c7b3865c1/content/renderer/media/midi/midi_message_filter.h
[add] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/content/renderer/media/midi/midi_session_client_impl.cc
[add] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/content/renderer/media/midi/midi_session_client_impl.h
[modify] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/content/renderer/media/midi/renderer_webmidiaccessor_impl.cc
[modify] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/content/renderer/media/midi/renderer_webmidiaccessor_impl.h
[modify] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/content/renderer/render_thread_impl.h
[modify] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/media/midi/BUILD.gn
[modify] https://crrev.com/e8ada8069dcbafe34b644de687b092bd95ef0258/media/midi/midi_service.mojom

Comment 14 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/210930c9863d4493698baa012babfeb4bec20497

commit 210930c9863d4493698baa012babfeb4bec20497
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Tue Dec 11 05:28:34 2018

[WebMIDI] Remove call to RenderProcessHost::FromID

Bug: 582328
Change-Id: I733060f119871b3de35c147e6d3eb1d6c83663f1
Reviewed-on: https://chromium-review.googlesource.com/c/1366299
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615434}
[modify] https://crrev.com/210930c9863d4493698baa012babfeb4bec20497/content/browser/media/midi_host.cc

Comment 15 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21

commit 5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Fri Dec 14 16:08:09 2018

[WebMIDI] Remove content/renderer/media/midi

- Moves functionality in content::RendererWebMIDIAccessorImpl to
  blink::MIDIAccessor, and functionality in
  content::MidiSessionClientImpl to blink::MIDIDispatcher.
- Removes blink::WebMIDIAccessor and blink::WebMIDIAccessorClient.
- Replaces MockMIDIWebAccessor with a JS implementation of
  midi::mojom::MidiSessionProvider and updates tests to use it.

Bug: 582328
Change-Id: I48fccfc20d85915450a0b738ad471edba18d3a8b
Reviewed-on: https://chromium-review.googlesource.com/c/1289955
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616699}
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/BUILD.gn
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/renderer/BUILD.gn
[delete] https://crrev.com/40e35b52bf1defc6638769c2322e78063dd521dd/content/renderer/media/midi/OWNERS
[delete] https://crrev.com/40e35b52bf1defc6638769c2322e78063dd521dd/content/renderer/media/midi/midi_session_client_impl.cc
[delete] https://crrev.com/40e35b52bf1defc6638769c2322e78063dd521dd/content/renderer/media/midi/midi_session_client_impl.h
[delete] https://crrev.com/40e35b52bf1defc6638769c2322e78063dd521dd/content/renderer/media/midi/renderer_webmidiaccessor_impl.cc
[delete] https://crrev.com/40e35b52bf1defc6638769c2322e78063dd521dd/content/renderer/media/midi/renderer_webmidiaccessor_impl.h
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/renderer/render_thread_impl.h
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/shell/renderer/web_test/web_test_content_renderer_client.cc
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/shell/renderer/web_test/web_test_content_renderer_client.h
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/shell/test_runner/BUILD.gn
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/shell/test_runner/DEPS
[delete] https://crrev.com/40e35b52bf1defc6638769c2322e78063dd521dd/content/shell/test_runner/mock_web_midi_accessor.cc
[delete] https://crrev.com/40e35b52bf1defc6638769c2322e78063dd521dd/content/shell/test_runner/mock_web_midi_accessor.h
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/shell/test_runner/test_runner.h
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/shell/test_runner/web_test_interfaces.cc
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/content/shell/test_runner/web_test_interfaces.h
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/public/blink_typemaps.gni
[delete] https://crrev.com/40e35b52bf1defc6638769c2322e78063dd521dd/third_party/blink/public/platform/modules/webmidi/DEPS
[delete] https://crrev.com/40e35b52bf1defc6638769c2322e78063dd521dd/third_party/blink/public/platform/modules/webmidi/OWNERS
[delete] https://crrev.com/40e35b52bf1defc6638769c2322e78063dd521dd/third_party/blink/public/platform/modules/webmidi/web_midi_accessor.h
[delete] https://crrev.com/40e35b52bf1defc6638769c2322e78063dd521dd/third_party/blink/public/platform/modules/webmidi/web_midi_accessor_client.h
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/renderer/core/testing/internals.h
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/renderer/core/testing/internals.idl
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/renderer/modules/webmidi/BUILD.gn
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/renderer/modules/webmidi/midi_accessor.cc
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/renderer/modules/webmidi/midi_accessor.h
[add] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/renderer/modules/webmidi/midi_dispatcher.cc
[add] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/renderer/modules/webmidi/midi_dispatcher.h
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/web_tests/http/tests/webmidi/midi-default-feature-policy.https.sub.html
[add] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/web_tests/http/tests/webmidi/mock-midiservice.js
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/web_tests/webmidi/add-port.html
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/web_tests/webmidi/implicit-open.html
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/web_tests/webmidi/loopback-receive.html
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/web_tests/webmidi/loopback-with-timestamp.html
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/web_tests/webmidi/open-close.html
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/web_tests/webmidi/permission.html
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/web_tests/webmidi/requestmidiaccess-fail.html
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/web_tests/webmidi/requestmidiaccess-in-detached-frame.html
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/web_tests/webmidi/requestmidiaccess-options.html
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/web_tests/webmidi/requestmidiaccess.html
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/web_tests/webmidi/send-messages.html
[modify] https://crrev.com/5b82b2e3840d0e3f5e2fb0da70a99135df6f2e21/third_party/blink/web_tests/webmidi/send-system-messages.html

Comment 16 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ceb2f740228afb21d0ad7bfa17f4a60be7f3013a

commit ceb2f740228afb21d0ad7bfa17f4a60be7f3013a
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Mon Dec 17 10:49:22 2018

[WebMIDI] Add connection error handler for midi_client_

We check |midi_client_| before calling EndSession in the destructor of
MidiHost as it tells us if we've started a session before. |midi_client_|
could potentially be false if there was a connection error and could skip
the EndSession call.

Bug: 913270, 582328
Change-Id: Iececf880fcd61f1cc8ad65673e3dcfc9724ea5db
Reviewed-on: https://chromium-review.googlesource.com/c/1376089
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617079}
[modify] https://crrev.com/ceb2f740228afb21d0ad7bfa17f4a60be7f3013a/content/browser/media/midi_host.cc
[modify] https://crrev.com/ceb2f740228afb21d0ad7bfa17f4a60be7f3013a/content/browser/media/midi_host_unittest.cc

Comment 17 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd9eb87d56e7d318281cd6ebe4767c8dd248e236

commit dd9eb87d56e7d318281cd6ebe4767c8dd248e236
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Thu Dec 20 16:26:06 2018

[WebMIDI] Check if accessor is in array before calling erase

The accessor may be in accessors_waiting_session_queue as SessionStarted
may not have been called when the document shuts down.

Bug: 915578,  915844 , 582328
Change-Id: Ie7d864bcdaeb9dec9c3153ff1026de58d7aa8050
Reviewed-on: https://chromium-review.googlesource.com/c/1379920
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618234}
[modify] https://crrev.com/dd9eb87d56e7d318281cd6ebe4767c8dd248e236/third_party/blink/renderer/modules/webmidi/midi_dispatcher.cc

Comment 18 by bugdroid1@chromium.org, Dec 21

Project Member
Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58e7b7e03f02ab6505e74ddddd4087692431570b

commit 58e7b7e03f02ab6505e74ddddd4087692431570b
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Fri Dec 21 15:06:32 2018

[WebMIDI] Add connection error handler for midi_client_

We check |midi_client_| before calling EndSession in the destructor of
MidiHost as it tells us if we've started a session before. |midi_client_|
could potentially be false if there was a connection error and could skip
the EndSession call.

Bug: 913270, 582328
Change-Id: Iececf880fcd61f1cc8ad65673e3dcfc9724ea5db
Reviewed-on: https://chromium-review.googlesource.com/c/1376089
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617079}(cherry picked from commit ceb2f740228afb21d0ad7bfa17f4a60be7f3013a)
Reviewed-on: https://chromium-review.googlesource.com/c/1388053
Cr-Commit-Position: refs/branch-heads/3626@{#497}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/58e7b7e03f02ab6505e74ddddd4087692431570b/content/browser/media/midi_host.cc
[modify] https://crrev.com/58e7b7e03f02ab6505e74ddddd4087692431570b/content/browser/media/midi_host_unittest.cc

Comment 19 by cr-audit...@appspot.gserviceaccount.com, Dec 21

Project Member
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/58e7b7e03f02ab6505e74ddddd4087692431570b

Commit: 58e7b7e03f02ab6505e74ddddd4087692431570b
Author: adithyas@chromium.org
Commiter: adithyas@chromium.org
Date: 2018-12-21 15:06:32 +0000 UTC

[WebMIDI] Add connection error handler for midi_client_

We check |midi_client_| before calling EndSession in the destructor of
MidiHost as it tells us if we've started a session before. |midi_client_|
could potentially be false if there was a connection error and could skip
the EndSession call.

Bug: 913270, 582328
Change-Id: Iececf880fcd61f1cc8ad65673e3dcfc9724ea5db
Reviewed-on: https://chromium-review.googlesource.com/c/1376089
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617079}(cherry picked from commit ceb2f740228afb21d0ad7bfa17f4a60be7f3013a)
Reviewed-on: https://chromium-review.googlesource.com/c/1388053
Cr-Commit-Position: refs/branch-heads/3626@{#497}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 20 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f42fae614d9ca56510a072d4ed6adb6f24184d0

commit 3f42fae614d9ca56510a072d4ed6adb6f24184d0
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Fri Dec 21 20:30:14 2018

[WebMIDI] Fix flakiness in midi-default-feature-policy.html

I changed the test in an earlier CL (https://crrev.com/c/1289955) to
use MojoInterfaceInterceptor to intercept mojo requests for the
MidiSessionProvider interface at the process level. However, the
interceptor's lifetime is tied to the frame in which it's created,
leading to some issues.

Bug:  915417 , 582328
Change-Id: I71e69d76454233c12e1b1e73f06ffc7525bc48ee
Reviewed-on: https://chromium-review.googlesource.com/c/1385020
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618583}
[modify] https://crrev.com/3f42fae614d9ca56510a072d4ed6adb6f24184d0/third_party/blink/web_tests/http/tests/resources/feature-policy-permissions-test.js

Comment 21 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d12d293f7c958cd389bb29d5bd1f6f3c274a7799

commit d12d293f7c958cd389bb29d5bd1f6f3c274a7799
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Wed Dec 26 06:20:53 2018

[WebMIDI] Detach clients in MidiService::Shutdown

MidiService::Shutdown clears the |manager_| pointer but doesn't directly
destroy MidiManager. Clients cannot call EndSession and remove themselves
from the |clients_| list in MidiManager (because MidiService no longer owns
it). These clients then can be independently destroyed, leading to a use
after free when MidiManager tries to call Detach on the clients.

Bug: 915693, 913270, 582328
Change-Id: I0f713743bfd8f736c17e3ec3dd8472bd05ad7254
Reviewed-on: https://chromium-review.googlesource.com/c/1383436
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618906}
[modify] https://crrev.com/d12d293f7c958cd389bb29d5bd1f6f3c274a7799/media/midi/midi_manager.cc
[modify] https://crrev.com/d12d293f7c958cd389bb29d5bd1f6f3c274a7799/media/midi/midi_manager.h
[modify] https://crrev.com/d12d293f7c958cd389bb29d5bd1f6f3c274a7799/media/midi/midi_service.cc

Comment 22 by toyoshim@chromium.org, Dec 26

Owner: adithyas@chromium.org
Notes on progress:

Essential changes to make it use Mojo instead of Chrome IPC are submitted on m72.
Found bugs were fixed, and patches were merged to the m72 branch.

Still we are making cleanup changes on m73 to remove unnecessary layers from renderers and the browser. Probably, adithyas@ will make some more changes to finish this work.

Sign in to add a comment