New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 13 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , All
Pri: 2
Type: Bug
Team-Blink-Paint

Blocked on:
issue 703908

Blocking:
issue 674593
issue 388780


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment
link

Issue 581955: Make WebKitCSSMatrix an alias of DOMMatrix

Reported by phil...@opera.com, Jan 28 2016

Issue description

With https://github.com/whatwg/compat/issues/19 DOMMatrix was changed sufficiently that WebKitCSSMatrix can be made a simple alias of it.

Rough steps:

1. Sync DOMMatrix with https://drafts.fxtf.org/geometry/#DOMMatrix (it's not shipped, so entirely safe)
2. Remove the WebKitCSSMatrix code in favor of an alias for DOMMatrix
3. Watch for regressions, revert, and tweak the spec until it works
 

Comment 1 by foolip@chromium.org, Nov 6 2016

Summary: Make WebKitCSSMatrix an alias of DOMMatrix (was: Make WebKitCSSMatrix and alias of DOMMatrix)

Comment 2 by gog...@gmail.com, Jan 17 2017

Is anyone working on it? If not, may I look into it?

Comment 3 by dominicc@chromium.org, Jan 18 2017

Cc: hs1217....@samsung.com
Not as far as I know. jinho.bang, hs1217.lee, would you be interested in doing informal reviews for this?

Comment 4 by jinho.b...@samsung.com, Jan 18 2017

Sure, we are already talking about this on another issue[1] :)

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=388780

Comment 5 by dominicc@chromium.org, Jan 18 2017

Blocking: 388780

Comment 6 by gog...@gmail.com, Jan 19 2017

Labels: OS-Android
Owner: gog...@gmail.com
Thanks, I will start it now : )

Comment 7 by l...@chromium.org, Feb 2 2017

Status: Started (was: Available)

Comment 8 by foolip@chromium.org, Feb 7 2017

Blocking: 674593

Comment 9 by foolip@chromium.org, Mar 9 2017

Cc: foolip@chromium.org

Comment 10 by esprehn@chromium.org, Mar 22 2017

Blockedon: 703908

Comment 11 by bugdroid1@chromium.org, Mar 24 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73f22088eb2c94df42edd55abd9cf1e345e18e7c

commit 73f22088eb2c94df42edd55abd9cf1e345e18e7c
Author: gogag2 <gogag2@gmail.com>
Date: Fri Mar 24 12:25:30 2017

Move geometry interface files to geometry directory.

The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared
in a lot of modules such as dom, css and so on. Also, it is not very relevant to
 the DOM, so it is proper to create a new geometry directory and then move the
 related files to the directory.

[1/2] This Patch (Move DOMMatrix related files to geometry folder)
[2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
 alias of DOMMatrix.)

BUG= 581955 

Review-Url: https://codereview.chromium.org/2741723005
Cr-Commit-Position: refs/heads/master@{#459398}

[modify] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/dom/CompositorProxy.h
[add] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/BUILD.gn
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMMatrix.cpp
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMMatrix.h
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMMatrix.idl
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMMatrixInit.idl
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.idl
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMMatrixTest.cpp
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMPoint.cpp
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMPoint.h
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMPoint.idl
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMPointInit.idl
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMPointReadOnly.cpp
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMPointReadOnly.h
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMPointReadOnly.idl
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMQuad.cpp
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMQuad.h
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMQuad.idl
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMQuadInit.idl
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMRect.cpp
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMRect.h
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMRect.idl
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMRectInit.idl
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMRectReadOnly.cpp
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMRectReadOnly.h
[rename] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/DOMRectReadOnly.idl
[add] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/geometry/OWNERS
[modify] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
[modify] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.cpp
[modify] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/modules/shapedetection/DetectedFace.cpp
[modify] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/modules/shapedetection/DetectedText.cpp
[modify] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[modify] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp
[modify] https://crrev.com/73f22088eb2c94df42edd55abd9cf1e345e18e7c/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp

Comment 12 by bugdroid1@chromium.org, Mar 24 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3f8fd183b59f68afba5b99668cae20e7d26e330

commit a3f8fd183b59f68afba5b99668cae20e7d26e330
Author: melandory <melandory@chromium.org>
Date: Fri Mar 24 13:31:42 2017

Revert of Move geometry interface files to geometry directory. (patchset #7 id:120001 of https://codereview.chromium.org/2741723005/ )

Reason for revert:
Findit identified CL at revision 459398 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzczZjIyMDg4ZWIyYzk0ZGY0MmVkZDU1YWJkOWNmMWUzNDVlMThlN2MM

Original issue's description:
> Move geometry interface files to geometry directory.
>
> The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared
> in a lot of modules such as dom, css and so on. Also, it is not very relevant to
>  the DOM, so it is proper to create a new geometry directory and then move the
>  related files to the directory.
>
> [1/2] This Patch (Move DOMMatrix related files to geometry folder)
> [2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
>  alias of DOMMatrix.)
>
> BUG= 581955 
>
> Review-Url: https://codereview.chromium.org/2741723005
> Cr-Commit-Position: refs/heads/master@{#459398}
> Committed: https://chromium.googlesource.com/chromium/src/+/73f22088eb2c94df42edd55abd9cf1e345e18e7c

TBR=dominicc@chromium.org,foolip@chromium.org,jinho.bang@samsung.com,esprehn@chromium.org,gogag2@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 581955 

Review-Url: https://codereview.chromium.org/2770253003
Cr-Commit-Position: refs/heads/master@{#459406}

[modify] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/CompositorProxy.h
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMMatrix.cpp
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMMatrix.h
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMMatrix.idl
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMMatrixInit.idl
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMMatrixTest.cpp
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMPoint.cpp
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMPoint.h
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMPoint.idl
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMPointInit.idl
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMPointReadOnly.cpp
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMPointReadOnly.h
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMPointReadOnly.idl
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMQuad.cpp
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMQuad.h
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMQuad.idl
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMQuadInit.idl
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMRect.cpp
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMRect.h
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMRect.idl
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMRectInit.idl
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMRectReadOnly.cpp
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMRectReadOnly.h
[rename] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/dom/DOMRectReadOnly.idl
[delete] https://crrev.com/9ed6f857a700f5a9cda4513050e1f908628ade10/third_party/WebKit/Source/core/geometry/BUILD.gn
[delete] https://crrev.com/9ed6f857a700f5a9cda4513050e1f908628ade10/third_party/WebKit/Source/core/geometry/OWNERS
[modify] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
[modify] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.cpp
[modify] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/modules/shapedetection/DetectedFace.cpp
[modify] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/modules/shapedetection/DetectedText.cpp
[modify] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[modify] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp
[modify] https://crrev.com/a3f8fd183b59f68afba5b99668cae20e7d26e330/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp

Comment 13 by bugdroid1@chromium.org, Mar 25 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ceec5078d982398f334025bb4c2bb5c01d39d42c

commit ceec5078d982398f334025bb4c2bb5c01d39d42c
Author: gogag2 <gogag2@gmail.com>
Date: Sat Mar 25 01:04:36 2017

Reland "Move geometry interface files to geometry directory."

Reason for revert:
Had to change the location of generated cpp and header file for IDL dictionary
in bindings/core/v8/BUILD.gn but it didn't. So, build was broken.

Original issue number:
https://codereview.chromium.org/2741723005/

Original issue's description:
> The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared
> in a lot of modules such as dom, css and so on. Also, it is not very relevant
> to the DOM, so it is proper to create a new geometry directory and then move
> the related files to the directory.
>
> [1/2] This Patch (Move DOMMatrix related files to geometry folder)
> [2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
> alias of DOMMatrix.)

BUG= 581955 

Review-Url: https://codereview.chromium.org/2778433002
Cr-Commit-Position: refs/heads/master@{#459612}

[modify] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/dom/CompositorProxy.h
[add] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/BUILD.gn
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMMatrix.cpp
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMMatrix.h
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMMatrix.idl
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMMatrixInit.idl
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.idl
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMMatrixTest.cpp
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMPoint.cpp
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMPoint.h
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMPoint.idl
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMPointInit.idl
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMPointReadOnly.cpp
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMPointReadOnly.h
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMPointReadOnly.idl
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMQuad.cpp
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMQuad.h
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMQuad.idl
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMQuadInit.idl
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMRect.cpp
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMRect.h
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMRect.idl
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMRectInit.idl
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMRectReadOnly.cpp
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMRectReadOnly.h
[rename] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/DOMRectReadOnly.idl
[add] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/geometry/OWNERS
[modify] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
[modify] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.cpp
[modify] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/modules/shapedetection/DetectedFace.cpp
[modify] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/modules/shapedetection/DetectedText.cpp
[modify] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[modify] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp
[modify] https://crrev.com/ceec5078d982398f334025bb4c2bb5c01d39d42c/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp

Comment 14 by tkent@chromium.org, May 11 2017

Components: -Blink>DOM Blink>Geometry

Comment 15 by fs...@chromium.org, May 15 2017

Cc: fs...@chromium.org

Comment 16 by bugdroid1@chromium.org, Jun 14 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ac2b97eb15689ba196f7f88b184b3a17f13d30d

commit 0ac2b97eb15689ba196f7f88b184b3a17f13d30d
Author: gogag2 <gogag2@gmail.com>
Date: Wed Jun 14 20:06:07 2017

Make WebkitCSSMatrix an alias of DOMMatrix

DOMMatrix was changed sufficiently that WebKitCSSMatrix can be made a simple alias of it.

Intent-to-ship Link :
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/
cAiTOdSGyes/Su7dlx32EQAJ

BUG= 581955 

Review-Url: https://codereview.chromium.org/2709763004
Cr-Commit-Position: refs/heads/master@{#479481}

[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/LayoutTests/SmokeTests
[delete] https://crrev.com/690256f7a5cfb0fe8e61cf19c8e026f3ac11af88/third_party/WebKit/LayoutTests/external/wpt/css/geometry-1/DOMMatrix-stringifier-expected.txt
[delete] https://crrev.com/690256f7a5cfb0fe8e61cf19c8e026f3ac11af88/third_party/WebKit/LayoutTests/external/wpt/css/geometry-1/WebKitCSSMatrix-expected.txt
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/LayoutTests/fast/dom/Window/custom-constructors-expected.txt
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/LayoutTests/fast/dom/call-a-constructor-as-a-function-expected.txt
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/LayoutTests/transforms/3d/general/cssmatrix-3d-zoom-expected.png
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/LayoutTests/transforms/cssmatrix-2d-interface-expected.txt
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/LayoutTests/transforms/cssmatrix-2d-interface.xhtml
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/LayoutTests/transforms/cssmatrix-3d-interface-expected.txt
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/LayoutTests/transforms/cssmatrix-3d-interface.xhtml
[delete] https://crrev.com/690256f7a5cfb0fe8e61cf19c8e026f3ac11af88/third_party/WebKit/LayoutTests/transforms/cssmatrix-crash-expected.txt
[delete] https://crrev.com/690256f7a5cfb0fe8e61cf19c8e026f3ac11af88/third_party/WebKit/LayoutTests/transforms/cssmatrix-crash.html
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/Source/core/css/BUILD.gn
[delete] https://crrev.com/690256f7a5cfb0fe8e61cf19c8e026f3ac11af88/third_party/WebKit/Source/core/css/CSSMatrix.cpp
[delete] https://crrev.com/690256f7a5cfb0fe8e61cf19c8e026f3ac11af88/third_party/WebKit/Source/core/css/CSSMatrix.h
[delete] https://crrev.com/690256f7a5cfb0fe8e61cf19c8e026f3ac11af88/third_party/WebKit/Source/core/css/WebKitCSSMatrix.idl
[modify] https://crrev.com/0ac2b97eb15689ba196f7f88b184b3a17f13d30d/third_party/WebKit/Source/core/frame/Window.idl

Comment 17 by fs...@chromium.org, Jun 14 2017

Status: Fixed (was: Started)

Comment 18 by bugdroid1@chromium.org, Jun 17 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd

commit 0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd
Author: jinho.bang <jinho.bang@samsung.com>
Date: Sat Jun 17 02:57:37 2017

Revert of Make WebKitCSSMatrix an alias of DOMMatrix (patchset #16 id:300001 of https://codereview.chromium.org/2709763004/ )

Reason for revert:
The WebKitCSSMatrix is not working after this change. Becuase the GeometryInterface is not shipped yet.

Original issue's description:
> Make WebkitCSSMatrix an alias of DOMMatrix
>
> DOMMatrix was changed sufficiently that WebKitCSSMatrix can be made a simple alias of it.
>
> Intent-to-ship Link :
> https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/
> cAiTOdSGyes/Su7dlx32EQAJ
>
> BUG= 581955 
>
> Review-Url: https://codereview.chromium.org/2709763004
> Cr-Commit-Position: refs/heads/master@{#479481}
> Committed: https://chromium.googlesource.com/chromium/src/+/0ac2b97eb15689ba196f7f88b184b3a17f13d30d

TBR=fserb@chromium.org,foolip@chromium.org,simonp@opera.com,timvolodine@chromium.org,dpranke@chromium.org,gogag2@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 581955 

Review-Url: https://codereview.chromium.org/2943213002
Cr-Commit-Position: refs/heads/master@{#480276}

[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/SmokeTests
[add] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/external/wpt/css/geometry-1/DOMMatrix-stringifier-expected.txt
[add] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/external/wpt/css/geometry-1/WebKitCSSMatrix-expected.txt
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/fast/dom/Window/custom-constructors-expected.txt
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/fast/dom/call-a-constructor-as-a-function-expected.txt
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/transforms/3d/general/cssmatrix-3d-zoom-expected.png
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/transforms/cssmatrix-2d-interface-expected.txt
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/transforms/cssmatrix-2d-interface.xhtml
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/transforms/cssmatrix-3d-interface-expected.txt
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/transforms/cssmatrix-3d-interface.xhtml
[add] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/transforms/cssmatrix-crash-expected.txt
[add] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/transforms/cssmatrix-crash.html
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/Source/core/css/BUILD.gn
[add] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/Source/core/css/CSSMatrix.cpp
[add] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/Source/core/css/CSSMatrix.h
[add] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/Source/core/css/WebKitCSSMatrix.idl
[modify] https://crrev.com/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd/third_party/WebKit/Source/core/frame/Window.idl

Sign in to add a comment