New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 5 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 697817



Sign in to add a comment

Fix various base APIs to use std::unique_ptr where appropriate

Project Member Reported by dcheng@chromium.org, Jan 27 2016

Issue description

There are some ownership taking functions in //base that pass things around as raw pointers.

base::SupportsUserData::SetUserData
base::DictionaryValue::Set
base::ListValue::Append
base::ListValue::AppendIfNotPresent
base::ListValue::Insert
base::Value::DeepCopy

and probably more
 

Comment 1 by danakj@chromium.org, Jan 27 2016

Cc: thakis@chromium.org mark@chromium.org thestig@chromium.org
Do we want to create a spreadsheet of header files in base/ and mark the ones that we have audited as such?

Comment 3 by danakj@chromium.org, Jan 28 2016

Yes that is a cool idea, would you mind making one?
https://docs.google.com/spreadsheets/d/1VwQDDYcu-FAO57mww7-Z_sXyZ005buMG8GPzrclp7oQ/edit?usp=sharing - just flip the audited to Yes as you go. Add more columns for notes or whatever else as desired. Everyone on this bug can edit. Doc is otherwise publicly viewable.
I would like to help with this cleanup if that's okay.

Comment 6 by danakj@chromium.org, Feb 25 2016

Ya, please. :)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/992ba621b0417b47f1ebd1efd99183215085ed2b

commit 992ba621b0417b47f1ebd1efd99183215085ed2b
Author: dcheng <dcheng@chromium.org>
Date: Wed Apr 27 23:46:48 2016

Convert generated extension bindings to use base::Value::CreateDeepCopy

BUG=581865

Review-Url: https://codereview.chromium.org/1926933002
Cr-Commit-Position: refs/heads/master@{#390239}

[modify] https://crrev.com/992ba621b0417b47f1ebd1efd99183215085ed2b/tools/json_schema_compiler/cc_generator.py
[modify] https://crrev.com/992ba621b0417b47f1ebd1efd99183215085ed2b/tools/json_schema_compiler/util.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 28 2016

Project Member

Comment 11 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a226db909b0c5ec72eff20cc9b1ff8eed69145a8

commit a226db909b0c5ec72eff20cc9b1ff8eed69145a8
Author: dcheng <dcheng@chromium.org>
Date: Tue May 03 19:12:37 2016

Use std::unique_ptr to transfer base::Value ownership in extensions::ValueStoreChange

BUG=581865

Review-Url: https://codereview.chromium.org/1940133002
Cr-Commit-Position: refs/heads/master@{#391322}

[modify] https://crrev.com/a226db909b0c5ec72eff20cc9b1ff8eed69145a8/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
[modify] https://crrev.com/a226db909b0c5ec72eff20cc9b1ff8eed69145a8/chrome/browser/extensions/api/storage/syncable_settings_storage.cc
[modify] https://crrev.com/a226db909b0c5ec72eff20cc9b1ff8eed69145a8/chrome/browser/extensions/api/storage/syncable_settings_storage.h
[modify] https://crrev.com/a226db909b0c5ec72eff20cc9b1ff8eed69145a8/extensions/browser/value_store/leveldb_value_store.cc
[modify] https://crrev.com/a226db909b0c5ec72eff20cc9b1ff8eed69145a8/extensions/browser/value_store/testing_value_store.cc
[modify] https://crrev.com/a226db909b0c5ec72eff20cc9b1ff8eed69145a8/extensions/browser/value_store/value_store_change.cc
[modify] https://crrev.com/a226db909b0c5ec72eff20cc9b1ff8eed69145a8/extensions/browser/value_store/value_store_change.h
[modify] https://crrev.com/a226db909b0c5ec72eff20cc9b1ff8eed69145a8/extensions/browser/value_store/value_store_change_unittest.cc
[modify] https://crrev.com/a226db909b0c5ec72eff20cc9b1ff8eed69145a8/extensions/browser/value_store/value_store_unittest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, May 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b344bc2793161243e2718cc02a311143440396f

commit 3b344bc2793161243e2718cc02a311143440396f
Author: dcheng <dcheng@chromium.org>
Date: Tue May 10 02:26:09 2016

Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

BUG=581865

Review-Url: https://codereview.chromium.org/1940153002
Cr-Commit-Position: refs/heads/master@{#392521}

[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/login/saml/saml_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/device_local_account_policy_provider.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/login_profile_policy_provider.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/download/download_dir_policy_handler_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/errorpage_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/extensions/api/management/management_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/extensions/extension_management_test_util.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/extensions/policy_handlers_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/policy/javascript_policy_handler_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/policy/policy_network_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/policy/policy_prefs_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/policy/policy_startup_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/policy/profile_policy_connector_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/prefs/proxy_policy_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/search/contextual_search_policy_handler_android_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/ui/webui/options/certificate_manager_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/ui/webui/options/preferences_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/ui/webui/policy_ui_browsertest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/chrome/browser/ui/webui/policy_ui_handler.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/browser/android/policy_converter.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/browser/autofill_policy_handler_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/browser/configuration_policy_handler_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/browser/proxy_policy_handler_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/browser/url_blacklist_policy_handler_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/async_policy_provider_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/cloud/component_cloud_policy_store.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/cloud/user_cloud_policy_manager_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/configuration_policy_provider_test.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/generate_policy_source_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/policy_bundle_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/policy_loader_mac.mm
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/policy_loader_mac_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/policy_loader_win.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/policy_loader_win_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/policy_map.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/policy_map.h
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/policy_map_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/policy_service_impl.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/policy_service_impl_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/policy_statistics_collector_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/proxy_policy_provider_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/schema_map.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/schema_map_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/policy/tools/generate_policy_source.py
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/search_engines/default_search_policy_handler_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/components/sync_driver/sync_policy_handler_unittest.cc
[modify] https://crrev.com/3b344bc2793161243e2718cc02a311143440396f/remoting/host/policy_watcher.cc

Project Member

Comment 13 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85f24dacc21477945bb8fb1a769725fb7d492b5a

commit 85f24dacc21477945bb8fb1a769725fb7d492b5a
Author: dcheng <dcheng@chromium.org>
Date: Fri May 20 22:20:26 2016

Remove ExtensionFunction::SetResult(T*) overload.

Code should use the std::unique_ptr<T> version instead to clearly
indicate ownership.

BUG=581865

Review-Url: https://codereview.chromium.org/1991083002
Cr-Commit-Position: refs/heads/master@{#395180}

[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/chromeos/extensions/first_run_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/chromeos/extensions/wallpaper_api.h
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/commands/commands.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/content_settings/content_settings_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/debugger/debugger_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/dial/dial_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/extension_action/extension_action_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/file_system/file_system_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/file_system/file_system_api.h
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/font_settings/font_settings_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/gcm/gcm_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/hotword_private/hotword_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/identity/identity_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/idltest/idltest_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/module/module.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/music_manager_private/music_manager_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/notifications/notifications_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/page_capture/page_capture_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/preference/chrome_direct_setting.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/system_private/system_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/tabs/app_window_controller.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/tabs/app_window_controller.h
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/tabs/windows_event_router.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/terminal/terminal_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/top_sites/top_sites_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/browser_extension_window_controller.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/browser_extension_window_controller.h
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/extension_tab_util.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/extension_tab_util.h
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/window_controller.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/extensions/window_controller.h
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/speech/extension_api/tts_extension_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/chrome/browser/ui/panels/panel.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/alarms/alarms_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/app_window/app_window_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/bluetooth/bluetooth_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/cast_channel/cast_channel_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/guest_view/guest_view_internal_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/networking_private/networking_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/serial/serial_apitest.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/socket/socket_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/system_cpu/system_cpu_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/system_memory/system_memory_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/system_storage/system_storage_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/test/test_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/extension_function.cc
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/extension_function.h
[modify] https://crrev.com/85f24dacc21477945bb8fb1a769725fb7d492b5a/extensions/browser/guest_view/web_view/web_view_find_helper.cc

Project Member

Comment 14 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb60e7032d871c4f6a7d03de41c8a81b9c234089

commit cb60e7032d871c4f6a7d03de41c8a81b9c234089
Author: dcheng <dcheng@chromium.org>
Date: Wed May 25 18:30:47 2016

Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
R=brettw@chromium.org,danakj@chromium.org
TBR=kenrb@chromium.org,stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2000803003
Cr-Commit-Position: refs/heads/master@{#395938}

[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/base/json/json_writer.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/base/trace_event/trace_event_argument.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/base/trace_event/trace_event_memory_overhead.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/base/values.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/base/values.h
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/cc/test/layer_tree_json_parser.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/banners/app_banner_settings_helper.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/chromeos/arc/arc_policy_bridge.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/chromeos/platform_keys/key_permissions.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/extensions/api/content_settings/content_settings_store.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/extensions/api/gcd_private/gcd_private_api.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/extensions/api/gcd_private/privet_v3_session.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/extensions/api/identity/identity_apitest.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/extensions/extension_override_apitest.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/extensions/extension_web_ui.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/interests/interests_fetcher.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/metrics/plugin_metrics_provider.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/permissions/chooser_context_base.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/plugins/plugin_prefs.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/policy/managed_bookmarks_policy_handler.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/spellchecker/spellcheck_service.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/supervised_user/supervised_user_site_list.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/ui/webui/options/certificate_manager_handler.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/ui/webui/settings/certificates_handler.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/common/extensions/manifest_handlers/linked_app_icons.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/service/cloud_print/printer_job_queue_handler.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/test/chromedriver/performance_logger.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chrome/utility/importer/nss_decryptor.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chromecast/crash/linux/crash_testing_utils.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chromecast/crash/linux/synchronized_minidump_manager.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chromeos/network/network_util.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chromeos/network/onc/onc_mapper.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chromeos/network/onc/onc_utils.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chromeos/network/onc/onc_validator.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chromeos/network/prohibited_technologies_handler.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chromeos/network/shill_property_handler.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/chromeos/system/statistics_provider.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/components/arc/net/arc_net_host_impl.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/components/ntp_snippets/ntp_snippet.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/components/ntp_snippets/ntp_snippets_service.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/components/policy/core/common/mac_util_unittest.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/components/policy/core/common/policy_loader_mac_unittest.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/components/policy/core/common/policy_test_utils.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/components/policy/core/common/policy_test_utils.h
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/components/signin/core/browser/account_tracker_service.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/components/update_client/component_patcher.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/components/update_client/component_patcher.h
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/components/url_matcher/url_matcher_factory.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/content/browser/android/java/gin_java_method_invocation_helper.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/content/browser/android/java/gin_java_method_invocation_helper.h
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/content/browser/media/webrtc/webrtc_internals.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/content/public/child/v8_value_converter.h
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/dbus/values_util.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/extensions/browser/api/device_permissions_manager.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/extensions/browser/api/networking_private/networking_private_chromeos.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/extensions/browser/api/system_network/system_network_apitest.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/extensions/browser/verified_contents.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/extensions/common/extension_api.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/extensions/common/features/base_feature_provider.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/extensions/common/manifest_handlers/kiosk_mode_info.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/ios/chrome/browser/ui/webui/history/browsing_history_handler.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/ipc/ipc_message_utils.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/net/http/http_server_properties_manager.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/remoting/protocol/http_ice_config_request.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/remoting/test/host_info.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/remoting/test/host_list_fetcher.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/services/catalog/entry.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/services/catalog/instance.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/sync/test/fake_server/fake_server_verifier.cc
[modify] https://crrev.com/cb60e7032d871c4f6a7d03de41c8a81b9c234089/tools/json_schema_compiler/util.h

Project Member

Comment 15 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0232f57400b65505a27db30b1de5e918bf2481b1

commit 0232f57400b65505a27db30b1de5e918bf2481b1
Author: dcheng <dcheng@chromium.org>
Date: Fri May 27 17:47:44 2016

Use std::unique_ptr<base::Value> in V8ValueConverter.

More ownership with less comments!

BUG=581865

Review-Url: https://codereview.chromium.org/2014323002
Cr-Commit-Position: refs/heads/master@{#396504}

[modify] https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1/android_webview/renderer/aw_message_port_client.cc
[modify] https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1/chrome/renderer/extensions/cast_streaming_native_handler.cc
[modify] https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1/content/child/v8_value_converter_impl.cc
[modify] https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1/content/child/v8_value_converter_impl.h
[modify] https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1/content/child/v8_value_converter_impl_unittest.cc
[modify] https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1/content/public/child/v8_value_converter.h
[modify] https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1/content/renderer/dom_automation_controller.cc
[modify] https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1/content/renderer/gpu/gpu_benchmarking_extension.cc
[modify] https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1/content/renderer/java/gin_java_bridge_value_converter.cc
[modify] https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1/content/renderer/java/gin_java_bridge_value_converter.h
[modify] https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1/content/renderer/web_ui_extension.cc
[modify] https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1/extensions/renderer/activity_log_converter_strategy.cc
[modify] https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1/extensions/renderer/activity_log_converter_strategy.h
[modify] https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1/extensions/renderer/script_injection.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a01060d89daad34fa1cd8a20a0e4fdb48976a79

commit 5a01060d89daad34fa1cd8a20a0e4fdb48976a79
Author: dcheng <dcheng@chromium.org>
Date: Thu Jun 02 00:15:20 2016

ExtensionFunction: don't pass ownership of base::Value by raw pointer.

BUG=581865
R=rockot@chromium.org
TBR=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2025103003
Cr-Commit-Position: refs/heads/master@{#397284}

[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/chromeos/extensions/input_method_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.h
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/extensions/api/identity/identity_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/extensions/api/instance_id/instance_id_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/extensions/api/settings_private/settings_private_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/extensions/browser/api/hid/hid_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/extensions/browser/api/idle/idle_manager.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/extensions/browser/api/idle/idle_manager.h
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/extensions/browser/api/management/management_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/extensions/browser/api/runtime/runtime_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/extensions/browser/api/storage/storage_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/extensions/browser/api/usb/usb_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/extensions/browser/api/vpn_provider/vpn_provider_api.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/extensions/browser/extension_function.cc
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/extensions/browser/extension_function.h
[modify] https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79/extensions/shell/browser/api/identity/identity_api.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 2 2016

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34661418ac5f137f1dcb72194e76c117308b6c7f

commit 34661418ac5f137f1dcb72194e76c117308b6c7f
Author: dcheng <dcheng@chromium.org>
Date: Thu Jun 02 22:38:26 2016

Revert of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (patchset #1 id:1 of https://codereview.chromium.org/2025103003/ )

Reason for revert:
Speculatively reverting to fix release-blocking crash.

Original issue's description:
> ExtensionFunction: don't pass ownership of base::Value by raw pointer.
>
> BUG=581865
> R=rockot@chromium.org
> TBR=rdevlin.cronin@chromium.org
>
> Committed: https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79
> Cr-Commit-Position: refs/heads/master@{#397284}

TBR=rdevlin.cronin@chromium.org,rockot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581865

Review-Url: https://codereview.chromium.org/2038613003
Cr-Commit-Position: refs/heads/master@{#397533}

[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/chromeos/extensions/input_method_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.h
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/extensions/api/identity/identity_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/extensions/api/instance_id/instance_id_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/extensions/api/settings_private/settings_private_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/extensions/browser/api/hid/hid_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/extensions/browser/api/idle/idle_manager.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/extensions/browser/api/idle/idle_manager.h
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/extensions/browser/api/management/management_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/extensions/browser/api/runtime/runtime_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/extensions/browser/api/storage/storage_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/extensions/browser/api/usb/usb_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/extensions/browser/api/vpn_provider/vpn_provider_api.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/extensions/browser/extension_function.cc
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/extensions/browser/extension_function.h
[modify] https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f/extensions/shell/browser/api/identity/identity_api.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3646638f8a49a9cdd4bcecfb9e02b0be8edd260a

commit 3646638f8a49a9cdd4bcecfb9e02b0be8edd260a
Author: dcheng <dcheng@chromium.org>
Date: Fri Jun 03 00:57:47 2016

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //tools

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865

Review-Url: https://codereview.chromium.org/2036013002
Cr-Commit-Position: refs/heads/master@{#397571}

[modify] https://crrev.com/3646638f8a49a9cdd4bcecfb9e02b0be8edd260a/tools/json_schema_compiler/test/additional_properties_unittest.cc
[modify] https://crrev.com/3646638f8a49a9cdd4bcecfb9e02b0be8edd260a/tools/json_schema_compiler/test/arrays_unittest.cc
[modify] https://crrev.com/3646638f8a49a9cdd4bcecfb9e02b0be8edd260a/tools/json_schema_compiler/test/callbacks_unittest.cc
[modify] https://crrev.com/3646638f8a49a9cdd4bcecfb9e02b0be8edd260a/tools/json_schema_compiler/test/choices_unittest.cc
[modify] https://crrev.com/3646638f8a49a9cdd4bcecfb9e02b0be8edd260a/tools/json_schema_compiler/test/enums_unittest.cc
[modify] https://crrev.com/3646638f8a49a9cdd4bcecfb9e02b0be8edd260a/tools/json_schema_compiler/test/functions_on_types_unittest.cc
[modify] https://crrev.com/3646638f8a49a9cdd4bcecfb9e02b0be8edd260a/tools/json_schema_compiler/test/idl_schemas_unittest.cc
[modify] https://crrev.com/3646638f8a49a9cdd4bcecfb9e02b0be8edd260a/tools/json_schema_compiler/test/objects_unittest.cc
[modify] https://crrev.com/3646638f8a49a9cdd4bcecfb9e02b0be8edd260a/tools/json_schema_compiler/test/simple_api_unittest.cc
[modify] https://crrev.com/3646638f8a49a9cdd4bcecfb9e02b0be8edd260a/tools/json_schema_compiler/util.cc

Project Member

Comment 22 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9ea6386f5238349f13baa3e3f48d7c6f115e715

commit d9ea6386f5238349f13baa3e3f48d7c6f115e715
Author: dcheng <dcheng@chromium.org>
Date: Fri Jun 03 02:27:18 2016

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865

Review-Url: https://codereview.chromium.org/2030013003
Cr-Commit-Position: refs/heads/master@{#397580}

[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/background/background_application_list_model_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/download/download_query_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/bluetooth_low_energy/utils.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/cookies/cookies_helpers.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/extension_action/extension_action_api.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/idltest/idltest_api.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/notifications/notifications_api.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/proxy/proxy_api_helpers.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/storage/settings_sync_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/tabs/tabs_event_router.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/tabs/windows_event_router.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/convert_user_script.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/extension_keybinding_registry.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/extension_management_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/extension_prefs_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/extension_special_storage_policy_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/menu_manager_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/policy_handlers.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/policy_handlers_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/extensions/webstore_inline_installer_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/media_galleries/media_galleries_test_util.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/net/predictor.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/net/predictor_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/notifications/notifier_state_tracker.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/speech/extension_api/tts_extension_api.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/tracing/chrome_tracing_delegate.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/invalidations_message_handler.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/options/certificate_manager_handler.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/options/core_options_handler.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/options/font_settings_handler.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/options/handler_options_handler.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/options/language_options_handler_common.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/options/options_browsertest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/options/preferences_browsertest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/options/supervised_user_import_handler.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/policy_ui_browsertest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/settings/font_handler.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/settings/people_handler_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/sync_internals_message_handler.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/common/extensions/api/common_extension_api_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/common/extensions/permissions/permission_set_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/renderer/chrome_content_renderer_client_unittest.cc
[modify] https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715/chrome/test/chromedriver/window_commands.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33f3dc9fd20d067f768c76b215441d0a19793486

commit 33f3dc9fd20d067f768c76b215441d0a19793486
Author: dcheng <dcheng@chromium.org>
Date: Fri Jun 03 02:38:23 2016

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //content

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865

Review-Url: https://codereview.chromium.org/2036893002
Cr-Commit-Position: refs/heads/master@{#397591}

[modify] https://crrev.com/33f3dc9fd20d067f768c76b215441d0a19793486/content/browser/webui/web_ui_message_handler_unittest.cc
[modify] https://crrev.com/33f3dc9fd20d067f768c76b215441d0a19793486/content/child/v8_value_converter_impl_unittest.cc
[modify] https://crrev.com/33f3dc9fd20d067f768c76b215441d0a19793486/content/common/font_list_pango.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73391a46a77dcafa1fb8b555542f4defeb7e9ed4

commit 73391a46a77dcafa1fb8b555542f4defeb7e9ed4
Author: dcheng <dcheng@chromium.org>
Date: Fri Jun 03 02:50:06 2016

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //gpu

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2036723003
Cr-Commit-Position: refs/heads/master@{#397604}

[modify] https://crrev.com/73391a46a77dcafa1fb8b555542f4defeb7e9ed4/gpu/config/gpu_control_list.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e86de2ad8d6e9159cf630570b90b079ef1aa64a

commit 3e86de2ad8d6e9159cf630570b90b079ef1aa64a
Author: dcheng <dcheng@chromium.org>
Date: Fri Jun 03 04:03:10 2016

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //ipc

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865

Review-Url: https://codereview.chromium.org/2036003002
Cr-Commit-Position: refs/heads/master@{#397622}

[modify] https://crrev.com/3e86de2ad8d6e9159cf630570b90b079ef1aa64a/ipc/ipc_message_utils_unittest.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a5b7518624811dc26a64242b8dcbdf5a8e3632f

commit 3a5b7518624811dc26a64242b8dcbdf5a8e3632f
Author: dcheng <dcheng@chromium.org>
Date: Fri Jun 03 04:21:20 2016

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //sync

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865

Review-Url: https://codereview.chromium.org/2034503003
Cr-Commit-Position: refs/heads/master@{#397627}

[modify] https://crrev.com/3a5b7518624811dc26a64242b8dcbdf5a8e3632f/sync/internal_api/js_sync_encryption_handler_observer_unittest.cc
[modify] https://crrev.com/3a5b7518624811dc26a64242b8dcbdf5a8e3632f/sync/test/fake_server/fake_server.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04f99a508817eeb89143a841c1d0ba1c2daf674c

commit 04f99a508817eeb89143a841c1d0ba1c2daf674c
Author: dcheng <dcheng@chromium.org>
Date: Fri Jun 03 17:38:20 2016

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865

Review-Url: https://codereview.chromium.org/2037703004
Cr-Commit-Position: refs/heads/master@{#397746}

[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/browser/api/management/management_api.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/browser/api/storage/settings_test_util.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/browser/api/storage/storage_frontend.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/browser/api/web_request/upload_data_presenter.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/browser/api/web_request/upload_data_presenter_unittest.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/browser/api/web_request/web_request_api_helpers.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/browser/event_router.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/browser/extension_prefs.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/browser/quota_service_unittest.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/common/extension_set_unittest.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/common/features/simple_feature_unittest.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/common/file_util_unittest.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/common/manifest_handlers/oauth2_manifest_unittest.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/common/permissions/api_permission_set_unittest.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/common/value_builder.cc
[modify] https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c/extensions/renderer/dom_activity_logger.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58241a814b2134be24c06ad0f8791cb038dc26f0

commit 58241a814b2134be24c06ad0f8791cb038dc26f0
Author: dcheng <dcheng@chromium.org>
Date: Fri Jun 03 18:18:42 2016

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865

Review-Url: https://codereview.chromium.org/2030833003
Cr-Commit-Position: refs/heads/master@{#397758}

[modify] https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0/components/flags_ui/flags_state.cc
[modify] https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0/components/flags_ui/pref_service_flags_storage.cc
[modify] https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0/components/json_schema/json_schema_validator_unittest_base.cc
[modify] https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
[modify] https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0/components/policy/core/common/schema_unittest.cc
[modify] https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0/components/prefs/pref_service_unittest.cc
[modify] https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0/components/search_engines/default_search_pref_test_util.cc
[modify] https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0/components/ssl_config/ssl_config_service_manager_pref_unittest.cc
[modify] https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0/components/syncable_prefs/pref_model_associator_unittest.cc
[modify] https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0/components/syncable_prefs/pref_service_syncable_unittest.cc
[modify] https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0/components/url_matcher/url_matcher_factory_unittest.cc
[modify] https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0/components/version_ui/version_handler_helper.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfec07b7ec31636c9c160434d203ec40899e7f02

commit dfec07b7ec31636c9c160434d203ec40899e7f02
Author: dcheng <dcheng@chromium.org>
Date: Fri Jun 03 20:26:06 2016

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //net

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865

Review-Url: https://codereview.chromium.org/2037933002
Cr-Commit-Position: refs/heads/master@{#397793}

[modify] https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02/net/base/address_list.cc
[modify] https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02/net/cert/x509_certificate_net_log_param.cc
[modify] https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02/net/dns/dns_config_service.cc
[modify] https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02/net/http/http_request_headers.cc
[modify] https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02/net/http/http_response_headers.cc
[modify] https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02/net/http/http_server_properties_impl.cc
[modify] https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02/net/http/transport_security_persister.cc
[modify] https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02/net/proxy/proxy_config.cc
[modify] https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02/net/proxy/proxy_service.cc
[modify] https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02/net/quic/quic_chromium_client_session.cc
[modify] https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02/net/quic/quic_connection_logger.cc
[modify] https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02/net/socket/client_socket_pool_base.cc
[modify] https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02/net/spdy/spdy_session.cc
[modify] https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02/net/test/spawned_test_server/base_test_server.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca2f5499338a33ed2ffd724f3e1143b9add482bd

commit ca2f5499338a33ed2ffd724f3e1143b9add482bd
Author: dcheng <dcheng@chromium.org>
Date: Fri Jun 03 21:19:35 2016

Reland of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (patchset #1 id:1 of https://codereview.chromium.org/2038613003/ )

Reason for revert:
As expected, didn't stop the crashes =)

Original issue's description:
> Revert of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (patchset #1 id:1 of https://codereview.chromium.org/2025103003/ )
>
> Reason for revert:
> Speculatively reverting to fix release-blocking crash.
>
> Original issue's description:
> > ExtensionFunction: don't pass ownership of base::Value by raw pointer.
> >
> > BUG=581865
> > R=rockot@chromium.org
> > TBR=rdevlin.cronin@chromium.org
> >
> > Committed: https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79
> > Cr-Commit-Position: refs/heads/master@{#397284}
>
> TBR=rdevlin.cronin@chromium.org,rockot@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=581865
>
> Committed: https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f
> Cr-Commit-Position: refs/heads/master@{#397533}

TBR=rdevlin.cronin@chromium.org,rockot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581865

Review-Url: https://codereview.chromium.org/2038083004
Cr-Commit-Position: refs/heads/master@{#397802}

[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/chromeos/extensions/input_method_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.h
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/extensions/api/identity/identity_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/extensions/api/instance_id/instance_id_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/extensions/api/settings_private/settings_private_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/extensions/browser/api/hid/hid_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/extensions/browser/api/idle/idle_manager.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/extensions/browser/api/idle/idle_manager.h
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/extensions/browser/api/management/management_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/extensions/browser/api/runtime/runtime_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/extensions/browser/api/storage/storage_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/extensions/browser/api/usb/usb_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/extensions/browser/api/vpn_provider/vpn_provider_api.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/extensions/browser/extension_function.cc
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/extensions/browser/extension_function.h
[modify] https://crrev.com/ca2f5499338a33ed2ffd724f3e1143b9add482bd/extensions/shell/browser/api/identity/identity_api.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Jun 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/930694e095e2f25add4d39d5478a952b481332a3

commit 930694e095e2f25add4d39d5478a952b481332a3
Author: dcheng <dcheng@chromium.org>
Date: Sat Jun 04 00:41:39 2016

Remove ListValue::Append(new {Fundamental,String}Value(...)) usage in //chrome (part 2)

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

This wasn't included in the original CL because the clang tool got
confused when processing this file. It turns out true and false can be
macros!

BUG=581865

Review-Url: https://codereview.chromium.org/2041513002
Cr-Commit-Position: refs/heads/master@{#397858}

[modify] https://crrev.com/930694e095e2f25add4d39d5478a952b481332a3/chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f046e8566d5fc9b8ad8f1e1bed20422bbab36e3

commit 4f046e8566d5fc9b8ad8f1e1bed20422bbab36e3
Author: dcheng <dcheng@chromium.org>
Date: Tue Jun 07 05:05:14 2016

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //dbus

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865

Review-Url: https://codereview.chromium.org/2037833003
Cr-Commit-Position: refs/heads/master@{#398228}

[modify] https://crrev.com/4f046e8566d5fc9b8ad8f1e1bed20422bbab36e3/dbus/values_util_unittest.cc

Project Member

Comment 34 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d09049ddefb1e992be88f3137a54362e9ea5408

commit 5d09049ddefb1e992be88f3137a54362e9ea5408
Author: dcheng <dcheng@chromium.org>
Date: Thu Jun 09 17:53:34 2016

base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

BUG=581865
R=thakis@chromium.org
TBR=jochen@chromium.org,junov@chromium.org,rdevlin.cronin@chromium.org,rogerta@chromium.org,sky@chromium.org,xhwang@chromium.org,wez@chromium.org,zea@chromium.org

Review-Url: https://codereview.chromium.org/2051663003
Cr-Commit-Position: refs/heads/master@{#398941}

[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/ash/touch/touch_hud_debug.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/base/trace_event/trace_event_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/bookmarks/managed_bookmark_service_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/copresence/copresence_api_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/extension_action/extension_action_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/identity/identity_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/management/management_api_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/settings_private/settings_private_delegate.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/tabs/tabs_event_router.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/extension_tab_util.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/menu_manager.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/permission_messages_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/permissions_updater.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/metrics/plugin_metrics_provider_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/signin/easy_unlock_app_manager.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/speech/extension_api/tts_engine_extension_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/spellchecker/feedback_sender.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/supervised_user/supervised_user_bookmarks_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/sync_file_system/drive_backend/metadata_database.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/task_profiler/task_profiler_data_serializer.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/tabs/pinned_tab_codec.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/cookies_tree_model_util.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/copresence_ui_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/foreign_session_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/invalidations_message_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/options/autofill_options_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/options/core_options_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/options/password_manager_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/test/chromedriver/chrome/log.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/test/chromedriver/commands.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/test/chromedriver/element_util.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/test/chromedriver/logging.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/browser_sync/browser/profile_sync_service.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/dom_distiller/webui/dom_distiller_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/domain_reliability/context_manager.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/domain_reliability/scheduler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/drive/service/fake_drive_service.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/invalidation/impl/invalidator_storage.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/invalidation/impl/unacked_invalidation_set.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/invalidation/impl/unacked_invalidation_set_test_util.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/invalidation/public/object_id_invalidation_map.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/invalidation/public/single_object_invalidation_set.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/policy/core/browser/configuration_policy_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/proximity_auth/webui/proximity_auth_webui_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/signin/core/browser/about_signin_internals.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/content/renderer/devtools/v8_sampling_profiler_browsertest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/alarms/alarm_manager.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/app_runtime/app_runtime_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/bluetooth/bluetooth_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/declarative/rules_registry.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/device_permissions_manager.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/hid/hid_device_manager.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/networking_private/networking_private_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/printer_provider/printer_provider_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/storage/settings_test_util.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/system_info/system_info_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/event_listener_map_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/common/event_filter_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/common/permissions/set_disjunction_permission.h
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/renderer/dom_activity_logger.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/google_apis/drive/drive_api_requests.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/media/cast/logging/stats_event_subscriber.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/media/cdm/json_web_key.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/remoting/host/pairing_registry_delegate_linux.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/remoting/protocol/pairing_registry.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/remoting/protocol/protocol_mock_objects.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/skia/ext/benchmarking_canvas.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/sync/syncable/directory.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/tools/json_schema_compiler/test/arrays_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/tools/json_schema_compiler/test/choices_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/tools/json_schema_compiler/test/crossref_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/tools/json_schema_compiler/test/enums_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/tools/json_schema_compiler/test/functions_on_types_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/tools/json_schema_compiler/test/idl_schemas_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/tools/json_schema_compiler/test/objects_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/ui/events/latency_info.cc

Project Member

Comment 36 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ad61d2a7998735245a7f86d8b21def472453d40

commit 4ad61d2a7998735245a7f86d8b21def472453d40
Author: dcheng <dcheng@chromium.org>
Date: Fri Jun 10 23:43:17 2016

value_cleanup: Rewrite more base::ListValue::Append(base::Value*) calls.

The tool now understands how to rewrite simple cases of constructing a
new base::Value that's stored in a raw pointer, manipulating it to
populate the data, and then passing ownership into base::ListValue with
the raw pointer overload of base::ListValue::Append.

BUG=581865

Review-Url: https://codereview.chromium.org/2056153003
Cr-Commit-Position: refs/heads/master@{#399319}

[modify] https://crrev.com/4ad61d2a7998735245a7f86d8b21def472453d40/tools/clang/value_cleanup/ListValueRewriter.cpp
[modify] https://crrev.com/4ad61d2a7998735245a7f86d8b21def472453d40/tools/clang/value_cleanup/ListValueRewriter.h
[modify] https://crrev.com/4ad61d2a7998735245a7f86d8b21def472453d40/tools/clang/value_cleanup/tests/list-value-append-expected.cc
[modify] https://crrev.com/4ad61d2a7998735245a7f86d8b21def472453d40/tools/clang/value_cleanup/tests/list-value-append-original.cc

Project Member

Comment 37 by bugdroid1@chromium.org, Jun 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98e96a7390e63333cd5e1a5128ef17e489cbfbb4

commit 98e96a7390e63333cd5e1a5128ef17e489cbfbb4
Author: dcheng <dcheng@chromium.org>
Date: Sat Jun 11 03:41:48 2016

Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=eroman@chromium.org,hashimoto@chromium.org,jochen@chromium.org,piman@chromium.org,rdevlin.cronin@chromium.org,rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2058233002
Cr-Commit-Position: refs/heads/master@{#399362}

[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/base/test/gtest_util.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/devtools/devtools_targets_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/content_settings/content_settings_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/content_settings/content_settings_store.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/cookies/cookies_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/file_system/file_system_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/font_settings/font_settings_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/proxy/proxy_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/tabs/tabs_event_router.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/top_sites/top_sites_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/convert_user_script.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/convert_web_app.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/extension_messages_apitest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/media_galleries/media_galleries_preferences.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/media_galleries/media_galleries_test_util.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/metrics/plugin_metrics_provider.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/net/predictor.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/net/referrer.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/plugins/plugin_prefs.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/prerender/prerender_history.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/profile_resetter/resettable_settings_snapshot.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/speech/extension_api/tts_extension_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/supervised_user/experimental/supervised_user_async_url_checker_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/sync_file_system/drive_backend/metadata_database.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/certificate_viewer_webui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/components_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/cookies_tree_model_util.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/flash_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/instant_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/nacl_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/certificate_manager_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/font_settings_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/handler_options_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/import_data_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/language_options_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/media_devices_selection_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/options_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/startup_pages_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/supervised_user_import_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/predictors/predictors_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/settings/certificates_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/system_info_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/crash/core/browser/crashes_ui_util.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/error_page/common/localized_error.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/error_page/renderer/net_error_helper_core.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/flags_ui/flags_state.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/policy/core/common/configuration_policy_provider_test.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/policy/core/common/schema_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/search_engines/template_url_prepopulate_data_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/signin/core/browser/about_signin_internals.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/sync_driver/about_sync_util.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/url_matcher/url_matcher_factory_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/content/browser/geolocation/network_location_provider_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/content/browser/media/media_internals.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/content/browser/net/network_errors_listing_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/content/browser/service_worker/service_worker_internals_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/content/common/font_list_pango.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/dbus/values_util_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/extensions/browser/api/serial/serial_apitest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/extensions/browser/api/web_request/upload_data_presenter.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/extensions/browser/extension_prefs.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/google_apis/drive/drive_api_requests.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/gpu/config/gpu_control_list.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/net/http/http_server_properties_manager.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/net/http/http_server_properties_manager_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/net/log/net_log_util.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/net/quic/quic_connection_logger.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/pdf/pdfium/pdfium_page.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/tools/json_schema_compiler/test/additional_properties_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/tools/json_schema_compiler/test/arrays_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/tools/json_schema_compiler/test/callbacks_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/tools/json_schema_compiler/test/idl_schemas_unittest.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d09049ddefb1e992be88f3137a54362e9ea5408

commit 5d09049ddefb1e992be88f3137a54362e9ea5408
Author: dcheng <dcheng@chromium.org>
Date: Thu Jun 09 17:53:34 2016

base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

BUG=581865
R=thakis@chromium.org
TBR=jochen@chromium.org,junov@chromium.org,rdevlin.cronin@chromium.org,rogerta@chromium.org,sky@chromium.org,xhwang@chromium.org,wez@chromium.org,zea@chromium.org

Review-Url: https://codereview.chromium.org/2051663003
Cr-Commit-Position: refs/heads/master@{#398941}

[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/ash/touch/touch_hud_debug.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/base/trace_event/trace_event_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/bookmarks/managed_bookmark_service_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/copresence/copresence_api_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/extension_action/extension_action_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/identity/identity_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/management/management_api_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/settings_private/settings_private_delegate.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/api/tabs/tabs_event_router.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/extension_tab_util.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/menu_manager.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/permission_messages_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/extensions/permissions_updater.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/metrics/plugin_metrics_provider_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/signin/easy_unlock_app_manager.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/speech/extension_api/tts_engine_extension_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/spellchecker/feedback_sender.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/supervised_user/supervised_user_bookmarks_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/sync_file_system/drive_backend/metadata_database.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/task_profiler/task_profiler_data_serializer.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/tabs/pinned_tab_codec.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/cookies_tree_model_util.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/copresence_ui_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/foreign_session_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/invalidations_message_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/options/autofill_options_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/options/core_options_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/options/password_manager_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/test/chromedriver/chrome/log.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/test/chromedriver/commands.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/test/chromedriver/element_util.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/chrome/test/chromedriver/logging.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/browser_sync/browser/profile_sync_service.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/dom_distiller/webui/dom_distiller_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/domain_reliability/context_manager.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/domain_reliability/scheduler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/drive/service/fake_drive_service.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/invalidation/impl/invalidator_storage.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/invalidation/impl/unacked_invalidation_set.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/invalidation/impl/unacked_invalidation_set_test_util.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/invalidation/public/object_id_invalidation_map.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/invalidation/public/single_object_invalidation_set.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/policy/core/browser/configuration_policy_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/proximity_auth/webui/proximity_auth_webui_handler.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/components/signin/core/browser/about_signin_internals.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/content/renderer/devtools/v8_sampling_profiler_browsertest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/alarms/alarm_manager.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/app_runtime/app_runtime_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/bluetooth/bluetooth_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/declarative/rules_registry.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/device_permissions_manager.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/hid/hid_device_manager.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/networking_private/networking_private_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/printer_provider/printer_provider_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/storage/settings_test_util.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/system_info/system_info_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/event_listener_map_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/common/event_filter_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/common/permissions/set_disjunction_permission.h
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/extensions/renderer/dom_activity_logger.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/google_apis/drive/drive_api_requests.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/media/cast/logging/stats_event_subscriber.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/media/cdm/json_web_key.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/remoting/host/pairing_registry_delegate_linux.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/remoting/protocol/pairing_registry.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/remoting/protocol/protocol_mock_objects.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/skia/ext/benchmarking_canvas.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/sync/syncable/directory.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/tools/json_schema_compiler/test/arrays_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/tools/json_schema_compiler/test/choices_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/tools/json_schema_compiler/test/crossref_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/tools/json_schema_compiler/test/enums_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/tools/json_schema_compiler/test/functions_on_types_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/tools/json_schema_compiler/test/idl_schemas_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/tools/json_schema_compiler/test/objects_unittest.cc
[modify] https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408/ui/events/latency_info.cc

Project Member

Comment 40 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ad61d2a7998735245a7f86d8b21def472453d40

commit 4ad61d2a7998735245a7f86d8b21def472453d40
Author: dcheng <dcheng@chromium.org>
Date: Fri Jun 10 23:43:17 2016

value_cleanup: Rewrite more base::ListValue::Append(base::Value*) calls.

The tool now understands how to rewrite simple cases of constructing a
new base::Value that's stored in a raw pointer, manipulating it to
populate the data, and then passing ownership into base::ListValue with
the raw pointer overload of base::ListValue::Append.

BUG=581865

Review-Url: https://codereview.chromium.org/2056153003
Cr-Commit-Position: refs/heads/master@{#399319}

[modify] https://crrev.com/4ad61d2a7998735245a7f86d8b21def472453d40/tools/clang/value_cleanup/ListValueRewriter.cpp
[modify] https://crrev.com/4ad61d2a7998735245a7f86d8b21def472453d40/tools/clang/value_cleanup/ListValueRewriter.h
[modify] https://crrev.com/4ad61d2a7998735245a7f86d8b21def472453d40/tools/clang/value_cleanup/tests/list-value-append-expected.cc
[modify] https://crrev.com/4ad61d2a7998735245a7f86d8b21def472453d40/tools/clang/value_cleanup/tests/list-value-append-original.cc

Project Member

Comment 41 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98e96a7390e63333cd5e1a5128ef17e489cbfbb4

commit 98e96a7390e63333cd5e1a5128ef17e489cbfbb4
Author: dcheng <dcheng@chromium.org>
Date: Sat Jun 11 03:41:48 2016

Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=eroman@chromium.org,hashimoto@chromium.org,jochen@chromium.org,piman@chromium.org,rdevlin.cronin@chromium.org,rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2058233002
Cr-Commit-Position: refs/heads/master@{#399362}

[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/base/test/gtest_util.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/devtools/devtools_targets_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/content_settings/content_settings_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/content_settings/content_settings_store.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/cookies/cookies_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/file_system/file_system_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/font_settings/font_settings_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/proxy/proxy_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/tabs/tabs_event_router.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/top_sites/top_sites_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/convert_user_script.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/convert_web_app.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/extensions/extension_messages_apitest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/media_galleries/media_galleries_preferences.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/media_galleries/media_galleries_test_util.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/metrics/plugin_metrics_provider.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/net/predictor.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/net/referrer.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/plugins/plugin_prefs.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/prerender/prerender_history.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/profile_resetter/resettable_settings_snapshot.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/speech/extension_api/tts_extension_api.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/supervised_user/experimental/supervised_user_async_url_checker_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/sync_file_system/drive_backend/metadata_database.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/certificate_viewer_webui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/components_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/cookies_tree_model_util.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/flash_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/instant_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/nacl_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/certificate_manager_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/font_settings_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/handler_options_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/import_data_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/language_options_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/media_devices_selection_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/options_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/startup_pages_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/options/supervised_user_import_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/predictors/predictors_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/settings/certificates_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/chrome/browser/ui/webui/system_info_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/crash/core/browser/crashes_ui_util.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/error_page/common/localized_error.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/error_page/renderer/net_error_helper_core.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/flags_ui/flags_state.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/policy/core/common/configuration_policy_provider_test.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/policy/core/common/schema_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/search_engines/template_url_prepopulate_data_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/signin/core/browser/about_signin_internals.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/sync_driver/about_sync_util.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/components/url_matcher/url_matcher_factory_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/content/browser/geolocation/network_location_provider_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/content/browser/media/media_internals.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/content/browser/net/network_errors_listing_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/content/browser/service_worker/service_worker_internals_ui.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/content/common/font_list_pango.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/dbus/values_util_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/extensions/browser/api/serial/serial_apitest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/extensions/browser/api/web_request/upload_data_presenter.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/extensions/browser/extension_prefs.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/google_apis/drive/drive_api_requests.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/gpu/config/gpu_control_list.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/net/http/http_server_properties_manager.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/net/http/http_server_properties_manager_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/net/log/net_log_util.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/net/quic/quic_connection_logger.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/pdf/pdfium/pdfium_page.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/tools/json_schema_compiler/test/additional_properties_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/tools/json_schema_compiler/test/arrays_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/tools/json_schema_compiler/test/callbacks_unittest.cc
[modify] https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4/tools/json_schema_compiler/test/idl_schemas_unittest.cc

Project Member

Comment 42 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/338b8829d4200d7ca84736e75e309311db3fd486

commit 338b8829d4200d7ca84736e75e309311db3fd486
Author: dcheng <dcheng@chromium.org>
Date: Thu Jun 16 10:48:42 2016

Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

BUG=581865
TBR=cpu@chromium.org,jochen@chromium.org,raymes@chromium.org,rockot@chromium.org

Review-Url: https://codereview.chromium.org/2065793002
Cr-Commit-Position: refs/heads/master@{#400126}

[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/base/json/json_writer_unittest.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/base/values.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/base/values.h
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/base/values_unittest.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/chrome/browser/extensions/api/audio_modem/audio_modem_api_unittest.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/chrome/browser/extensions/api/idltest/idltest_api.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/content/browser/renderer_host/pepper/pepper_socket_utils.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/content/child/v8_value_converter_impl.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/content/common/android/gin_java_bridge_value.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/content/common/android/gin_java_bridge_value.h
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/extensions/browser/api/cast_channel/cast_message_util.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/extensions/browser/api/hid/hid_api.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/extensions/browser/api/web_request/upload_data_presenter.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/extensions/browser/api/web_request/upload_data_presenter.h
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/extensions/browser/api/web_request/upload_data_presenter_unittest.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/ipc/ipc_message_utils.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/mojo/common/common_custom_types_unittest.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc
[modify] https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.h

Project Member

Comment 44 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53a55db87aab3043556fb11e52148b6e43603167

commit 53a55db87aab3043556fb11e52148b6e43603167
Author: dcheng <dcheng@chromium.org>
Date: Tue Jun 21 20:24:42 2016

Don't use deprecated ListValue::Append(Value*) overload.

Fixes for //chrome/browser/ui/webui and its dependencies.

BUG=581865

Review-Url: https://codereview.chromium.org/2086763002
Cr-Commit-Position: refs/heads/master@{#401091}

[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/certificate_viewer_webui.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/copresence_ui_handler.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/foreign_session_handler.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/identity_internals_ui.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/ntp/app_launcher_handler.h
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/options/autofill_options_handler.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/options/handler_options_handler.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/options/password_manager_handler.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/options/search_engine_manager_handler.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/options/search_engine_manager_handler.h
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/quota_internals/quota_internals_types.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/quota_internals/quota_internals_types.h
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/settings/search_engines_handler.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/settings/search_engines_handler.h
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/content/browser/media/media_internals_proxy.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/content/browser/media/media_internals_proxy.h
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/net/log/net_log.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/net/log/net_log.h
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/net/log/net_log_unittest.cc
[modify] https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167/net/log/trace_net_log_observer_unittest.cc

Project Member

Comment 45 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89

commit 0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89
Author: thestig <thestig@chromium.org>
Date: Thu Jun 30 08:04:40 2016

Make base::Environment::Create() return unique_ptrs.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
TBR=jshin@chromium.org

Review-Url: https://codereview.chromium.org/2094913002
Cr-Commit-Position: refs/heads/master@{#403115}

[modify] https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89/base/environment.cc
[modify] https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89/base/environment.h
[modify] https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89/base/files/file_util_unittest.cc
[modify] https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89/base/nix/xdg_util_unittest.cc
[modify] https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89/chrome/browser/shell_integration_linux_unittest.cc
[modify] https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89/net/proxy/proxy_config_service_linux.cc
[modify] https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89/net/proxy/proxy_config_service_linux.h
[modify] https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89/net/proxy/proxy_config_service_linux_unittest.cc
[modify] https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89/sandbox/linux/suid/client/setuid_sandbox_client.cc
[modify] https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89/sandbox/linux/suid/client/setuid_sandbox_client.h
[modify] https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89/sandbox/linux/suid/client/setuid_sandbox_host.cc
[modify] https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89/sandbox/linux/suid/client/setuid_sandbox_host.h
[modify] https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89/sandbox/win/src/address_sanitizer_test.cc
[modify] https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89/ui/base/l10n/l10n_util_unittest.cc

Project Member

Comment 46 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0df2bae8b6aba21a905ec7240c50fbe44ff361ec

commit 0df2bae8b6aba21a905ec7240c50fbe44ff361ec
Author: thestig <thestig@chromium.org>
Date: Tue Jul 26 17:59:36 2016

Return unique_ptrs from base::ProcessMetrics.

- Use more C++11
- Get rid of linked_ptrs
- IWYU
- Remove dead code in old task manager

BUG=581865

Review-Url: https://codereview.chromium.org/2181493002
Cr-Commit-Position: refs/heads/master@{#407851}

[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/base/process/process_metrics.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/base/process/process_metrics.h
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/base/process/process_metrics_freebsd.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/base/process/process_metrics_ios.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/base/process/process_metrics_linux.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/base/process/process_metrics_mac.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/base/process/process_metrics_openbsd.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/base/process/process_metrics_win.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/base/trace_event/trace_event_system_stats_monitor.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/browser/memory_details_mac.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/browser/memory_details_win.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/browser/performance_monitor/performance_monitor.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/browser/performance_monitor/performance_monitor.h
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/browser/performance_monitor/process_metrics_history.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/browser/performance_monitor/process_metrics_history.h
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/browser/power/process_power_collector.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/browser/power/process_power_collector.h
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/browser/task_management/sampling/task_group.h
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/browser/task_management/sampling/task_group_sampler.cc
[delete] https://crrev.com/956d7aca53f56b5cff228af586ea2e5f895f2e9b/chrome/browser/task_manager/os_resource_win.cc
[delete] https://crrev.com/956d7aca53f56b5cff228af586ea2e5f895f2e9b/chrome/browser/task_manager/os_resource_win.h
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/browser/task_manager/task_manager.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/browser/task_manager/task_manager.h
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/browser/ui/webui/about_ui.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/test/base/chrome_process_util.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/chrome/test/base/chrome_process_util.h
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/components/memory_pressure/direct_memory_pressure_calculator_linux.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/components/memory_pressure/direct_memory_pressure_calculator_linux.h
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/components/memory_pressure/direct_memory_pressure_calculator_linux_unittest.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/components/memory_pressure/direct_memory_pressure_calculator_win.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/components/memory_pressure/direct_memory_pressure_calculator_win.h
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/components/memory_pressure/direct_memory_pressure_calculator_win_unittest.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/components/tracing/common/process_metrics_memory_dump_provider.cc
[modify] https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec/ipc/ipc_mojo_perftest.cc

Project Member

Comment 47 by bugdroid1@chromium.org, Aug 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe

commit 32fd7c4ca1b445b9f0044bed9b8686aee59ceefe
Author: dcheng <dcheng@chromium.org>
Date: Sat Aug 27 11:16:06 2016

Switch //components away from base::ListValue::Append(Value*) overload.

This overload is deprecated: prefer the std::unique_ptr<Value> version,
which helps the compiler enforce that ownership transfer occurs.

BUG=581865
R=danakj@chromium.org
TBR=blundell@chromium.org

Review-Url: https://codereview.chromium.org/2287733002
Cr-Commit-Position: refs/heads/master@{#414932}

[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/bookmarks/browser/bookmark_codec.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/bookmarks/browser/bookmark_codec.h
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/cloud_devices/common/description_items_inl.h
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/cloud_devices/common/printer_description.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/devtools_http_handler/devtools_http_handler.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/devtools_http_handler/devtools_http_handler.h
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/domain_reliability/scheduler.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/error_page/common/localized_error.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/error_page/renderer/net_error_helper_core_unittest.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/flags_ui/flags_state.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/gcm_driver/gcm_internals_helper.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/history/core/browser/web_history_service.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/json_schema/json_schema_validator_unittest_base.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/policy/core/common/configuration_policy_provider_test.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/policy/core/common/schema_unittest.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/search_engines/default_search_manager_unittest.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/search_engines/template_url_prepopulate_data_unittest.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/signin/core/browser/about_signin_internals.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/signin/core/browser/about_signin_internals.h
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/signin/core/browser/account_tracker_service.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/signin/core/browser/account_tracker_service_unittest.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/spellcheck/browser/spellcheck_action.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/spellcheck/browser/spellcheck_action.h
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/sync/device_info/device_info.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/sync/device_info/device_info.h
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/sync/driver/about_sync_util.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/sync/syncable/entry_kernel.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/sync/syncable/entry_kernel.h
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/sync/syncable/write_transaction_info.cc
[modify] https://crrev.com/32fd7c4ca1b445b9f0044bed9b8686aee59ceefe/components/user_prefs/tracked/pref_hash_calculator_unittest.cc

Project Member

Comment 48 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/031a8f86b4679f1fb077516c978ea12f76036d42

commit 031a8f86b4679f1fb077516c978ea12f76036d42
Author: dcheng <dcheng@chromium.org>
Date: Thu Sep 08 21:04:33 2016

Remove more usage of the base::ListValue::Append(Value*) overload.

This overload is deprecated: prefer the std::unique_ptr<Value> version,
which helps the compiler enforce that ownership transfer occurs.

BUG=581865
R=danakj@chromium.org
TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2285933003
Cr-Commit-Position: refs/heads/master@{#417396}

[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/base/json/json_parser.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/base/json/json_parser.h
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/base/json/json_parser_unittest.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/base/test/gtest_util.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/chrome/test/base/javascript_browser_test.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/chrome/test/chromedriver/chrome/automation_extension.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/chrome/test/chromedriver/chrome/web_view_impl.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/chrome/test/chromedriver/commands_unittest.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/chrome/test/chromedriver/element_commands.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/chrome/test/chromedriver/element_util.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/chrome/test/chromedriver/element_util.h
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/chrome/test/chromedriver/logging.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/chrome/test/chromedriver/performance_logger_unittest.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/chrome/test/chromedriver/window_commands.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/content/browser/accessibility/accessibility_tree_formatter.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/content/browser/accessibility/accessibility_ui.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/content/browser/gpu/gpu_internals_ui.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/content/browser/service_worker/service_worker_internals_ui.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/content/browser/webrtc/webrtc_internals.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/content/renderer/media/peer_connection_tracker.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/device/geolocation/network_location_request.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/google_apis/drive/drive_api_requests.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/printing/print_settings_conversion.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/remoting/client/plugin/chromoting_instance.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/remoting/host/gcd_rest_client.cc
[modify] https://crrev.com/031a8f86b4679f1fb077516c978ea12f76036d42/skia/ext/benchmarking_canvas.cc

Project Member

Comment 49 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66c7a4cb89abd6a94f36c1ef976e08f7f9878255

commit 66c7a4cb89abd6a94f36c1ef976e08f7f9878255
Author: dcheng <dcheng@chromium.org>
Date: Wed Sep 14 05:49:58 2016

Change more base::ListValue methods to use std::unique_ptr.

AppendIfNotPresent() and Insert() now take unique_ptr instead of a raw
pointer.

BUG=581865
TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2336863003
Cr-Commit-Position: refs/heads/master@{#418494}

[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/base/values.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/base/values.h
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/chromeos/login/login_manager_test.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/chromeos/policy/affiliation_test_helper.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/component_updater/supervised_user_whitelist_installer.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/extensions/extension_management_test_util.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/extensions/extension_web_ui.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/notifications/notifier_state_tracker.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/permissions/chooser_context_base.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/chromeos/dbus/fake_shill_manager_client.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/components/error_page/common/localized_error.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/components/syncable_prefs/pref_model_associator.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/components/user_manager/user_manager_base.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/extensions/browser/script_executor.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/extensions/common/url_pattern_set.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/net/http/http_server_properties_manager.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/net/http/http_server_properties_manager_unittest.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/rlz/chromeos/lib/rlz_value_store_chromeos.cc
[modify] https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255/rlz/chromeos/lib/rlz_value_store_chromeos.h

Project Member

Comment 50 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f19502008401dc093629f3ca082f82edbc47e475

commit f19502008401dc093629f3ca082f82edbc47e475
Author: dcheng <dcheng@chromium.org>
Date: Wed Sep 14 15:18:18 2016

Remove use of deprecated base::ListValue::Append(Value*) overload in extensions.

BUG=581865

Review-Url: https://codereview.chromium.org/2323993004
Cr-Commit-Position: refs/heads/master@{#418568}

[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/api/commands/commands.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/api/debugger/debugger_api.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/api/downloads/downloads_api.h
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/api/font_settings/font_settings_api.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/api/system_private/system_private_api.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/api/tabs/app_window_controller.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/api/tabs/app_window_controller.h
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/api/tabs/tabs_event_router.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/browser_extension_window_controller.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/browser_extension_window_controller.h
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/menu_manager.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/chrome/browser/extensions/window_controller.h
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/extensions/browser/api/networking_private/networking_private_linux.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/extensions/browser/api/printer_provider/printer_provider_apitest.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/extensions/browser/api/runtime/runtime_api.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/extensions/browser/api/web_request/web_request_api_helpers.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/extensions/browser/api/web_request/web_request_api_helpers.h
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/extensions/browser/app_window/app_window_contents.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/extensions/browser/computed_hashes.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/extensions/browser/event_router.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/extensions/common/event_filter_unittest.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/extensions/common/extension_l10n_util_unittest.cc
[modify] https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475/extensions/common/permissions/manifest_permission.cc

Project Member

Comment 51 by bugdroid1@chromium.org, Sep 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71bb8453e8df8e6b5b596a3d4b038b42d03529d2

commit 71bb8453e8df8e6b5b596a3d4b038b42d03529d2
Author: dcheng <dcheng@chromium.org>
Date: Sat Sep 17 01:30:15 2016

Remove deprecated ListValue::Append(Value*) overload on Linux.

Less comments, more type safety.

BUG=581865
R=danakj@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2014103002
Cr-Commit-Position: refs/heads/master@{#419360}

[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/base/values.cc
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/base/values.h
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/browser/bookmarks/managed_bookmark_service_unittest.cc
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/browser/custom_handlers/protocol_handler_registry.cc
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/browser/devtools/devtools_targets_ui.cc
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/browser/devtools/devtools_targets_ui.h
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/browser/media_galleries/media_galleries_preferences.cc
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/browser/net/predictor.cc
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/browser/net/predictor_unittest.cc
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/browser/net/referrer.cc
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/browser/net/referrer.h
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/browser/signin/signin_manager_unittest.cc
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/browser/sync/test/integration/preferences_helper.cc
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/common/custom_handlers/protocol_handler.cc
[modify] https://crrev.com/71bb8453e8df8e6b5b596a3d4b038b42d03529d2/chrome/common/custom_handlers/protocol_handler.h

Project Member

Comment 52 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e07b19a4535fefbd08d823e891db47737521618

commit 0e07b19a4535fefbd08d823e891db47737521618
Author: dcheng <dcheng@chromium.org>
Date: Tue Oct 04 07:00:30 2016

Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
R=sky@chromium.org,xiyuan@chromium.org
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2392693002
Cr-Commit-Position: refs/heads/master@{#422726}

[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/ash/common/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/extensions/dictionary_event_router.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/extensions/input_method_api.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/extensions/input_method_event_router.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/file_manager/url_util.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/file_system_provider/operations/write_file.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/platform_keys/key_permissions.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/policy/device_local_account.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/proxy_cros_settings_parser.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/settings/cros_settings_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/settings/device_settings_provider.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/settings/owner_flags_storage.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/chromeos/system/timezone_util.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/extensions/api/terminal/terminal_private_api.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/ash/chrome_keyboard_ui.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/chromeos/login/l10n_util.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/chromeos/login/l10n_util_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/chromeos/network_ui.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/chromeos/power_ui.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/options/chromeos/power_handler.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/options/preferences_browsertest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chrome/browser/ui/webui/voice_search_ui.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chromeos/dbus/fake_gsm_sms_client.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chromeos/dbus/gsm_sms_client_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chromeos/dbus/shill_manager_client_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chromeos/dbus/shill_profile_client_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chromeos/network/network_state_handler_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chromeos/network/network_util.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chromeos/network/network_util_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chromeos/network/onc/onc_mapper.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chromeos/network/onc/onc_translator_shill_to_onc.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/chromeos/network/shill_property_handler_unittest.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/components/user_manager/known_user.cc
[modify] https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618/components/user_manager/user_manager_base.cc

Comment 53 by jif@chromium.org, Oct 6 2016

Cc: eugene...@chromium.org kkhorimoto@chromium.org jif@chromium.org
Issue 653009 has been merged into this issue.
Project Member

Comment 57 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/518db73d1cbd212aabe93be8c150f3fe14e65f84

commit 518db73d1cbd212aabe93be8c150f3fe14e65f84
Author: dcheng <dcheng@chromium.org>
Date: Thu Oct 13 21:48:45 2016

Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/chromeos

BUG=581865

Review-Url: https://codereview.chromium.org/2418833003
Cr-Commit-Position: refs/heads/master@{#425174}

[modify] https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84/chrome/browser/chromeos/arc/arc_policy_bridge.cc
[modify] https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
[modify] https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
[modify] https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84/chrome/browser/chromeos/login/app_launch_signin_screen.cc
[modify] https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
[modify] https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
[modify] https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc
[modify] https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
[modify] https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84/chrome/browser/chromeos/settings/cros_settings.cc
[modify] https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84/chrome/browser/chromeos/settings/cros_settings_unittest.cc

Project Member

Comment 58 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/454aa39f1d349a1ec7b2a82840ed4650f8ea81ff

commit 454aa39f1d349a1ec7b2a82840ed4650f8ea81ff
Author: dcheng <dcheng@chromium.org>
Date: Fri Oct 14 19:06:14 2016

Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/ui/ash

CreateAppDict()'s return value is passed to Append(); just change
it to return a std::unique_ptr<base::Value> instead of a
base::Value*.

BUG=581865

Review-Url: https://codereview.chromium.org/2416963002
Cr-Commit-Position: refs/heads/master@{#425413}

[modify] https://crrev.com/454aa39f1d349a1ec7b2a82840ed4650f8ea81ff/chrome/browser/ui/ash/chrome_launcher_prefs.cc
[modify] https://crrev.com/454aa39f1d349a1ec7b2a82840ed4650f8ea81ff/chrome/browser/ui/ash/chrome_launcher_prefs.h

Project Member

Comment 59 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23779e84f947f059a7655819f0ec658c1c37bf44

commit 23779e84f947f059a7655819f0ec658c1c37bf44
Author: dcheng <dcheng@chromium.org>
Date: Mon Oct 17 02:19:00 2016

Remove deprecated ListValue::Append(Value*) overload on CrOS.

BUG=581865
R=avi@chromium.org

Review-Url: https://codereview.chromium.org/2419363002
Cr-Commit-Position: refs/heads/master@{#425608}

[modify] https://crrev.com/23779e84f947f059a7655819f0ec658c1c37bf44/base/values.cc
[modify] https://crrev.com/23779e84f947f059a7655819f0ec658c1c37bf44/base/values.h

Comment 60 by vabr@chromium.org, Apr 11 2017

Cc: vabr@chromium.org
I guess I'm continuing the same work under bug 697817 (motivated by finding a cause for a crasher).

There is unlikely a danger of conflict (if anything, working in parallel on this should make the progress quicker), but if anybody would prefer me to move the logs from commits here in the future, let me know.

Comment 61 by vabr@chromium.org, Apr 11 2017

Blocking: 697817
I'm not actively working on this at the moment.

If you're interested, there is a clang tool which can automate large parts of this (though not everything). It doesn't currently work on anything other than ListValue::Append, but I tried to write it in a way that it'd be easy to extend to DictinoaryValue::Set, etc.

Comment 63 by vabr@chromium.org, Apr 12 2017

Thanks, dcheng@.
I saw that tool. For my current work on DictionaryValue::Set I couldn't think of an easy way to automate that, there are far too many patterns to fix (CertificateViewerDialogHandler::RequestCertificateFields has been my favourite so far).

I did have a look at clang-tools for simpler accompanying tasks. I spent yesterday trying to figure out how to report some dubious use of std::move, and the only result so far was freezing my machine :). I might contact you for help with concrete questions if you don't mind.
Project Member

Comment 64 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b9c3f652b91e4668bea6e821d177f4b639b0df0

commit 2b9c3f652b91e4668bea6e821d177f4b639b0df0
Author: vabr <vabr@chromium.org>
Date: Fri Apr 14 22:05:09 2017

Introduce CertNodeBuilder in CertificateViewerDialogHandler::RequestCertificateFields

CertificateViewerDialogHandler::RequestCertificateFields builds a DictionaryValue
representing certificate metadata. It contains a lot of boilerplate and
serializes what is a nested structure, thus making the code hard to understand.

This CL introduces a helper class for building that representation:
CertNodeBuilder. This class hides the boilerplate and through natural C++ code
indenting emphasises the data structure.

The change was originally motivated by ensuring that migrating
CertificateViewerDialogHandler::RequestCertificateFields from raw-pointer base::Value
API is correct. In the meantime, r463684 took care of that. But the additional
readability of the code might still be of value.

The CL also additionally changes raw owning base::Value pointers into unique_ptr
in other parts of the file.

BUG=581865

Review-Url: https://codereview.chromium.org/2813203002
Cr-Commit-Position: refs/heads/master@{#464805}

[modify] https://crrev.com/2b9c3f652b91e4668bea6e821d177f4b639b0df0/chrome/browser/ui/webui/certificate_viewer_webui.cc

vabr: You're absolutely right that it doesn't handle the more complex cases. It's primarily aimed at things that are straightforward translations.

e.g.

base::Value* value = new base::Value(42);
dictionary->Set("abc", value);

can be easily changed to:

auto value = base::MakeUnique<Value>(42);
dictionary->Set("abc", std::move(value));

At least for ListValue, there were a large amount of these, so the tool made sense there. What sort of dubious uses of std::move() are you referring to? I'm happy to help with any of the clang tooling stuff.

Comment 66 by vabr@chromium.org, Apr 15 2017

Hi dcheng@,

I believe already the example similar to you gave may be problematic. A pattern I encounter frequently is:

base::Value* value = new base::ListValue();
dictionary->Set("abc", value);
...
value->Append(...)

The last use of |value| is non-owning. Once |value| becomes a unique_ptr, that code is no longer working and needs to be reordered to be fixed.


The dubious use of std::move is one I accidentally introduced (and fixed since): using it on a raw pointer. That has no effect and signals a mistake (there should have been some unique_ptr passed into std::move instead). My goal was to check for potential other instances (even sanitizers can miss this, apparently). It's probably easy for you to write, but if you don't mind, I'd like to try it myself, to get familiar with the tools.

One general question: all the clang tooling I saw in tools/clang are rewriting tools. My use-case above is more of a reporting tool: assuming there are none such instances or just a handful, the tool should simply point me to the parts of code needing manual fixing. It can be done by a rewrite tool (I can rewrite it to anything and just get the locations from the report), but I wonder if there is a more standard way to do it?
Project Member

Comment 67 by bugdroid1@chromium.org, Apr 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aac471cc7394249b1a3d32a777d0539c2ae54d5

commit 4aac471cc7394249b1a3d32a777d0539c2ae54d5
Author: vabr <vabr@chromium.org>
Date: Sat Apr 15 08:54:18 2017

Stop passing raw pointers to base::Value API in c/b/ui

Passing ownership of base::Value into API methods DictionaryValue::Set,
DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
pointers is deprecated, can hide bugs and should be done via unique_ptr
instead.

Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.

BUG=581865
TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2812953002
Cr-Commit-Position: refs/heads/master@{#464860}

[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/chromeos/proxy_cros_settings_parser.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/chromeos/proxy_cros_settings_parser.h
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/app_list/search/common/webservice_cache.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/app_list/search/common/webservice_cache.h
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/ash/chrome_launcher_prefs.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/browser_window_state.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/chromeos/login/network_screen_handler.h
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/chromeos/network_ui.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/chromeos/power_ui.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/chromeos/set_time_ui.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/components_ui.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/components_ui.h
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/cookies_tree_model_util.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/flags_ui.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/flash_ui.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/foreign_session_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/identity_internals_ui.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/instant_ui.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/nacl_ui.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/autofill_options_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/certificate_manager_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/core_options_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/core_options_handler.h
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/handler_options_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/language_options_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/language_options_handler.h
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/language_options_handler_common.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/language_options_handler_common.h
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/search_engine_manager_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/options/supervised_user_import_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/policy_ui_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/predictors/predictors_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/settings/certificates_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/settings/protocol_handlers_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/settings/search_engines_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/system_info_ui.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/webui/voice_search_ui.cc
[modify] https://crrev.com/4aac471cc7394249b1a3d32a777d0539c2ae54d5/chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc

Project Member

Comment 68 by bugdroid1@chromium.org, Apr 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aec0f17718b8e13656d7c9f9fe795a0b8066ffcc

commit aec0f17718b8e13656d7c9f9fe795a0b8066ffcc
Author: vabr <vabr@chromium.org>
Date: Sat Apr 15 08:59:18 2017

Remove ListValue::Append(raw ptr) on Mac and iOS

ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be
used instead. This CL achieves that on Mac and iOS specifically.

The CL also changes some related calls to DictionaryValue::Set to take
a unique_ptr instead of a raw one.

BUG=581865

Review-Url: https://codereview.chromium.org/2817603003
Cr-Commit-Position: refs/heads/master@{#464862}

[modify] https://crrev.com/aec0f17718b8e13656d7c9f9fe795a0b8066ffcc/base/values.cc
[modify] https://crrev.com/aec0f17718b8e13656d7c9f9fe795a0b8066ffcc/base/values.h
[modify] https://crrev.com/aec0f17718b8e13656d7c9f9fe795a0b8066ffcc/components/policy/core/common/mac_util.cc
[modify] https://crrev.com/aec0f17718b8e13656d7c9f9fe795a0b8066ffcc/components/policy/core/common/mac_util_unittest.cc
[modify] https://crrev.com/aec0f17718b8e13656d7c9f9fe795a0b8066ffcc/components/wifi/fake_wifi_service.cc
[modify] https://crrev.com/aec0f17718b8e13656d7c9f9fe795a0b8066ffcc/components/wifi/wifi_service_mac.mm
[modify] https://crrev.com/aec0f17718b8e13656d7c9f9fe795a0b8066ffcc/content/browser/accessibility/accessibility_tree_formatter_mac.mm
[modify] https://crrev.com/aec0f17718b8e13656d7c9f9fe795a0b8066ffcc/content/common/font_list_mac.mm
[modify] https://crrev.com/aec0f17718b8e13656d7c9f9fe795a0b8066ffcc/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/aec0f17718b8e13656d7c9f9fe795a0b8066ffcc/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
[modify] https://crrev.com/aec0f17718b8e13656d7c9f9fe795a0b8066ffcc/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

Project Member

Comment 69 by bugdroid1@chromium.org, Apr 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f38a9ff1e78023cc3fa341a30448d1b9ca5a891

commit 2f38a9ff1e78023cc3fa341a30448d1b9ca5a891
Author: vabr <vabr@chromium.org>
Date: Sat Apr 15 09:56:14 2017

Remove ListValue::Append(raw ptr) on Android

ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be
used instead. This CL achieves that on Android specifically.

BUG=581865

Review-Url: https://codereview.chromium.org/2811253004
Cr-Commit-Position: refs/heads/master@{#464865}

[modify] https://crrev.com/2f38a9ff1e78023cc3fa341a30448d1b9ca5a891/base/values.cc
[modify] https://crrev.com/2f38a9ff1e78023cc3fa341a30448d1b9ca5a891/base/values.h
[modify] https://crrev.com/2f38a9ff1e78023cc3fa341a30448d1b9ca5a891/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc
[modify] https://crrev.com/2f38a9ff1e78023cc3fa341a30448d1b9ca5a891/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
[modify] https://crrev.com/2f38a9ff1e78023cc3fa341a30448d1b9ca5a891/content/browser/android/java/gin_java_bridge_dispatcher_host.cc
[modify] https://crrev.com/2f38a9ff1e78023cc3fa341a30448d1b9ca5a891/content/browser/android/java/gin_java_method_invocation_helper.cc
[modify] https://crrev.com/2f38a9ff1e78023cc3fa341a30448d1b9ca5a891/content/browser/android/java/gin_java_method_invocation_helper_unittest.cc
[modify] https://crrev.com/2f38a9ff1e78023cc3fa341a30448d1b9ca5a891/content/renderer/java/gin_java_bridge_value_converter.cc
[modify] https://crrev.com/2f38a9ff1e78023cc3fa341a30448d1b9ca5a891/content/renderer/java/gin_java_function_invocation_helper.cc

Project Member

Comment 70 by bugdroid1@chromium.org, Apr 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cc8da77161b4ab86ff43a06bda52a53f59a0bff

commit 7cc8da77161b4ab86ff43a06bda52a53f59a0bff
Author: vabr <vabr@chromium.org>
Date: Sat Apr 15 10:07:19 2017

Remove ListValue::Append(raw ptr) on Win

ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be
used instead. This CL achieves that on Win, which is the last platform to still
use the raw-pointer Append.

The CL also changes some related calls to DictionaryValue::Set to take
a unique_ptr instead of a raw one.

BUG=581865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2809933003
Cr-Commit-Position: refs/heads/master@{#464866}

[modify] https://crrev.com/7cc8da77161b4ab86ff43a06bda52a53f59a0bff/base/values.cc
[modify] https://crrev.com/7cc8da77161b4ab86ff43a06bda52a53f59a0bff/base/values.h
[modify] https://crrev.com/7cc8da77161b4ab86ff43a06bda52a53f59a0bff/chrome/browser/win/enumerate_modules_model.cc
[modify] https://crrev.com/7cc8da77161b4ab86ff43a06bda52a53f59a0bff/components/policy/core/common/policy_loader_win_unittest.cc
[modify] https://crrev.com/7cc8da77161b4ab86ff43a06bda52a53f59a0bff/components/wifi/wifi_service_win.cc
[modify] https://crrev.com/7cc8da77161b4ab86ff43a06bda52a53f59a0bff/content/browser/tracing/etw_tracing_agent_win.cc
[modify] https://crrev.com/7cc8da77161b4ab86ff43a06bda52a53f59a0bff/content/common/font_list_win.cc
[modify] https://crrev.com/7cc8da77161b4ab86ff43a06bda52a53f59a0bff/remoting/host/pairing_registry_delegate_win.cc

Project Member

Comment 71 by bugdroid1@chromium.org, Apr 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a351077393017cd8e0286942e2539144207e10f

commit 9a351077393017cd8e0286942e2539144207e10f
Author: findit-for-me <findit-for-me@appspot.gserviceaccount.com>
Date: Sat Apr 15 10:21:16 2017

Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5 id:80001 of https://codereview.chromium.org/2812953002/ )

Reason for revert:

Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRhYWM0NzFjYzczOTQyNDliMWEzZDMyYTc3N2QwNTM5YzJhZTU0ZDUM

Original issue's description:
> Stop passing raw pointers to base::Value API in c/b/ui
>
> Passing ownership of base::Value into API methods DictionaryValue::Set,
> DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> pointers is deprecated, can hide bugs and should be done via unique_ptr
> instead.
>
> Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
>
> BUG=581865
> TBR=dbeam@chromium.org
>
> Review-Url: https://codereview.chromium.org/2812953002
> Cr-Commit-Position: refs/heads/master@{#464860}
> Committed: https://chromium.googlesource.com/chromium/src/+/4aac471cc7394249b1a3d32a777d0539c2ae54d5

TBR=derat@chromium.org,estade@chromium.org,jdoerrie@chromium.org,msw@chromium.org,dpapad@chromium.org,dbeam@chromium.org,vabr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581865

Review-Url: https://codereview.chromium.org/2820823005
Cr-Commit-Position: refs/heads/master@{#464867}

[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/chromeos/proxy_cros_settings_parser.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/chromeos/proxy_cros_settings_parser.h
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/app_list/search/common/webservice_cache.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/app_list/search/common/webservice_cache.h
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/ash/chrome_launcher_prefs.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/browser_window_state.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/chromeos/login/network_screen_handler.h
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/chromeos/network_ui.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/chromeos/power_ui.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/chromeos/set_time_ui.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/components_ui.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/components_ui.h
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/cookies_tree_model_util.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/flags_ui.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/flash_ui.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/foreign_session_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/identity_internals_ui.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/instant_ui.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/nacl_ui.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/autofill_options_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/certificate_manager_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/core_options_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/core_options_handler.h
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/handler_options_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/language_options_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/language_options_handler.h
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/language_options_handler_common.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/language_options_handler_common.h
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/search_engine_manager_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/options/supervised_user_import_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/policy_ui_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/predictors/predictors_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/settings/certificates_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/settings/protocol_handlers_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/settings/search_engines_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/system_info_ui.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/webui/voice_search_ui.cc
[modify] https://crrev.com/9a351077393017cd8e0286942e2539144207e10f/chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc

Project Member

Comment 72 by bugdroid1@chromium.org, Apr 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d092ccd5cf26beafb4c364af453f64293f2b6372

commit d092ccd5cf26beafb4c364af453f64293f2b6372
Author: vabr <vabr@chromium.org>
Date: Sat Apr 15 12:16:50 2017

Reland of Stop passing raw pointers to base::Value API in c/b/ui (patchset #1 id:1 of https://codereview.chromium.org/2820823005/ )

The failure was in code like this:
unique_ptr<Value> f() {
  unique_ptr<ListValue> list;
  ...
  return list;
}

Some compilers already support upcasting like this, but for others this needs to become:
return std::move(list);

The compilation error was not detected by the basic CQ set, so adding the specific bot below:
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:chromeos_x86-generic_chromium_compile_only_ng

Original issue's description:
> Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5 id:80001 of https://codereview.chromium.org/2812953002/ )
>
> Reason for revert:
>
> Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
> culprit for failures in the build cycles as shown on:
> https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRhYWM0NzFjYzczOTQyNDliMWEzZDMyYTc3N2QwNTM5YzJhZTU0ZDUM
>
> Original issue's description:
> > Stop passing raw pointers to base::Value API in c/b/ui
> >
> > Passing ownership of base::Value into API methods DictionaryValue::Set,
> > DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> > pointers is deprecated, can hide bugs and should be done via unique_ptr
> > instead.
> >
> > Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
> >
> > BUG=581865
> > TBR=dbeam@chromium.org

TBR=derat@chromium.org,dbeam@chromium.org,jdoerrie@chromium.org,alexmos@google.com,estade@chromium.org,msw@chromium.org,loyso@google.com,mastiz@google.com,pfeldman@google.com,paulmeyer@google.com,dpapad@chromium.org,findit-for-me@appspot.gserviceaccount.com
BUG=581865

Review-Url: https://codereview.chromium.org/2814363006
Cr-Commit-Position: refs/heads/master@{#464870}

[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/chromeos/proxy_cros_settings_parser.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/chromeos/proxy_cros_settings_parser.h
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/app_list/search/common/webservice_cache.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/app_list/search/common/webservice_cache.h
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/ash/chrome_launcher_prefs.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/browser_window_state.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/chromeos/login/network_screen_handler.h
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/chromeos/network_ui.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/chromeos/power_ui.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/chromeos/set_time_ui.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/components_ui.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/components_ui.h
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/cookies_tree_model_util.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/flags_ui.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/flash_ui.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/foreign_session_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/identity_internals_ui.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/instant_ui.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/nacl_ui.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/autofill_options_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/certificate_manager_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/core_options_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/core_options_handler.h
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/handler_options_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/language_options_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/language_options_handler.h
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/language_options_handler_common.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/language_options_handler_common.h
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/search_engine_manager_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/options/supervised_user_import_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/policy_ui_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/predictors/predictors_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/settings/certificates_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/settings/protocol_handlers_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/settings/search_engines_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/system_info_ui.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/webui/voice_search_ui.cc
[modify] https://crrev.com/d092ccd5cf26beafb4c364af453f64293f2b6372/chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc

We've already generalized run_tool.py so that the clang tool can emit
whatever output it wants to stdout: it can be edits that are fed into
extract_edits.py | apply_edits.py, or it can be any sort of other output.

It should be pretty easy to write a reporting tool for this: the reporting
tool would use a cxxMemberExpr matcher to capture raw pointer arguments to
Value methods that pass ownership. The argument can be captured by matching
against a declRefExpr matcher, and the tool can iterate through the matched
results to see if there are multiple references to the same VarDecl. The
results can simply be dumped to stdout for run_tool.py to capture.
Project Member

Comment 74 by bugdroid1@chromium.org, Apr 28 2017

Labels: merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab7a614f33bd8389fa1714e5f0406ac8275c32b1

commit ab7a614f33bd8389fa1714e5f0406ac8275c32b1
Author: Vaclav Brozek <vabr@chromium.org>
Date: Fri Apr 28 08:38:29 2017

Remove ListValue::Append(raw ptr) on Mac and iOS

ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be
used instead. This CL achieves that on Mac and iOS specifically.

The CL also changes some related calls to DictionaryValue::Set to take
a unique_ptr instead of a raw one.

BUG=581865

Review-Url: https://codereview.chromium.org/2817603003
Cr-Commit-Position: refs/heads/master@{#464862}
(cherry picked from commit aec0f17718b8e13656d7c9f9fe795a0b8066ffcc)

Review-Url: https://codereview.chromium.org/2846213002 .
Cr-Commit-Position: refs/branch-heads/3071@{#288}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/ab7a614f33bd8389fa1714e5f0406ac8275c32b1/base/values.cc
[modify] https://crrev.com/ab7a614f33bd8389fa1714e5f0406ac8275c32b1/base/values.h
[modify] https://crrev.com/ab7a614f33bd8389fa1714e5f0406ac8275c32b1/components/policy/core/common/mac_util.cc
[modify] https://crrev.com/ab7a614f33bd8389fa1714e5f0406ac8275c32b1/components/policy/core/common/mac_util_unittest.cc
[modify] https://crrev.com/ab7a614f33bd8389fa1714e5f0406ac8275c32b1/components/wifi/fake_wifi_service.cc
[modify] https://crrev.com/ab7a614f33bd8389fa1714e5f0406ac8275c32b1/components/wifi/wifi_service_mac.mm
[modify] https://crrev.com/ab7a614f33bd8389fa1714e5f0406ac8275c32b1/content/browser/accessibility/accessibility_tree_formatter_mac.mm
[modify] https://crrev.com/ab7a614f33bd8389fa1714e5f0406ac8275c32b1/content/common/font_list_mac.mm
[modify] https://crrev.com/ab7a614f33bd8389fa1714e5f0406ac8275c32b1/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/ab7a614f33bd8389fa1714e5f0406ac8275c32b1/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
[modify] https://crrev.com/ab7a614f33bd8389fa1714e5f0406ac8275c32b1/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

Project Member

Comment 75 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c92df1c2ea02446a46d6e1f51d1eaa117d6e18a2

commit c92df1c2ea02446a46d6e1f51d1eaa117d6e18a2
Author: Vaclav Brozek <vabr@chromium.org>
Date: Fri Apr 28 08:39:44 2017

Remove ListValue::Append(raw ptr) on Android

ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be
used instead. This CL achieves that on Android specifically.

BUG=581865

Review-Url: https://codereview.chromium.org/2811253004
Cr-Commit-Position: refs/heads/master@{#464865}
(cherry picked from commit 2f38a9ff1e78023cc3fa341a30448d1b9ca5a891)

Review-Url: https://codereview.chromium.org/2848493006 .
Cr-Commit-Position: refs/branch-heads/3071@{#289}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/c92df1c2ea02446a46d6e1f51d1eaa117d6e18a2/base/values.cc
[modify] https://crrev.com/c92df1c2ea02446a46d6e1f51d1eaa117d6e18a2/base/values.h
[modify] https://crrev.com/c92df1c2ea02446a46d6e1f51d1eaa117d6e18a2/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc
[modify] https://crrev.com/c92df1c2ea02446a46d6e1f51d1eaa117d6e18a2/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
[modify] https://crrev.com/c92df1c2ea02446a46d6e1f51d1eaa117d6e18a2/content/browser/android/java/gin_java_bridge_dispatcher_host.cc
[modify] https://crrev.com/c92df1c2ea02446a46d6e1f51d1eaa117d6e18a2/content/browser/android/java/gin_java_method_invocation_helper.cc
[modify] https://crrev.com/c92df1c2ea02446a46d6e1f51d1eaa117d6e18a2/content/browser/android/java/gin_java_method_invocation_helper_unittest.cc
[modify] https://crrev.com/c92df1c2ea02446a46d6e1f51d1eaa117d6e18a2/content/renderer/java/gin_java_bridge_value_converter.cc
[modify] https://crrev.com/c92df1c2ea02446a46d6e1f51d1eaa117d6e18a2/content/renderer/java/gin_java_function_invocation_helper.cc

Comment 76 by vabr@chromium.org, Apr 28 2017

The merge done in #75 was approved in https://crbug.com/715659#c16. Sorry for the confusion.

Comment 77 by vabr@chromium.org, Apr 28 2017

Also the merge in #74 here was approved in https://crbug.com/715659#c16.
Project Member

Comment 78 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c

commit 97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed May 17 16:29:54 2017

Remove raw base::DictionaryValue::Set in //chrome

This change removes the deprecated raw pointer version of
base::DictionaryValue::Set in //chrome and replaces it with the unique
pointer version or other convenience functions where appropriate.

BUG=646113, 581865

Review-Url: https://codereview.chromium.org/2888073002
Cr-Commit-Position: refs/heads/master@{#472473}

[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/extensions/api/proxy/proxy_api.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/extensions/api/proxy/proxy_api_helpers.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/extensions/api/proxy/proxy_api_helpers.h
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/extensions/api/tabs/tabs_event_router.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/extensions/extension_management_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/media_galleries/media_galleries_test_util.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/permissions/chooser_context_base.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/policy/test/local_policy_test_server.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/prerender/prerender_history.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/prerender/prerender_history.h
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/prerender/prerender_history_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/profile_resetter/profile_resetter_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/speech/extension_api/tts_extension_api.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/supervised_user/legacy/supervised_user_sync_service_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/supervised_user/supervised_user_settings_service.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/supervised_user/supervised_user_whitelist_service_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/task_profiler/task_profiler_data_serializer.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/themes/theme_syncable_service_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/ui/webui/local_state/local_state_ui_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/browser/ui/webui/sync_internals_message_handler.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/common/custom_handlers/protocol_handler.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/common/extensions/api/common_extension_api_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/common/extensions/command_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/common/extensions/manifest_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/common/extensions/permissions/settings_override_permission_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/common/extensions/sync_type_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/renderer/chrome_content_renderer_client_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/test/chromedriver/capabilities_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/test/chromedriver/chrome/devtools_client_impl.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/test/chromedriver/chrome/web_view_impl.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/test/chromedriver/chrome_launcher.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/test/chromedriver/commands.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/test/chromedriver/commands_unittest.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/test/chromedriver/devtools_events_logger.cc
[modify] https://crrev.com/97df444c72d8ec0b4ec6e440dc8e9d02ba4aa19c/chrome/test/chromedriver/performance_logger_unittest.cc

Project Member

Comment 79 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89aa5721a06d876d9bcd20387a8c48794a208e7c

commit 89aa5721a06d876d9bcd20387a8c48794a208e7c
Author: jdoerrie <jdoerrie@chromium.org>
Date: Mon May 22 08:36:03 2017

Remove raw base::DictionaryValue::SetWithoutPathExpansion

This change removes the deprecated raw pointer version of
base::DictionaryValue::SetWithoutPathExpansion and replaces it with the
unique pointer version or other convenience functions where appropriate.

BUG=646113, 581865

Review-Url: https://codereview.chromium.org/2884933002
Cr-Commit-Position: refs/heads/master@{#473525}

[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/base/values.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/base/values.h
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/chromeos/network/onc/onc_translator_shill_to_onc.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/components/policy/core/common/policy_test_utils.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/components/policy/core/common/registry_dict.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/components/sync_preferences/pref_model_associator.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/components/sync_preferences/pref_model_associator.h
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/components/sync_preferences/pref_model_associator_unittest.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/components/url_matcher/url_matcher_factory_unittest.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/components/user_manager/user_manager_base.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/components/wifi/wifi_service_mac.mm
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/content/browser/service_manager/merge_dictionary.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/dbus/values_util_unittest.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/extensions/browser/api/bluetooth_low_energy/utils.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/ios/chrome/browser/autofill/autofill_agent.mm
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/ios/chrome/browser/browser_state/browser_state_info_cache.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/ios/chrome/browser/browser_state/browser_state_info_cache.h
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/ipc/ipc_message_unittest.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/ipc/ipc_message_utils_unittest.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/net/http/http_server_properties_manager.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/net/http/http_server_properties_manager_unittest.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/net/socket/client_socket_pool_base.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/net/spdy/core/spdy_header_block.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/services/preferences/tracked/pref_hash_filter_unittest.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/tools/ipc_fuzzer/fuzzer/fuzzer.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/tools/json_schema_compiler/test/choices_unittest.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/tools/json_schema_compiler/test/enums_unittest.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/tools/json_schema_compiler/test/error_generation_unittest.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/tools/json_schema_compiler/test/simple_api_unittest.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/tools/json_schema_compiler/test/test_util.cc
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/tools/json_schema_compiler/test/test_util.h
[modify] https://crrev.com/89aa5721a06d876d9bcd20387a8c48794a208e7c/ui/app_list/search/history_data_store.cc

Summary: Fix various base APIs to use std::unique_ptr where appropriate (was: Fix various base APIs to use scoped_ptr where appropriate)
Project Member

Comment 81 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1a515dfc10c025e5406f19b51f47ecba5496f5b

commit c1a515dfc10c025e5406f19b51f47ecba5496f5b
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Jun 02 09:44:38 2017

Remove raw DictionaryValue::Set in //components

This change removes the deprecated raw pointer version of
base::DictionaryValue::Set in //components and replaces it with the unique
pointer version or other convenience functions where appropriate.

BUG=646113, 581865

Review-Url: https://codereview.chromium.org/2889163002
Cr-Commit-Position: refs/heads/master@{#476609}

[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/base/test/values_test_util.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/base/test/values_test_util.h
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/chrome/browser/bookmarks/bookmark_html_writer.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/autofill/core/browser/autofill_address_util.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/bookmarks/browser/bookmark_codec.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/bookmarks/browser/bookmark_codec.h
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/cloud_devices/common/cloud_device_description.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/cloud_devices/common/printer_description.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/domain_reliability/beacon.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/domain_reliability/context.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/error_page/common/localized_error.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/error_page/renderer/net_error_helper_core.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/error_page/renderer/net_error_helper_core_unittest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/flags_ui/flags_state.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/gcm_driver/gcm_internals_helper.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/history/core/browser/web_history_service.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/invalidation/impl/p2p_invalidator.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/invalidation/impl/sync_invalidation_listener.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/invalidation/impl/unacked_invalidation_set.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/invalidation/public/invalidation.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/json_schema/json_schema_validator_unittest_base.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/login/screens/screen_context.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/physical_web/webui/physical_web_base_message_handler.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/policy/core/common/config_dir_policy_loader_unittest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/policy/core/common/configuration_policy_provider_test.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/policy/core/common/schema_unittest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/proximity_auth/screenlock_bridge.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/search_engines/default_search_manager_unittest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/search_engines/default_search_policy_handler.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/search_engines/template_url_prepopulate_data_unittest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/signin/core/browser/about_signin_internals.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/base/model_type.h
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/driver/about_sync_util.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/engine/cycle/sync_cycle_snapshot.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/engine/events/protocol_event.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/engine_impl/js_mutation_event_observer.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/engine_impl/js_mutation_event_observer_unittest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/engine_impl/js_sync_encryption_handler_observer_unittest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/js/js_event_details_unittest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/protocol/sync_protocol_error.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/protocol/sync_protocol_error.h
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/syncable/base_node.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/syncable/base_node.h
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/syncable/entry.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/syncable/entry.h
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/syncable/entry_kernel.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/syncable/entry_kernel.h
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/syncable/model_type.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/syncable/model_type_unittest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/syncable/syncable_id.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/syncable/syncable_id.h
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/syncable/syncable_id_unittest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/syncable/write_transaction_info.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/syncable/write_transaction_info.h
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync/test/fake_server/fake_server.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/sync_wifi/wifi_credential.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/url_matcher/url_matcher_factory_unittest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/webcrypto/algorithms/aes_cbc_unittest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/webcrypto/algorithms/aes_kw_unittest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/webcrypto/algorithms/hmac_unittest.cc
[modify] https://crrev.com/c1a515dfc10c025e5406f19b51f47ecba5496f5b/components/webcrypto/jwk.cc

Project Member

Comment 82 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/664305c0416320561681f1593627ad5d25aca07f

commit 664305c0416320561681f1593627ad5d25aca07f
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Jun 07 08:34:34 2017

Remove raw base::DictionaryValue::Set in //content

This change removes the deprecated raw pointer version of
base::DictionaryValue::Set in //content and replaces it with the unique
pointer version or other convenience functions where appropriate.

BUG=646113, 581865

Review-Url: https://codereview.chromium.org/2891933004
Cr-Commit-Position: refs/heads/master@{#477581}

[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/accessibility/accessibility_tree_formatter.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/accessibility/accessibility_tree_formatter_auralinux.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/accessibility/accessibility_tree_formatter_blink.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/accessibility/accessibility_ui.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/devtools/protocol/system_info_handler.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/gpu/compositor_util.h
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/gpu/gpu_data_manager_impl.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/gpu/gpu_data_manager_impl.h
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/gpu/gpu_data_manager_impl_private.h
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/gpu/gpu_internals_ui.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/media/media_internals.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/media/media_internals_proxy.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/media/media_internals_proxy.h
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/net/network_errors_listing_ui.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/service_worker/service_worker_internals_ui.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/tracing/tracing_controller_impl.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/browser/webrtc/webrtc_internals.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/renderer/media/peer_connection_tracker.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/shell/browser/shell_devtools_bindings.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/shell/browser/shell_net_log.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/content/shell/renderer/layout_test/leak_detector.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/net/log/net_log.cc
[modify] https://crrev.com/664305c0416320561681f1593627ad5d25aca07f/net/log/net_log.h

Project Member

Comment 83 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ff270cabd2fe758de8cf57060dd660ae7d8ef68

commit 6ff270cabd2fe758de8cf57060dd660ae7d8ef68
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Jun 07 10:31:45 2017

Remove raw base::DictionaryValue::Set in //extensions

This change removes the deprecated raw pointer version of
base::DictionaryValue::Set in //extensions and replaces it with the unique
pointer version or other convenience functions where appropriate.

BUG=646113, 581865

Review-Url: https://codereview.chromium.org/2899743002
Cr-Commit-Position: refs/heads/master@{#477602}

[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/api/app_runtime/app_runtime_api.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/api/app_window/app_window_api.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/api/declarative/declarative_api.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/api/socket/socket_api.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/api/usb/usb_api.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/api/web_request/web_request_api_helpers.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/api/web_request/web_request_api_helpers.h
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/api/web_request/web_request_event_details.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/app_window/app_window.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/computed_hashes.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/event_listener_map_unittest.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/extension_prefs.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/guest_view/app_view/app_view_guest.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/guest_view/web_view/web_view_find_helper.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/guest_view/web_view/web_view_permission_helper.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/browser/value_store/value_store_change.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/common/event_filter_unittest.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/common/extension_l10n_util_unittest.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/common/extension_set_unittest.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/common/file_util_unittest.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/common/manifest_handlers/oauth2_manifest_unittest.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/common/message_bundle_unittest.cc
[modify] https://crrev.com/6ff270cabd2fe758de8cf57060dd660ae7d8ef68/extensions/utility/unpacker.cc

Project Member

Comment 84 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eea70fa2aa13869e8599bc1cd511a0e05146af4

commit 4eea70fa2aa13869e8599bc1cd511a0e05146af4
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Jun 07 11:58:32 2017

Remove raw DictionaryValue::Set in //net

This change removes the deprecated raw pointer version of
base::DictionaryValue::Set in //net and replaces it with the unique
pointer version or other convenience functions where appropriate.

BUG=646113, 581865

Review-Url: https://codereview.chromium.org/2899723003
Cr-Commit-Position: refs/heads/master@{#477614}

[modify] https://crrev.com/4eea70fa2aa13869e8599bc1cd511a0e05146af4/net/dns/dns_config_service.cc
[modify] https://crrev.com/4eea70fa2aa13869e8599bc1cd511a0e05146af4/net/http/http_request_headers.cc
[modify] https://crrev.com/4eea70fa2aa13869e8599bc1cd511a0e05146af4/net/http/http_response_headers.cc
[modify] https://crrev.com/4eea70fa2aa13869e8599bc1cd511a0e05146af4/net/http/transport_security_persister.cc
[modify] https://crrev.com/4eea70fa2aa13869e8599bc1cd511a0e05146af4/net/log/net_log_util.cc
[modify] https://crrev.com/4eea70fa2aa13869e8599bc1cd511a0e05146af4/net/proxy/proxy_config.cc
[modify] https://crrev.com/4eea70fa2aa13869e8599bc1cd511a0e05146af4/net/proxy/proxy_service.cc
[modify] https://crrev.com/4eea70fa2aa13869e8599bc1cd511a0e05146af4/net/quic/chromium/quic_connection_logger.cc
[modify] https://crrev.com/4eea70fa2aa13869e8599bc1cd511a0e05146af4/net/socket/ssl_client_socket_pool.cc
[modify] https://crrev.com/4eea70fa2aa13869e8599bc1cd511a0e05146af4/net/test/spawned_test_server/base_test_server.cc

Project Member

Comment 85 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb205a56e608f489af6496d4c76f71abe0b7aef9

commit cb205a56e608f489af6496d4c76f71abe0b7aef9
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Jun 08 16:16:44 2017

Remove raw DictionaryValue::Set

This change removes the deprecated raw pointer version of
base::DictionaryValue::Set and replaces it with the unique
pointer version or other convenience functions where appropriate.

BUG=646113, 581865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2911033002
Cr-Commit-Position: refs/heads/master@{#477985}

[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/base/values.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/base/values.h
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/chrome/browser/supervised_user/supervised_user_service_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/chrome/browser/sync_file_system/drive_backend/metadata_database.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/chrome/browser/ui/webui/conflicts_handler.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/chrome/browser/win/enumerate_modules_model.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/chrome/browser/win/enumerate_modules_model.h
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/chrome/test/chromedriver/performance_logger.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/chrome/test/chromedriver/server/http_handler.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/chromecast/browser/cast_net_log.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/chromeos/dbus/fake_shill_service_client.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/chromeos/network/network_configuration_handler_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/chromeos/network/onc/onc_validator.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/components/cloud_devices/common/description_items_inl.h
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/components/policy/core/common/mac_util.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/components/policy/core/common/policy_loader_win_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/components/policy/core/common/registry_dict_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/components/wifi/network_properties.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/content/browser/accessibility/accessibility_tree_formatter_win.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/content/browser/tracing/etw_tracing_agent_win.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/dbus/values_util_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/device/geolocation/network_location_request.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/extensions/browser/api/socket/socket_api.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/extensions/browser/api/storage/settings_test_util.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/google_apis/drive/drive_api_requests.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/google_apis/gaia/google_service_auth_error.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/gpu/config/gpu_control_list.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/headless/lib/browser/headless_net_log.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/ios/chrome/browser/autofill/autofill_agent.mm
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/ios/chrome/browser/notification_promo.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/ios/chrome/browser/notification_promo_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/ios/chrome/browser/ui/webui/flags_ui.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/ipc/ipc_message_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/media/cast/logging/stats_event_subscriber.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/media/cdm/json_web_key.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/net/http/http_proxy_client_socket_pool.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/net/reporting/reporting_delivery_agent.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/net/test/spawned_test_server/base_test_server.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/printing/print_settings_conversion.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/remoting/client/plugin/chromoting_instance.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/remoting/host/it2me/it2me_native_messaging_host.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/remoting/host/security_key/security_key_extension_session.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/remoting/host/setup/me2me_native_messaging_host.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/rlz/chromeos/lib/rlz_value_store_chromeos.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/services/preferences/tracked/dictionary_hash_store_contents.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/services/preferences/tracked/pref_hash_calculator_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/services/preferences/tracked/pref_hash_filter.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/services/preferences/tracked/pref_hash_filter_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/services/preferences/tracked/pref_hash_store_impl_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/services/preferences/tracked/tracked_preferences_migration.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/skia/ext/benchmarking_canvas.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/third_party/dom_distiller_js/protoc_plugins/json_values_converter.py
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/third_party/dom_distiller_js/test_sample_json_converter.h.golden
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/tools/json_schema_compiler/test/additional_properties_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/tools/json_schema_compiler/test/arrays_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/tools/json_schema_compiler/test/choices_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/tools/json_schema_compiler/test/crossref_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/tools/json_schema_compiler/test/enums_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/tools/json_schema_compiler/test/functions_as_parameters_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/tools/json_schema_compiler/test/objects_unittest.cc
[modify] https://crrev.com/cb205a56e608f489af6496d4c76f71abe0b7aef9/ui/app_list/search/history_data_store.cc

Project Member

Comment 86 by bugdroid1@chromium.org, Oct 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c5b825c07430e0cd85249caf8cb1d15c98c2d76

commit 8c5b825c07430e0cd85249caf8cb1d15c98c2d76
Author: jdoerrie <jdoerrie@chromium.org>
Date: Sat Oct 14 06:28:58 2017

Update and Clean Up value_cleanup Tool

This change adds a value rewriter to the value_cleanup clang tool. It is
intended to be extended for future use cases, currently it supports the
renaming of base::Value::GetType to base::Value::type.

Furthermore, this change removes the existing ListValueRewriters which
became obsolete with r464866. For future discoverability it adds a
reference to //docs/clang_tool_refactoring.md.

Bug: 646113, 581865
Change-Id: I07b5c1279753a65c123ebdd4a5c5f3a384321081
Reviewed-on: https://chromium-review.googlesource.com/702454
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508932}
[modify] https://crrev.com/8c5b825c07430e0cd85249caf8cb1d15c98c2d76/docs/clang_tool_refactoring.md
[modify] https://crrev.com/8c5b825c07430e0cd85249caf8cb1d15c98c2d76/tools/clang/value_cleanup/CMakeLists.txt
[delete] https://crrev.com/1c2edfba58aea9a316c796649fb932636a491932/tools/clang/value_cleanup/ListValueRewriter.cpp
[delete] https://crrev.com/1c2edfba58aea9a316c796649fb932636a491932/tools/clang/value_cleanup/ListValueRewriter.h
[modify] https://crrev.com/8c5b825c07430e0cd85249caf8cb1d15c98c2d76/tools/clang/value_cleanup/ValueCleanup.cpp
[add] https://crrev.com/8c5b825c07430e0cd85249caf8cb1d15c98c2d76/tools/clang/value_cleanup/ValueRewriter.cpp
[add] https://crrev.com/8c5b825c07430e0cd85249caf8cb1d15c98c2d76/tools/clang/value_cleanup/ValueRewriter.h
[delete] https://crrev.com/1c2edfba58aea9a316c796649fb932636a491932/tools/clang/value_cleanup/tests/list-value-append-expected.cc
[delete] https://crrev.com/1c2edfba58aea9a316c796649fb932636a491932/tools/clang/value_cleanup/tests/list-value-append-original.cc
[add] https://crrev.com/8c5b825c07430e0cd85249caf8cb1d15c98c2d76/tools/clang/value_cleanup/tests/value-get-type-expected.cc
[add] https://crrev.com/8c5b825c07430e0cd85249caf8cb1d15c98c2d76/tools/clang/value_cleanup/tests/value-get-type-original.cc
[modify] https://crrev.com/8c5b825c07430e0cd85249caf8cb1d15c98c2d76/tools/clang/value_cleanup/tests/values.h

Sign in to add a comment