New issue
Advanced search Search tips

Issue 580691 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 579196



Sign in to add a comment

Remove code to support Windows XP/Vista from net/

Project Member Reported by mmenke@chromium.org, Jan 22 2016

Issue description

There's not a huge amount of it, but there is some special case XP/Vista code in various parts of net.

Doesn't seem worth filing separate bugs for every single chunk of code to support these platforms.
 

Comment 1 by mmenke@chromium.org, Jan 22 2016

Blocking: chromium:579196
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3983f64a3c99469d868ca1107a35336732c7dd6a

commit 3983f64a3c99469d868ca1107a35336732c7dd6a
Author: mmenke <mmenke@chromium.org>
Date: Tue Jan 26 05:53:12 2016

Remove code to set the send/receive buffer size on XP.

Since we're no longer supporting XP, this is no longer needed.  Newer
versions of windows automatically tune the buffer sizes.

BUG= 580691 

Review URL: https://codereview.chromium.org/1626643002

Cr-Commit-Position: refs/heads/master@{#371466}

[modify] http://crrev.com/3983f64a3c99469d868ca1107a35336732c7dd6a/net/socket/tcp_socket_win.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8f527056c4653134fc76f01900b5f053adc8b05

commit c8f527056c4653134fc76f01900b5f053adc8b05
Author: maksim.sisov <maksim.sisov@intel.com>
Date: Wed May 04 08:20:06 2016

Since we are not supporting WinXP platform anymore, there is
no need in AddressSorterWinXP wrapper for AddressSorterWin
for address sorting.

+ Modified comment in the net/socket/tcp_socket_win.h in
accordance to https://codereview.chromium.org/1626643002

BUG= 580691 

Review-Url: https://codereview.chromium.org/1945583002
Cr-Commit-Position: refs/heads/master@{#391461}

[modify] https://crrev.com/c8f527056c4653134fc76f01900b5f053adc8b05/net/dns/address_sorter_win.cc
[modify] https://crrev.com/c8f527056c4653134fc76f01900b5f053adc8b05/net/socket/tcp_socket_win.h

Project Member

Comment 5 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95e711a2e73ffd4d5029206deeb71d3624754902

commit 95e711a2e73ffd4d5029206deeb71d3624754902
Author: maksim.sisov <maksim.sisov@intel.com>
Date: Thu May 19 06:39:23 2016

Remove Windows Vista/XP specific code from net/cert.
Changes to unittests.

BUG= 580691 

Review-Url: https://codereview.chromium.org/1987633002
Cr-Commit-Position: refs/heads/master@{#394700}

[modify] https://crrev.com/95e711a2e73ffd4d5029206deeb71d3624754902/net/cert/cert_verify_proc_unittest.cc
[modify] https://crrev.com/95e711a2e73ffd4d5029206deeb71d3624754902/net/cert/x509_certificate_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3a795ebed090c2b43e8dcf2af854382b5d3a7b0

commit e3a795ebed090c2b43e8dcf2af854382b5d3a7b0
Author: martijn <martijn@martijnc.be>
Date: Thu May 19 21:21:53 2016

Remove Windows Vista/XP specific code from net/quic.

BUG= 580691 

Review-Url: https://codereview.chromium.org/1977293002
Cr-Commit-Position: refs/heads/master@{#394869}

[modify] https://crrev.com/e3a795ebed090c2b43e8dcf2af854382b5d3a7b0/net/quic/crypto/proof_test.cc
[modify] https://crrev.com/e3a795ebed090c2b43e8dcf2af854382b5d3a7b0/net/quic/quic_stream_factory.cc

Project Member

Comment 7 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/003cd61ab7a3e38d8f7fdfe55068c5450ed1bb68

commit 003cd61ab7a3e38d8f7fdfe55068c5450ed1bb68
Author: martijn <martijn@martijnc.be>
Date: Thu May 19 22:24:38 2016

Remove Windows Vista/XP specific code from net/socket.

The socket code currently contains an option to cleanup idle socket after a small delay. This option is only used on Windows as a workaround for Windows XP. Now that Windows XP is no longer supported, this option can be removed.

BUG= 580691 

Review-Url: https://codereview.chromium.org/1982263003
Cr-Commit-Position: refs/heads/master@{#394886}

[modify] https://crrev.com/003cd61ab7a3e38d8f7fdfe55068c5450ed1bb68/net/socket/client_socket_pool_base.cc
[modify] https://crrev.com/003cd61ab7a3e38d8f7fdfe55068c5450ed1bb68/net/socket/client_socket_pool_base.h
[modify] https://crrev.com/003cd61ab7a3e38d8f7fdfe55068c5450ed1bb68/net/socket/client_socket_pool_base_unittest.cc
[modify] https://crrev.com/003cd61ab7a3e38d8f7fdfe55068c5450ed1bb68/net/socket/socket_descriptor.cc

Project Member

Comment 9 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c69619d715a66dd0fc0c5d795e93236c6ef66577

commit c69619d715a66dd0fc0c5d795e93236c6ef66577
Author: maksim.sisov <maksim.sisov@intel.com>
Date: Fri May 20 19:23:55 2016

Remove Windows Vista/XP specific code from net/base.
Files affected: net_interfaces_win + unittests.
+ Fixed build failure after code dynamic linking
of functions

BUG= 580691 

Review-Url: https://codereview.chromium.org/1984133003
Cr-Commit-Position: refs/heads/master@{#395134}

[modify] https://crrev.com/c69619d715a66dd0fc0c5d795e93236c6ef66577/net/BUILD.gn
[modify] https://crrev.com/c69619d715a66dd0fc0c5d795e93236c6ef66577/net/base/network_interfaces_unittest.cc
[modify] https://crrev.com/c69619d715a66dd0fc0c5d795e93236c6ef66577/net/base/network_interfaces_win.cc
[modify] https://crrev.com/c69619d715a66dd0fc0c5d795e93236c6ef66577/net/base/network_interfaces_win.h

Status: Fixed (was: Available)
Looks like all uses of base::win::VERSION_* have been removed from net, so closing this.  Still a comment or two that mentions VISTA, but none look to have vista-specific magic.

Sign in to add a comment