New issue
Advanced search Search tips

Issue 579678 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature

Blocking:
issue 579196

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Remove GDI font path

Project Member Reported by scottmg@chromium.org, Jan 20 2016

Issue description

Without Vista/XP we can remove all GDI font paths.
 
Blocking: chromium:579196
Owner: kulshin@chromium.org
Status: Assigned

Comment 3 by e...@chromium.org, Jan 27 2016

Cc: e...@chromium.org
Labels: -Type-Bug Type-Feature Cr-Blink-Fonts

Comment 4 by yukawa@chromium.org, Feb 11 2016

Perhaps we could close  Issue 102449  if we remove all GDI font paths.

Comment 5 by drott@chromium.org, Feb 16 2016

Cc: behdad@chromium.org drott@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8

commit 1acd6b6af8c9ef59fe7227faff4585310e5c2ec8
Author: kulshin <kulshin@chromium.org>
Date: Wed Apr 27 20:09:33 2016

Delete GDI font rendering

This patch will remove the gdi font rendering, the "disable-direct-write"
switch, and associated code. All font rendering will now be done by
DirectWrite.

BUG= 579678 

Review-Url: https://codereview.chromium.org/1919573002
Cr-Commit-Position: refs/heads/master@{#390163}

[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/chrome/app/chrome_exe_main_win.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/chrome/browser/about_flags.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/content/browser/renderer_host/dwrite_font_proxy_message_filter_win_unittest.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/content/common/content_switches_internal.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/content/common/sandbox_win.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/content/ppapi_plugin/ppapi_plugin_main.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/content/renderer/renderer_main_platform_delegate_win.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/content/shell/app/blink_test_platform_support_win.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/content/test/layouttest_support.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/third_party/WebKit/Source/platform/fonts/FontCache.cpp
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/third_party/WebKit/Source/platform/fonts/FontCache.h
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/third_party/WebKit/Source/web/win/WebFontRendering.cpp
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/third_party/WebKit/public/web/win/WebFontRendering.h
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/ui/gfx/font_render_params_win.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/ui/gfx/platform_font_win_unittest.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/ui/gfx/switches.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/ui/gfx/switches.h
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/ui/gfx/test/run_all_unittests.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/ui/gfx/win/direct_write.cc
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/ui/gfx/win/direct_write.h
[modify] https://crrev.com/1acd6b6af8c9ef59fe7227faff4585310e5c2ec8/ui/message_center/views/bounded_label_unittest.cc

Comment 7 by ebra...@gnu.org, Apr 27 2016

Status: Fixed (was: Assigned)
But I'd guess there are some Skia GDI-related extra things.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd63d3b845f72c8e43723b505bd644bdacb15b68

commit bd63d3b845f72c8e43723b505bd644bdacb15b68
Author: eae <eae@chromium.org>
Date: Thu Apr 28 02:45:31 2016

Simplify FontCache::createTypeface

Share code between Linux and Windows in FontCache::createTypeface given
that both now use the SkFontManager interface.

BUG= 579678 
R=kojii@chromium.org

Review-Url: https://codereview.chromium.org/1931733002
Cr-Commit-Position: refs/heads/master@{#390279}

[modify] https://crrev.com/bd63d3b845f72c8e43723b505bd644bdacb15b68/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b331622a5bd93461fbcbff715d4a7b874dd56d55

commit b331622a5bd93461fbcbff715d4a7b874dd56d55
Author: eae <eae@chromium.org>
Date: Thu Apr 28 09:55:37 2016

Remove font subpixel positioning flag

Remove the static FontCache::s_useSubpixelPositioning field and the bool
FontPlatformData::m_useSubpixelPositioning field. They are only ever set
explicitly on Windows and always to true since the GDI path was removed.

BUG= 579678 
R=kojii@chromium.org

Review-Url: https://codereview.chromium.org/1930503003
Cr-Commit-Position: refs/heads/master@{#390337}

[modify] https://crrev.com/b331622a5bd93461fbcbff715d4a7b874dd56d55/third_party/WebKit/Source/platform/fonts/FontCache.cpp
[modify] https://crrev.com/b331622a5bd93461fbcbff715d4a7b874dd56d55/third_party/WebKit/Source/platform/fonts/FontCache.h
[modify] https://crrev.com/b331622a5bd93461fbcbff715d4a7b874dd56d55/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
[modify] https://crrev.com/b331622a5bd93461fbcbff715d4a7b874dd56d55/third_party/WebKit/Source/platform/fonts/FontPlatformData.h
[modify] https://crrev.com/b331622a5bd93461fbcbff715d4a7b874dd56d55/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp
[modify] https://crrev.com/b331622a5bd93461fbcbff715d4a7b874dd56d55/third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm
[modify] https://crrev.com/b331622a5bd93461fbcbff715d4a7b874dd56d55/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
[modify] https://crrev.com/b331622a5bd93461fbcbff715d4a7b874dd56d55/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
[modify] https://crrev.com/b331622a5bd93461fbcbff715d4a7b874dd56d55/third_party/WebKit/Source/platform/fonts/win/FontPlatformDataWin.cpp

Don't you see that DirectWrite renders much more blurry fonts than GDI that are almost unreadable at grayscale rendering. Have you just taken into account the opinion of hundreds of users on all the product forums of Chrome, Chromium and its derivatives?

If not, here are some.

See all the opinions here.
https://productforums.google.com/forum/#!topic/chrome/VStr-JaPbwQ
https://productforums.google.com/forum/#!msg/chrome/Q6QGBRvULbQ/5FQtKz0TCAAJ
https://productforums.google.com/forum/#!topic/chrome/bkFBZbeMklk
https://bugs.chromium.org/p/chromium/issues/detail?id=405445
http://www.trilithium.com/johan/2015/03/chrome-directwrite-2/
https://forums.opera.com/discussion/1873864/disabling-option-to-disable-directwrite-font-rendering-in-opera-beta-39-0-2256-15#Item_5
https://forums.opera.com/discussion/1865224/opera-blurry-fonts/p1

See the examples here.
https://productforums.google.com/forum/#!topic/chrome/zi3gClg8uiQ;context-place=topicsearchin/chrome/category$3Agive-feature-feedback-and-suggestions%7Csort:relevance%7Cspell:false

Make sure your eyes are opened and you view the example images not on high-end 4K monitors, but on standard resolution and standard PPI monitors (a 15.6 inch 1366x768 is good) that 90% of your users have.

You just can't be this ignorant on your users. Would it mean that much extra effort to keep maintaining the support for GDI rendering (which is supported in Windows 7 and is the only alternative for sharp fonts on lower-PPI screens that MOST OF US HAVE)?!

Please keep GDI rendering and the "disable directwrite" flag.
I've only just learned about this.

Forcing DirectWrite is a huge mistake.

This was clearly forgotten about: https://bugs.chromium.org/p/chromium/issues/detail?id=444141

DirectWrite is the #1 user complaint with text rendering across all browsers.

For me personally, I suffer immense eye strain trying to read fonts rendered with DirectWrite.  I had to change my Windows system fonts because of ClearType.

With this change, Chromium is now unusable.  And that's terrible because many many things are based off of Chromium.

Firefox and Google Chrome have done nothing but get worse over the years.

Comment 12 by ased...@gmail.com, Jul 22 2016

Please put it back, Chrome now looks awful on Windows 7.

https://drive.google.com/file/d/0B7tsrYpXC3iZX0pOdmpIVVdick0/view?pref=2&pli=1
@asedeno / #12 - it actually looks like you're hitting  issue 610466  that's causing some font styles to not load properly, which is making Chrome fallback on other styles. To help us diagnose this, could you open a command prompt and run the following command:

reg query "HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Fonts" >reg_fonts.txt

That will create a reg_fonts.txt file. Please attach that file and your screenshot to  issue 610466 .

Comment 14 by ased...@gmail.com, Jul 22 2016

I was indeed hitting  issue 610466 , more details there.
I don't think you will get any more reasonable help here.

Developers have let this happen as they are too ignorant to notice that their DirectWrite fonts are unreadable. They will just tell you to mess around with ClearType and stuff.

Please sign this to address Google Inc. with the issue and to tell them to pay more attention to their users.

https://www.change.org/p/google-inc-bring-sharp-fonts-back-in-google-chrome-disable-directwrite
lol.
Labels: Restrict-AddIssueComment-EditIssue
Please keep the bug respectful and focused on technical issues. This is not the right forum for petitions and other similar discussion.

Sign in to add a comment