New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 579495 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 579196



Sign in to add a comment

Chrome bundle xinput1_3.dll, chromium local build doesn't support gamepad (if no DirectX SDK 2010 content copied)

Project Member Reported by aleksand...@intel.com, Jan 20 2016

Issue description

Version: all
OS: Windows after XP

Explanation: "chromium local build doesn't support gamepad"
[1] Google build machine has content from DirectX 2010 redist (APR2007_xinput_x64.cab and APR2007_xinput_x86.cab) copied to chromeroot\src\third_party\directxsdk\files\Redist and when packaging, xinput1_3.dll would be extracted and packaged.

If building chromium without this content copied to build machine, no gamepad support.

Now that XP support gets removed [2], whatever xinput is available on platform can be used - no need to bundle xinput1_3.dll with chrome build.

Background information bellow.
[1]
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/koCQK5kn_AU
[2]
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/xp/chromium-dev/fVgomDvpHT0/rnHec8HQAgAJ

 
So, I'll start preparing the patch.
Blocking: chromium:579196
Could it be that the blocking against 579196 is reverse - cannot remove xinput1_3.dll until XP support is officially dropped?
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5568924a9a4a3508a32512c9921d065e30155c1f

commit 5568924a9a4a3508a32512c9921d065e30155c1f
Author: aleksandar.stojiljkovic <aleksandar.stojiljkovic@intel.com>
Date: Sat Apr 02 15:14:05 2016

Use Windows provided xinput dll instead of bundling dll from DX redist.

Internal Chrome build machines have a copy of DirectX 2010 redist on predefined
path. Built chromium package would then include a copy of xinput1_3.dll from
DirectX redist.
Here, approach is to use whatever xinput dll platform includes. Logic about
what dll is in use for different platforms is copied from Xinput.h.
In order to target all of the Windows versions with the same binary, chosen to
keep dynamic linking approach. Otherwise, there would be a problem with
XInputEnable not available in xinput dll before Windows8 and deprecated on
Windows 10.

BUG= 579495 

Review URL: https://codereview.chromium.org/1719693002

Cr-Commit-Position: refs/heads/master@{#384809}

[modify] https://crrev.com/5568924a9a4a3508a32512c9921d065e30155c1f/.gn
[modify] https://crrev.com/5568924a9a4a3508a32512c9921d065e30155c1f/chrome/installer/mini_installer/chrome.release
[modify] https://crrev.com/5568924a9a4a3508a32512c9921d065e30155c1f/chrome/tools/build/win/FILES.cfg
[modify] https://crrev.com/5568924a9a4a3508a32512c9921d065e30155c1f/content/browser/gamepad/gamepad_platform_data_fetcher_win.cc
[modify] https://crrev.com/5568924a9a4a3508a32512c9921d065e30155c1f/content/browser/gamepad/gamepad_platform_data_fetcher_win.h
[delete] https://crrev.com/52ef1ab0da46ea871271a0a2a6fa0ced541b0381/content/content.gni
[modify] https://crrev.com/5568924a9a4a3508a32512c9921d065e30155c1f/content/content.gyp
[modify] https://crrev.com/5568924a9a4a3508a32512c9921d065e30155c1f/content/content_common.gypi
[modify] https://crrev.com/5568924a9a4a3508a32512c9921d065e30155c1f/content/gpu/BUILD.gn
[modify] https://crrev.com/5568924a9a4a3508a32512c9921d065e30155c1f/tools/checkbins/checkbins.py

Status: Fixed (was: Untriaged)
Components: -IO>Gamepad Blink>GamepadAPI

Sign in to add a comment