New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Regression]:Browser becomes unresponsive on closing the "Save file" dialog.

Project Member Reported by ysriniva...@mahindrasatyam.com, Jan 20 2016

Issue description

Version: 50.0.2626.0
OS: Ubuntu 12.04 & 14.04

What steps will reproduce the problem?
1.Launch chrome>> Click on Avatar icon>> Select "Sign-in to Chrome".
2.Right click mouse on "Google" logo>> Select "Save image as..." option.
3.Now close the "Save File" dialog without saving & try to do any operation.

What is the expected output? 
Browser should not become unresponsive.

What do you see instead?
Browser becomes unresponsive and unable to do any operation.

This is a regression issue broken in M49....will provide other info soon.

Issue is not seen on Windows.
 
Actual.ogv
1.1 MB Download
Expected.ogv
970 KB Download

Comment 1 by tkent@chromium.org, Jan 20 2016

Labels: -Cr-Blink
Labels: Needs-Bisect
Able to reproduce the issue on Ubuntu 14.04 using chrome latest Dev M50 - 50.0.2626.0. Observed the browser goes unresponsive on closing " save file" dialog. Issue is not seen on Mac OS 10.11.2 as well.
Labels: -Needs-Bisect hasBisect
Owner: juncai@chromium.org
Status: Assigned
Below is the bisect info.

Good-49.0.2569.0

Bad-49.0.2570.0

CR: https://chromium.googlesource.com/chromium/src/+log/49.0.2569.0..49.0.2570.0?pretty=fuller&n=10000

r360961 may be the suspect.

@joone.hur: Please feel free to re-assign if issue is not because of your change.

Comment 4 by baolin...@gmail.com, Jan 20 2016

I have this problem too ... not show save as dialog & no responsive some website

Comment 5 by juncai@chromium.org, Jan 20 2016

Cc: juncai@chromium.org
Owner: sadrul@chromium.org
Labels: labelStability-Sheriff-Desktop
We have a Dev channel release tomorrow, Sadrul,please get a fix or revert soon.
Labels: -labelStability-Sheriff-Desktop Stability-Sheriff-Desktop

Comment 8 by sadrul@chromium.org, Jan 20 2016

r360961 does look like the culprit. juncai@: are you unable to fix? If so, I will revert the original CL. I am unfortunately unable to find a fix right now.

Comment 9 by juncai@chromium.org, Jan 20 2016

Cc: msw@chromium.org e...@chromium.org sky@chromium.org
I am unable to fix it. I am going to CC other reviewers of the origin patch r360961 to see if they know how to fix it.
BTW, the patch r360961 owner: joone.hur@intel.com is not at the CC list.

Comment 11 by e...@chromium.org, Jan 20 2016

It should just get reverted.
An fyi, M49 already branched, so we may need a revert in branch also.
Cc: joone....@intel.com
I am going to revert for now.
thanks much sadrul@
Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Moving as RBB , please make sure that the CL is reverted the branch -  2623 also.
Labels: Merge-Request-49
The revert landed in tot (crrev.com/370570). Requesting merge to M49 (branch 2623).
Status: Started
Labels: -Merge-Request-49 Merge-Approved-49
Merge approved for M49 (branch 2623)
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 21 2016

Labels: -Merge-Approved-49 merge-merged-2623
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7015d8a6ceafecb85f79c4747be4f48470fdb6d

commit d7015d8a6ceafecb85f79c4747be4f48470fdb6d
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Thu Jan 21 05:35:56 2016

Revert of Make File-Picker modal on Linux (patchset #18 id:340001 of https://codereview.chromium.org/1233913009/ )

Reason for revert:
Breaks input events in some cases ( crbug.com/579408 )

Original issue's description:
> Make File-Picker modal on Linux
>
> Chromium for Linux opens a Gtk file-picker for file browsing, but it is not
> modal because there is no GtkWindow as parent of file-picker.
>
> This patch allows the X11 host window to disable input event handling to make
> a file-picker modal
>
> The original CL was reverted due to wrong DCHECK with modal_dialog_xid_:
> https://codereview.chromium.org/1243503002
>
> BUG= 408481 
> TEST=BrowserSelectFileDialogTest, ModalTest
>
> Committed: https://crrev.com/3bc35de4ff086027d50519c9fb40122f27eb82f4
> Cr-Commit-Position: refs/heads/master@{#360961}

TBR=erg@chromium.org,juncai@chromium.org,msw@chromium.org,sky@chromium.org,joone.hur@intel.com
BUG= 408481 ,  579408 

Review URL: https://codereview.chromium.org/1594973009

Cr-Commit-Position: refs/heads/master@{#370570}
(cherry picked from commit 0bf45553ab62cc5c97ee24bcdfbba9a0526235ea)

Review URL: https://codereview.chromium.org/1616703002 .

Cr-Commit-Position: refs/branch-heads/2623@{#36}
Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907}

[modify] http://crrev.com/d7015d8a6ceafecb85f79c4747be4f48470fdb6d/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc
[modify] http://crrev.com/d7015d8a6ceafecb85f79c4747be4f48470fdb6d/chrome/browser/ui/libgtk2ui/select_file_dialog_interactive_uitest.cc
[modify] http://crrev.com/d7015d8a6ceafecb85f79c4747be4f48470fdb6d/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] http://crrev.com/d7015d8a6ceafecb85f79c4747be4f48470fdb6d/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
[modify] http://crrev.com/d7015d8a6ceafecb85f79c4747be4f48470fdb6d/ui/views/widget/desktop_aura/x11_desktop_handler.cc

Labels: -Stability-Sheriff-Desktop
Removing "Stability-Sheriff-Desktop" because the CL is reverted.  
Labels: -ReleaseBlock-Beta
Removing RB since the CL has been reverted. We will verify in next Dev channel.
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df7f78e35f95dfae098dd6197b012e0506f68e0f

commit df7f78e35f95dfae098dd6197b012e0506f68e0f
Author: joone.hur <joone.hur@intel.com>
Date: Mon Oct 03 19:06:15 2016

Make File-Picker modal on Linux

Chromium for Linux uses GtkFileChooserDialog for opening a file-picker,
but it is not modal to the X11 host window because GtkFileChooserDialog
can be modal only to the parent GtkWindow.

This patch allows the X11 host window to disable input event handling
to make a file-picker modal.

Design doc and discussion:
https://docs.google.com/document/d/12CfKVTpaonxxM3sNksq6vY6qb0J2qR3b7h_bLxzYanE

This CL was reverted due to the UI freezing problem that happens when the
users open a file-picker from a child window of the X11 host window:
https://codereview.chromium.org/1594973009

BUG= 408481 , 579408 
TEST=BrowserSelectFileDialogTest.ModalTest

Review-Url: https://codereview.chromium.org/1624793002
Cr-Commit-Position: refs/heads/master@{#422482}

[modify] https://crrev.com/df7f78e35f95dfae098dd6197b012e0506f68e0f/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc
[modify] https://crrev.com/df7f78e35f95dfae098dd6197b012e0506f68e0f/chrome/browser/ui/libgtk2ui/select_file_dialog_interactive_uitest.cc
[modify] https://crrev.com/df7f78e35f95dfae098dd6197b012e0506f68e0f/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/df7f78e35f95dfae098dd6197b012e0506f68e0f/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h

Status: Fixed (was: Started)

Sign in to add a comment